- gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: IPL4asp: Fix ppid always shows 0, remove Iuh workaround

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26776 ) Change subject: IPL4asp: Fix ppid always shows 0, remove Iuh workaround ...................................................................... IPL4asp: Fix ppid always shows 0, remove Iuh workaround Change-Id: I941a794849c347ed61ca5170bca32f5329818d92 --- M deps/Makefile M library/Iuh_CodecPort.ttcn 2 files changed, 7 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/26776/1 diff --git a/deps/Makefile b/deps/Makefile index 5c69ee9..27f59b3 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -13,10 +13,12 @@ # See the License for the specific language governing permissions and # limitations under the License. +FORKEDGITLAB:=https://gitlab.eclipse.org/dwillmannv72 ECLIPSEGITLAB:=https://gitlab.eclipse.org/eclipse/titan OSMOGITHUB:=https://github.com/osmocom OSMOGIT:=git://git.osmocom.org +FORKEDGITLAB_REPOS= titan.TestPorts.IPL4asp ECLIPSEGITLAB_REPOS= titan.Libraries.TCCUsefulFunctions \ titan.ProtocolEmulations.M3UA \ titan.ProtocolModules.BSSAPP_v7.3.0 \ @@ -50,7 +52,6 @@ titan.TestPorts.Common_Components.Socket-API \ titan.TestPorts.Common_Components.Abstract_Socket \ titan.TestPorts.HTTPmsg \ - titan.TestPorts.IPL4asp \ titan.TestPorts.LANL2asp \ titan.TestPorts.PCAPasp \ titan.TestPorts.PIPEasp \ @@ -71,7 +72,7 @@ titan.TestPorts.AF_PACKET \ osmo-uecups -ALL_REPOS=$(ECLIPSEGITLAB_REPOS) $(OSMOGITHUB_REPOS) $(OSMOGIT_REPOS) +ALL_REPOS=$(ECLIPSEGITLAB_REPOS) $(OSMOGITHUB_REPOS) $(OSMOGIT_REPOS) $(FORKEDGITLAB_REPOS) # Tag names from 'git-describe --tags'; if not available, a commit hash may be used instead. # Do not put references to branches here, except for local testing: this breaks the caching @@ -115,7 +116,7 @@ titan.TestPorts.Common_Components.Socket-API_commit= R.6.A-6-gf4380d0 titan.TestPorts.Common_Components.Abstract_Socket_commit= R.9.B-4-gbd41994 titan.TestPorts.HTTPmsg_commit= R.9.B-4-g9a0dfde -titan.TestPorts.IPL4asp_commit= R.30.E +titan.TestPorts.IPL4asp_commit= R.30.E-4-gdcf7858 titan.TestPorts.LANL2asp_commit= R.8.C-3-gb07c265 titan.TestPorts.MTP3asp_commit= 1cecdad6f3641a5f19b3833703bff6e5005eff11 titan.TestPorts.PCAPasp_commit= R.8.A-3-g9ad320f @@ -187,3 +188,6 @@ $(foreach dir,$(OSMOGIT_REPOS), \ $(eval $(call GIT_template,$(dir),$(OSMOGIT)))) + +$(foreach dir,$(FORKEDGITLAB_REPOS), \ + $(eval $(call GIT_template,$(dir),$(FORKEDGITLAB)))) diff --git a/library/Iuh_CodecPort.ttcn b/library/Iuh_CodecPort.ttcn index 6bedc0b..75c45dd 100644 --- a/library/Iuh_CodecPort.ttcn +++ b/library/Iuh_CodecPort.ttcn @@ -94,14 +94,6 @@ case (20) { pout.msg.hnbap := dec_HNBAP_PDU(pin.msg); } - case (0) { - /* FIXME: lower layers report sinfo_ppid=0: */ - if (match(pin.msg, '000100380000070003000C02404F736D6F484E6F64654200080001000009000300F110000B0004000000100006000200020007000103000A00020004'O)) { - pout.msg.hnbap := dec_HNBAP_PDU(pin.msg); - } else { - pout.msg.rua := dec_RUA_PDU(pin.msg); - } - } case else { pout.msg.payload := pin.msg; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I941a794849c347ed61ca5170bca32f5329818d92 Gerrit-Change-Number: 26776 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 5 months

2
3
0 0

Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... ipaccess.c: register RSL/OML related osmo_fds for monitoring The osmo_fds used for ipaccess based E1 traffic should be registered for monitoring to get tcp_stats for all RSL/OML links. Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e depends: libosmocore I64b288174ae3dd22d50a701ce7cbf9e623246479 Related: SYS#5701 --- M src/input/ipaccess.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 04b4474..dbb8b2e 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -50,6 +50,7 @@ #include <osmocom/abis/ipa.h> #include <osmocom/core/backtrace.h> #include <osmocom/gsm/ipa.h> +#include <osmocom/core/stats_tcp.h> /* global parameters of IPA input driver */ struct ipa_pars g_e1inp_ipaccess_pars; @@ -341,6 +342,7 @@ "could not register FD\n"); goto err; } + osmo_stats_tcp_osmo_fd_register(newbfd, "ipa-rsl"); e1i_ts = ipaccess_line_ts(newbfd, new_line); ipaccess_bsc_keepalive_fsm_alloc(e1i_ts, newbfd, "rsl_bsc_to_bts"); @@ -671,6 +673,7 @@ LOGP(DLINP, LOGL_ERROR, "could not register FD\n"); goto err_line; } + osmo_stats_tcp_osmo_fd_register(bfd, "ipa-oml"); update_fd_settings(line, bfd->fd); @@ -724,6 +727,8 @@ LOGP(DLINP, LOGL_ERROR, "could not register FD\n"); goto err_line; } + osmo_stats_tcp_osmo_fd_register(bfd, "ipa-rsl"); + /* Request ID. FIXME: request LOCATION, HW/SW VErsion, Unit Name, Serno */ ret = ipa_ccm_send_id_req(bfd->fd); if (ret < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 09:42:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-iuh[master]: mgw_fsm: add MGW support to osmo-hnbgw

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26725 ) Change subject: mgw_fsm: add MGW support to osmo-hnbgw ...................................................................... Patch Set 2: (7 comments) https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/configure.ac File configure.ac: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/configure.ac@52 PS2, Line 52: PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.9.0) Please also make sure that both: * 'contrib/osmo-iuh.spec.in' and * debian/control are updated to reflect the new dependency. https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw.c File src/hnbgw.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw.c@376 PS2, Line 376: LOGL_DEBUG Why debug? All other categories are set to LOGL_NOTICE. https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw.c@379 PS2, Line 379: ws https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_cn.c File src/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_cn.c@349 PS2, Line 349: uint8_t *msg_data; const https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_cn.c@362 PS2, Line 362: /* Intercept RAB Assignment Request, Setup MGW FSM */ I am not saying the current approach is wrong, just an alternative variant: if (!map->is_ps && msgb_l2len(oph->msg) > 2) { switch (msgb_l2(oph->msg)[1]) { case RANAP_ProcedureCode_id_RAB_Assignment: return mgw_fsm_alloc_and_handle_rab_ass_req(map, oph); case RANAP_ProcedureCode_id_Iu_Release: /* Any IU Release will terminate the MGW FSM */ mgw_fsm_handle_iu_release(map); } } IMO, it's shorter and easier to read. https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_rua.c File src/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_rua.c@192 PS2, Line 192: uint8_t *msg_data; const https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/mgw_fsm.c File src/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/mgw_fsm.c@189 PS2, Line 189: switch (event) { weird formatting -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4 Gerrit-Change-Number: 26725 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 07:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 05:57:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: Fix Not enough tailroom msgb_put in _output_buf callers

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26726 ) Change subject: logging: Fix Not enough tailroom msgb_put in _output_buf callers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8d71bd1a0dad37606acb8302b05c2ae338112e57 Gerrit-Change-Number: 26726 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Jan 2022 05:51:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring

by dexter

Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 to look at the new patch set (#4). Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... ipaccess.c: register RSL/OML related osmo_fds for monitoring The osmo_fds used for ipaccess based E1 traffic should be registered for monitoring to get tcp_stats for all RSL/OML links. Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e depends: libosmocore I64b288174ae3dd22d50a701ce7cbf9e623246479 Related: SYS#5701 --- M src/input/ipaccess.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/55/26455/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/libosmo-abis/+/26455/3/src/input/ipaccess.c File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/26455/3/src/input/ipaccess.c@676 PS3, Line 676: rsl > oml Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 15:58:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: RTP_Emulation: Several fixes and improvements for IuUP streams

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26719 ) Change subject: RTP_Emulation: Several fixes and improvements for IuUP streams ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4f8b02a8123bb30b659c40148c8ab4c7c2078a1 Gerrit-Change-Number: 26719 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 15:22:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: mgw: Introduce test TC_two_crcx_mdcx_and_iuup

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26720 ) Change subject: mgw: Introduce test TC_two_crcx_mdcx_and_iuup ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0866fb499c6d426386d9811d075a7fe8386c5cb1 Gerrit-Change-Number: 26720 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 15:19:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log