- gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: Fix printf type
by fixeria 01 Sep '22

01 Sep '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29261 ) Change subject: trxcon: Fix printf type ...................................................................... trxcon: Fix printf type data_len is a size_t, and gcc warns about it. Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931 --- M src/host/trxcon/src/trxcon_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index 40d5253..aa7193a 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -80,7 +80,7 @@ break; } if (req->data_len != GSM_MACBLOCK_LEN) { - LOGPFSML(fi, LOGL_ERROR, "Unexpected data length=%u\n", req->data_len); + LOGPFSML(fi, LOGL_ERROR, "Unexpected data length=%zu\n", req->data_len); break; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931 Gerrit-Change-Number: 29261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmocom-bb[master]: trxcon: Fix printf type
by fixeria 01 Sep '22

01 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29261 ) Change subject: trxcon: Fix printf type ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931 Gerrit-Change-Number: 29261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 14:37:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libgtpnl[master]: README: fix link to homepage
by pespin 01 Sep '22

01 Sep '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/29262 ) Change subject: README: fix link to homepage ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/29262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229 Gerrit-Change-Number: 29262 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 12:31:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libgtpnl[master]: README: fix link to homepage
by osmith 01 Sep '22

01 Sep '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/29262 ) Change subject: README: fix link to homepage ...................................................................... README: fix link to homepage Old link is 404, so adjust it. Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229 --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/62/29262/1 diff --git a/README.md b/README.md index 23c1d25..5d3b5bf 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ ## Homepage The official homepage of the project is -<https://osmocom.org/projects/libgtpnl/wiki/> +<https://osmocom.org/projects/linux-kernel-gtp-u/wiki/Libgtpnl> GIT Repository -------------- -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/29262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229 Gerrit-Change-Number: 29262 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-netif[master]: osmux: Drop long time deprecated APIs
by pespin 01 Sep '22

01 Sep '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29256 ) Change subject: osmux: Drop long time deprecated APIs ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/1acc0f5e_25bb4b63 PS2, Line 10: been > "not been"? […] We'll require a major bump anyway since the whole API will be improved/extended/changed (see for instance the new _alloc() function in follow up commit). The idea of deprecating APIs is not to keep them forever, but to signal users that the API will be removed at some point, and give some rational time to them to do move to the new APIs. 4 years of time given the amount of users of this API looks more than reasonable to me. File src/osmux.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/d9df38cb_756f393a PS2, Line 49: #if 0 > this is "deprecated API" ? Yes, it's implementation stuff from APIs being removed. After those are gone, this is not needed and hence it is removed as part of the API implementation. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853 Gerrit-Change-Number: 29256 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 11:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: osmux: Move osmux_xfrm_output_set_tx_cb() further down to the xfrm_ou...
by neels 01 Sep '22

01 Sep '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29257 ) Change subject: osmux: Move osmux_xfrm_output_set_tx_cb() further down to the xfrm_output section ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I46628d1f712e9c5c56c306e27c34ff45731c0172 Gerrit-Change-Number: 29257 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 11:46:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: osmux: Drop long time deprecated APIs
by neels 01 Sep '22

01 Sep '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29256 ) Change subject: osmux: Drop long time deprecated APIs ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/feab05bb_7d3307bd PS2, Line 10: been "not been"? what makes you so sure, the idea behind keeping deprecated API is to remain backwards compatible *forever*. dropping would require a major version bump. if they make things hard to understand, maybe just move to the bottom / a new file File src/osmux.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/e8ca9dcc_88b9b269 PS2, Line 49: #if 0 this is "deprecated API" ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853 Gerrit-Change-Number: 29256 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 11:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: examples/osmux-test-output: Avoid using deprecated Osmux API
by neels 01 Sep '22

01 Sep '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29255 ) Change subject: examples/osmux-test-output: Avoid using deprecated Osmux API ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/29255/comment/63c1cdd9_9b68f823 PS1, Line 7: examples/osmux-test-output: Avoid using deprecated Osmux API funny, just before also deprecating osmux_xfrm_output_init2() -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I408bfc84b9c1740df946fa29191f0e286f5b46e1 Gerrit-Change-Number: 29255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 11:41:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: osmux: Allocate struct osmux_out_handle through API
by neels 01 Sep '22

01 Sep '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29258 ) Change subject: osmux: Allocate struct osmux_out_handle through API ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/osmux.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29258/comment/e8054752_9c585571 PS4, Line 873: /* Returned pointer can be freed with regular talloc_free, queue will be flushed should be doxygen comment? /*! -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie8df581f375c9a183a7af60b431561bda82f6e34 Gerrit-Change-Number: 29258 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 11:38:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: Fix printf type
by neels 01 Sep '22

01 Sep '22

Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29261 ) Change subject: trxcon: Fix printf type ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931 Gerrit-Change-Number: 29261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 11:29:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log