- gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: osmux: Drop long time deprecated APIs
by pespin 02 Sep '22

02 Sep '22

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256 to look at the new patch set (#3). Change subject: osmux: Drop long time deprecated APIs ...................................................................... osmux: Drop long time deprecated APIs Those APIs where deprecated 4 years ago (end of Aug 2018), and they have not been used since around that time. Hence it can be considered safe to drop them, since they only make the whole code more complex to understand. API osmux_xfrm_output_init() is left since openbsc.git is still using it. Related: OS#5987 Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853 --- M include/osmocom/netif/osmux.h M src/osmux.c 2 files changed, 0 insertions(+), 122 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/56/29256/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853 Gerrit-Change-Number: 29256 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-netif[master]: osmux: Move osmux_xfrm_output_set_tx_cb() further down to the xfrm_ou...
by pespin 02 Sep '22

02 Sep '22

Attention is currently required from: pespin. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/29257 to look at the new patch set (#3). Change subject: osmux: Move osmux_xfrm_output_set_tx_cb() further down to the xfrm_output section ...................................................................... osmux: Move osmux_xfrm_output_set_tx_cb() further down to the xfrm_output section Change-Id: I46628d1f712e9c5c56c306e27c34ff45731c0172 --- M src/osmux.c 1 file changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/57/29257/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I46628d1f712e9c5c56c306e27c34ff45731c0172 Gerrit-Change-Number: 29257 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-netif[master]: osmux: Allocate struct osmux_out_handle through API
by pespin 02 Sep '22

02 Sep '22

Attention is currently required from: pespin. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/29258 to look at the new patch set (#5). Change subject: osmux: Allocate struct osmux_out_handle through API ...................................................................... osmux: Allocate struct osmux_out_handle through API Until now, the osmux_out_handle was allocated by the client, and passed to the API to initialize it. This makes it really hard to improve the implementation without breaking the ABI. Let's break the ABI now one last time (hopefully) by allocating the struct through an API. With only this change, the already built users (osmo-mgw, openbsc) can still work fine, since there's no change on the struct osmux_out_handle. However, they will somehow break next time the struct is changed until they are ported to the same API (easy to do). Related: OS#5987 Change-Id: Ie8df581f375c9a183a7af60b431561bda82f6e34 --- M TODO-RELEASE M examples/osmux-test-output.c M include/osmocom/netif/osmux.h M src/osmux.c M tests/jibuf/jibuf_tool.c M tests/osmux/osmux_test.c M tests/osmux/osmux_test2.c 7 files changed, 161 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/58/29258/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie8df581f375c9a183a7af60b431561bda82f6e34 Gerrit-Change-Number: 29258 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-netif[master]: examples/osmux-test-output: Avoid using deprecated Osmux API
by pespin 02 Sep '22

02 Sep '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29255 ) Change subject: examples/osmux-test-output: Avoid using deprecated Osmux API ...................................................................... examples/osmux-test-output: Avoid using deprecated Osmux API Change-Id: I408bfc84b9c1740df946fa29191f0e286f5b46e1 --- M examples/osmux-test-output.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/examples/osmux-test-output.c b/examples/osmux-test-output.c index 0ab03a7..d39277b 100644 --- a/examples/osmux-test-output.c +++ b/examples/osmux-test-output.c @@ -155,7 +155,7 @@ /* * initialize OSMUX handlers. */ - osmux_xfrm_output_init(&h_output, random()); + osmux_xfrm_output_init2(&h_output, random(), 98); osmux_xfrm_output_set_tx_cb(&h_output, tx_cb, NULL); /* * initialize datagram server. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I408bfc84b9c1740df946fa29191f0e286f5b46e1 Gerrit-Change-Number: 29255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmo-netif[master]: examples/osmux-test-output: Avoid using deprecated Osmux API
by pespin 02 Sep '22

02 Sep '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29255 ) Change subject: examples/osmux-test-output: Avoid using deprecated Osmux API ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I408bfc84b9c1740df946fa29191f0e286f5b46e1 Gerrit-Change-Number: 29255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Sep 2022 09:19:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libgtpnl[master]: README: fix link to homepage
by osmith 02 Sep '22

02 Sep '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/29262 ) Change subject: README: fix link to homepage ...................................................................... README: fix link to homepage Old link is 404, so adjust it. Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229 --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/README.md b/README.md index 23c1d25..5d3b5bf 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ ## Homepage The official homepage of the project is -<https://osmocom.org/projects/libgtpnl/wiki/> +<https://osmocom.org/projects/linux-kernel-gtp-u/wiki/Libgtpnl> GIT Repository -------------- -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/29262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229 Gerrit-Change-Number: 29262 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libgtpnl[master]: README: fix link to homepage
by fixeria 01 Sep '22

01 Sep '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/29262 ) Change subject: README: fix link to homepage ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/29262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229 Gerrit-Change-Number: 29262 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 17:07:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: cosmetic: Fix formatting of if-else block brackets
by pespin 01 Sep '22

01 Sep '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29263 ) Change subject: cosmetic: Fix formatting of if-else block brackets ...................................................................... cosmetic: Fix formatting of if-else block brackets Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9 --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index b530d25..65f397d 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -505,7 +505,7 @@ if (msgb_l2len(msg) == GSM_MACBLOCK_LEN) { gsm0503_tch_fr_encode(*bursts_p, msg->l2h, msgb_l2len(msg), 1); chan_state->dl_facch_bursts = 8; - } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) + } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) { /* the first FN 4,13,21 defines that CMI is included in frame, * the first FN 0,8,17 defines that CMR is included in frame. */ @@ -514,8 +514,9 @@ chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); - else + } else { gsm0503_tch_fr_encode(*bursts_p, msg->l2h, msgb_l2len(msg), 1); + } /* free message */ msgb_free(msg); diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index 7b0f96a..a5f6747 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -432,7 +432,7 @@ gsm0503_tch_hr_encode(*bursts_p, msg->l2h, msgb_l2len(msg)); chan_state->dl_ongoing_facch = 1; /* first of two TCH frames */ chan_state->dl_facch_bursts = 6; - } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) + } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) { /* the first FN 4,13,21 or 5,14,22 defines that CMI is included * in frame, the first FN 0,8,17 or 1,9,18 defines that CMR is * included in frame. */ @@ -441,8 +441,9 @@ chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); - else + } else { gsm0503_tch_hr_encode(*bursts_p, msg->l2h, msgb_l2len(msg)); + } /* free message */ msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9 Gerrit-Change-Number: 29263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: cosmetic: Fix formatting of if-else block brackets
by fixeria 01 Sep '22

01 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29263 ) Change subject: cosmetic: Fix formatting of if-else block brackets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9 Gerrit-Change-Number: 29263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Sep 2022 16:37:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: cosmetic: Fix formatting of if-else block brackets
by pespin 01 Sep '22

01 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29263 ) Change subject: cosmetic: Fix formatting of if-else block brackets ...................................................................... cosmetic: Fix formatting of if-else block brackets Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9 --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/63/29263/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index b530d25..65f397d 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -505,7 +505,7 @@ if (msgb_l2len(msg) == GSM_MACBLOCK_LEN) { gsm0503_tch_fr_encode(*bursts_p, msg->l2h, msgb_l2len(msg), 1); chan_state->dl_facch_bursts = 8; - } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) + } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) { /* the first FN 4,13,21 defines that CMI is included in frame, * the first FN 0,8,17 defines that CMR is included in frame. */ @@ -514,8 +514,9 @@ chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); - else + } else { gsm0503_tch_fr_encode(*bursts_p, msg->l2h, msgb_l2len(msg), 1); + } /* free message */ msgb_free(msg); diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index 7b0f96a..a5f6747 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -432,7 +432,7 @@ gsm0503_tch_hr_encode(*bursts_p, msg->l2h, msgb_l2len(msg)); chan_state->dl_ongoing_facch = 1; /* first of two TCH frames */ chan_state->dl_facch_bursts = 6; - } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) + } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) { /* the first FN 4,13,21 or 5,14,22 defines that CMI is included * in frame, the first FN 0,8,17 or 1,9,18 defines that CMR is * included in frame. */ @@ -441,8 +441,9 @@ chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); - else + } else { gsm0503_tch_hr_encode(*bursts_p, msg->l2h, msgb_l2len(msg)); + } /* free message */ msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9 Gerrit-Change-Number: 29263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log