- gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: tests/osmux_test2: Document unit tests
by pespin 28 Sep '22

28 Sep '22

Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/29504 to look at the new patch set (#2). Change subject: tests/osmux_test2: Document unit tests ...................................................................... tests/osmux_test2: Document unit tests Change-Id: I56f27af52b6a8d798879c70d68a9a3b9e512867d --- M tests/osmux/osmux_test2.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/04/29504/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I56f27af52b6a8d798879c70d68a9a3b9e512867d Gerrit-Change-Number: 29504 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-netif[master]: tests: rename test osmux_test2 -> osmux_output_test
by pespin 28 Sep '22

28 Sep '22

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/29506 to look at the new patch set (#2). Change subject: tests: rename test osmux_test2 -> osmux_output_test ...................................................................... tests: rename test osmux_test2 -> osmux_output_test That file focuses on testing the osmux_output_* API, ie receiving Osmux frames and decoding it into batches and later on into rtp packets. Change-Id: I7e6eda1e2e676673771bc6a7c3682d07ac1d344e --- M tests/Makefile.am R tests/osmux/osmux_output_test.c R tests/osmux/osmux_output_test.ok M tests/testsuite.at 4 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/06/29506/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7e6eda1e2e676673771bc6a7c3682d07ac1d344e Gerrit-Change-Number: 29506 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-netif[master]: tests/osmux_test2: Document unit tests
by pespin 28 Sep '22

28 Sep '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29504 ) Change subject: tests/osmux_test2: Document unit tests ...................................................................... Patch Set 1: (1 comment) File tests/osmux/osmux_test2.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29504/comment/33dc880f_1c63b465 PS1, Line 357: flushed > "is called" you mean? Ack -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I56f27af52b6a8d798879c70d68a9a3b9e512867d Gerrit-Change-Number: 29504 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Sep 2022 17:02:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: include: use '#pragma once' everywhere
by fixeria 28 Sep '22

28 Sep '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/29509 ) Change subject: include: use '#pragma once' everywhere ...................................................................... include: use '#pragma once' everywhere Change-Id: Iecc1754caae401aca28444d3e3d0cca04b398f26 --- M include/osmocom/core/isdnhdlc.h M include/osmocom/core/sercomm.h M include/osmocom/gsm/protocol/gsm_04_08_gprs.h M include/osmocom/gsm/protocol/gsm_09_02.h M include/osmocom/sim/sim.h 5 files changed, 5 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/29509/1 diff --git a/include/osmocom/core/isdnhdlc.h b/include/osmocom/core/isdnhdlc.h index 43e6e7a..c8cfdc3 100644 --- a/include/osmocom/core/isdnhdlc.h +++ b/include/osmocom/core/isdnhdlc.h @@ -22,8 +22,7 @@ * GNU General Public License for more details. */ -#ifndef __ISDNHDLC_H__ -#define __ISDNHDLC_H__ +#pragma once #include <stdint.h> @@ -76,5 +75,3 @@ extern int osmo_isdnhdlc_encode(struct osmo_isdnhdlc_vars *hdlc, const uint8_t *src, uint16_t slen, int *count, uint8_t *dst, int dsize); - -#endif /* __ISDNHDLC_H__ */ diff --git a/include/osmocom/core/sercomm.h b/include/osmocom/core/sercomm.h index 072f4d9..38e6271 100644 --- a/include/osmocom/core/sercomm.h +++ b/include/osmocom/core/sercomm.h @@ -2,8 +2,7 @@ * Osmocom Sercomm HDLC (de)multiplex. */ -#ifndef _SERCOMM_H -#define _SERCOMM_H +#pragma once #include <osmocom/core/msgb.h> @@ -110,5 +109,3 @@ } /*! @} */ - -#endif /* _SERCOMM_H */ diff --git a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h index 4729e14..2bc6164 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h +++ b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h @@ -1,7 +1,6 @@ /*! \file gsm_04_08_gprs.h */ -#ifndef _GSM48_GPRS_H -#define _GSM48_GPRS_H +#pragma once #include <stdint.h> #include <stdbool.h> @@ -465,6 +464,3 @@ /* octet 16 */ uint8_t guar_bitrate_down_ext; }; - - -#endif /* _GSM48_GPRS_H */ diff --git a/include/osmocom/gsm/protocol/gsm_09_02.h b/include/osmocom/gsm/protocol/gsm_09_02.h index 0b54fb7..4d5ff13 100644 --- a/include/osmocom/gsm/protocol/gsm_09_02.h +++ b/include/osmocom/gsm/protocol/gsm_09_02.h @@ -1,8 +1,7 @@ /*! \file gsm_09_02.h * GSM TS 09.02 definitions (MAP). */ -#ifndef PROTO_GSM_09_02_H -#define PROTO_GSM_09_02_H +#pragma once /* Section 17.7.4 */ /* SS-Status */ @@ -134,5 +133,3 @@ #define GSM0902_TS_CODE_PLMN_SPECIFIC_TS_C 0xDC #define GSM0902_TS_CODE_PLMN_SPECIFIC_TS_D 0xDD #define GSM0902_TS_CODE_PLMN_SPECIFIC_TS_E 0xDE - -#endif /* PROTO_GSM_09_02_H */ diff --git a/include/osmocom/sim/sim.h b/include/osmocom/sim/sim.h index 5e7099f..639682a 100644 --- a/include/osmocom/sim/sim.h +++ b/include/osmocom/sim/sim.h @@ -2,8 +2,7 @@ * Routines for helping with SIM (ISO/IEC 7816-4 more generally) communication. */ -#ifndef _OSMOCOM_SIM_H -#define _OSMOCOM_SIM_H +#pragma once #include <osmocom/core/msgb.h> #include <osmocom/core/linuxlist.h> @@ -445,4 +444,3 @@ struct osim_card_hdl *osim_card_open(struct osim_reader_hdl *rh, enum osim_proto proto); int osim_card_reset(struct osim_card_hdl *card, bool cold_reset); int osim_card_close(struct osim_card_hdl *card); -#endif /* _OSMOCOM_SIM_H */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iecc1754caae401aca28444d3e3d0cca04b398f26 Gerrit-Change-Number: 29509 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-netif[master]: tests: rename test osmux_test2 -> osmux_output_test
by fixeria 28 Sep '22

28 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29506 ) Change subject: tests: rename test osmux_test2 -> osmux_output_test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7e6eda1e2e676673771bc6a7c3682d07ac1d344e Gerrit-Change-Number: 29506 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Sep 2022 16:45:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: tests/osmux: Always run with fake time
by fixeria 28 Sep '22

28 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29505 ) Change subject: tests/osmux: Always run with fake time ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I549a4722d63d700b54b146260131a68e656b843e Gerrit-Change-Number: 29505 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Sep 2022 16:44:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: tests/osmux_test2: Document unit tests
by fixeria 28 Sep '22

28 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29504 ) Change subject: tests/osmux_test2: Document unit tests ...................................................................... Patch Set 1: (1 comment) File tests/osmux/osmux_test2.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29504/comment/21546624_1247b1a1 PS1, Line 357: flushed "is called" you mean? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I56f27af52b6a8d798879c70d68a9a3b9e512867d Gerrit-Change-Number: 29504 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Sep 2022 16:43:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: tests/osmux_test2: Document unit tests
by fixeria 28 Sep '22

28 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29504 ) Change subject: tests/osmux_test2: Document unit tests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I56f27af52b6a8d798879c70d68a9a3b9e512867d Gerrit-Change-Number: 29504 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Sep 2022 16:42:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: gb: add bssgp2_enc_flush_ll encode FLUSH-LL
by fixeria 28 Sep '22

28 Sep '22

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29507 ) Change subject: gb: add bssgp2_enc_flush_ll encode FLUSH-LL ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I76dc3b08a63cfd78c9f7657fb58c2ddfa9b4b7e2 Gerrit-Change-Number: 29507 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 28 Sep 2022 16:24:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: gb: add bssgp2_enc_flush_ll encode FLUSH-LL
by lynxis lazus 28 Sep '22

28 Sep '22

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29507 to look at the new patch set (#3). Change subject: gb: add bssgp2_enc_flush_ll encode FLUSH-LL ...................................................................... gb: add bssgp2_enc_flush_ll encode FLUSH-LL Change-Id: I76dc3b08a63cfd78c9f7657fb58c2ddfa9b4b7e2 --- M include/osmocom/gprs/gprs_bssgp2.h M src/gb/gprs_bssgp2.c M src/gb/libosmogb.map 3 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/29507/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I76dc3b08a63cfd78c9f7657fb58c2ddfa9b4b7e2 Gerrit-Change-Number: 29507 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log