- gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh reso...
by fixeria 29 Jun '22

29 Jun '22

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28485 ) Change subject: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Better use strlen(). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168 Gerrit-Change-Number: 28485 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 17:09:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh reso...
by fixeria 29 Jun '22

29 Jun '22

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28485 ) Change subject: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm not sure about this one is the proper way to check for 3digit. […] There can be 3-digit MNCs starting with 0. MNC=099 is *not* equal to MNC=99, so I think using strlen() here is better, because "cgi_ps.rai.lac.plmn.mnc > 99" does not distinguish between MNC=099 and MNC=99. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168 Gerrit-Change-Number: 28485 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 17:07:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh reso...
by pespin 29 Jun '22

29 Jun '22

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28485 ) Change subject: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not sure about this one is the proper way to check for 3digit. Should I instead check with "strlen(tok) > 2"? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168 Gerrit-Change-Number: 28485 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 16:57:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh reso...
by pespin 29 Jun '22

29 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28485 ) Change subject: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd ...................................................................... nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd Fixes: Coverity CID#272987 Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168 --- M src/nacc_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/85/28485/1 diff --git a/src/nacc_fsm.c b/src/nacc_fsm.c index c049f60..e46a66a 100644 --- a/src/nacc_fsm.c +++ b/src/nacc_fsm.c @@ -799,6 +799,7 @@ if (!(tok = strtok_r(NULL, "-", &saveptr))) goto free_ret; cgi_ps.rai.lac.plmn.mnc = atoi(tok); + cgi_ps.rai.lac.plmn.mnc_3_digits = cgi_ps.rai.lac.plmn.mnc > 99; if (!(tok = strtok_r(NULL, "-", &saveptr))) goto free_ret; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168 Gerrit-Change-Number: 28485 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-hnbgw[master]: hnbgw_cn.c: Guard against null ss7 ptr during init
by pespin 29 Jun '22

29 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28484 ) Change subject: hnbgw_cn.c: Guard against null ss7 ptr during init ...................................................................... hnbgw_cn.c: Guard against null ss7 ptr during init Fixes: Coverity CID#272989 Change-Id: Ic787d52a3c2e73ac272735a33b20bb94e29fad95 --- M src/osmo-hnbgw/hnbgw_cn.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/84/28484/1 diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 5499e5d..7c1dc9d 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -541,6 +541,8 @@ LOGP(DRANAP, LOGL_NOTICE, "No cs7 instance configured for IuCS nor IuPS," " creating default instance\n"); ss7 = osmo_ss7_instance_find_or_create(gw, 0); + if (!ss7) + return -1; ss7->cfg.primary_pc = (23 << 3) + 5; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic787d52a3c2e73ac272735a33b20bb94e29fad95 Gerrit-Change-Number: 28484 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-mgw[master]: mgcp-client: Remove impossible code path
by pespin 29 Jun '22

29 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28482 ) Change subject: mgcp-client: Remove impossible code path ...................................................................... mgcp-client: Remove impossible code path read(4096 - 128) cannot return > 4096 - 128. Change-Id: I352c3b28c8de6482277cb84cd0f51893494dc929 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/82/28482/1 diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 3711f24..77de23f 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -726,10 +726,6 @@ msgb_free(msg); return -1; - } else if (ret > 4096 - 128) { - LOGPMGW(mgcp, LOGL_ERROR, "Too much data: %s: %d\n", osmo_sock_get_name2(fd->fd), ret); - msgb_free(msg); - return -1; } msg->l2h = msgb_put(msg, ret); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I352c3b28c8de6482277cb84cd0f51893494dc929 Gerrit-Change-Number: 28482 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-mgw[master]: mgcp-client: Avoid string not null terminated access
by pespin 29 Jun '22

29 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28483 ) Change subject: mgcp-client: Avoid string not null terminated access ...................................................................... mgcp-client: Avoid string not null terminated access >>> CID 272990: Memory - illegal accesses (STRING_NULL) >>> Passing unterminated string "msg->data" to "mgcp_client_rx", which expects a null-terminated string. 736 ret = mgcp_client_rx(mgcp, msg); mgcp_response_parse_head() will do: """ r->body = (char *)msg->data; if (sscanf(r->body, "%3d %u %n", ... """ Fixes: Coverity CID#272990 Change-Id: Icb61a22f6dfd6267e469dc3e607e7d634b7d4685 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/83/28483/1 diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 77de23f..8a04b75 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -719,7 +719,7 @@ return -1; } - ret = read(fd->fd, msg->data, 4096 - 128); + ret = read(fd->fd, msg->data, (4096 - 1) - 128); if (ret <= 0) { LOGPMGW(mgcp, LOGL_ERROR, "Failed to read: %s: %d='%s'\n", osmo_sock_get_name2(fd->fd), errno, strerror(errno)); @@ -729,6 +729,8 @@ } msg->l2h = msgb_put(msg, ret); + /* EOS char to avoid out-of-buf str access, not part of the msg: */ + *msg->tail = '\0'; ret = mgcp_client_rx(mgcp, msg); talloc_free(msg); return ret; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icb61a22f6dfd6267e469dc3e607e7d634b7d4685 Gerrit-Change-Number: 28483 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-sccp[master]: xua_snm: assert to guard against NULL ptr
by pespin 29 Jun '22

29 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 ) Change subject: xua_snm: assert to guard against NULL ptr ...................................................................... xua_snm: assert to guard against NULL ptr This is similarly done for same IE in other functions, so let's do it here too in order to make coverity happy, and avoid random access ptr probably ending up in obscure crash. Fixes: Coverity CID#272994 Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0 --- M src/xua_snm.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/81/28481/1 diff --git a/src/xua_snm.c b/src/xua_snm.c index 1212162..c7d0d2e 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -464,6 +464,8 @@ const uint32_t *cong_level = xua_msg_get_u32p(xua, M3UA_IEI_CONG_IND, &_cong_level); int log_ss = osmo_ss7_asp_get_log_subsys(asp); + OSMO_ASSERT(ie_aff_pc); + LOGPASP(asp, log_ss, LOGL_NOTICE, "RX SCON(%s) for %s level=%u\n", info_str ? info_str : "", format_affected_pcs_c(xua, asp->inst, ie_aff_pc), cong_level ? *cong_level : 0); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0 Gerrit-Change-Number: 28481 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmocore[master]: iuup: Explicitly mark default case as unexpected with assert
by pespin 29 Jun '22

29 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28480 ) Change subject: iuup: Explicitly mark default case as unexpected with assert ...................................................................... iuup: Explicitly mark default case as unexpected with assert That code path should not happen since this function is only called for data frames coming with IUUP_FSM_EVT_IUUP_DATA_IND. Control frames should come with specific events like IUUP_FSM_EVT_IUUP_CONFIG_REQ. Hence, let's add an assert to make sure we early exit if that ever happens (it shouldn't), instead of carrying on reading uninitialized var "dt". Fixes: Coverity CID#272996 Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d --- M src/gsm/iuup.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/28480/1 diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index ca7eb2b..c6a575e 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -476,6 +476,8 @@ dt.frame_nr = h1->frame_nr; dt.fqc = h1->fqc; break; + default: + OSMO_ASSERT(0); } /* pull up to the IuUP payload and push a new primitive header in front */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d Gerrit-Change-Number: 28480 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmocore[master]: cbsp: avoid potential msgb write overflow in osmo_cbsp_recv_buffered
by fixeria 29 Jun '22

29 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28478 ) Change subject: cbsp: avoid potential msgb write overflow in osmo_cbsp_recv_buffered ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17c558254f9c7907b56d61c53c2f597e8e4566cf Gerrit-Change-Number: 28478 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 16:18:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log