- gerrit-log - lists.osmocom.org

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Export accumulated error
by tnt 04 Oct '22

04 Oct '22

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29607 ) Change subject: icE1usb fw/gpsdo: Export accumulated error ...................................................................... icE1usb fw/gpsdo: Export accumulated error This is a pretty usefu stat as this is what actually matters Note that structure is just extended so any call with a wLength shorter will just get the beginning of the struct (usb stack limits response to wLength) and thus is fully backward compatible. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I0aa919d4870ca7e1b653b82ac4f76ed26b5e3b08 --- M firmware/ice40-riscv/icE1usb/gpsdo.c M firmware/ice40-riscv/icE1usb/ice1usb_proto.h 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/07/29607/1 diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index c1df4b0..477d2e7 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -102,6 +102,7 @@ status->tune.coarse = g_gpsdo.tune.coarse; status->tune.fine = g_gpsdo.tune.fine; status->freq_est = g_gpsdo.meas.last; + status->err_acc = (g_gpsdo.state == STATE_TUNE_FINE) ? g_gpsdo.fine.acc : 0; } void diff --git a/firmware/ice40-riscv/icE1usb/ice1usb_proto.h b/firmware/ice40-riscv/icE1usb/ice1usb_proto.h index 3170d55..38cb23b 100644 --- a/firmware/ice40-riscv/icE1usb/ice1usb_proto.h +++ b/firmware/ice40-riscv/icE1usb/ice1usb_proto.h @@ -65,6 +65,7 @@ uint8_t mode; /*!< Current configured operating mode */ struct e1usb_gpsdo_tune tune; /*!< Current VCXO tuning values */ uint32_t freq_est; /*!< Latest frequency estimate measurement */ + int16_t err_acc; /*!< Accumulated error */ } __attribute__((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I0aa919d4870ca7e1b653b82ac4f76ed26b5e3b08 Gerrit-Change-Number: 29607 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

1 0

Change in libosmocore[master]: msgb: dont return a length when msgb->lXh is NULL
by pespin 04 Oct '22

04 Oct '22

Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29591 ) Change subject: msgb: dont return a length when msgb->lXh is NULL ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Let's better OSMO_ASSERT() there, I run myself into this sort of problem in the past and it's really costly to find out what's going on. Maybe even better, use osmo_panic() explaining the error before asserting. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1795c559f190713ebbabfbabf3453ab77da46a49 Gerrit-Change-Number: 29591 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:05:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmux: Close osmux socket when bts is freed
by osmith 04 Oct '22

04 Oct '22

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29576 ) Change subject: osmux: Close osmux socket when bts is freed ...................................................................... Patch Set 4: (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29576/comment/0367cbf6_64464cea PS2, Line 301: close(bts->osmux.fd.fd); > Ye,s Good catch! why not use osmo_fd_close() instead of these three lines? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibd3faa33b28d45048c340b177f13d5685f41a784 Gerrit-Change-Number: 29576 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:03:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmux: Skip lchans in lookup which still have no remote associated
by pespin 04 Oct '22

04 Oct '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29575 ) Change subject: osmux: Skip lchans in lookup which still have no remote associated ...................................................................... osmux: Skip lchans in lookup which still have no remote associated Lchans which are marked as non-connected have not yet received information about its remote peer, hence they may not have some fields available yet. Let's skip them to avoid accessing such fields (lchan->abis_ip.osmux.in). Related: SYS#5987 Change-Id: Id53822c4a0486b0090df2db3d185e047d14fc90a --- M src/common/osmux.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/osmux.c b/src/common/osmux.c index d10d091..498fe24 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -237,6 +237,8 @@ struct osmux_handle *h; if (!lchan->abis_ip.osmux.use) continue; + if (!lchan_osmux_connected(lchan)) + continue; if (lchan->abis_ip.osmux.local_cid != osmux_cid) continue; h = osmux_xfrm_input_get_deliver_cb_data(lchan->abis_ip.osmux.in); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id53822c4a0486b0090df2db3d185e047d14fc90a Gerrit-Change-Number: 29575 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: osmux: nullify osmux.rtpst after freeing it
by pespin 04 Oct '22

04 Oct '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29574 ) Change subject: osmux: nullify osmux.rtpst after freeing it ...................................................................... osmux: nullify osmux.rtpst after freeing it Change-Id: I806cbe42cfc8fe59134ae842f3d7398acb1a1848 --- M src/common/osmux.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/osmux.c b/src/common/osmux.c index 8a5d1ee..d10d091 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -427,8 +427,10 @@ osmux_handle_put(bts, lchan->abis_ip.osmux.in); lchan->abis_ip.osmux.in = NULL; } - if (lchan->abis_ip.osmux.rtpst) + if (lchan->abis_ip.osmux.rtpst) { osmo_rtp_handle_free(lchan->abis_ip.osmux.rtpst); + lchan->abis_ip.osmux.rtpst = NULL; + } lchan->abis_ip.osmux.use = false; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I806cbe42cfc8fe59134ae842f3d7398acb1a1848 Gerrit-Change-Number: 29574 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: osmux: Log remote address upon rx of osmux pkt
by pespin 04 Oct '22

04 Oct '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29572 ) Change subject: osmux: Log remote address upon rx of osmux pkt ...................................................................... osmux: Log remote address upon rx of osmux pkt Related: SYS#5987 Change-Id: I391bc02a16eae1602680cb96128252f262852e14 --- M src/common/osmux.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/osmux.c b/src/common/osmux.c index 02faab4..e178e0c 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -263,9 +263,11 @@ while ((osmuxh = osmux_xfrm_output_pull(msg)) != NULL) { struct gsm_lchan *lchan = osmux_lchan_find(bts, &rem_addr, osmuxh->circuit_id); if (!lchan) { + char addr_str[64]; + osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), &rem_addr); LOGP(DOSMUX, LOGL_NOTICE, - "Cannot find lchan for circuit_id=%d\n", - osmuxh->circuit_id); + "Cannot find lchan for %s CID=%d\n", + addr_str, osmuxh->circuit_id); continue; } osmux_xfrm_output_sched(lchan->abis_ip.osmux.out, osmuxh); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I391bc02a16eae1602680cb96128252f262852e14 Gerrit-Change-Number: 29572 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: osmux: Lower log level when osmux batch received for unknown CID
by pespin 04 Oct '22

04 Oct '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29573 ) Change subject: osmux: Lower log level when osmux batch received for unknown CID ...................................................................... osmux: Lower log level when osmux batch received for unknown CID This is actually quite common, since our peer may be sending some osmux packets to us a while after we have closed the conn on our side, specially if latency is high in the network (eg satellite links). Related: SYS#598 Change-Id: I102047685b9b9f4cba43970945f955c4fe9c4c95 --- M src/common/osmux.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/osmux.c b/src/common/osmux.c index e178e0c..8a5d1ee 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -265,7 +265,7 @@ if (!lchan) { char addr_str[64]; osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), &rem_addr); - LOGP(DOSMUX, LOGL_NOTICE, + LOGP(DOSMUX, LOGL_DEBUG, "Cannot find lchan for %s CID=%d\n", addr_str, osmuxh->circuit_id); continue; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I102047685b9b9f4cba43970945f955c4fe9c4c95 Gerrit-Change-Number: 29573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: osmux: Match remote address in osmux_lchan_find()
by pespin 04 Oct '22

04 Oct '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29571 ) Change subject: osmux: Match remote address in osmux_lchan_find() ...................................................................... osmux: Match remote address in osmux_lchan_find() Related: SYS#5987 Depends: libosmo-netif.git I95433b18802f73fa70e758f4aa02128eee940d88 Change-Id: I6813686b55fc3a74f1676a7965186e1e5fa00481 --- M src/common/osmux.c 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/osmux.c b/src/common/osmux.c index cacc3aa..02faab4 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -234,10 +234,15 @@ subslots = ts_subslots(ts); for (subslot = 0; subslot < subslots; subslot++) { struct gsm_lchan *lchan = &ts->lchan[subslot]; + struct osmux_handle *h; if (!lchan->abis_ip.osmux.use) continue; - if (lchan->abis_ip.osmux.local_cid == osmux_cid) - return lchan; + if (lchan->abis_ip.osmux.local_cid != osmux_cid) + continue; + h = osmux_xfrm_input_get_deliver_cb_data(lchan->abis_ip.osmux.in); + if (osmo_sockaddr_cmp(&h->rem_addr, rem_addr) != 0) + continue; + return lchan; /* Found it! */ } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6813686b55fc3a74f1676a7965186e1e5fa00481 Gerrit-Change-Number: 29571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: osmux: Log remote address upon rx of osmux pkt
by pespin 04 Oct '22

04 Oct '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29572 ) Change subject: osmux: Log remote address upon rx of osmux pkt ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I391bc02a16eae1602680cb96128252f262852e14 Gerrit-Change-Number: 29572 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:02:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmux: Match remote address in osmux_lchan_find()
by pespin 04 Oct '22

04 Oct '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29571 ) Change subject: osmux: Match remote address in osmux_lchan_find() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6813686b55fc3a74f1676a7965186e1e5fa00481 Gerrit-Change-Number: 29571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:02:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log