- gerrit-log - lists.osmocom.org

Change in osmo-remsim[master]: client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level
by laforge 13 Jul '22

13 Jul '22

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/28565 to look at the new patch set (#3). Change subject: client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level ...................................................................... client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level Closes: OS#5615 Change-Id: I9b54a53ef2809c9bfd110636a9ccb0c0d8c90cda --- M src/client/main_fsm.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/65/28565/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9b54a53ef2809c9bfd110636a9ccb0c0d8c90cda Gerrit-Change-Number: 28565 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: Cosmetic: coverity: how to add a new project
by osmith 13 Jul '22

13 Jul '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28589 ) Change subject: Cosmetic: coverity: how to add a new project ...................................................................... Cosmetic: coverity: how to add a new project Mention that new projects should be added to the components list, as a lot of projects were not listed there. I've just added all missing ones. Put it as comment in prepare_source_Osmocom.sh because that's probably the most likely spot where people will see it while adding a new project. Change-Id: I48630f4eb5b4f2b7b714697d15432c0d71f136f9 --- M coverity/prepare_source_Osmocom.sh 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/28589/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 01e3d73..31d6714 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -1,6 +1,12 @@ #!/bin/sh BASEDIR=source-Osmocom +# How to add a new project: +# * add it to the list below +# * add it to build_Osmocom.sh +# * add it as component here: +# https://scan.coverity.com/projects/osmocom?tab=analysis_settings + PROJECTS=" libasn1c libosmo-abis -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I48630f4eb5b4f2b7b714697d15432c0d71f136f9 Gerrit-Change-Number: 28589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-remsim[master]: Install + package remsim-apitool as separate sub-package
by laforge 13 Jul '22

13 Jul '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28563 ) Change subject: Install + package remsim-apitool as separate sub-package ...................................................................... Patch Set 5: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I11d779f66833b5294ffeb422ce6b2a705719a899 Gerrit-Change-Number: 28563 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Jul 2022 07:22:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level
by laforge 13 Jul '22

13 Jul '22

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/28565 to look at the new patch set (#2). Change subject: client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level ...................................................................... client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level Closes: OS#5615 Change-Id: I9b54a53ef2809c9bfd110636a9ccb0c0d8c90cda --- M src/client/main_fsm.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/65/28565/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9b54a53ef2809c9bfd110636a9ccb0c0d8c90cda Gerrit-Change-Number: 28565 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

Change in osmo-remsim[master]: Install + package remsim-apitool as separate sub-package
by laforge 13 Jul '22

13 Jul '22

Attention is currently required from: laforge, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28563 ) Change subject: Install + package remsim-apitool as separate sub-package ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I11d779f66833b5294ffeb422ce6b2a705719a899 Gerrit-Change-Number: 28563 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Jul 2022 07:12:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: debian/control: Don't use misc:Package
by laforge 13 Jul '22

13 Jul '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28588 ) Change subject: debian/control: Don't use misc:Package ...................................................................... debian/control: Don't use misc:Package dpkg-gencontrol: warning: package osmo-remsim-doc: substitution variable ${misc:Package} used, but is not defined dpkg-gencontrol: warning: package osmo-remsim-doc: substitution variable ${misc:Package} used, but is not defined and indeed, the variable seems to substitute to an empty string, resulting in $ apt-cache search osmo-remsim-doc osmo-remsim-doc/unknown 1.0.0 all PDF documentation Change-Id: I58d267ea61dd9d71e7b9e630e71fd2f64f274569 --- M debian/control 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/88/28588/1 diff --git a/debian/control b/debian/control index b899b0f..a9e2e56 100644 --- a/debian/control +++ b/debian/control @@ -105,5 +105,5 @@ Section: doc Priority: optional Depends: ${misc:Depends} -Description: ${misc:Package} PDF documentation - User manual for ${misc:Package} in PDF format. +Description: Osmocom Remote SIM documentation + User manual for Osmocom Remote SIM in PDF format. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I58d267ea61dd9d71e7b9e630e71fd2f64f274569 Gerrit-Change-Number: 28588 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-remsim[master]: bankd: Log not just ModemToCard but also CardToModem
by laforge 13 Jul '22

13 Jul '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28564 ) Change subject: bankd: Log not just ModemToCard but also CardToModem ...................................................................... bankd: Log not just ModemToCard but also CardToModem This way we'll get a full trace of commands and repsonses. Right now the log only shows one direction which is a bit odd. Related: OS#5615 Change-Id: Ia2de0b850ce78074a411cf0edebfb3ad19253d34 --- M src/bankd/bankd_main.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 8c1c9a8..b28eec9 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -746,6 +746,7 @@ if (rc < 0) return rc; + LOGW(worker, "Tx RSPRO tpduCardToModem(%s)\n", osmo_hexdump_nospc(rx_buf, rx_buf_len)); /* encode response PDU and send it */ pdu_resp = rspro_gen_TpduCard2Modem(&mdm2sim->toBankSlot, &mdm2sim->fromClientSlot, rx_buf, rx_buf_len); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia2de0b850ce78074a411cf0edebfb3ad19253d34 Gerrit-Change-Number: 28564 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-remsim[master]: bankd: Log not just ModemToCard but also CardToModem
by laforge 13 Jul '22

13 Jul '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28564 ) Change subject: bankd: Log not just ModemToCard but also CardToModem ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia2de0b850ce78074a411cf0edebfb3ad19253d34 Gerrit-Change-Number: 28564 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Jul 2022 05:32:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: bankd: log BankID:SlotNr in every log line
by laforge 13 Jul '22

13 Jul '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28561 ) Change subject: bankd: log BankID:SlotNr in every log line ...................................................................... bankd: log BankID:SlotNr in every log line It's relatively inconvenient having to mentally map the slot-number to a thread-id on every (re)connect to correlate the logs. The logs should contain the Bank/Slot number they relate to. Closes: OS#5611 Change-Id: I84879609781a301338dacde7ff495632e3af08b9 --- M src/bankd/bankd.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/bankd/bankd.h b/src/bankd/bankd.h index c007802..9bf9bc9 100644 --- a/src/bankd/bankd.h +++ b/src/bankd/bankd.h @@ -20,7 +20,7 @@ extern struct value_string worker_state_names[]; #define LOGW(w, fmt, args...) \ - LOGP(DBANKDW, LOGL_INFO, "[%03u %s] " fmt, (w)->num, get_value_string(worker_state_names, (w)->state), \ + LOGP(DBANKDW, LOGL_INFO, "[%03u B%u:%u %s] " fmt, (w)->num, (w)->slot.bank_id, (w)->slot.slot_nr, get_value_string(worker_state_names, (w)->state), \ ## args) struct bankd; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I84879609781a301338dacde7ff495632e3af08b9 Gerrit-Change-Number: 28561 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-remsim[master]: main_fsm: Log bankd config (ip/port/bank_id/slot_nr) + disconnect
by laforge 13 Jul '22

13 Jul '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28562 ) Change subject: main_fsm: Log bankd config (ip/port/bank_id/slot_nr) + disconnect ...................................................................... main_fsm: Log bankd config (ip/port/bank_id/slot_nr) + disconnect Closes: OS#6513 Change-Id: I30a814ba95eb9c545220a1513805f41ccb5acb42 --- M src/client/main_fsm.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/client/main_fsm.c b/src/client/main_fsm.c index 0aa7429..be3238f 100644 --- a/src/client/main_fsm.c +++ b/src/client/main_fsm.c @@ -233,6 +233,7 @@ switch (event) { case MF_E_BANKD_LOST: + LOGPFSML(fi, LOGL_ERROR, "Connection to bankd lost\n"); osmo_fsm_inst_state_chg(fi, MF_ST_WAIT_BANKD, 0, 0); break; case MF_E_SRVC_CONFIG_BANK: @@ -244,6 +245,8 @@ rspro_IpAddr2str(&pdu_rx->msg.choice.configClientBankReq.bankd.ip)); bc->bankd_conn.server_port = pdu_rx->msg.choice.configClientBankReq.bankd.port; rspro2bank_slot(&bc->bankd_slot, &pdu_rx->msg.choice.configClientBankReq.bankSlot); + LOGPFSML(fi, LOGL_INFO, "Rx configClientBankReq(%s:%u / B%u:%u)\n", bc->bankd_conn.server_host, + bc->bankd_conn.server_port, bc->bankd_slot.bank_id, bc->bankd_slot.slot_nr); /* bankd port 0 is a magic value to indicate "no bankd" */ if (bc->bankd_conn.server_port == 0) osmo_fsm_inst_state_chg(fi, MF_ST_UNCONFIGURED, 0, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I30a814ba95eb9c545220a1513805f41ccb5acb42 Gerrit-Change-Number: 28562 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2025

2024

2023

2022

gerrit-log