- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by osmith 28 Nov '25

28 Nov '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/00bed74c_4821… : PS1, Line 654: /* FIXME: DUNA doesn't exist in IPA. Sould we probably receive SCCP UDTS here? */ so it cannot fail here because of https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524/comment/5d1b0c3a_5c202… seems a bit weird at first, but still makes sense to add this I guess, so it could be extended in the future and so we can easily get into that code path from a test when working on it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Nov 2025 13:42:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: mtp3: Implement RTPC transfer prohibited to concerned SP or STP
by osmith 28 Nov '25

28 Nov '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524?usp=email ) Change subject: mtp3: Implement RTPC transfer prohibited to concerned SP or STP ...................................................................... Patch Set 1: (1 comment) File src/mtp3_rtpc.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524/comment/5d1b0c3a_5c202… : PS1, Line 118: /* FIXME: No DUNA in IPA, maybe send SUA CLDR (SCCP UDTS) instead? */ log a message when this happens? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7e89db3d82374ca03a2e71fb558c7cec9bd651c4 Gerrit-Change-Number: 41524 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Nov 2025 13:39:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sigtran[master]: mtp3: Implement RTPC transfer prohibited to concerned SP or STP
by osmith 28 Nov '25

28 Nov '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524?usp=email ) Change subject: mtp3: Implement RTPC transfer prohibited to concerned SP or STP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7e89db3d82374ca03a2e71fb558c7cec9bd651c4 Gerrit-Change-Number: 41524 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Nov 2025 13:31:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: Split ss7_hmrt.c into mtp3_hm{dc,dt,rt}.c
by osmith 28 Nov '25

28 Nov '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41521?usp=email ) Change subject: Split ss7_hmrt.c into mtp3_hm{dc,dt,rt}.c ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1b94c1474722b49ce29796681cfbcfce65c95388 Gerrit-Change-Number: 41521 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Nov 2025 13:27:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by pespin 28 Nov '25

28 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... stp: Introduce tests to validate inaccessible SP scenario Related: OS#6892 Related: libosmo-sigtran.git Change-Id I7e89db3d82374ca03a2e71fb558c7cec9bd651c4 Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d --- M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml 3 files changed, 88 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/41525/1 diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index b110228..c518829 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -638,6 +638,25 @@ f_tc_combinedlset_loadshare(true); } +/* test "traffic-mode override" behavior */ +testcase TC_inaccessible_sp() runs on IPA_CT { + var Misc_Helpers.ro_charstring asps := { "ipa-asp-override-sender" }; + var IpaConfigs ipa_configs := ipa_build_configs(asps); + f_init_ipa(ipa_configs := ipa_configs); + + /* bring up the 'sender' side (single ASP in AS) */ + f_connect_ipa(0); + /* Here none of ipa-asp-override-receiver* is brought up on purpose, so test route failure inside IUT. */ + + var octetstring data := f_SCCP_UDT(); + f_IPA_send(0, data); + + /* FIXME: DUNA doesn't exist in IPA. Sould we probably receive SCCP UDTS here? */ + f_sleep(1.0); + + setverdict(pass); +} + private function f_IPA_ping(integer idx) runs on IPA_CT { var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING; @@ -753,6 +772,7 @@ execute( TC_unknown_client_dynamic_tmt_loadshare() ); execute( TC_combinedlset_loadshare() ); execute( TC_unknown_client_dynamic_combinedlset_loadshare() ); + execute( TC_inaccessible_sp() ); execute( TC_beat() ); execute( TC_beat_timeout() ); diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index ebdb6e1..d4c4dc8 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -49,6 +49,12 @@ M3uaConfigs mp_m3ua_configs := {}; integer mp_recovery_timeout_msec := 2000; charstring mp_sccp_service_type := "mtp3_itu"; + + /* Some PC which is known to be inaccessible for the IUT (no route) */ + integer mp_inaccessible_pc := 666; + + /* Network Indicator of the STP (IUT) network: */ + OCT1 mp_ni := '00'O; } type record M3uaConfig { @@ -669,7 +675,7 @@ /* Test if traffic is routed from idx_tx/pc_tx to idx_rx/pc_rx */ friend function f_test_traffic(integer idx_tx, template (omit) OCT4 rctx_sender, OCT4 pc_tx, integer idx_rx, template (omit) OCT4 rctx_receiver, OCT4 pc_rx, - OCT1 si := '23'O, OCT1 ni := '00'O, OCT1 mp := '00'O, OCT1 sls := '00'O) + OCT1 si := '23'O, OCT1 ni := mp_ni, OCT1 mp := '00'O, OCT1 sls := '00'O) runs on RAW_M3UA_CT { var octetstring data := f_rnd_octstring_rnd_len(100); f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, @@ -1765,6 +1771,62 @@ f_clear_m3ua(); } +private function f_tc_inaccessible_sp_duna(integer idx_tx, OCT4 pc_sender, OCT4 rctx_sender, + OCT4 pc_receiver, OCT4 rctx_receiver) runs on RAW_M3UA_CT { + var octetstring data := f_rnd_octstring_rnd_len(100); + var template (value) M3UA_Protocol_Data m3ua_data; + + /* bring up the sender specifying a routing context */ + f_M3UA_asp_up_act(idx_tx, rctx := rctx_sender); + + /* check if DATA is accepted without Routing Context IE */ + m3ua_data := ts_M3UA_protocol_data(pc_sender, pc_receiver, si:= '23'O, ni := mp_ni, + mp := '00'O, sls := '00'O, data := data); + f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, m3ua_data), 1); + f_M3UA_exp(idx_tx, tr_M3UA_DUNA({ts_M3UA_PC(oct2int(pc_receiver), 0)}, rctx_sender)); + + /* TODO: test Q.704 timer T8: After we received the first DUNA, if we send another message we shouldn't receive another DUNA until T8 times out. + * Soe here we need: + * f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, m3ua_data), 1); + * f_M3UA_exp_no(idx_tx, tr_M3UA_DUNA({ts_M3UA_PC(oct2int(pc_receiver), 0)}, rctx_sender), timeout := T8) + * f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, m3ua_data), 1); + * f_M3UA_exp(idx_tx, tr_M3UA_DUNA({ts_M3UA_PC(oct2int(pc_receiver), 0)}, rctx_sender)); + **/ + + f_clear_m3ua(); +} + +/* test whether the STP sends back a M3UA DUNA when receiving a pkt towards an inaccessible SP (non existing/routable PC) */ +testcase TC_inaccessible_sp_duna() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-sender" }; + var M3uaConfigs m3ua_configs := m3ua_build_configs(asps); + var OCT4 rctx_sender := int2oct(m3ua_configs[0].routing_ctx, 4); + var OCT4 pc_sender := int2oct(m3ua_configs[0].point_code, 4); + var OCT4 rctx_receiver := int2oct(3, 4); + var OCT4 pc_receiver := int2oct(mp_inaccessible_pc, 4); + + f_init_m3ua(m3ua_configs := m3ua_configs); + + /* bring up the sender specifying a routing context */ + f_tc_inaccessible_sp_duna(0, pc_sender, rctx_sender, pc_receiver, rctx_receiver); +} + +/* test whether the STP sends back a M3UA DUNA when receiving a pkt towards an + * inaccessible SP (PC/AS known but no active ASPs towards it). */ +testcase TC_inaccessible_sp_duna2() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-sender", "asp-receiver0" }; + var M3uaConfigs m3ua_configs := m3ua_build_configs(asps); + var OCT4 rctx_sender := int2oct(m3ua_configs[0].routing_ctx, 4); + var OCT4 pc_sender := int2oct(m3ua_configs[0].point_code, 4); + var OCT4 rctx_receiver := int2oct(m3ua_configs[1].routing_ctx, 4); + var OCT4 pc_receiver := int2oct(m3ua_configs[1].point_code, 4); + + f_init_m3ua(m3ua_configs := m3ua_configs); + + /* bring up the sender specifying a routing context */ + f_tc_inaccessible_sp_duna(0, pc_sender, rctx_sender, pc_receiver, rctx_receiver); +} + control { /* M3UA Tests */ execute( TC_connect_asp_up() ); @@ -1782,6 +1844,8 @@ execute( TC_act_rctx_data_no_rctx() ); execute( TC_m3ua_sctp_srv_adm_shutdown() ); execute( TC_combinedlset_loadshare() ); + execute( TC_inaccessible_sp_duna() ); + execute( TC_inaccessible_sp_duna2() ); /* M3UA RKM tests */ execute( TC_rkm_reg_static_notpermitted() ); diff --git a/stp/expected-results.xml b/stp/expected-results.xml index e0170de..5834abb 100644 --- a/stp/expected-results.xml +++ b/stp/expected-results.xml @@ -15,6 +15,8 @@ <testcase classname='STP_Tests_M3UA' name='TC_act_rctx_data_no_rctx' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_m3ua_sctp_srv_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_combinedlset_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_inaccessible_sp_duna' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_inaccessible_sp_duna2' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_static_notpermitted' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_static_permitted' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_dynamic_permitted' time='MASKED'/> @@ -61,6 +63,7 @@ <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_tmt_loadshare' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_combinedlset_loadshare' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_combinedlset_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_inaccessible_sp' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat_timeout' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_clnt_beat_timeout' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: mtp3: Implement RTPC transfer prohibited to concerned SP or STP
by pespin 28 Nov '25

28 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524?usp=email ) Change subject: mtp3: Implement RTPC transfer prohibited to concerned SP or STP ...................................................................... mtp3: Implement RTPC transfer prohibited to concerned SP or STP Send Transfer prohibited (DUNA in M3UA) to originator upon trying to route message to inaccessible DPC, as explained in Q.704 Figure 44 and section 13.2. Related: OS#6892 Change-Id: I7e89db3d82374ca03a2e71fb558c7cec9bd651c4 --- M src/Makefile.am M src/m3ua.c M src/mtp3_hmrt.c A src/mtp3_rtpc.c A src/mtp3_rtpc.h M src/xua_internal.h 6 files changed, 151 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/24/41524/1 diff --git a/src/Makefile.am b/src/Makefile.am index 29cf10a..f51819e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -6,6 +6,7 @@ mtp3_hmdc.h \ mtp3_hmdt.h \ mtp3_hmrt.h \ + mtp3_rtpc.h \ sccp_connection.h \ sccp_scoc_fsm.h \ sccp_instance.h \ @@ -53,6 +54,7 @@ mtp3_hmdc.c \ mtp3_hmdt.c \ mtp3_hmrt.c \ + mtp3_rtpc.c \ sccp2sua.c \ sccp_connection.c \ sccp_helpers.c \ diff --git a/src/m3ua.c b/src/m3ua.c index 36018e1..2b7c1e7 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -864,9 +864,9 @@ ***********************************************************************/ /* 3.4.1 Destination Unavailable (DUNA) */ -static struct xua_msg *m3ua_encode_duna(const uint32_t *rctx, unsigned int num_rctx, - const uint32_t *aff_pc, unsigned int num_aff_pc, - const char *info_string) +struct xua_msg *m3ua_encode_duna(const uint32_t *rctx, unsigned int num_rctx, + const uint32_t *aff_pc, unsigned int num_aff_pc, + const char *info_string) { struct xua_msg *xua = xua_msg_alloc(); diff --git a/src/mtp3_hmrt.c b/src/mtp3_hmrt.c index 9ab7e33..25b2bc4 100644 --- a/src/mtp3_hmrt.c +++ b/src/mtp3_hmrt.c @@ -36,6 +36,7 @@ #include <osmocom/sigtran/protocol/m3ua.h> #include "mtp3_hmdc.h" +#include "mtp3_rtpc.h" #include "xua_internal.h" #include "ss7_as.h" #include "ss7_asp.h" @@ -111,8 +112,9 @@ } else { LOGSS7(inst, LOGL_ERROR, "MTP-TRANSFER.req for dpc=%u=%s: no route!\n", dpc, osmo_ss7_pointcode_print(inst, dpc)); - /* DPC unknown HMRT -> MGMT */ - /* Message Received for inaccesible SP HMRT ->RTPC */ + /* "Message received for unknown SP HMRT -> MGMT"*/ + /* "Message received for inaccessible SP HMRT -> RTPC" */ + mtp3_rtpc_rx_msg_for_inaccessible_sp(inst, xua); /* Discard Message */ } xua_msg_free(xua); diff --git a/src/mtp3_rtpc.c b/src/mtp3_rtpc.c new file mode 100644 index 0000000..b832fcf --- /dev/null +++ b/src/mtp3_rtpc.c @@ -0,0 +1,127 @@ +/*********************************************************************** + * MTP Level 3 - Transfer prohibited control (RTPC), ITU Q.704 Figure 44 + ***********************************************************************/ + +/* (C) 2025 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <stdint.h> + +#include <osmocom/sigtran/protocol/m3ua.h> +#include <osmocom/sigtran/osmo_ss7.h> + +#include "mtp3_hmdt.h" +#include "mtp3_rtpc.h" +#include "ss7_as.h" +#include "ss7_internal.h" +#include "ss7_route.h" +#include "ss7_route_table.h" +#include "xua_internal.h" +#include "xua_msg.h" + +/* Generate a DUNA message to be sent back to originator. */ +static struct xua_msg *gen_duna_ret_msg(struct osmo_ss7_instance *inst, const struct xua_msg *orig_xua) +{ + struct xua_msg *xua; + struct xua_msg_part *rctx_ie; + unsigned int num_rctx = 0; + uint32_t rctx = 0; + uint32_t aff_pc = htonl(orig_xua->mtp.dpc); + + if ((rctx_ie = xua_msg_find_tag(orig_xua, M3UA_IEI_ROUTE_CTX))) { + rctx = xua_msg_part_get_u32(rctx_ie); + num_rctx = 1; + } + xua = m3ua_encode_duna(&rctx, num_rctx, &aff_pc, 1, + "transfer prohibited (inaccessible SP)"); + OSMO_ASSERT(xua); + + xua->mtp = orig_xua->mtp; + xua->mtp.opc = orig_xua->mtp.dpc; + xua->mtp.dpc = orig_xua->mtp.opc; + return xua; +} + + /* Figure 44/Q.704 (sheet 1 of 3), "Message received for inaccessible SP HMRT -> RTPC" */ +int mtp3_rtpc_rx_msg_for_inaccessible_sp(struct osmo_ss7_instance *inst, const struct xua_msg *orig_xua) +{ + struct xua_msg *xua; + char buf_orig_opc[MAX_PC_STR_LEN]; + char buf_orig_dpc[MAX_PC_STR_LEN]; + struct osmo_ss7_route_label rtlabel; + struct osmo_ss7_route *rt; + + /* TODO: Start T8 */ + + /* "transfer prohibited RTPC -> HMRT", "To concerned SP or STP". + * See also Q.704 13.2 Transfer-prohibited. */ + + /* Note: There's no explicit mention of MTP3 TFP equivalent in RFC4666 (M3UA) specs, + * but section 1.4.3.2 explicitly mentions: "TFP ... MUST NOT be encapsulated as + * Data message Payload Data and sent either from SG to ASP or from ASP to + * SG. The SG MUST terminate these messages and generate M3UA messages, + * as appropriate." + * Best match for it is DUNA, so DUNA we send. + */ + + if (osmo_ss7_pc_is_local(inst, orig_xua->mtp.opc)) { + xua = gen_duna_ret_msg(inst, orig_xua); + return mtp3_hmdt_message_for_distribution(inst, xua); + } + + /* We should only be sending DUNA to M3UA peers, hence why we don't + * simply call mtp3_hmrt_message_for_routing() here. */ + rtlabel = (struct osmo_ss7_route_label){ + .opc = orig_xua->mtp.dpc, + .dpc = orig_xua->mtp.opc, + .sls = orig_xua->mtp.sls, + }; + rt = ss7_instance_lookup_route(inst, &rtlabel); + if (!rt) { + LOGSS7(inst, LOGL_NOTICE, "Tx TFP (DUNA) inaccessible SP %u=%s to concerned SP %u=%s: no route!\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + return 0; + } + if (!rt->dest.as) { + LOGSS7(inst, LOGL_ERROR, "Tx TFP (DUNA) inaccessible SP %u=%s to concerned SP %u=%s: unsupported for linkset!\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + return 0; + } + + switch (rt->dest.as->cfg.proto) { + case OSMO_SS7_ASP_PROT_M3UA: + LOGSS7(inst, LOGL_INFO, "Message received for inaccessible SP %u=%s. Tx TFP (DUNA) to concerned SP %u=%s\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + xua = gen_duna_ret_msg(inst, orig_xua); + return m3ua_tx_xua_as(rt->dest.as, xua); + case OSMO_SS7_ASP_PROT_IPA: + /* FIXME: No DUNA in IPA, maybe send SUA CLDR (SCCP UDTS) instead? */ + return 0; + default: + LOGSS7(inst, LOGL_ERROR, "DUNA message for ASP of unknown protocol %u\n", + rt->dest.as->cfg.proto); + return 0; + } + + return 0; +} diff --git a/src/mtp3_rtpc.h b/src/mtp3_rtpc.h new file mode 100644 index 0000000..8a0569d --- /dev/null +++ b/src/mtp3_rtpc.h @@ -0,0 +1,11 @@ +#pragma once + +#include <stdint.h> +#include <unistd.h> + +#include <osmocom/sigtran/mtp_sap.h> + +#include "ss7_instance.h" +#include "xua_msg.h" + +int mtp3_rtpc_rx_msg_for_inaccessible_sp(struct osmo_ss7_instance *inst, const struct xua_msg *xua); diff --git a/src/xua_internal.h b/src/xua_internal.h index a1023c1..8674ef5 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -53,6 +53,10 @@ void m3ua_tx_dupu(struct osmo_ss7_asp *asp, const uint32_t *rctx, unsigned int num_rctx, uint32_t dpc, uint16_t user, uint16_t cause, const char *info_str); +struct xua_msg *m3ua_encode_duna(const uint32_t *rctx, unsigned int num_rctx, + const uint32_t *aff_pc, unsigned int num_aff_pc, + const char *info_string); + void xua_tx_snm_available(struct osmo_ss7_asp *asp, const uint32_t *rctx, unsigned int num_rctx, const uint32_t *aff_pc, unsigned int num_aff_pc, const char *info_str, bool available); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7e89db3d82374ca03a2e71fb558c7cec9bd651c4 Gerrit-Change-Number: 41524 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 28 Nov '25

28 Nov '25

Attention is currently required from: laforge, lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 16: (1 comment) File tests/vty/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/3fce46c5_82597… : PS15, Line 35: ss7_asp_test.vty \ This is still wrong, but I don't think it explains the build failures in the jenkins job. @osmith@sysmocom.de any ideas? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 28 Nov 2025 11:04:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 28 Nov '25

28 Nov '25

Attention is currently required from: laforge, lynxis lazus, pespin. daniel has uploaded a new patch set (#16) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified-1 by Jenkins Builder Change subject: Add TCAP based loadsharing/routing ...................................................................... Add TCAP based loadsharing/routing TCAP based loadsharing will share the load based on the TCAP oTID and dTID. Because TCAP are session based, a TCAP session based tracking is implemented, to allow following traffic to forwarded to the same ASP. This TCAP session tracking is similar to IP connection tracking. ASPs within an AS can use the new IPA TCAP ROUTING protocol to register for specific TCAP ranges. TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP), will use the oTID of the `TCAP Begin` to loadshare and select a ASP. Further if the TCAP session was initiated by a `loadshared` ASP, the oTID will be added to the session tracking. Co-authored-by: Harald Welte <laforge(a)osmocom.org> Co-authored-by: Alexander Couzens <lynxis(a)fe80.eu> Co-authored-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Related: SYS#5423 Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d --- M configure.ac M src/Makefile.am M src/ipa.c M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/ss7_asp.h A src/tcap_as_loadshare.c A src/tcap_as_loadshare.h A src/tcap_trans_tracking.c A src/tcap_trans_tracking.h M src/xua_asp_fsm.c M tests/Makefile.am A tests/tcap/Makefile.am A tests/tcap/tcap_transaction_tracking_test.c A tests/tcap/tcap_transaction_tracking_test.ok M tests/testsuite.at M tests/vty/Makefile.am M tests/vty/osmo_stp_test.vty A tests/vty/osmo_stp_test_tcap.vty 20 files changed, 1,979 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/16 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmocore[master]: Add DLTCAP log category
by daniel 28 Nov '25

28 Nov '25

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email ) Change subject: Add DLTCAP log category ...................................................................... Add DLTCAP log category Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f Related: SYS#5423 --- M include/osmocom/core/logging.h M src/core/logging.c M tests/logging/logging_vty_test.vty 3 files changed, 11 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index 82e686f..9d4f1fb 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -155,7 +155,8 @@ #define DLM2PA -27 /*!< Osmocom M2PA (libosmo-sigtran) */ #define DLM2UA -28 /*!< Reserved for future Osmocom M2UA (libosmo-sigtran) */ #define DLIO -29 /*!< Osmocom IO sub-system */ -#define OSMO_NUM_DLIB 29 /*!< Number of logging sub-systems in libraries */ +#define DLTCAP -30 /*!< Osmocom TCAP */ +#define OSMO_NUM_DLIB 30 /*!< Number of logging sub-systems in libraries */ /* Colors that can be used in log_info_cat.color */ #define OSMO_LOGCOLOR_NORMAL NULL diff --git a/src/core/logging.c b/src/core/logging.c index e172124..cccfd93 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -393,6 +393,12 @@ .enabled = 1, .loglevel = LOGL_NOTICE, .color = "\033[38;5;67m", }, + [INT2IDX(DLTCAP)] = { + .name = "DLTCAP", + .description = "TCAP", + .enabled = 1, .loglevel = LOGL_NOTICE, + .color = "\033[38;5;69m", + }, }; void assert_loginfo(const char *src) diff --git a/tests/logging/logging_vty_test.vty b/tests/logging/logging_vty_test.vty index da09be7..edf0512 100644 --- a/tests/logging/logging_vty_test.vty +++ b/tests/logging/logging_vty_test.vty @@ -54,7 +54,7 @@ logging print level (0|1) logging print file (0|1|basename) [last] logging set-log-mask MASK - logging level (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1|lio) (debug|info|notice|error|fatal) + logging level (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1|lio|ltcap) (debug|info|notice|error|fatal) logging level set-all (debug|info|notice|error|fatal) logging level force-all (debug|info|notice|error|fatal) no logging level force-all @@ -568,7 +568,7 @@ logging_vty_test# list ... - logp (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1|lio) (debug|info|notice|error|fatal) .LOGMESSAGE + logp (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1|lio|ltcap) (debug|info|notice|error|fatal) .LOGMESSAGE ... logging_vty_test# logp? @@ -607,6 +607,7 @@ lpfcp libosmo-pfcp Packet Forwarding Control Protocol lcsn1 libosmo-csn1 Concrete Syntax Notation 1 codec lio libosmocore IO Subsystem + ltcap TCAP logging_vty_test# logp lglobal ? debug Log debug messages and higher levels -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f Gerrit-Change-Number: 41520 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: Add DLTCAP log category
by pespin 28 Nov '25

28 Nov '25

Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email ) Change subject: Add DLTCAP log category ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f Gerrit-Change-Number: 41520 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Nov 2025 08:46:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log