- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by pespin 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 2: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/45bb59ed_5a77… : PS2, Line 207: "while waiting for ", msg)); > the first message could mention that the message is unexpected within the timer It does: "received unexpected M3UA". > wonder if the msg parameter is even useful, It is, because it quickly tells you which message arrived. I think this second branch is still useful because it tells you of non-envisioned scenarios for the test, besides the one specific obvious/known scenario. So it's good to have them diffentiated, and it's good to have it since it may uncover other bugs. I think in general the comments are fine, in the end they are useful to get a file+line and see where it fails, when it becomes obvious, but I'll try to improve the strings. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 08:32:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: add support for VND.THEMWI.CCSD codec
by pespin 01 Dec '25

01 Dec '25

Attention is currently required from: falconia, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email ) Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 Gerrit-Change-Number: 41529 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 01 Dec 2025 08:27:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by osmith 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 2: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/aad23743_c322… : PS2, Line 207: "while waiting for ", msg)); IMHO the error messages are hard to understand. - the first message could mention that the message is unexpected within the timer - the second message has "while waiting for", but this function does the opposite, it waits for the timer to pass and checks that the message does *not* arrive I wonder if the msg parameter is even useful, couldn't it just ensure that no message arrives (except for the beat if answer_beat is true) until the timeout is done, and have one obvious error message saying that an unexpected message arrived before the timeout? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 07:38:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in ...osmo-s1gw[master]: config/sys.config: document available sockopts
by fixeria 01 Dec '25

01 Dec '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41532?usp=email ) Change subject: config/sys.config: document available sockopts ...................................................................... config/sys.config: document available sockopts Change-Id: Ie6b62839ec1634078b292cdd7e0f2a481ebd83fc Related: SYS#7653 --- M config/sys.config 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/32/41532/1 diff --git a/config/sys.config b/config/sys.config index f17dd13..3c8f0f3 100644 --- a/config/sys.config +++ b/config/sys.config @@ -10,8 +10,9 @@ laddr => "127.0.1.1", %% local (bind) port for incoming eNB connections lport => 36412, - %% socket options (recbuf, sndbuf, nodelay) - %% if omitted or left empty, defaults apply + %% socket options (if omitted or left empty, defaults apply) + %% * recbuf/sndbuf - Rx/Rx buffer size (default: 65536) + %% * nodelay - enable (false) / disable (true) the Naggle (default: true) sockopts => #{ } }}, %% SCTP client configuration @@ -22,8 +23,7 @@ raddr => "127.0.2.10", %% remote port for outgoing connections to the MME rport => 36412, - %% socket options (recbuf, sndbuf, nodelay) - %% if omitted or left empty, defaults apply + %% socket options (if omitted or left empty, defaults apply) - see above sockopts => #{ } }}, {pfcp_loc_addr, "127.0.1.1"}, %% local address for incoming PFCP PDUs from the UPF -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6b62839ec1634078b292cdd7e0f2a481ebd83fc Gerrit-Change-Number: 41532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_common: gen_sockopts/1: add heartbeat and RTO params
by fixeria 01 Dec '25

01 Dec '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params ...................................................................... sctp_common: gen_sockopts/1: add heartbeat and RTO params Set the SCTP heartbeat interval and Retransmission time-out params explicitly for both sctp_{client,server}. Make the relevant values configurable via the environment (config file). Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3 Co-authored-by: Andreas Eversberg <jolly(a)eversberg.eu> Related: SYS#7653 --- M config/sys.config M src/sctp_common.erl 2 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/31/41531/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3 Gerrit-Change-Number: 41531 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in ...osmo-s1gw[master]: config/sys.config: group sctp_{client,server} params into maps
by fixeria 30 Nov '25

30 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41530?usp=email ) Change subject: config/sys.config: group sctp_{client,server} params into maps ...................................................................... config/sys.config: group sctp_{client,server} params into maps A follow-up patch brings even more SCTP SockOpts related params. Let's prepare for this by grouping the existing sctp_{client,server} related variables into distinct maps and moving the socket options into their own sub-map. Keep support for legacy options, for the sake of backwards compatibility. This helps to avoid having two instances of each new parameter (s1gw_ and mme_) and generally improves readability/editability of the config file. Change-Id: Ib573915fdeb3ce73a1f6110c19fd6b1d46e68a03 Related: SYS#7653 --- M config/sys.config M src/osmo_s1gw_sup.erl M src/sctp_common.erl 3 files changed, 67 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/30/41530/1 diff --git a/config/sys.config b/config/sys.config index 9ad1ca2..f17dd13 100644 --- a/config/sys.config +++ b/config/sys.config @@ -2,18 +2,30 @@ [%% ================================================================================ %% application config - %% - %% eNB S1GW - %% +-----+ +----------------+ - %% | ... | --> | s1gw_bind_addr | MME - %% +-----+ +----------------+ +-----------------+ - %% | mme_loc_addr | --> | mme_rem_addr | - %% +----------------+ +-----------------+ %% ================================================================================ - {osmo_s1gw, - [{s1gw_bind_addr, "127.0.1.1"}, %% S1GW bind address for incoming eNB connections - {mme_loc_addr, "127.0.2.1"}, %% local address for outgoing connections to the MME - {mme_rem_addr, "127.0.2.10"}, %% remote address for outgoing connections to the MME + {osmo_s1gw, [ + %% SCTP server configuration + {sctp_server, #{ + %% local (bind) address for incoming eNB connections + laddr => "127.0.1.1", + %% local (bind) port for incoming eNB connections + lport => 36412, + %% socket options (recbuf, sndbuf, nodelay) + %% if omitted or left empty, defaults apply + sockopts => #{ } + }}, + %% SCTP client configuration + {sctp_client, #{ + %% local (bind) address for outgoing connections to the MME + laddr => "127.0.2.1", + %% remote address for outgoing connections to the MME + raddr => "127.0.2.10", + %% remote port for outgoing connections to the MME + rport => 36412, + %% socket options (recbuf, sndbuf, nodelay) + %% if omitted or left empty, defaults apply + sockopts => #{ } + }}, {pfcp_loc_addr, "127.0.1.1"}, %% local address for incoming PFCP PDUs from the UPF {pfcp_rem_addr, "127.0.1.2"} %% remote address for outgoing PFCP PDUs to the UPF %% Optional PFCP Network Instance IEs (omitted if not configured) diff --git a/src/osmo_s1gw_sup.erl b/src/osmo_s1gw_sup.erl index 1616fe5..bde7b54 100644 --- a/src/osmo_s1gw_sup.erl +++ b/src/osmo_s1gw_sup.erl @@ -41,8 +41,6 @@ -include("s1ap.hrl"). -define(SERVER, ?MODULE). --define(ENV_DEFAULT_SCTP_BUFSZ, 65536). --define(ENV_DEFAULT_SCTP_NODELAY, true). -define(ENV_DEFAULT_S1GW_BIND_ADDR, "127.0.1.1"). -define(ENV_DEFAULT_S1GW_BIND_PORT, ?S1AP_PORT). -define(ENV_DEFAULT_MME_LOC_ADDR, "127.0.2.1"). @@ -103,26 +101,44 @@ %% private API %% ------------------------------------------------------------------ +-spec parse_env_map(map()) -> map(). +parse_env_map(M0) -> + M1 = maps:map(fun(_, P) -> osmo_s1gw:get_env(P, undefined) end, M0), + maps:filter(fun(_, V) -> V =/= undefined end, M1). + -spec client_cfg() -> sctp_client:cfg(). client_cfg() -> - SockOpts = #{sctp_nodelay => osmo_s1gw:get_env(mme_nodelay, ?ENV_DEFAULT_SCTP_NODELAY), - recbuf => osmo_s1gw:get_env(mme_recbuf, ?ENV_DEFAULT_SCTP_BUFSZ), - sndbuf => osmo_s1gw:get_env(mme_sndbuf, ?ENV_DEFAULT_SCTP_BUFSZ)}, - #{laddr => osmo_s1gw:get_env(mme_loc_addr, ?ENV_DEFAULT_MME_LOC_ADDR), - raddr => osmo_s1gw:get_env(mme_rem_addr, ?ENV_DEFAULT_MME_REM_ADDR), - rport => osmo_s1gw:get_env(mme_rem_port, ?ENV_DEFAULT_MME_REM_PORT), - sockopts => maps:to_list(SockOpts)}. + %% parse old/legacy environment options, if any + OldCfg = parse_env_map(#{laddr => mme_loc_addr, + raddr => mme_rem_addr, + rport => mme_rem_port}), + OldSockOpts = parse_env_map(#{nodelay => mme_nodelay, + recbuf => mme_recbuf, + sndbuf => mme_sndbuf}), + %% parse the new sctp_client configuration block + Cfg = maps:merge(OldCfg, osmo_s1gw:get_env(sctp_client, #{ })), + SockOpts = maps:merge(OldSockOpts, maps:get(sockopts, Cfg, #{ })), + #{laddr => maps:get(laddr, Cfg, ?ENV_DEFAULT_MME_LOC_ADDR), + raddr => maps:get(raddr, Cfg, ?ENV_DEFAULT_MME_REM_ADDR), + rport => maps:get(rport, Cfg, ?ENV_DEFAULT_MME_REM_PORT), + sockopts => sctp_common:gen_sockopts(SockOpts)}. -spec server_cfg() -> sctp_server:cfg(). server_cfg() -> - SockOpts = #{sctp_nodelay => osmo_s1gw:get_env(s1gw_nodelay, ?ENV_DEFAULT_SCTP_NODELAY), - recbuf => osmo_s1gw:get_env(s1gw_recbuf, ?ENV_DEFAULT_SCTP_BUFSZ), - sndbuf => osmo_s1gw:get_env(s1gw_sndbuf, ?ENV_DEFAULT_SCTP_BUFSZ)}, - #{laddr => osmo_s1gw:get_env(s1gw_bind_addr, ?ENV_DEFAULT_S1GW_BIND_ADDR), - lport => osmo_s1gw:get_env(s1gw_bind_port, ?ENV_DEFAULT_S1GW_BIND_PORT), - sockopts => maps:to_list(SockOpts), + %% parse old/legacy environment options, if any + DefCfg = parse_env_map(#{laddr => s1gw_bind_addr, + lport => s1gw_bind_port}), + DefSockOpts = parse_env_map(#{nodelay => s1gw_nodelay, + recbuf => s1gw_recbuf, + sndbuf => s1gw_sndbuf}), + %% parse the new sctp_server configuration block + Cfg = maps:merge(DefCfg, osmo_s1gw:get_env(sctp_server, #{ })), + SockOpts = maps:merge(DefSockOpts, maps:get(sockopts, Cfg, #{ })), + #{laddr => maps:get(laddr, Cfg, ?ENV_DEFAULT_S1GW_BIND_ADDR), + lport => maps:get(lport, Cfg, ?ENV_DEFAULT_S1GW_BIND_PORT), + sockopts => sctp_common:gen_sockopts(SockOpts), handler => sctp_proxy, priv => client_cfg()}. diff --git a/src/sctp_common.erl b/src/sctp_common.erl index 9b86b50..9a57798 100644 --- a/src/sctp_common.erl +++ b/src/sctp_common.erl @@ -36,6 +36,7 @@ -export([parse_addr/1, report_error/1, + gen_sockopts/1, send_data/2, shutdown/1]). @@ -46,6 +47,10 @@ -include("s1ap.hrl"). +-define(SOCKOPTS_DEFAULT_BUFSZ, 65536). +-define(SOCKOPTS_DEFAULT_NODELAY, true). + + -type sock_aid() :: {gen_sctp:sctp_socket(), gen_sctp:assoc_id()}. @@ -84,6 +89,14 @@ end. +-spec gen_sockopts(map()) -> [gen_sctp:option()]. +gen_sockopts(SockOptsCfg) -> + SockOpts = #{recbuf => maps:get(recbuf, SockOptsCfg, ?SOCKOPTS_DEFAULT_BUFSZ), + sndbuf => maps:get(sndbuf, SockOptsCfg, ?SOCKOPTS_DEFAULT_BUFSZ), + sctp_nodelay => maps:get(nodelay, SockOptsCfg, ?SOCKOPTS_DEFAULT_NODELAY)}, + maps:to_list(SockOpts). + + -spec send_data(sock_aid(), binary()) -> ok | {error, term()}. send_data({Sock, Aid}, Data) -> gen_sctp:send(Sock, #sctp_sndrcvinfo{stream = ?S1AP_SCTP_STREAM, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41530?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib573915fdeb3ce73a1f6110c19fd6b1d46e68a03 Gerrit-Change-Number: 41530 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_common: gen_sockopts/1: add heartbeat and RTO params
by fixeria 30 Nov '25

30 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email ) Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params ...................................................................... sctp_common: gen_sockopts/1: add heartbeat and RTO params Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3 Co-authored-by: Andreas Eversberg <jolly(a)eversberg.eu> Related: SYS#7653 --- M src/sctp_common.erl 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/31/41531/1 diff --git a/src/sctp_common.erl b/src/sctp_common.erl index 9a57798..88be87c 100644 --- a/src/sctp_common.erl +++ b/src/sctp_common.erl @@ -49,6 +49,10 @@ -define(SOCKOPTS_DEFAULT_BUFSZ, 65536). -define(SOCKOPTS_DEFAULT_NODELAY, true). +-define(SOCKOPTS_DEFAULT_HBINTERVAL, 2000). +-define(SOCKOPTS_DEFAULT_RTO_INIT, 1000). +-define(SOCKOPTS_DEFAULT_RTO_MIN, 1000). +-define(SOCKOPTS_DEFAULT_RTO_MAX, 1000). -type sock_aid() :: {gen_sctp:sctp_socket(), @@ -91,9 +95,21 @@ -spec gen_sockopts(map()) -> [gen_sctp:option()]. gen_sockopts(SockOptsCfg) -> + %% heartbeat parameters + HBInterval = maps:get(hbinterval, SockOptsCfg, ?SOCKOPTS_DEFAULT_HBINTERVAL), + PAP = #sctp_paddrparams{assoc_id = 0, + hbinterval = HBInterval, + flags = [hb_enable]}, + %% retransmission time-out parameters + RTO = #sctp_rtoinfo{assoc_id = 0, + initial = maps:get(rto_initial, SockOptsCfg, ?SOCKOPTS_DEFAULT_RTO_INIT), + min = maps:get(rto_min, SockOptsCfg, ?SOCKOPTS_DEFAULT_RTO_MIN), + max = maps:get(rto_max, SockOptsCfg, ?SOCKOPTS_DEFAULT_RTO_MAX)}, SockOpts = #{recbuf => maps:get(recbuf, SockOptsCfg, ?SOCKOPTS_DEFAULT_BUFSZ), sndbuf => maps:get(sndbuf, SockOptsCfg, ?SOCKOPTS_DEFAULT_BUFSZ), - sctp_nodelay => maps:get(nodelay, SockOptsCfg, ?SOCKOPTS_DEFAULT_NODELAY)}, + sctp_nodelay => maps:get(nodelay, SockOptsCfg, ?SOCKOPTS_DEFAULT_NODELAY), + sctp_peer_addr_params => PAP, + sctp_rtoinfo => RTO}, maps:to_list(SockOpts). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3 Gerrit-Change-Number: 41531 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: add support for VND.THEMWI.CCSD codec
by falconia 30 Nov '25

30 Nov '25

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email ) Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The linter is being overly, unreasonably zealous here - the formatting changes it asks for would clearly worsen code readability, not improve. How do we override in such cases? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 Gerrit-Change-Number: 41529 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 30 Nov 2025 05:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: add support for VND.THEMWI.CCSD codec
by falconia 30 Nov '25

30 Nov '25

Attention is currently required from: falconia. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email ) Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/41529/comment/c638a64b_8d9ce0ef?usp… : PS1, Line 22: Beyond the present client library addition, desired support for I included this explanation to make it clear that I plan to follow up with patches to actual Osmocom programs, enabling compressed CSD functionality in Osmocom, rather than a library-only addition like some of my other recent patches. But I wonder if I should perhaps take this verbiage out of the commit message and maybe turn it into a standalone Gerrit comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 Gerrit-Change-Number: 41529 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sun, 30 Nov 2025 05:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: add support for VND.THEMWI.CCSD codec
by falconia 30 Nov '25

30 Nov '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email ) Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec ...................................................................... mgcp_client: add support for VND.THEMWI.CCSD codec TW-TS-007 defines a compressed RTP payload format for GSM CSD, reducing the payload size from 160 bytes of mostly constant filler bits to 16, 32 or 37 bytes depending on specific CSD mode: https://www.freecalypso.org/specs/tw-ts-007-v010001.txt Clause 9 specifies payload type number 127 when this pseudo-codec is used on AoIP interface, while Annex A gives it the name VND.THEMWI.CCSD for SDP. Add support for this codec to libosmo-mgcp-client, to make it possible for OsmoBSC and OsmoMSC to request this codec from MGWs. Beyond the present client library addition, desired support for compressed CSD per TW-TS-007 in Osmocom components is as follows: * Equip osmo-mgw rtpbridge with ability to convert between CCSD and CLEARMODE on the fly, using already merged libosmotrau functions for the actual conversion; * Add CCSD support to tw-e1abis-mgw while regular osmo-mgw has no CSD support at all in E1 mode; possibly bring tw-e1abis-mgw into Osmocom at some point; * Have OsmoBSC direct its MGW to emit CCSD when the CN requested it via TW-TS-003 BSSMAP extension; * Possibly add compressed CSD support to OsmoMSC. Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 --- M include/osmocom/mgcp_client/mgcp_client.h M src/libosmo-mgcp-client/mgcp_client.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/29/41529/1 diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h index 1d33690..d53f442 100644 --- a/include/osmocom/mgcp_client/mgcp_client.h +++ b/include/osmocom/mgcp_client/mgcp_client.h @@ -58,6 +58,7 @@ CODEC_AMRWB_16000_1 = 113, /* 3GPP TS 48.103 table 5.4.2.2.1 */ CODEC_IUFP = 96, CODEC_CLEARMODE = 120, /* 3GPP TS 48.103 table 5.4.2.2.1 */ + CODEC_COMPR_CSD = 127, /* compressed CSD per TW-TS-007 */ }; /* Note: when new codec types are added, the corresponding value strings * in mgcp_client.c (codec_table) must be updated as well. Enumerations diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 63d03f9..4924be4 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -61,6 +61,7 @@ { CODEC_AMRWB_16000_1, "AMR-WB/16000/1" }, { CODEC_IUFP, "VND.3GPP.IUFP/16000" }, { CODEC_CLEARMODE, "CLEARMODE/8000" }, + { CODEC_COMPR_CSD, "VND.THEMWI.CCSD/8000" }, { 0, NULL }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 Gerrit-Change-Number: 41529 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

2026

2025

2024

2023

2022

gerrit-log