- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-netif[master]: stream_srv: keep sockname in iofd name if a stream name is explicitly...
by pespin 16 Jan '26

16 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41856?usp=email ) Change subject: stream_srv: keep sockname in iofd name if a stream name is explicitly set ...................................................................... stream_srv: keep sockname in iofd name if a stream name is explicitly set This matches with how we log in eg. LOGSRV() macro. In essence, the user doesn't need to care about requesting to log the sockname, that's internally done in all cases. Instead, the stream set_name() is used to log more upper-layer information. Change-Id: I8f95b3a1cae66d39f7b83a4022880ab390b7715e --- M src/stream_srv.c 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/stream_srv.c b/src/stream_srv.c index d6d4e2d..3abc55a 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -1103,8 +1103,11 @@ talloc_free((void *)conn->name); conn->name = name; - if (conn->mode == OSMO_STREAM_MODE_OSMO_IO && conn->iofd) - osmo_iofd_set_name(conn->iofd, conn->name); + if (conn->mode == OSMO_STREAM_MODE_OSMO_IO && conn->iofd) { + char *tmp = talloc_asprintf(conn, "%s,%s", conn->name, conn->sockname); + osmo_iofd_set_name(conn->iofd, tmp); + talloc_free(tmp); + } } /*! Retrieve name previously set on the srv object (see osmo_stream_srv_set_name()). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I8f95b3a1cae66d39f7b83a4022880ab390b7715e Gerrit-Change-Number: 41856 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream_cli: Add stream sockname to iofd name
by pespin 16 Jan '26

16 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41857?usp=email ) Change subject: stream_cli: Add stream sockname to iofd name ...................................................................... stream_cli: Add stream sockname to iofd name Change-Id: If6f42afefdc61f3ce8c3387c22ac6867c21cb87b --- M src/stream_cli.c 1 file changed, 23 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/stream_cli.c b/src/stream_cli.c index befa3e1..b098e4a 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -411,6 +411,26 @@ #endif } +/* Update cli->sockname based on socket info: */ +static void stream_cli_update_iofd_name(struct osmo_stream_cli *cli) +{ + if (!(cli->mode == OSMO_STREAM_MODE_OSMO_IO && cli->iofd)) + return; + + char *tmp = talloc_asprintf(cli, "%s,%s", cli->name, cli->sockname); + osmo_iofd_set_name(cli->iofd, tmp); + talloc_free(tmp); +} + +/* Update cli->sockname based on socket info: */ +static void stream_cli_update_sockname(struct osmo_stream_cli *cli) +{ + osmo_sock_get_name_buf(cli->sockname, sizeof(cli->sockname), osmo_stream_cli_get_fd(cli)); + /* Update stream iofd with the new cli->sockname too: */ + stream_cli_update_iofd_name(cli); + +} + /* returns true if cli is freed */ static bool stream_cli_handle_connecting(struct osmo_stream_cli *cli, int res) { @@ -435,8 +455,7 @@ if (cli->mode == OSMO_STREAM_MODE_OSMO_FD && llist_empty(&cli->tx_queue)) osmo_fd_write_disable(&cli->ofd); - /* Update sockname based on socket info: */ - osmo_sock_get_name_buf(cli->sockname, sizeof(cli->sockname), osmo_stream_cli_get_fd(cli)); + stream_cli_update_sockname(cli); LOGSCLI(cli, LOGL_INFO, "connection established\n"); cli->state = STREAM_CLI_STATE_CONNECTED; @@ -691,8 +710,8 @@ talloc_free((void *)cli->name); cli->name = name; - if (cli->mode == OSMO_STREAM_MODE_OSMO_IO && cli->iofd) - osmo_iofd_set_name(cli->iofd, cli->name); + /* Update stream iofd with the new cli->name too: */ + stream_cli_update_iofd_name(cli); } /*! Retrieve name previously set on the cli object (see osmo_stream_cli_set_name()). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41857?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If6f42afefdc61f3ce8c3387c22ac6867c21cb87b Gerrit-Change-Number: 41857 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream_cli: Add stream sockname to iofd name
by pespin 16 Jan '26

16 Jan '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41857?usp=email ) Change subject: stream_cli: Add stream sockname to iofd name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41857?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If6f42afefdc61f3ce8c3387c22ac6867c21cb87b Gerrit-Change-Number: 41857 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:31:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-netif[master]: stream_cli: Add stream sockname to iofd name
by osmith 16 Jan '26

16 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41857?usp=email ) Change subject: stream_cli: Add stream sockname to iofd name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41857?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If6f42afefdc61f3ce8c3387c22ac6867c21cb87b Gerrit-Change-Number: 41857 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:28:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-hnbgw[master]: nft_kpi: add udp/2152 filtering rules separately
by fixeria 16 Jan '26

16 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email ) Change subject: nft_kpi: add udp/2152 filtering rules separately ...................................................................... nft_kpi: add udp/2152 filtering rules separately Mixing declarative and imperative syntax is supported by recent nftables versions, but is known to be broken in older releases. This affects the nftables version currently provided by Osmocom for Debian 12 (bookworm): 1.0.6.3~osmocom.429.7d98. As a result, the generated ruleset ends up accepting all packets rather than only udp/2152 as intended. Consequently, the nftables counters do not reflect GTP-U traffic alone, but also include signalling traffic. Let's work this around by adding the udp/2152 filtering rules separately using the imperative syntax. Split the logic for adding a chain into a separate function to avoid code duplication. Change-Id: I36eb3b18751fc029297fb91545af2d28e61067fd Related: SYS#7808 --- M src/osmo-hnbgw/nft_kpi.c 1 file changed, 19 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-hnbgw/nft_kpi.c b/src/osmo-hnbgw/nft_kpi.c index f8671fc..3513688 100644 --- a/src/osmo-hnbgw/nft_kpi.c +++ b/src/osmo-hnbgw/nft_kpi.c @@ -324,6 +324,23 @@ LOGP(DNFT, LOGL_DEBUG, "thread %s: successfully allocated nft ctx\n", g_nft_thread->label); } +static void _nft_add_chain(struct osmo_strbuf *sb, + const char *chain_name, + const char *hook) +{ + /* add a chain */ + OSMO_STRBUF_PRINTF(*sb, + "add chain inet %s %s {" + " type filter hook %s priority 0; policy accept;" + "};\n", + g_nft_thread->table_name, chain_name, hook); + /* accept (ignore) all traffic other than GTP-U (udp/2152) */ + OSMO_STRBUF_PRINTF(*sb, "add rule inet %s %s ip protocol != udp accept;\n", + g_nft_thread->table_name, chain_name); + OSMO_STRBUF_PRINTF(*sb, "add rule inet %s %s udp dport != 2152 accept;\n", + g_nft_thread->table_name, chain_name); +} + /* worker thread */ static int do_init_table(void) { @@ -332,20 +349,8 @@ /* add global nftables structures */ OSMO_STRBUF_PRINTF(sb, "add table inet %s { flags owner; };\n", g_nft_thread->table_name); - OSMO_STRBUF_PRINTF(sb, - "add chain inet %s gtpu-ul {" - " type filter hook prerouting priority 0; policy accept;" - " ip protocol != udp accept;" - " udp dport != 2152 accept;" - "};\n", - g_nft_thread->table_name); - OSMO_STRBUF_PRINTF(sb, - "add chain inet %s gtpu-dl {" - " type filter hook postrouting priority 0; policy accept;" - " ip protocol != udp accept;" - " udp dport != 2152 accept;" - "};\n", - g_nft_thread->table_name); + _nft_add_chain(&sb, "gtpu-ul", "prerouting"); + _nft_add_chain(&sb, "gtpu-dl", "postrouting"); OSMO_ASSERT(sb.chars_needed < sizeof(cmd)); return nft_run_now(cmd, NULL, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I36eb3b18751fc029297fb91545af2d28e61067fd Gerrit-Change-Number: 41752 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-netif[master]: stream_srv: keep sockname in iofd name if a stream name is explicitly...
by osmith 16 Jan '26

16 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41856?usp=email ) Change subject: stream_srv: keep sockname in iofd name if a stream name is explicitly set ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I8f95b3a1cae66d39f7b83a4022880ab390b7715e Gerrit-Change-Number: 41856 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:23:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-hnbgw[master]: nft_kpi: add udp/2152 filtering rules separately
by fixeria 16 Jan '26

16 Jan '26

Attention is currently required from: laforge, neels. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email ) Change subject: nft_kpi: add udp/2152 filtering rules separately ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I36eb3b18751fc029297fb91545af2d28e61067fd Gerrit-Change-Number: 41752 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:23:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: ipaccess: Add ipa_unit_data to logging context of bsc ipaccess srv st...
by pespin 16 Jan '26

16 Jan '26

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41854?usp=email ) Change subject: ipaccess: Add ipa_unit_data to logging context of bsc ipaccess srv stream ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41854?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I79f68e82420a59e1490d4959ad4996e4b40a16f8 Gerrit-Change-Number: 41854 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:23:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-netif[master]: stream_cli: Log state in stream_sctp_recvmsg_wrapper()
by osmith 16 Jan '26

16 Jan '26

Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41855?usp=email ) Change subject: stream_cli: Log state in stream_sctp_recvmsg_wrapper() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icac56b48b0d5715096a4d4872f88997eb6d708d2 Gerrit-Change-Number: 41855 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:22:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: ipaccess: Add ipa_unit_data to logging context of bsc ipaccess srv st...
by osmith 16 Jan '26

16 Jan '26

Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41854?usp=email ) Change subject: ipaccess: Add ipa_unit_data to logging context of bsc ipaccess srv stream ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41854?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I79f68e82420a59e1490d4959ad4996e4b40a16f8 Gerrit-Change-Number: 41854 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:21:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log