- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: debian-trixie-obs-asan: new container
by pespin 16 Jan '26

16 Jan '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41859?usp=email ) Change subject: debian-trixie-obs-asan: new container ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icda707751fca8a314e92200bce0e473e43e426f3 Gerrit-Change-Number: 41859 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:43:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Remove unused function
by pespin 16 Jan '26

16 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41860?usp=email ) Change subject: ipaccess: Remove unused function ...................................................................... ipaccess: Remove unused function Change-Id: I6c35112cef9894074ebb9ef2a171d9eae929e0ef --- M src/input/ipaccess.c 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/60/41860/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 6eddba0..7329d37 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -69,14 +69,6 @@ struct osmo_stream_cli *ipa_cli[NUM_E1_TS]; /* 0=OML, 1+N=TRX_N */ }; -static inline struct e1inp_ts *ipaccess_line_ts(struct osmo_fd *bfd, struct e1inp_line *line) -{ - if (bfd->priv_nr == E1INP_SIGN_OML) - return e1inp_line_ipa_oml_ts(line); - else - return e1inp_line_ipa_rsl_ts(line, bfd->priv_nr - E1INP_SIGN_RSL); -} - static inline void ipaccess_keepalive_fsm_cleanup(struct e1inp_ts *e1i_ts) { struct osmo_ipa_ka_fsm_inst *ka_fsm; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I6c35112cef9894074ebb9ef2a171d9eae929e0ef Gerrit-Change-Number: 41860 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in docker-playground[master]: debian-trixie-obs-asan: new container
by osmith 16 Jan '26

16 Jan '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41859?usp=email ) Change subject: debian-trixie-obs-asan: new container ...................................................................... debian-trixie-obs-asan: new container Switching to debian 13 by default requires this new container for ttcn3-bts-test-asan. Fixes: 82bee6c4 ("jenkins-common: use debian 13 by default") Change-Id: Icda707751fca8a314e92200bce0e473e43e426f3 --- A debian-trixie-obs-asan/Dockerfile A debian-trixie-obs-asan/Makefile 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/59/41859/1 diff --git a/debian-trixie-obs-asan/Dockerfile b/debian-trixie-obs-asan/Dockerfile new file mode 100644 index 0000000..b9c7af8 --- /dev/null +++ b/debian-trixie-obs-asan/Dockerfile @@ -0,0 +1,38 @@ +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=debian:trixie +FROM ${REGISTRY}/${UPSTREAM_DISTRO} + +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" +ARG OSMOCOM_REPO_PATH="packages/osmocom:" +ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/nightly:/asan/Debian_13/" +ARG UID + +# Copy from common dir +COPY .common/respawn.sh /usr/local/bin/respawn.sh +COPY .common/Release.key /usr/share/keyrings/osmocom-nightly-asan.asc + +# Configure build user, disable installing man pages +# * /usr/local: osmo-python-tests's contrib/jenkins.sh writes there +# * man pages: without them we avoid waiting for "generating manpages" +RUN set -x && \ + useradd --uid=${UID} -d /build -m build && \ + chown -R build:build /usr/local && \ + \ + echo "path-exclude=/usr/share/man/*" \ + > /etc/dpkg/dpkg.cfg.d/exclude-man-pages && \ + rm -rf /usr/share/man/ + +# Configure Osmocom nightly asan repository, add telnet for debugging +RUN set -x && \ + apt-get update && \ + apt-get install -y --no-install-recommends \ + ca-certificates \ + telnet \ + && \ + apt-get clean && \ + echo "deb [signed-by=/usr/share/keyrings/osmocom-nightly-asan.asc] $OSMOCOM_REPO ./" \ + > /etc/apt/sources.list.d/osmocom-nightly-asan.list + +# Invalidate cache once the repository is updated +ADD $OSMOCOM_REPO/Release /tmp/Release diff --git a/debian-trixie-obs-asan/Makefile b/debian-trixie-obs-asan/Makefile new file mode 100644 index 0000000..bbbc0f3 --- /dev/null +++ b/debian-trixie-obs-asan/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO=debian:trixie +DISTRO=debian-trixie +include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icda707751fca8a314e92200bce0e473e43e426f3 Gerrit-Change-Number: 41859 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: ipaccess: Add ipa_unit_data to logging context of bsc ipaccess srv st...
by pespin 16 Jan '26

16 Jan '26

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41854?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: ipaccess: Add ipa_unit_data to logging context of bsc ipaccess srv stream ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41854?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I79f68e82420a59e1490d4959ad4996e4b40a16f8 Gerrit-Change-Number: 41854 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: paging: Remove unused function
by pespin 16 Jan '26

16 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/41850?usp=email ) Change subject: paging: Remove unused function ...................................................................... paging: Remove unused function Change-Id: Iff4d062e2d7ea49b61843f929ec19957a38453ab --- M include/osmo-bts/paging.h M src/common/paging.c 2 files changed, 0 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/include/osmo-bts/paging.h b/include/osmo-bts/paging.h index e74ba3c..d8efb34 100644 --- a/include/osmo-bts/paging.h +++ b/include/osmo-bts/paging.h @@ -61,12 +61,6 @@ struct paging_state *paging_init(struct gsm_bts *bts, unsigned int num_paging_max, unsigned int paging_lifetime); - -/* (re) configure paging code */ -void paging_config(struct paging_state *ps, - unsigned int num_paging_max, - unsigned int paging_lifetime); - void paging_reset(struct paging_state *ps); /* The max number of paging entries */ diff --git a/src/common/paging.c b/src/common/paging.c index bdd5180..9e28de6 100644 --- a/src/common/paging.c +++ b/src/common/paging.c @@ -884,14 +884,6 @@ return ps; } -void paging_config(struct paging_state *ps, - unsigned int num_paging_max, - unsigned int paging_lifetime) -{ - ps->num_paging_max = num_paging_max; - ps->paging_lifetime = paging_lifetime; -} - void paging_reset(struct paging_state *ps) { int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4d062e2d7ea49b61843f929ec19957a38453ab Gerrit-Change-Number: 41850 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: vty: document default value for 'paging queue-size'
by pespin 16 Jan '26

16 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email ) Change subject: vty: document default value for 'paging queue-size' ...................................................................... vty: document default value for 'paging queue-size' Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02 --- M include/osmo-bts/paging.h M src/common/bts.c M src/common/vty.c 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/include/osmo-bts/paging.h b/include/osmo-bts/paging.h index d8efb34..5d26459 100644 --- a/include/osmo-bts/paging.h +++ b/include/osmo-bts/paging.h @@ -57,6 +57,8 @@ } nln_pch; }; +#define NUM_PAGING_MAX_DEFAULT 200 + /* initialize paging code */ struct paging_state *paging_init(struct gsm_bts *bts, unsigned int num_paging_max, diff --git a/src/common/bts.c b/src/common/bts.c index 73cb8a6..ea6b3d6 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -336,7 +336,7 @@ bts->agch_queue.thresh_level = GSM_BTS_AGCH_QUEUE_THRESH_LEVEL_DEFAULT; /* configurable via VTY */ - bts->paging_state = paging_init(bts, 200, 0); + bts->paging_state = paging_init(bts, NUM_PAGING_MAX_DEFAULT, 0); bts->rtp_jitter_adaptive = false; bts->rtp_port_range_start = 16384; bts->rtp_port_range_end = 17407; diff --git a/src/common/vty.c b/src/common/vty.c index ca7947b..6964306 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -56,6 +56,7 @@ #include <osmo-bts/oml.h> #include <osmo-bts/signal.h> #include <osmo-bts/bts_model.h> +#include <osmo-bts/paging.h> #include <osmo-bts/pcuif_proto.h> #include <osmo-bts/measurement.h> #include <osmo-bts/vty.h> @@ -838,7 +839,7 @@ cfg_bts_paging_queue_size_cmd, "paging queue-size <1-1024>", PAG_STR "Maximum length of BTS-internal paging queue\n" - "Maximum length of BTS-internal paging queue\n", + "Maximum length of BTS-internal paging queue (default " OSMO_STRINGIFY_VAL(NUM_PAGING_MAX_DEFAULT) ")\n", CMD_ATTR_IMMEDIATE) { struct gsm_bts *bts = vty->index; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02 Gerrit-Change-Number: 41851 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: vty: document default value for 'paging queue-size'
by osmith 16 Jan '26

16 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email ) Change subject: vty: document default value for 'paging queue-size' ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02 Gerrit-Change-Number: 41851 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:36:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: paging: Remove unused function
by osmith 16 Jan '26

16 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41850?usp=email ) Change subject: paging: Remove unused function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4d062e2d7ea49b61843f929ec19957a38453ab Gerrit-Change-Number: 41850 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jan 2026 12:35:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: osmo_io: Introduce API osmo_iofd_set_name_f()
by pespin 16 Jan '26

16 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41853?usp=email ) Change subject: osmo_io: Introduce API osmo_iofd_set_name_f() ...................................................................... osmo_io: Introduce API osmo_iofd_set_name_f() Change-Id: I0800255fde37d4b3c096c4a4a53e370c546c1f16 --- M TODO-RELEASE M include/osmocom/core/osmo_io.h M src/core/libosmocore.map M src/core/osmo_io.c 4 files changed, 21 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 4859444..3c98f06 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line core added osmo_sock_set_nonblock(), osmo_sock_get_nonblock() core added gsmtap_source_set_nonblock(), gsmtap_source_using_wq() +core added osmo_iofd_set_name_f() diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h index 0733240..c428191 100644 --- a/include/osmocom/core/osmo_io.h +++ b/include/osmocom/core/osmo_io.h @@ -240,6 +240,7 @@ int osmo_iofd_get_fd(const struct osmo_io_fd *iofd); const char *osmo_iofd_get_name(const struct osmo_io_fd *iofd); void osmo_iofd_set_name(struct osmo_io_fd *iofd, const char *name); +void osmo_iofd_set_name_f(struct osmo_io_fd *iofd, const char *fmt, ...); int osmo_iofd_set_ioops(struct osmo_io_fd *iofd, const struct osmo_io_ops *ioops); void osmo_iofd_get_ioops(struct osmo_io_fd *iofd, struct osmo_io_ops *ioops); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 6a46f6c..2818f8a 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -267,6 +267,7 @@ osmo_iofd_get_fd; osmo_iofd_get_name; osmo_iofd_set_name; +osmo_iofd_set_name_f; osmo_iofd_get_priv_nr; osmo_iofd_init; osmo_iofd_mode_names; diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index b28f170..1a55ff1 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -1153,6 +1153,24 @@ osmo_talloc_replace_string(iofd, &iofd->name, name); } +/*! Set the human-readable name of the file descriptor using arguments like printf() + * \param[in] iofd the file descriptor + * \param[in] fmt the fmt to set on the file descriptor */ +void osmo_iofd_set_name_f(struct osmo_io_fd *iofd, const char *fmt, ...) +{ + char *name = NULL; + + if (fmt) { + va_list ap; + + va_start(ap, fmt); + name = talloc_vasprintf(iofd, fmt, ap); + va_end(ap); + } + talloc_free((void *)iofd->name); + iofd->name = name; +} + /*! Set the osmo_io_ops calbacks for an osmo_io_fd. * This function can be used to update/overwrite the call-back functions for the given osmo_io_fd; it * replaces the currently-set call-back function pointers from a previous call to osmo_iofd_set_ioops() -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41853?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0800255fde37d4b3c096c4a4a53e370c546c1f16 Gerrit-Change-Number: 41853 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-netif[master]: stream_cli: Log state in stream_sctp_recvmsg_wrapper()
by pespin 16 Jan '26

16 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41855?usp=email ) Change subject: stream_cli: Log state in stream_sctp_recvmsg_wrapper() ...................................................................... stream_cli: Log state in stream_sctp_recvmsg_wrapper() Same as done in LOGSCLI macro. Change-Id: Icac56b48b0d5715096a4d4872f88997eb6d708d2 --- M src/stream_cli.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/stream_cli.c b/src/stream_cli.c index f0606b4..befa3e1 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -1433,7 +1433,9 @@ case IPPROTO_SCTP: { char log_pfx[128]; - snprintf(log_pfx, sizeof(log_pfx), "CLICONN(%s,%s)", cli->name ? : "", cli->sockname); + snprintf(log_pfx, sizeof(log_pfx), "CLICONN(%s,%s){%s}", + cli->name ? : "", cli->sockname, + get_value_string(stream_cli_state_names, cli->state)); ret = stream_sctp_recvmsg_wrapper(cli->ofd.fd, msg, log_pfx); break; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icac56b48b0d5715096a4d4872f88997eb6d708d2 Gerrit-Change-Number: 41855 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log