- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use
by neels 23 Jan '26

23 Jan '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: discover all useful ConfigurableParameter subclasses
by neels 23 Jan '26

23 Jan '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40095?usp=email ) Change subject: personalization: discover all useful ConfigurableParameter subclasses ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4970657294130b6b65d50ff19ffbb9ebab3be609 Gerrit-Change-Number: 40095 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: esim param_source: add is_abstract flag
by neels 23 Jan '26

23 Jan '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40206?usp=email ) Change subject: esim param_source: add is_abstract flag ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icfccdd0a8ecb5e0e9d22afa490d73c9f1849a64c Gerrit-Change-Number: 40206 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[L] Change in pysim[master]: SdKey params: add KVN to SdKey names
by neels 23 Jan '26

23 Jan '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/41772?usp=email ) Change subject: SdKey params: add KVN to SdKey names ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie296a438efd4737b39eaf133288ceed51bd593bc Gerrit-Change-Number: 41772 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in pysim[master]: personalization: refactor ConfigurableParameter, Iccid, Imsi
by neels 23 Jan '26

23 Jan '26

Attention is currently required from: laforge, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 18: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/8ed0850d_737929b1?usp=em… : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the > about the stub idea: […] I'd like to try and see if i'm allowed to resolve this now... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 18 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 23:54:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: personalization: refactor ConfigurableParameter, Iccid, Imsi
by neels 23 Jan '26

23 Jan '26

Attention is currently required from: laforge, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 18: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/7c69df23_a36ab212?usp=em… : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the > > re the build failure, dear Vadim, on the contrary. […] about the stub idea: - if I have to add a fake non-abstract yet abstract stub to prevent ABC from doing what it was designed to do, it defies the point of ABC, right? =) Instead I can just remove the @abstractmethod decorator to achieve the same goal. - I can adjust these classes here, but i want to keep other peoples' subclasses that may be out there intact, too. I would like to add the new classmethod in an *optional* way, leaving the transition to the new features up to the implementing classes -- transitions are shown in the subsequent commits. As part of this discussion, I'd also like to mention from the future: In a later patch, we generate SdKey classes by using `type('Xxx',...)` instead of `class Xxx:` According to python docs, they are identical: https://docs.python.org/3/library/functions.html#type "The following two...create identical..." However, it turns out that, as soon as ConfigurableParameter inherits from ABC, the newly created `SdKeyXxx.__module__` member suddenly points to module `abc`, not to `pySim.esim.saip.personalization` where it was actually created, and I have to set the `__module__` member explicitly to make things work again. (I don't really like generating classes very much, we should be generating class *instances* instead, but the choice is again to stay backwards compatible with the existing API) So, in all honesty, my opinion is still that ... well ... that abc serves no purpose and doesn't work, as harsh as it may sound. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 18 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 23:53:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: core: guard SCTP include in osmo_io_internal.h
by Timur Davydov 23 Jan '26

23 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41921?usp=email ) Change subject: core: guard SCTP include in osmo_io_internal.h ...................................................................... core: guard SCTP include in osmo_io_internal.h Include <netinet/sctp.h> only when libsctp support is available. This avoids pulling in SCTP-specific headers on builds where libsctp is disabled or unavailable, while keeping the internal header usable across all configurations. No functional changes intended. Change-Id: Icd626d908192a954d55d76a46d7cc863ed332631 --- M src/core/osmo_io_internal.h 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/21/41921/1 diff --git a/src/core/osmo_io_internal.h b/src/core/osmo_io_internal.h index f425da2..727f617 100644 --- a/src/core/osmo_io_internal.h +++ b/src/core/osmo_io_internal.h @@ -2,9 +2,13 @@ #pragma once +#include "../config.h" + #include <unistd.h> #include <stdbool.h> +#ifdef HAVE_LIBSCTP #include <netinet/sctp.h> +#endif #include <osmocom/core/osmo_io.h> #include <osmocom/core/linuxlist.h> @@ -12,8 +16,6 @@ #include <osmocom/core/select.h> #include <osmocom/core/socket.h> -#include "../config.h" - #define OSMO_IO_DEFAULT_MSGB_SIZE 1024 #define OSMO_IO_DEFAULT_MSGB_HEADROOM 128 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd626d908192a954d55d76a46d7cc863ed332631 Gerrit-Change-Number: 41921 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmocore[master]: build: keep netns API public and gate features with HAVE_*
by Timur Davydov 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: build: keep netns API public and gate features with HAVE_* ...................................................................... build: keep netns API public and gate features with HAVE_* The netns API was previously guarded by platform-specific preprocessor conditions (e.g. !EMBEDDED and defined(__linux__)), which caused the netns headers and implementation to be entirely excluded from non-Linux builds such as Emscripten. This in turn led to build failures in code depending on the netns API, as the symbols and declarations were not available at all. Always build netns.c and keep the public declarations available for non-embedded builds. Move platform/feature conditionals into the implementation: guard the netns code paths with HAVE_SETNS/HAVE_UNSHARE/ HAVE_MOUNT and HAVE_CLONE_NEWNET, and return -ENOSYS when the required functionality is not available. Add configure-time checks for the required headers/functions and for the CLONE_NEWNET declaration, defining the corresponding HAVE_* macros. No functional changes intended for platforms where netns is available. Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea --- M configure.ac M include/osmocom/core/netns.h M src/core/netns.c 3 files changed, 35 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/78/41878/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 9 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in pysim[master]: improve Imsi,Iccid.get_values_from_pes()
by neels 22 Jan '26

22 Jan '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41917?usp=email ) Change subject: improve Imsi,Iccid.get_values_from_pes() ...................................................................... improve Imsi,Iccid.get_values_from_pes() Change-Id: I40c888e81fc3172d5abbd5fc49029e5f7cf720ab --- M pySim/esim/saip/personalization.py 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/17/41917/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 00b8f49..4b865a2 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -393,9 +393,9 @@ yield iccid for pe in pes.get_pes_for_type('mf'): - iccid_pe = pe.decoded.get('ef-iccid', None) - if iccid_pe: - yield dec_iccid(b2h(file_tuples_content_as_bytes(iccid_pe))) + iccid_f = pe.files.get('ef-iccid', None) + if iccid_f is not None: + yield dec_iccid(b2h(iccid_f.body)) class Imsi(DecimalParam): """Configurable IMSI. Expects value to be a string of digits. Automatically sets the ACC to @@ -420,9 +420,10 @@ @classmethod def get_values_from_pes(cls, pes: ProfileElementSequence): for pe in pes.get_pes_for_type('usim'): - imsi_pe = pe.decoded.get('ef-imsi', None) - if imsi_pe: - yield dec_imsi(b2h(file_tuples_content_as_bytes(imsi_pe))) + imsi_f = pe.files.get('ef-imsi', None) + acc_f = pe.files.get('ef-acc', None) + if imsi_f: + yield dec_imsi(b2h(imsi_f.body)) class SmspTpScAddr(ConfigurableParameter): """Configurable SMSC (SMS Service Centre) TP-SC-ADDR. Expects to be a phone number in national or -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I40c888e81fc3172d5abbd5fc49029e5f7cf720ab Gerrit-Change-Number: 41917 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: ConfigurableParameter: do not magically overwrite the 'name' attribute
by neels 22 Jan '26

22 Jan '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41918?usp=email ) Change subject: ConfigurableParameter: do not magically overwrite the 'name' attribute ...................................................................... ConfigurableParameter: do not magically overwrite the 'name' attribute Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169 --- M pySim/esim/saip/personalization.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/18/41918/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 3e526e5..058686b 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -53,7 +53,6 @@ x = super().__new__(metacls, name, bases, namespace) for k, v in kwargs.items(): setattr(x, k, v) - setattr(x, 'name', camel_to_snake(name)) return x def file_tuples_content_as_bytes(l: List[Tuple]) -> Optional[bytes]: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169 Gerrit-Change-Number: 41918 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log