- gerrit-log - lists.osmocom.org

[XS] Change in osmocom-bb[master]: trxcon/l1sched: l1sched_reset(): also reset bsic
by fixeria 23 Jan '26

23 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41904?usp=email ) Change subject: trxcon/l1sched: l1sched_reset(): also reset bsic ...................................................................... trxcon/l1sched: l1sched_reset(): also reset bsic Change-Id: I4dfe5663fac12548d33393fe3b1426e5d80f50e7 Related: 8428b1ea0 ("trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC") --- M src/host/trxcon/src/sched_trx.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c index a2ee464..e3b1674 100644 --- a/src/host/trxcon/src/sched_trx.c +++ b/src/host/trxcon/src/sched_trx.c @@ -195,6 +195,8 @@ /* Reset UL SACCH cache */ l1sched_sacch_cache_update(sched, meas_rep_dummy); + + sched->bsic = 0; } void l1sched_sacch_cache_read(struct l1sched_state *sched, uint8_t *out) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4dfe5663fac12548d33393fe3b1426e5d80f50e7 Gerrit-Change-Number: 41904 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trxcon/l1ctl: print an error for uhnandled DATA.req / TRAFFIC.req
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41900?usp=email ) Change subject: trxcon/l1ctl: print an error for uhnandled DATA.req / TRAFFIC.req ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1d965c2882eb72dc845bea85a4ffaa26d37cee05 Gerrit-Change-Number: 41900 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 08:02:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: trxcon/l1ctl: print an error for uhnandled DATA.req / TRAFFIC.req
by osmith 23 Jan '26

23 Jan '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41900?usp=email ) Change subject: trxcon/l1ctl: print an error for uhnandled DATA.req / TRAFFIC.req ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1d965c2882eb72dc845bea85a4ffaa26d37cee05 Gerrit-Change-Number: 41900 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 07:55:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: build: keep netns API public and gate features with HAVE_*
by Timur Davydov 23 Jan '26

23 Jan '26

Attention is currently required from: laforge, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email ) Change subject: build: keep netns API public and gate features with HAVE_* ...................................................................... Patch Set 9: (1 comment) File src/core/netns.c: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/bf6cfb02_45bdd8fa?… : PS7, Line 92: return -ENOSYS; > unrelated cleanup patches should be a separate patch. […] Yes, thanks, that’s why I asked. I’ll remove the unused headers in a separate cleanup patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 9 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 07:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in pysim[master]: es2p.py: also allow 18 digit ICCID
by neels 23 Jan '26

23 Jan '26

Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40341?usp=email ) Change subject: es2p.py: also allow 18 digit ICCID ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > ping? IIRC i leaned on this one: commit 284efda086ee1f590c488310f307ad9d8314e3a4 Refs: 1.0-559-g284efda0 Author: Harald Welte <laforge(a)osmocom.org> AuthorDate: Tue Jul 11 11:08:24 2023 +0200 Commit: Harald Welte <laforge(a)osmocom.org> CommitDate: Tue Jul 11 11:09:00 2023 +0200 pySim-prog: Also accept 18-digit ICCIDs There are cards with 18-digit ICCIDs, so let's be a bit more tolerant. Unfortunately I don't remember the context anymore, let's just abandon...? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40341?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaa6e710132e3f4c6cecc5ff786922f6c0fcfb54e Gerrit-Change-Number: 40341 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 23 Jan 2026 02:34:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmocore[master]: core: guard TCP stats on availability of linux/tcp.h and struct tcp_info
by Timur Davydov 23 Jan '26

23 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email ) Change subject: core: guard TCP stats on availability of linux/tcp.h and struct tcp_info ...................................................................... core: guard TCP stats on availability of linux/tcp.h and struct tcp_info Detect availability of linux/tcp.h and struct tcp_info at configure time and build TCP statistics code conditionally based on that. This replaces platform-specific conditionals with proper feature checks and avoids build failures on systems lacking Linux TCP headers or types (e.g. non-Linux or cross-build environments). When TCP_INFO support is unavailable, the TCP stats code is compiled out, while keeping the public API intact. No functional changes on systems where linux/tcp.h and struct tcp_info are available. Change-Id: Ibcd00f15131b0291f0b10eca51401c518b77cc39 --- M configure.ac M src/core/stats_tcp.c 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/41922/1 diff --git a/configure.ac b/configure.ac index 5d1bdec..1ef513d 100644 --- a/configure.ac +++ b/configure.ac @@ -627,6 +627,13 @@ CHECK_BUILTIN_SUPPORT([__builtin_cpu_supports], [Runtime SIMD detection will be disabled]) +dnl Check header linux/tcp.h +AC_CHECK_HEADERS([linux/tcp.h]) +AC_CHECK_TYPES([struct tcp_info], + [AC_DEFINE([HAVE_TCP_INFO], 1, [Define if struct tcp_info exists])], + [], + [[#include <linux/tcp.h>]]) + dnl There are some members in struct tcp_info that might not exist on all linux versions AC_CHECK_MEMBER([struct tcp_info.tcpi_notsent_bytes], AC_DEFINE([HAVE_TCP_INFO_TCPI_NOTSENT_BYTES], diff --git a/src/core/stats_tcp.c b/src/core/stats_tcp.c index c6459fe..f79fc6a 100644 --- a/src/core/stats_tcp.c +++ b/src/core/stats_tcp.c @@ -29,7 +29,9 @@ #include <sys/socket.h> #include <netinet/in.h> #include <netinet/ip.h> +#ifdef HAVE_LINUX_TCP_H #include <linux/tcp.h> +#endif #include <errno.h> #include <pthread.h> @@ -74,6 +76,7 @@ STATS_TCP_REORD_SEEN, }; +#if HAVE_TCP_INFO static struct osmo_stat_item_desc stats_tcp_item_desc[] = { [STATS_TCP_UNACKED] = { "tcp:unacked", "unacknowledged packets", "", 60, 0 }, [STATS_TCP_LOST] = { "tcp:lost", "lost packets", "", 60, 0 }, @@ -93,9 +96,11 @@ .num_items = ARRAY_SIZE(stats_tcp_item_desc), .item_desc = stats_tcp_item_desc, }; +#endif /* HAVE_TCP_INFO */ static void fill_stats(struct stats_tcp_entry *stats_tcp_entry) { +#if HAVE_TCP_INFO int rc; struct tcp_info tcp_info; socklen_t tcp_info_len = sizeof(tcp_info); @@ -161,6 +166,7 @@ osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_REORD_SEEN), -1); #endif +#endif /* HAVE_TCP_INFO */ } static bool is_tcp(const struct osmo_fd *fd) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd00f15131b0291f0b10eca51401c518b77cc39 Gerrit-Change-Number: 41922 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: core: fix printf format casts for struct timeval fields
by Timur Davydov 23 Jan '26

23 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41923?usp=email ) Change subject: core: fix printf format casts for struct timeval fields ...................................................................... core: fix printf format casts for struct timeval fields Explicitly cast struct timeval fields to long when passing them to printf-style functions. This avoids compiler warnings/errors on platforms where tv_sec or tv_usec are not exactly of type long, while keeping the existing log and control output unchanged. Change-Id: Icac9e392c728948a7976970658e37f5e0da41709 --- M src/core/fsm.c M src/ctrl/fsm_ctrl_commands.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/41923/1 diff --git a/src/core/fsm.c b/src/core/fsm.c index 9333cac..a4f1bcb 100644 --- a/src/core/fsm.c +++ b/src/core/fsm.c @@ -660,7 +660,7 @@ else snprintf(trailer, sizeof(trailer), "(keeping " OSMO_T_FMT ", %ld.%03lds remaining)", OSMO_T_FMT_ARGS(fi->T), - (long) remaining.tv_sec, remaining.tv_usec / 1000); + (long) remaining.tv_sec, (long) (remaining.tv_usec / 1000)); } else if (timeout_ms) { if (timeout_ms % 1000 == 0) /* keep log output legacy compatible to avoid autotest failures */ diff --git a/src/ctrl/fsm_ctrl_commands.c b/src/ctrl/fsm_ctrl_commands.c index c93d3a5..76bc481 100644 --- a/src/ctrl/fsm_ctrl_commands.c +++ b/src/ctrl/fsm_ctrl_commands.c @@ -120,7 +120,7 @@ if (osmo_timer_remaining(&fi->timer, NULL, &remaining) < 0) cmd->reply = "0,0,0"; else - cmd->reply = talloc_asprintf(cmd, "%u,%ld,%ld", fi->T, remaining.tv_sec, remaining.tv_usec); + cmd->reply = talloc_asprintf(cmd, "%u,%ld,%ld", fi->T, (long) remaining.tv_sec, (long) remaining.tv_usec); return CTRL_CMD_REPLY; } @@ -149,7 +149,7 @@ rc = osmo_timer_remaining(&fi->timer, NULL, &remaining); if (rc == 0) { cmd->reply = talloc_asprintf_append(cmd->reply, ",timeout_sec=%ld,timeout_usec=%ld", - remaining.tv_sec, remaining.tv_usec); + (long) remaining.tv_sec, (long) remaining.tv_usec); } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icac9e392c728948a7976970658e37f5e0da41709 Gerrit-Change-Number: 41923 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: vty: guard definition of _XOPEN_SOURCE
by Timur Davydov 23 Jan '26

23 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41924?usp=email ) Change subject: vty: guard definition of _XOPEN_SOURCE ...................................................................... vty: guard definition of _XOPEN_SOURCE Define _XOPEN_SOURCE only if it is not already provided by the build environment. This avoids redefinition warnings/errors while ensuring required POSIX interfaces are available. Change-Id: I4f53aff1afef02abce7cb70d1b29080ba900ff41 --- M src/vty/command.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/41924/1 diff --git a/src/vty/command.c b/src/vty/command.c index c1bda8a..38c6648 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -33,7 +33,9 @@ #include <stdbool.h> #include <syslog.h> #include <errno.h> +#ifndef _XOPEN_SOURCE #define _XOPEN_SOURCE +#endif #include <unistd.h> #include <ctype.h> #include <time.h> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4f53aff1afef02abce7cb70d1b29080ba900ff41 Gerrit-Change-Number: 41924 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by Timur Davydov 23 Jan '26

23 Jan '26

Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, fixeria, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email to look at the new patch set (#20). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Add Emscripten build support and JS callback logging backend This change enables building libosmocore for sandboxed, non-POSIX environments, specifically WebAssembly targets produced via the Emscripten toolchain. The broader motivation is to allow partial execution of selected Osmocom components in isolated runtime environments where direct access to hardware and traditional operating system facilities (filesystem, sockets, privileged execution) is not available. One intended use case is running a GSM 2G base station where the radio-facing components are executed inside a web environment, while the remaining Osmocom stack and core network components continue to run unchanged on a conventional backend server. In this model, highly stripped-down variants of osmo-bts and osmo-trx are built as static WebAssembly libraries and executed in the browser, while depending on core libraries such as libosmocore, libosmo-netif, and libosmo-abis. A practical advantage of this approach is that no deployment or privileged setup is required on the radio endpoint side. A user can instantiate a radio endpoint with minimal configuration, while all stateful logic and operational complexity remains centralized on the backend. Multiple such radio endpoints may connect to the same backend core network, effectively forming a single logical network from the core network perspective, independent of the physical location of the radio endpoints. Existing libosmocore build logic and platform assumptions rely on the availability of POSIX APIs and OS services which are not present in WebAssembly runtimes. This currently prevents libosmocore from being built for such targets without targeted, build-time adjustments. This patch introduces the minimal set of changes required to enable such builds, without affecting native platforms. As part of this groundwork, a minimal callback-based logging hook is introduced. When building for Emscripten, this hook allows forwarding log messages to an external environment via a user-provided JavaScript callback. This enables integration with browser-side logging or UI infrastructure without introducing new logging backends or runtime dependencies. For all other build targets, the hook resolves to a no-op implementation and does not alter existing logging behavior. No runtime behavior, protocol semantics, or network interactions are changed by this patch. All modifications are strictly limited to build-time and platform-specific code paths and are only active when targeting Emscripten. Native builds and existing deployment scenarios remain unaffected. This patch is intended as groundwork. Follow-up changes, proposed separately and incrementally, may extend similar support to other Osmocom components such as libosmo-netif, libosmo-abis, osmo-bts, and osmo-trx, while keeping all such changes optional and isolated from native builds. Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 --- M .gitignore M configure.ac M include/osmocom/core/logging.h M src/core/Makefile.am M src/core/libosmocore.map A src/core/logging_emscripten.c M src/core/netdev.c M src/core/tun.c M src/vty/logging_vty.c 9 files changed, 164 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/41813/20 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 20 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by Timur Davydov 23 Jan '26

23 Jan '26

Attention is currently required from: laforge, neels, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 19: (5 comments) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/ac292e99_fddbad83?… : PS16, Line 259: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes" && test "x$emscripten" != "xyes") > This will still probably need fixing in a separate patch like the NETNS stuff you fixed Agreed, this likely needs an additional fix. This should follow the same approach as netns. I’ll address this in a follow-up patch. File src/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/e4e0753f_7b78d474?… : PS16, Line 87: if ENABLE_TUN > This will probably need some sort of other fix? Why can't you add it when building for emscripten? Agreed, this likely needs an additional fix. This should follow the same approach as netns. I’ll address this in a follow-up patch. File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/b0a4317c_9b0388a0?… : PS16, Line 5: #include "../config.h" > This and the change below deserve a separate patch, feel free to submit previously in the branch to […] Done, split out and submitted as a separate patch. File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/9a5e15b4_66cc0485?… : PS16, Line 198: #if !defined(__EMSCRIPTEN__) > This should be fixed in a more generic way. […] The build fails due to missing Linux-specific headers/types. First, without any guards: stats_tcp.c:33:10: fatal error: 'linux/tcp.h' file not found #include <linux/tcp.h> If I try to workaround this by guarding the include with `#if defined(__linux__)`, the build still fails because the code below relies on Linux-only types/macros: stats_tcp.c:103:18: error: variable has incomplete type 'struct tcp_info' stats_tcp.c:112:56: error: use of undeclared identifier 'TCP_INFO' So this can’t be fixed just by wrapping the include. We need a generic configure-time feature/header check (e.g. for linux/tcp.h and/or the presence of struct tcp_info / TCP_INFO) and conditionally build/enable the TCP_INFO stats code based on that. I’ll address this in a separate patch. File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/0dd72b47_c759ba86?… : PS16, Line 937: #if !defined(__EMSCRIPTEN__) > what about leaving this in and let it fail during runtime if user tries to use it? Agreed. I disabled it only to avoid creating files on the Web side, but since Emscripten provides an IndexedDB-backed filesystem, leaving it enabled and failing at runtime is fine. I’ll update the patch -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 19 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 00:42:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log