- gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: Timur Davydov, laforge, neels. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 21: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 21 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 08:35:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: core: guard TCP stats on availability of linux/tcp.h
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email ) Change subject: core: guard TCP stats on availability of linux/tcp.h ...................................................................... Patch Set 2: (2 comments) File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/215f7c69_5dedc33f?… : PS2, Line 25: #if !defined(EMBEDDED) > I see the point, but I'm a bit hesitant to drop the EMBEDDED guard purely […] Done https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/aade51f5_e06adc53?… : PS2, Line 52: static struct osmo_tcp_stats_config s_tcp_stats_config = { > I don't think this can be moved entirely under HAVE_LINUX_TCP_H. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd00f15131b0291f0b10eca51401c518b77cc39 Gerrit-Change-Number: 41922 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 08:31:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmocore[master]: core: always build tun.c and gate TUN support by headers
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41939?usp=email ) Change subject: core: always build tun.c and gate TUN support by headers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6d1ea1644d12ef59a54cf2f73b9155def58b17a9 Gerrit-Change-Number: 41939 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 08:23:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: f_build_meas_res_tmpl(): expect specific L3 INFO
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41937?usp=email ) Change subject: bts: f_build_meas_res_tmpl(): expect specific L3 INFO ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1892d3ae3f72443ded6321487e9b191cd1948aac Gerrit-Change-Number: 41937 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 08:19:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: library: make ts_MEAS_REP accept MeasurementResults
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41933?usp=email ) Change subject: library: make ts_MEAS_REP accept MeasurementResults ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12113360f52b0ce09aa9bc11472fdd04bf14f368 Gerrit-Change-Number: 41933 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 08:19:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: f_est_dchan(): populate UL SACCH cache
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41936?usp=email ) Change subject: bts: f_est_dchan(): populate UL SACCH cache ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4781fe7539e64e77d594e84f905646c127f46b64 Gerrit-Change-Number: 41936 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 08:17:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: move as_rsl_meas_res() params to ConnHdlrPars
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41935?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: bts: move as_rsl_meas_res() params to ConnHdlrPars ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Does this even need to be set from outside the component? I'm not sure moving i there is needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41935?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iceb58bb636817afcd0fdf1eb3344d03153860a56 Gerrit-Change-Number: 41935 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 08:16:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: rename s/as_meas_res/as_rsl_meas_res/
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41934?usp=email ) Change subject: bts: rename s/as_meas_res/as_rsl_meas_res/ ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9dd0d06ac6fcaba5724c6a3eb7459d0971139f9 Gerrit-Change-Number: 41934 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 08:14:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: move as_rsl_meas_res() params to ConnHdlrPars
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41935?usp=email ) Change subject: bts: move as_rsl_meas_res() params to ConnHdlrPars ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41935?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iceb58bb636817afcd0fdf1eb3344d03153860a56 Gerrit-Change-Number: 41935 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 08:14:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: core: guard TCP stats on availability of linux/tcp.h
by Timur Davydov 25 Jan '26

25 Jan '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email ) Change subject: core: guard TCP stats on availability of linux/tcp.h ...................................................................... Patch Set 2: (2 comments) File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/81aa7d6b_bed2da43?… : PS2, Line 25: #if !defined(EMBEDDED) > You can probably remove this defined(EMBEDDED) block now, since it will be covered by the ifdef HAVE […] I see the point, but I'm a bit hesitant to drop the EMBEDDED guard purely because of HAVE_LINUX_TCP_H. With --enable-embedded this code path used to be disabled regardless of what headers are present. If we remove the EMBEDDED guard now, an embedded build could end up compiling it just because linux/tcp.h happens to be available in the toolchain sysroot, which would be a behaviour change compared to before. I'd prefer to keep the embedded decision explicit (either keep the EMBEDDED guard or force HAVE_LINUX_TCP_H / the corresponding feature off when --enable-embedded is used in configure.ac), and only use HAVE_LINUX_TCP_H to guard the Linux-specific implementation details. This way embedded builds stay consistent, and CI should remain happy. https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/cca1e99a_29dc69e8?… : PS2, Line 52: static struct osmo_tcp_stats_config s_tcp_stats_config = { > This should also be inside the HAVE_LIJNUX_TCP_H block below. I don't think this can be moved entirely under HAVE_LINUX_TCP_H. The data structure is accessed unconditionally from other code paths: - stats.c calls osmo_stats_tcp_set_interval(osmo_tcp_stats_config->interval) - stats_vty.c reads/writes osmo_tcp_stats_config->{interval,batch_size} and prints them in the VTY config output If the definition/allocation is moved under HAVE_LINUX_TCP_H, those callers will end up dereferencing a NULL pointer at runtime, leading to a segfault. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd00f15131b0291f0b10eca51401c518b77cc39 Gerrit-Change-Number: 41922 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Jan 2026 22:38:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log