- gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: configure.ac: Add arpa/inet.h to AC_CHECK_HEADERS
by osmith 26 Jan '26

26 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41930?usp=email ) Change subject: configure.ac: Add arpa/inet.h to AC_CHECK_HEADERS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib2d1fb3efb1dcb429b511698691249c257e00720 Gerrit-Change-Number: 41930 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 11:05:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: socket.h: Include netinet/in.h instead of arpa/inet.h
by osmith 26 Jan '26

26 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41929?usp=email ) Change subject: socket.h: Include netinet/in.h instead of arpa/inet.h ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03919c4adc962bbcfabc9030c6f12c0e10ff060c Gerrit-Change-Number: 41929 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 11:05:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io.h: Avoid including sys/socket.h
by osmith 26 Jan '26

26 Jan '26

Attention is currently required from: jolly, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41927?usp=email ) Change subject: osmo_io.h: Avoid including sys/socket.h ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5bcba8f72a2be6161d7782a3100d25a7025341d0 Gerrit-Change-Number: 41927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 11:04:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: core: guard Linux netlink headers by libmnl usage
by osmith 26 Jan '26

26 Jan '26

Attention is currently required from: Timur Davydov. osmith has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41941?usp=email ) Change subject: core: guard Linux netlink headers by libmnl usage ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0b681deb1f1e025e3ea9996f19b1de06a5feb408 Gerrit-Change-Number: 41941 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 11:01:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: core: guard Linux netlink headers by libmnl usage
by Timur Davydov 26 Jan '26

26 Jan '26

Timur Davydov has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/libosmocore/+/41941?usp=email ) Change subject: core: guard Linux netlink headers by libmnl usage ...................................................................... core: guard Linux netlink headers by libmnl usage Only include Linux-specific netlink headers when the libmnl backend is enabled. The code paths requiring <linux/if_link.h> and <linux/rtnetlink.h> are entirely guarded by ENABLE_LIBMNL conditionals, so the headers should not be included unconditionally. This avoids pulling in Linux-only headers when the corresponding backend is not built. Change-Id: I0b681deb1f1e025e3ea9996f19b1de06a5feb408 --- M src/core/netdev.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/41941/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0b681deb1f1e025e3ea9996f19b1de06a5feb408 Gerrit-Change-Number: 41941 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: core: guard Linux netlink headers by libmnl usage
by Timur Davydov 26 Jan '26

26 Jan '26

Timur Davydov has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/41941?usp=email ) Change subject: core: guard Linux netlink headers by libmnl usage ...................................................................... core: guard Linux netlink headers by libmnl usage Only include Linux-specific netlink headers when the libmnl backend is enabled. The code paths requiring <linux/if_link.h> and <linux/rtnetlink.h> are entirely guarded by ENABLE_LIBMNL conditionals, so the headers should not be included unconditionally. This avoids pulling in Linux-only headers when the corresponding backend is not built. Change-Id: I0b681deb1f1e025e3ea9996f19b1de06a5feb408 --- M src/core/netdev.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/41941/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0b681deb1f1e025e3ea9996f19b1de06a5feb408 Gerrit-Change-Number: 41941 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by Timur Davydov 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria, laforge, neels, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 22: (2 comments) File src/core/netdev.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/bd6cdc38_1ff8e0e1?… : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__) > I'm delaying review of this patch until the previous one regarding netdev is solved, because anyway […] I've moved the netdev changes into a separate patch and will address that first. I dropped the Emscripten-specific include logic and instead guard the Linux netlink headers by the libmnl backend, because the only code that needs <linux/if_link.h>/<linux/rtnetlink.h> is under the libmnl-enabled blocks. So when libmnl is disabled, we no longer try to include Linux-only headers on non-Linux targets. When libmnl is enabled, requiring those Linux headers is expected. https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/27e9de57_c1f1ed3f?… : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__) > I'm delaying review of this patch until the previous one regarding netdev is solved, because anyway […] I've moved the netdev changes into a separate patch and will address that first. I dropped the Emscripten-specific include logic and instead guard the Linux netlink headers by the libmnl backend, because the only code that needs <linux/if_link.h>/<linux/rtnetlink.h> is under the libmnl-enabled blocks. So when libmnl is disabled, we no longer try to include Linux-only headers on non-Linux targets. When libmnl is enabled, requiring those Linux headers is expected. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 22 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 10:09:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmocore[master]: core: guard TCP stats on availability of linux/tcp.h
by Timur Davydov 26 Jan '26

26 Jan '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email ) Change subject: core: guard TCP stats on availability of linux/tcp.h ...................................................................... Patch Set 3: (1 comment) File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/0a900d36_14d0d9a8?… : PS2, Line 47: #include <errno.h> > Please move this up before the ifdef HAVE_LINUX_TCP_H. Done, moved it above the HAVE_LINUX_TCP_H guard. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd00f15131b0291f0b10eca51401c518b77cc39 Gerrit-Change-Number: 41922 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 10:04:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: core: guard Linux netlink headers by libmnl usage
by Timur Davydov 26 Jan '26

26 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41941?usp=email ) Change subject: core: guard Linux netlink headers by libmnl usage ...................................................................... core: guard Linux netlink headers by libmnl usage Only include Linux-specific netlink headers when the libmnl backend is enabled. The code paths requiring <linux/if_link.h> and <linux/rtnetlink.h> are entirely guarded by ENABLE_LIBMNL conditionals, so the headers should not be included unconditionally. This avoids pulling in Linux-only headers when the corresponding backend is not built. Change-Id: I0b681deb1f1e025e3ea9996f19b1de06a5feb408 --- M src/core/netdev.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/41941/1 diff --git a/src/core/netdev.c b/src/core/netdev.c index 1e886f9..22e1e00 100644 --- a/src/core/netdev.c +++ b/src/core/netdev.c @@ -82,6 +82,8 @@ #include <net/if.h> #include <net/route.h> +#ifdef ENABLE_LIBMNL + #if defined(__linux__) #include <linux/if_link.h> #include <linux/rtnetlink.h> @@ -89,6 +91,8 @@ #error "Unknown platform!" #endif +#endif /* if ENABLE_LIBMNL */ + #include <osmocom/core/utils.h> #include <osmocom/core/select.h> #include <osmocom/core/linuxlist.h> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0b681deb1f1e025e3ea9996f19b1de06a5feb408 Gerrit-Change-Number: 41941 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmocore[master]: core: always build tun.c and gate TUN support by headers
by Timur Davydov 26 Jan '26

26 Jan '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41939?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: core: always build tun.c and gate TUN support by headers ...................................................................... core: always build tun.c and gate TUN support by headers Always build tun.c and move platform-specific checks into the implementation. Guard the TUN-specific code paths based on the availability of linux/if_tun.h detected at configure time. If TUN support is not available, osmo_tundev_open() returns -ENOTSUP. This keeps the public TUN API available while disabling unsupported functionality in a capability-based way. Change-Id: I6d1ea1644d12ef59a54cf2f73b9155def58b17a9 --- M configure.ac M src/core/tun.c 2 files changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/41939/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6d1ea1644d12ef59a54cf2f73b9155def58b17a9 Gerrit-Change-Number: 41939 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

2026

2025

2024

2023

2022

gerrit-log