- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: Use newer M3UA & MTP3 deps generating MTP-STATUS,PAUSE,RESUME.ind
by pespin 27 Jan '26

27 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41959?usp=email ) Change subject: Use newer M3UA & MTP3 deps generating MTP-STATUS,PAUSE,RESUME.ind ...................................................................... Use newer M3UA & MTP3 deps generating MTP-STATUS,PAUSE,RESUME.ind * titan.TestPorts.MTP3asp pointer is changed to osmocom fork containing extra patch adding missing fields to MTP-STATUS,PAUSE,RESUME records. It also adds templates for them. * titan.ProtocolEmulations.M3UA pointer is changed to osmocom fork containing extra patch improving M3UA_Emulation component to build MTP-STATUS,PAUSE,RESUME.ind primiives when receiving DAVA/DUNA/DUPU/SCON from M3UA link. The upper layers building on top of MTP3asp_PT (ie. port MTP3asp_SCCP_PT from SCCP_MApping.ttcnp) are fine because they explicitly discard ASP_MTP3_PAUSE,RESUME,STATUS messages in the port defintion. Hence, supporting those in SCCP layer is left as a subsequent task. Related: OS#6907 Change-Id: I67cc2bcf3395a81fa8acee861af01e752984ebb3 --- M deps/Makefile M sccp/SCCP_Tests_RAW.ttcn 2 files changed, 6 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/41959/1 diff --git a/deps/Makefile b/deps/Makefile index 61d5fee..f6d5c5f 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -8,7 +8,6 @@ OSMOGITEA:=https://gitea.osmocom.org/ttcn3 ECLIPSEGITLAB_REPOS= titan.Libraries.TCCUsefulFunctions \ - titan.ProtocolEmulations.M3UA \ titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSAPP_v7.3.0 \ titan.ProtocolModules.DIAMETER_ProtocolModule_Generator \ @@ -44,7 +43,6 @@ titan.TestPorts.HTTPmsg \ titan.TestPorts.IPL4asp \ titan.TestPorts.LANL2asp \ - titan.TestPorts.MTP3asp \ titan.TestPorts.PCAPasp \ titan.TestPorts.PIPEasp \ titan.TestPorts.SIPmsg \ @@ -54,6 +52,8 @@ titan.TestPorts.UNIX_DOMAIN_SOCKETasp OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \ + titan.TestPorts.MTP3asp \ + titan.ProtocolEmulations.M3UA \ titan.ProtocolModules.BSSGP_v13.0.0 OSMOGERRIT_REPOS= osmo-uecups @@ -74,7 +74,7 @@ # exact commits of deps when doing regression testing. nas_commit= 60a69a44cc6bbb32d96aecc4e355128ac5f95a5e titan.Libraries.TCCUsefulFunctions_commit= R.35.B-6-gb3687da -titan.ProtocolEmulations.M3UA_commit= b58f92046e48a7b1ed531e243a2319ebca53bf4c +titan.ProtocolEmulations.M3UA_commit= 071bceabe0cdea65d4562ce12630eaaef964675a titan.ProtocolEmulations.SCCP_commit= 750a3e836831e58eae59d4757ef5d0c759f9ca5d titan.ProtocolModules.BSSAPP_v7.3.0_commit= R.2.A-4-g20cfaf8 titan.ProtocolModules.BSSGP_v13.0.0_commit= e97d92a8b66bec399babea52f593771b76cb175a @@ -114,7 +114,7 @@ titan.TestPorts.HTTPmsg_commit= R.9.B-4-g9a0dfde titan.TestPorts.IPL4asp_commit= R.30.E-7-g029bccb titan.TestPorts.LANL2asp_commit= R.8.C-3-gb07c265 -titan.TestPorts.MTP3asp_commit= 88224e93e9fffba082061b9642251551209ee567 +titan.TestPorts.MTP3asp_commit= 3e92ca9b24615f582741812350b0c2023f0a426c titan.TestPorts.PCAPasp_commit= R.8.A-3-g9ad320f titan.TestPorts.PIPEasp_commit= R.7.D-3-g8b01154 titan.TestPorts.SCTPasp_commit= R.11.A-8-g2e911c3 diff --git a/sccp/SCCP_Tests_RAW.ttcn b/sccp/SCCP_Tests_RAW.ttcn index 9b53a1c..3366111 100644 --- a/sccp/SCCP_Tests_RAW.ttcn +++ b/sccp/SCCP_Tests_RAW.ttcn @@ -554,11 +554,8 @@ }; MTP3.send(tx); - /* TODO: Here we should wait to receive a MTP-STATUS.ind in MTP3 port generated by - * received DUPU (see https://datatracker.ietf.org/doc/html/rfc4666#section-5.5.2.3.4), - * but forwarding non-data M3UA messages up the stack is not yet implemented - * in M3UA_Emulation.ttcn, see OS#6907. */ - f_sleep(1.0); + /* DUPU gets translated to MTP-STATUS.ind: */ + MTP3.receive(tr_ASP_MTP3_STATUS(g_param.dpc, cause := ?, user := bit2int(unavail_sio.si))); setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41959?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I67cc2bcf3395a81fa8acee861af01e752984ebb3 Gerrit-Change-Number: 41959 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Fix misalignment of iofd->cmsg used as struct cmsghdr
by jolly 27 Jan '26

27 Jan '26

Attention is currently required from: Hoernchen, daniel, fixeria, laforge, pespin. jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email ) Change subject: osmo_io: Fix misalignment of iofd->cmsg used as struct cmsghdr ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia80dfc4dbffe85514b18dcf8d36b85bfafd76d64 Gerrit-Change-Number: 41950 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jan 2026 12:08:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update titan.TestPorts.MTP3asp to upstream master
by osmith 27 Jan '26

27 Jan '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41958?usp=email ) Change subject: deps/Makefile: Update titan.TestPorts.MTP3asp to upstream master ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieecb643db8bd3eb8739d960dfaaee183368b0c1d Gerrit-Change-Number: 41958 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jan 2026 12:03:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: Fix misalignment of iofd->cmsg used as struct cmsghdr
by osmith 27 Jan '26

27 Jan '26

Attention is currently required from: Hoernchen, daniel, fixeria, jolly, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email ) Change subject: osmo_io: Fix misalignment of iofd->cmsg used as struct cmsghdr ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia80dfc4dbffe85514b18dcf8d36b85bfafd76d64 Gerrit-Change-Number: 41950 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jan 2026 12:02:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update titan.TestPorts.MTP3asp to upstream master
by pespin 27 Jan '26

27 Jan '26

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41958?usp=email ) Change subject: deps/Makefile: Update titan.TestPorts.MTP3asp to upstream master ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: NOTE: The extra commit in github.com:osmocom/titan.TestPorts.MTP3asp.git was in branch "master" there. I renamed that branch to "laforge/master" for now, and changed master to be up to date with upstream master. The "laforge/master" branch can be dropped once we merge this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieecb643db8bd3eb8739d960dfaaee183368b0c1d Gerrit-Change-Number: 41958 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jan 2026 11:56:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update titan.TestPorts.MTP3asp to upstream master
by pespin 27 Jan '26

27 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41958?usp=email ) Change subject: deps/Makefile: Update titan.TestPorts.MTP3asp to upstream master ...................................................................... deps/Makefile: Update titan.TestPorts.MTP3asp to upstream master We used to point to an osmocom fork with a commit from 2018 fixing build without MTP3asp_PT.cc/hh. That commit was merged upstream in 2020, so we can point back to upstream. Change-Id: Ieecb643db8bd3eb8739d960dfaaee183368b0c1d --- M deps/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/41958/1 diff --git a/deps/Makefile b/deps/Makefile index 1e5ead2..61d5fee 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -44,6 +44,7 @@ titan.TestPorts.HTTPmsg \ titan.TestPorts.IPL4asp \ titan.TestPorts.LANL2asp \ + titan.TestPorts.MTP3asp \ titan.TestPorts.PCAPasp \ titan.TestPorts.PIPEasp \ titan.TestPorts.SIPmsg \ @@ -53,7 +54,6 @@ titan.TestPorts.UNIX_DOMAIN_SOCKETasp OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \ - titan.TestPorts.MTP3asp \ titan.ProtocolModules.BSSGP_v13.0.0 OSMOGERRIT_REPOS= osmo-uecups @@ -114,7 +114,7 @@ titan.TestPorts.HTTPmsg_commit= R.9.B-4-g9a0dfde titan.TestPorts.IPL4asp_commit= R.30.E-7-g029bccb titan.TestPorts.LANL2asp_commit= R.8.C-3-gb07c265 -titan.TestPorts.MTP3asp_commit= 1cecdad6f3641a5f19b3833703bff6e5005eff11 +titan.TestPorts.MTP3asp_commit= 88224e93e9fffba082061b9642251551209ee567 titan.TestPorts.PCAPasp_commit= R.8.A-3-g9ad320f titan.TestPorts.PIPEasp_commit= R.7.D-3-g8b01154 titan.TestPorts.SCTPasp_commit= R.11.A-8-g2e911c3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieecb643db8bd3eb8739d960dfaaee183368b0c1d Gerrit-Change-Number: 41958 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_local_unavailable_user_part_dupu
by pespin 27 Jan '26

27 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41954?usp=email ) Change subject: sccp: Introduce test TC_local_unavailable_user_part_dupu ...................................................................... sccp: Introduce test TC_local_unavailable_user_part_dupu Related: OS#6907 Related: OS#6891 Change-Id: Ia0e71cc98c267692bc9230be8d15bbc861d5daad --- M sccp/SCCP_Tests_RAW.ttcn 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/sccp/SCCP_Tests_RAW.ttcn b/sccp/SCCP_Tests_RAW.ttcn index f0d716a..9b53a1c 100644 --- a/sccp/SCCP_Tests_RAW.ttcn +++ b/sccp/SCCP_Tests_RAW.ttcn @@ -12,6 +12,8 @@ module SCCP_Tests_RAW { +import from MTP3asp_Types all; + import from General_Types all; import from Osmocom_Types all; import from Misc_Helpers all; @@ -535,6 +537,32 @@ setverdict(pass); } +/* test whether the M3UA stack under SCCP sends back a M3UA DUPU when receiving + * a pkt towards a local unavailable User Part */ +testcase TC_local_unavailable_user_part_dupu() runs on SCCP_Test_RAW_CT { + f_init_raw(mp_sccp_cfg[0]); + f_sleep(1.0); + + var MTP3_Field_sio unavail_sio := g_param.sio; + unavail_sio.si := '0100'B; /* SI=DUP */ + var SCCP_MTP3_TRANSFERreq tx := { + sio := unavail_sio, + opc := g_param.opc, + dpc := g_param.dpc, + sls := g_param.sls, + data := valueof(ts_SCCP_CC(g_own_lref, '000000'O)) + }; + MTP3.send(tx); + + /* TODO: Here we should wait to receive a MTP-STATUS.ind in MTP3 port generated by + * received DUPU (see https://datatracker.ietf.org/doc/html/rfc4666#section-5.5.2.3.4), + * but forwarding non-data M3UA messages up the stack is not yet implemented + * in M3UA_Emulation.ttcn, see OS#6907. */ + f_sleep(1.0); + + setverdict(pass); +} + control { execute( TC_cr_cc() ); @@ -550,6 +578,8 @@ execute( TC_callingparty_ssn_only() ); execute( TC_cr_timeout_cc_too_late() ); + + execute( TC_local_unavailable_user_part_dupu() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41954?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0e71cc98c267692bc9230be8d15bbc861d5daad Gerrit-Change-Number: 41954 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_local_unavailable_user_part_dupu
by pespin 27 Jan '26

27 Jan '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41954?usp=email ) Change subject: sccp: Introduce test TC_local_unavailable_user_part_dupu ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41954?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0e71cc98c267692bc9230be8d15bbc861d5daad Gerrit-Change-Number: 41954 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jan 2026 11:13:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: Fix misalignment of iofd->cmsg used as struct cmsghdr
by pespin 27 Jan '26

27 Jan '26

Attention is currently required from: Hoernchen, daniel, fixeria, jolly, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email ) Change subject: osmo_io: Fix misalignment of iofd->cmsg used as struct cmsghdr ...................................................................... Patch Set 3: (2 comments) Patchset: PS1: > shouldn't we use CMSG_ALIGN macro instead of a hard-coded 8 here? CSMG_ALIGN returns the whole size including the required alignment, which is not what we want here. I instead actually changed the patch to use _Alignas, which is what we need here. Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41950/comment/3395872b_0a3883e7?… : PS1, Line 7: misaligment > sp: misalignment Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia80dfc4dbffe85514b18dcf8d36b85bfafd76d64 Gerrit-Change-Number: 41950 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jan 2026 11:11:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmocore[master]: osmo_io: Fix misalignment of iofd->cmsg used as struct cmsghdr
by pespin 27 Jan '26

27 Jan '26

Attention is currently required from: Hoernchen, daniel, fixeria, jolly, osmith, pespin. Hello Hoernchen, Jenkins Builder, daniel, fixeria, jolly, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email to look at the new patch set (#3). Change subject: osmo_io: Fix misalignment of iofd->cmsg used as struct cmsghdr ...................................................................... osmo_io: Fix misalignment of iofd->cmsg used as struct cmsghdr Fixes following ASAN runtime error: """ src/stream.c:398:47: runtime error: member access within misaligned address 0x516000012b81 for type 'struct cmsghdr', which requires 8 byte alignment 0x516000012b81: note: pointer points here 51 00 00 00 30 00 00 00 00 00 00 00 84 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 03 ^ """ Current GCC documentation [1] states that __attribute__ ((__aligned__ (alignment))) is the older sytnax. The newer _Alignas mimics the standarized alignas() in C23. Since we build with CLAGS=-std=gnu11 we are fine using _Alignas, which was introduced in C11. [1] https://www.gnu.org/software/c-intro-and-ref/manual/html_node/Type-Alignmen… Related: OS#6905 Change-Id: Ia80dfc4dbffe85514b18dcf8d36b85bfafd76d64 --- M src/core/osmo_io_internal.h 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/41950/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia80dfc4dbffe85514b18dcf8d36b85bfafd76d64 Gerrit-Change-Number: 41950 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log