- gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/gerrit: debian10 for osmo-gbproxy + deps
by osmith 28 Jan '26

28 Jan '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41964?usp=email ) Change subject: jobs/gerrit: debian10 for osmo-gbproxy + deps ...................................................................... jobs/gerrit: debian10 for osmo-gbproxy + deps Related: SYS#7859 Change-Id: I7ad3412d945de8c29b6ab62fcadfd2f231c19581 --- M jobs/gerrit-verifications.yml 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/64/41964/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 09714fa..e139e25 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -176,7 +176,7 @@ a1: !!python/tuple [arm-none-eabi, amd64] combination_filter: '!(arch=="arm-none-eabi" && label=="FreeBSD_amd64")' cmd: '{docker_run_ccache} {docker_img} {wrapper_cmd} /build/contrib/jenkins_arch.sh "$arch"' - pipeline_binpkgs: "centos:7 debian:11 debian:13" # centos7: SYS#6760 + pipeline_binpkgs: "centos:7 debian:10 debian:13" # centos7: SYS#6760, debian10: SYS#7859 - libsmpp34 @@ -299,7 +299,8 @@ -e WITH_MANUALS="$WITH_MANUALS" \ {docker_img} {wrapper_cmd} /build/contrib/jenkins.sh - - osmo-gsm-manuals + - osmo-gsm-manuals: + pipeline_binpkgs: "debian:10 debian:13" # debian10: SYS#7859 - osmo_gsup: repos_url: '{gerrit_url}/erlang/{repos}' @@ -482,7 +483,10 @@ pipeline_binpkgs: "" - osmo-smlc - - osmo-gbproxy + + - osmo-gbproxy: + pipeline_binpkgs: "debian:10 debian:13" # debian10: SYS#7859 + - osmo-hnodeb - osmo-hnbgw: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7ad3412d945de8c29b6ab62fcadfd2f231c19581 Gerrit-Change-Number: 41964 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: Use newer M3UA & MTP3 deps generating MTP-STATUS,PAUSE,RESUME.ind
by pespin 28 Jan '26

28 Jan '26

Attention is currently required from: daniel, fixeria, laforge, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41959?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith, Code-Review+2 by laforge, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: Use newer M3UA & MTP3 deps generating MTP-STATUS,PAUSE,RESUME.ind ...................................................................... Use newer M3UA & MTP3 deps generating MTP-STATUS,PAUSE,RESUME.ind * titan.TestPorts.MTP3asp pointer is changed to osmocom fork containing extra patch adding missing fields to MTP-STATUS,PAUSE,RESUME records. It also adds templates for them. * titan.ProtocolEmulations.M3UA pointer is changed to osmocom fork containing extra patch improving M3UA_Emulation component to build MTP-STATUS,PAUSE,RESUME.ind primiives when receiving DAVA/DUNA/DUPU/SCON from M3UA link. The upper layers building on top of MTP3asp_PT (ie. port MTP3asp_SCCP_PT from SCCP_MApping.ttcnp) are fine because they explicitly discard ASP_MTP3_PAUSE,RESUME,STATUS messages in the port defintion. Hence, supporting those in SCCP layer is left as a subsequent task. Related: OS#6907 Change-Id: I67cc2bcf3395a81fa8acee861af01e752984ebb3 --- M deps/Makefile M sccp/SCCP_Tests_RAW.ttcn 2 files changed, 6 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/41959/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41959?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I67cc2bcf3395a81fa8acee861af01e752984ebb3 Gerrit-Change-Number: 41959 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: Expect and discard N-PCSTATE.ind with newer SCCP_Emulation
by pespin 28 Jan '26

28 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41961?usp=email ) Change subject: Expect and discard N-PCSTATE.ind with newer SCCP_Emulation ...................................................................... Expect and discard N-PCSTATE.ind with newer SCCP_Emulation Newer titan.ProtocolEmulations.SCCP will generate N-PCSTATE.ind when needed. Since our tests written so far don't expect those (yet), discard them at the port level so the indications don't interfere with it. Work to enable them will be done in follow-up patches. Related: OS#6907 Change-Id: I532b9f839ab2c08e707fbd63a1e1058253f79b6c --- M deps/Makefile M library/BSSAP_CodecPort.ttcn M library/BSSAP_LE_CodecPort.ttcn M library/ranap/RANAP_CodecPort.ttcn M library/tcap/TCAP_CodecPort.ttcn 5 files changed, 18 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/41961/1 diff --git a/deps/Makefile b/deps/Makefile index e8575cc..3fed0d3 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -8,7 +8,6 @@ OSMOGITEA:=https://gitea.osmocom.org/ttcn3 ECLIPSEGITLAB_REPOS= titan.Libraries.TCCUsefulFunctions \ - titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSAPP_v7.3.0 \ titan.ProtocolModules.DIAMETER_ProtocolModule_Generator \ titan.ProtocolModules.DNS \ @@ -54,6 +53,7 @@ OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \ titan.TestPorts.MTP3asp \ titan.ProtocolEmulations.M3UA \ + titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSGP_v13.0.0 OSMOGERRIT_REPOS= osmo-uecups @@ -75,7 +75,7 @@ nas_commit= 60a69a44cc6bbb32d96aecc4e355128ac5f95a5e titan.Libraries.TCCUsefulFunctions_commit= R.35.B-6-gb3687da titan.ProtocolEmulations.M3UA_commit= a70095b9113b23d2ea2405a5775befec18dd0fe0 -titan.ProtocolEmulations.SCCP_commit= 750a3e836831e58eae59d4757ef5d0c759f9ca5d +titan.ProtocolEmulations.SCCP_commit= 744f3eeb58d7b5bc372c9fd01db737a20bae069a titan.ProtocolModules.BSSAPP_v7.3.0_commit= R.2.A-4-g20cfaf8 titan.ProtocolModules.BSSGP_v13.0.0_commit= e97d92a8b66bec399babea52f593771b76cb175a titan.ProtocolModules.BSSMAP_commit= 4acb6ab5f058477f0b90c2da182d52054e3614b0 diff --git a/library/BSSAP_CodecPort.ttcn b/library/BSSAP_CodecPort.ttcn index 5339b32..2bb6ab6 100644 --- a/library/BSSAP_CodecPort.ttcn +++ b/library/BSSAP_CodecPort.ttcn @@ -388,7 +388,8 @@ BSSAP_N_NOTICE_ind, ASP_SCCP_N_RESET_ind, ASP_SCCP_N_RESET_cfm, - ASP_SCCP_N_STATE_ind; + ASP_SCCP_N_STATE_ind, + ASP_SCCP_N_PCSTATE_ind; } with { extension "internal user SCCPasp_PT out(BSSAP_N_CONNECT_req -> ASP_SCCP_N_CONNECT_req: function(f_enc_ConnectReq); BSSAP_N_CONNECT_res -> ASP_SCCP_N_CONNECT_res: function(f_enc_ConnectRes); @@ -404,7 +405,8 @@ ASP_SCCP_N_NOTICE_ind -> BSSAP_N_NOTICE_ind: function(f_dec_NoticeInd); ASP_SCCP_N_RESET_ind -> ASP_SCCP_N_RESET_ind: simple; ASP_SCCP_N_RESET_cfm -> ASP_SCCP_N_RESET_cfm: simple; - ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple)" + ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple; + ASP_SCCP_N_PCSTATE_ind -> -: discard)" } diff --git a/library/BSSAP_LE_CodecPort.ttcn b/library/BSSAP_LE_CodecPort.ttcn index f1d930f..418e55a 100644 --- a/library/BSSAP_LE_CodecPort.ttcn +++ b/library/BSSAP_LE_CodecPort.ttcn @@ -357,7 +357,8 @@ BSSAP_LE_N_NOTICE_ind, ASP_SCCP_N_RESET_ind, ASP_SCCP_N_RESET_cfm, - ASP_SCCP_N_STATE_ind; + ASP_SCCP_N_STATE_ind, + ASP_SCCP_N_PCSTATE_ind; } with { extension "internal user SCCPasp_PT out(BSSAP_LE_N_CONNECT_req -> ASP_SCCP_N_CONNECT_req: function(f_enc_ConnectReq); BSSAP_LE_N_CONNECT_res -> ASP_SCCP_N_CONNECT_res: function(f_enc_ConnectRes); @@ -373,7 +374,8 @@ ASP_SCCP_N_NOTICE_ind -> BSSAP_LE_N_NOTICE_ind: function(f_dec_NoticeInd); ASP_SCCP_N_RESET_ind -> ASP_SCCP_N_RESET_ind: simple; ASP_SCCP_N_RESET_cfm -> ASP_SCCP_N_RESET_cfm: simple; - ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple)" + ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple; + ASP_SCCP_N_PCSTATE_ind -> -: discard)" } diff --git a/library/ranap/RANAP_CodecPort.ttcn b/library/ranap/RANAP_CodecPort.ttcn index af2090c..084d1cf 100644 --- a/library/ranap/RANAP_CodecPort.ttcn +++ b/library/ranap/RANAP_CodecPort.ttcn @@ -387,7 +387,8 @@ RANAP_N_NOTICE_ind, ASP_SCCP_N_RESET_ind, ASP_SCCP_N_RESET_cfm, - ASP_SCCP_N_STATE_ind; + ASP_SCCP_N_STATE_ind, + ASP_SCCP_N_PCSTATE_ind; } with { extension "internal user SCCPasp_PT out(RANAP_N_CONNECT_req -> ASP_SCCP_N_CONNECT_req: function(f_enc_ConnectReq); RANAP_N_CONNECT_res -> ASP_SCCP_N_CONNECT_res: function(f_enc_ConnectRes); @@ -403,7 +404,8 @@ ASP_SCCP_N_NOTICE_ind -> RANAP_N_NOTICE_ind: function(f_dec_NoticeInd); ASP_SCCP_N_RESET_ind -> ASP_SCCP_N_RESET_ind: simple; ASP_SCCP_N_RESET_cfm -> ASP_SCCP_N_RESET_cfm: simple; - ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple)" + ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple; + ASP_SCCP_N_PCSTATE_ind -> -: discard)" } diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn index cb52814..5f17bc1 100644 --- a/library/tcap/TCAP_CodecPort.ttcn +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -385,7 +385,8 @@ TCAP_N_NOTICE_ind, ASP_SCCP_N_RESET_ind, ASP_SCCP_N_RESET_cfm, - ASP_SCCP_N_STATE_ind; + ASP_SCCP_N_STATE_ind, + ASP_SCCP_N_PCSTATE_ind; } with { extension "internal user SCCPasp_PT out(TCAP_N_CONNECT_req -> ASP_SCCP_N_CONNECT_req: function(f_enc_ConnectReq); TCAP_N_CONNECT_res -> ASP_SCCP_N_CONNECT_res: function(f_enc_ConnectRes); @@ -401,7 +402,8 @@ ASP_SCCP_N_NOTICE_ind -> TCAP_N_NOTICE_ind: function(f_dec_NoticeInd); ASP_SCCP_N_RESET_ind -> ASP_SCCP_N_RESET_ind: simple; ASP_SCCP_N_RESET_cfm -> ASP_SCCP_N_RESET_cfm: simple; - ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple)" + ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple; + ASP_SCCP_N_PCSTATE_ind -> -: discard)" } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I532b9f839ab2c08e707fbd63a1e1058253f79b6c Gerrit-Change-Number: 41961 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: Osmocom_Types: Add API ro_integer_get_first_pos()
by pespin 28 Jan '26

28 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41962?usp=email ) Change subject: Osmocom_Types: Add API ro_integer_get_first_pos() ...................................................................... Osmocom_Types: Add API ro_integer_get_first_pos() It is sometimes useful to find out the position of the 1st item (only one if the list is expected to be a set of unique items), in order to update extra state on an external list.t Change-Id: Id70b2c7d6bf702489de03aed1c389ae892aee835 --- M library/Osmocom_Types.ttcn 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/41962/1 diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn index 690535c..6fbcb39 100644 --- a/library/Osmocom_Types.ttcn +++ b/library/Osmocom_Types.ttcn @@ -401,13 +401,19 @@ type record of integer ro_integer; -function ro_integer_contains(ro_integer r, integer x) return boolean { +/* returns position of "x" in "r", -1 otherwise. */ +function ro_integer_get_first_pos(ro_integer r, integer x) return integer { for (var integer j := 0; j < lengthof(r); j := j+1) { if (r[j] == x) { - return true; + return j; } } - return false; + return -1; +} + + +function ro_integer_contains(ro_integer r, integer x) return boolean { + return ro_integer_get_first_pos(r, x) != -1; } function ro_integer_add_unique(inout ro_integer roi, integer new_entry) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id70b2c7d6bf702489de03aed1c389ae892aee835 Gerrit-Change-Number: 41962 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Handle N-PCSTATE.ind in STP_Tests_TCAP.ttcn
by pespin 28 Jan '26

28 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963?usp=email ) Change subject: stp: Handle N-PCSTATE.ind in STP_Tests_TCAP.ttcn ...................................................................... stp: Handle N-PCSTATE.ind in STP_Tests_TCAP.ttcn Make sure none of the peers we want to talk to is explicitly announced as unavailable before starting the test. Related: OS#6907 Change-Id: Ie1beb2cd69ce1847f3b3bd9917b42a2acaef57c8 --- M library/tcap/TCAP_CodecPort.ttcn M stp/STP_Tests_TCAP.ttcn 2 files changed, 65 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/41963/1 diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn index 5f17bc1..a9bdcc5 100644 --- a/library/tcap/TCAP_CodecPort.ttcn +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -403,7 +403,7 @@ ASP_SCCP_N_RESET_ind -> ASP_SCCP_N_RESET_ind: simple; ASP_SCCP_N_RESET_cfm -> ASP_SCCP_N_RESET_cfm: simple; ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple; - ASP_SCCP_N_PCSTATE_ind -> -: discard)" + ASP_SCCP_N_PCSTATE_ind -> ASP_SCCP_N_PCSTATE_ind: simple)" } diff --git a/stp/STP_Tests_TCAP.ttcn b/stp/STP_Tests_TCAP.ttcn index 3341de9..14708ce 100644 --- a/stp/STP_Tests_TCAP.ttcn +++ b/stp/STP_Tests_TCAP.ttcn @@ -94,6 +94,69 @@ return tcap_configs; } +private function f_get_peer_pc_list() runs on TCAP_CT return Osmocom_Types.ro_integer +{ + var Osmocom_Types.ro_integer peer_pc_list := {}; + + for (var integer i := 0; i < lengthof(g_tcap); i := i + 1) { + ro_integer_add_unique(peer_pc_list, g_tcap[i].sccp_pars.dpc); + } + return peer_pc_list; +} + +/* Wait until none of the peer PCs is explicitly unavailable */ +private function f_wait_peers_available(float timeout_sec := 3.0) +runs on TCAP_CT +{ + timer T; + var ASP_SCCP_N_PCSTATE_ind n_pcstate_ind; + var Osmocom_Types.ro_integer peer_pc_list := f_get_peer_pc_list(); + var Osmocom_Types.ro_integer peer_st_list := {}; /* 1: available, 0: unknown, -1: unavailable */ + + /* Initialize state list item to "unknown": */ + for (var integer i := 0; i < lengthof(peer_pc_list); i := i + 1) { + peer_st_list := peer_st_list & { 0 }; + } + + log("Waiting for SCCP peer_pc_list=", peer_pc_list, " to become available"); + T.start(timeout_sec); + + alt { + [] any from SCCP_TCAP.receive(t_ASP_N_PCSTATE_ind(?, ?, *, *)) -> value n_pcstate_ind { + var integer aff_pc := bit2int(n_pcstate_ind.affectedSP); + var integer idx := ro_integer_get_first_pos(peer_pc_list, aff_pc); + if (idx < 0) { + log("Waiting for SCCP peer_pc_list=", peer_pc_list, ": Rx N-PCSTATE.ind for another peer PC=", aff_pc, ", ",n_pcstate_ind); + repeat; + } + if (n_pcstate_ind.spStatus == SCCP_PAR_SP_Status_accessible and + n_pcstate_ind.remSCCPStatus == SCCP_PAR_Remote_SCCP_Status_available) { + log("SCCP peer PC=", aff_pc," is now available"); + peer_st_list[idx] := 1; /* available */ + for (var integer i := 0; i < lengthof(peer_st_list); i := i + 1) { + if (peer_st_list[i] != 1) { + log("Keep waiting for SCCP peer_pc_list=", peer_pc_list, ", peer_st_list=", peer_st_list); + repeat; + } + } + /* All peers are explicitly available, we are done */ + T.stop; + break; + } + peer_st_list[idx] := -1; /* unavailable */ + repeat; + } + [] T.timeout { + if (ro_integer_contains(peer_st_list, -1)) { + /* explicitly unavailable:*/ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Timeout waiting for SCCP peer_pc_list=", peer_pc_list, ", peer_st_list=", peer_st_list)); + } + /* Done, assume PCs for which we didn't receive an explicit "unavailable" are actually available. */ + } + } + log("Done waiting for SCCP peer_pc_list=", peer_pc_list, ", peer_st_list=", peer_st_list); +} private function f_init_tcap(TCAP_CT_Configurations tcap_configs) runs on TCAP_CT { f_init_common(); @@ -114,10 +177,7 @@ f_sccp_adapter_start(g_tcap[i]); } - /* M3UA Emulation doesn't yet signal events up the stack, so it's - impossible to know exactly when the ASP becomes active. Hence, wait for - a while here to do ASPUP+ASPAC procedures: */ - f_sleep(3.0); + f_wait_peers_available(); } private function f_asp_tx_ipa_ext_tcap_routing(template (value) IPA_EXT_TCAP_ROUTING_Message send_msg, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie1beb2cd69ce1847f3b3bd9917b42a2acaef57c8 Gerrit-Change-Number: 41963 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: core: guard TCP stats on availability of linux/tcp.h
by Timur Davydov 28 Jan '26

28 Jan '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email ) Change subject: core: guard TCP stats on availability of linux/tcp.h ...................................................................... Patch Set 3: (2 comments) File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/2d17a05b_37c36713?… : PS1, Line 315: osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0); > I stats are not used, we should disable this too. Done. I reworked it as suggested: the implementation is now wrapped in HAVE_LINUX_TCP_H, with stub implementations for the public APIs returning -ENOTSUP when the header is unavailable. https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/0ced7f91_008946c3?… : PS1, Line 328: osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL); > I stats are not used, we can disable this function completelly afaiu. Done. I reworked it as suggested: the implementation is now wrapped in HAVE_LINUX_TCP_H, with stub implementations for the public APIs returning -ENOTSUP when the header is unavailable. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd00f15131b0291f0b10eca51401c518b77cc39 Gerrit-Change-Number: 41922 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Jan 2026 11:58:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs: disable ttcn3-gbproxy-test-fr
by osmith 28 Jan '26

28 Jan '26

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41960?usp=email ) Change subject: jobs: disable ttcn3-gbproxy-test-fr ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41960?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I15fcb4fd1f145bd913456ac08356e9fa65e34269 Gerrit-Change-Number: 41960 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 28 Jan 2026 11:28:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: pySimLogger: user __name__ of the module when creating a new logger
by dexter 28 Jan '26

28 Jan '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pySimLogger: user __name__ of the module when creating a new logger ...................................................................... pySimLogger: user __name__ of the module when creating a new logger At the moment we use random identifiers as names when we create a new logger for pySimLogger. Let's switch to consistently use the module name here. For the top level modules let's use the program name so that it will show up in the log instead of __init__. Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a --- M contrib/csv-to-pgsql.py M contrib/es2p_server.py M pySim-shell.py M pySim/card_key_provider.py M pySim/log.py M pySim/runtime.py M tests/unittests/test_log.py 7 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/90/41890/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a Gerrit-Change-Number: 41890 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySimLogger: user __name__ of the module when creating a new logger
by dexter 28 Jan '26

28 Jan '26

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41890?usp=email ) Change subject: pySimLogger: user __name__ of the module when creating a new logger ...................................................................... Patch Set 3: (4 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/3454230a_e2a27094?usp=em… : PS1, Line 38: log = PySimLogger.get(__name__) > Indeed, `log` should be accessible globally. […] I have re-tested this. There seems to be no problem when removing the line. I think I was just irritated. Maybe the problems I had when I was writing the original code were caused by something else that resolved itself later. File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/ac897176_428d8634?usp=em… : PS2, Line 15: log = PySimLogger.get("csv-to-pqsql") > you can generalize this with […] Thanks for the hint. This works fine. I have updated it now in the other code locations as well. File contrib/es2p_server.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/6da24d19_7e307dbe?usp=em… : PS2, Line 35: logger = logging.getLogger("es2p_server") > you can generalize this with […] Done File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/67cfccd3_240db4ec?usp=em… : PS1, Line 41: PySimLogger.get > I was wrong about inheriting configuration of the parent loggers then. […] ACK, then we work on this later. I think it would be great if we could make it work this way. Things would be a lot simpler then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a Gerrit-Change-Number: 41890 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Jan 2026 11:20:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: transport/init: use PySimLogger to print messages
by dexter 28 Jan '26

28 Jan '26

Attention is currently required from: dexter. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: transport/init: use PySimLogger to print messages ...................................................................... transport/init: use PySimLogger to print messages The module still uses print to output information. Let's replace those print calls with the more modern PySimLogger method calls. Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 --- M pySim/transport/__init__.py 1 file changed, 11 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/41812/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 Gerrit-Change-Number: 41812 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log