- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: epdg: add sleep to f_TC_hss_initiated_deregister_permanent_termination
by osmith 19 May '25

19 May '25

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40319?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: epdg: add sleep to f_TC_hss_initiated_deregister_permanent_termination ...................................................................... epdg: add sleep to f_TC_hss_initiated_deregister_permanent_termination The test sends PERMANENT_TERMINATION twice to osmo-epdg. If we don't sleep between them, osmo-epdg is not able to terminate related FSMs quickly enough between the first and the second termination request when running in QEMU, which results in osmo-epdg answering with DIAMETER_SUCESS instead of DIAMETER_ERROR_USER_UNKNOWN for the second f_DIA_SWx_RT. Related: OS#6796 Change-Id: I5d7021b6a9800cf1d7588f4a0ef864f5c30cf475 --- M epdg/EPDG_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/40319/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40319?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d7021b6a9800cf1d7588f4a0ef864f5c30cf475 Gerrit-Change-Number: 40319 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: epdg: TC_concurrent_ues_MTC: rx CMD_ATTACHED without from vc_conn_lis...
by osmith 19 May '25

19 May '25

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40320?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: epdg: TC_concurrent_ues_MTC: rx CMD_ATTACHED without from vc_conn_list[i] ...................................................................... epdg: TC_concurrent_ues_MTC: rx CMD_ATTACHED without from vc_conn_list[i] This is needed to make the test pass in QEMU. I think this makes it accept the COORD_CMD_ATTACHED in any order instead of the order the COORD_CMD_START were sent beforehand. Increasing the sleep between the COORD_CMD_START also makes the test pass in QEMU, but that increases the overall test time significantly in TC_concurrent_ues100. Change-Id: I4c76d12273a14df562ea906e6c8ddb348d1b0eda --- M epdg/EPDG_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/40320/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4c76d12273a14df562ea906e6c8ddb348d1b0eda Gerrit-Change-Number: 40320 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: epdg: initial testenv.cfg
by pespin 19 May '25

19 May '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40321?usp=email ) Change subject: epdg: initial testenv.cfg ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide2873be7830cc43e7fa09f26b2d504d0563a3c2 Gerrit-Change-Number: 40321 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 May 2025 14:05:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ttcn3-hacks[master]: epdg: initial testenv.cfg
by osmith 19 May '25

19 May '25

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40321?usp=email ) Change subject: epdg: initial testenv.cfg ...................................................................... Patch Set 2: Verified+1 (1 comment) Patchset: PS2: tested locally and on jenkins, all tests pass: https://jenkins.osmocom.org/jenkins/job/osmith-ttcn3-epdg-test/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide2873be7830cc43e7fa09f26b2d504d0563a3c2 Gerrit-Change-Number: 40321 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 May 2025 13:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ttcn3-hacks[master]: epdg: initial testenv.cfg
by osmith 19 May '25

19 May '25

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40321?usp=email ) Change subject: epdg: initial testenv.cfg ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide2873be7830cc43e7fa09f26b2d504d0563a3c2 Gerrit-Change-Number: 40321 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 19 May 2025 13:57:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: OBS: build_binpkg: fix building for ubuntu 24.04
by osmith 19 May '25

19 May '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40329?usp=email ) Change subject: OBS: build_binpkg: fix building for ubuntu 24.04 ...................................................................... OBS: build_binpkg: fix building for ubuntu 24.04 Delete the user with the given UID if it already exists, so the image can be built for ubuntu 24.04 too with UID=1000: > [3/6] RUN USERADD --uid=1000 -m user: 0.166 useradd: UID 1000 is not unique Change-Id: I85acbf2de53f02a65ef72d4fed8c2918ec6fa317 --- M scripts/obs/data/build_binpkg.Dockerfile 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile index 0a96272..ba26a2d 100644 --- a/scripts/obs/data/build_binpkg.Dockerfile +++ b/scripts/obs/data/build_binpkg.Dockerfile @@ -6,7 +6,11 @@ COPY Release.key /usr/share/keyrings/osmocom.asc -RUN useradd --uid=${UID} -m user +RUN set -x && \ + if id "${UID}" >/dev/null 2>&1; then \ + userdel "$(getent passwd "${UID}" | cut -d: -f1)"; \ + fi && \ + useradd --uid=${UID} -m user # Only install build-essential here, and what's needed to add the Osmocom # repository. Everything else must be defined as dependency in the package -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40329?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I85acbf2de53f02a65ef72d4fed8c2918ec6fa317 Gerrit-Change-Number: 40329 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: build_binpkg: ubuntu 24.04: fix eclipse-titan
by osmith 19 May '25

19 May '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40330?usp=email ) Change subject: OBS: build_binpkg: ubuntu 24.04: fix eclipse-titan ...................................................................... OBS: build_binpkg: ubuntu 24.04: fix eclipse-titan Fix that installing openjdk-21 as builddep of eclipse-titan fails with: Setting up openjdk-21-jre-headless:amd64 (21.0.7+6~us1-0ubuntu1~24.04) ... update-alternatives: using /usr/lib/jvm/java-21-openjdk-amd64/bin/java to provide /usr/bin/java (java) in auto mode update-alternatives: error: error creating symbolic link '/usr/share/man/man1/java.1.gz.dpkg-tmp': No such file or directory Change-Id: I0d3cf36e5f54616fc7b8629b4ad8eb63342ceb08 --- M scripts/obs/data/build_binpkg.Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile index ba26a2d..a86d48b 100644 --- a/scripts/obs/data/build_binpkg.Dockerfile +++ b/scripts/obs/data/build_binpkg.Dockerfile @@ -25,6 +25,7 @@ echo "path-exclude=/usr/share/man/*" \ > /etc/dpkg/dpkg.cfg.d/exclude-man-pages && \ rm -rf /usr/share/man/ && \ + mkdir -p /usr/share/man/man1/ && \ apt-get update && \ apt-get install -y --no-install-recommends \ build-essential \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0d3cf36e5f54616fc7b8629b4ad8eb63342ceb08 Gerrit-Change-Number: 40330 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: OBS: gerrit_binpkgs: add FEED parameter
by osmith 19 May '25

19 May '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40331?usp=email ) Change subject: OBS: gerrit_binpkgs: add FEED parameter ...................................................................... OBS: gerrit_binpkgs: add FEED parameter Allow switching to another feed easily. I'm using this to build packages for ubuntu quickly, for which we don't have a master feed (only for debian 10, 11, 12 currently). Change-Id: I1b04694e475a74b130ab3f801b99a0e827519ff8 --- M scripts/obs/gerrit_binpkgs.sh 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/scripts/obs/gerrit_binpkgs.sh b/scripts/obs/gerrit_binpkgs.sh index f199844..34f90c4 100755 --- a/scripts/obs/gerrit_binpkgs.sh +++ b/scripts/obs/gerrit_binpkgs.sh @@ -1,6 +1,7 @@ #!/bin/sh -e SCRIPTS_OBS_DIR="$(realpath "$(dirname "$0")")" DISTRO="$1" +FEED=${2:-master} error_exit() { echo "---" @@ -12,9 +13,13 @@ if [ -z "$DISTRO" ]; then - echo "usage: gerrit-binpkgs.sh DISTRO" + echo "usage: gerrit-binpkgs.sh DISTRO [FEED]" + echo + echo "FEED defaults to master." + echo echo "examples:" echo " gerrit-binpkgs.sh debian:12" + echo " gerrit-binpkgs.sh ubuntu:24.04 nightly" echo " gerrit-binpkgs.sh almalinux:8" exit 1 fi @@ -35,6 +40,8 @@ mkdir -p "$CACHE_DIR" rsync -a --delete "$GIT_REPO_DIR" "$CACHE_DIR" +# --feed must be master here, as for build_srcpkg it means that we take the +# currently checked out commit and add a commit_….txt file. echo ":: Building the source package" "$SCRIPTS_OBS_DIR"/build_srcpkg.py \ --allow-unknown-package \ @@ -48,6 +55,7 @@ echo ":: Building the binary packages" "$SCRIPTS_OBS_DIR"/build_binpkg.py \ --docker "$DISTRO" \ + --feed "$FEED" \ "$PROJECT_NAME" || error_exit echo ":: Find binary packages in: $SCRIPTS_OBS_DIR/_temp/binpkgs" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1b04694e475a74b130ab3f801b99a0e827519ff8 Gerrit-Change-Number: 40331 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: OBS: gerrit_binpkgs: add FEED parameter
by fixeria 19 May '25

19 May '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40331?usp=email ) Change subject: OBS: gerrit_binpkgs: add FEED parameter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1b04694e475a74b130ab3f801b99a0e827519ff8 Gerrit-Change-Number: 40331 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 May 2025 13:17:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: OBS: build_binpkg: ubuntu 24.04: fix eclipse-titan
by fixeria 19 May '25

19 May '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40330?usp=email ) Change subject: OBS: build_binpkg: ubuntu 24.04: fix eclipse-titan ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0d3cf36e5f54616fc7b8629b4ad8eb63342ceb08 Gerrit-Change-Number: 40330 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 May 2025 13:17:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log