- gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: debian-bookworm-erlang: add libnftables-dev
by laforge 23 May '25

23 May '25

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40346?usp=email ) Change subject: debian-bookworm-erlang: add libnftables-dev ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I08e08954dbf90f6548d817e0d179cc1bfbe6f315 Gerrit-Change-Number: 40346 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 May 2025 09:07:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: debian-bookworm-erlang: add libnftables-dev
by fixeria 23 May '25

23 May '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40346?usp=email ) Change subject: debian-bookworm-erlang: add libnftables-dev ...................................................................... debian-bookworm-erlang: add libnftables-dev Change-Id: I08e08954dbf90f6548d817e0d179cc1bfbe6f315 Related: osmo-s1gw.git I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Related: SYS#7307 --- M debian-bookworm-erlang/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/46/40346/1 diff --git a/debian-bookworm-erlang/Dockerfile b/debian-bookworm-erlang/Dockerfile index 60e7583..4de9485 100644 --- a/debian-bookworm-erlang/Dockerfile +++ b/debian-bookworm-erlang/Dockerfile @@ -37,6 +37,7 @@ RUN set -x && \ apt-get update && \ apt-get install -y --no-install-recommends \ + libnftables-dev \ libpcap-dev \ libsctp1 \ && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I08e08954dbf90f6548d817e0d179cc1bfbe6f315 Gerrit-Change-Number: 40346 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: s2b: add PDN type to the create session request
by fixeria 23 May '25

23 May '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email ) Change subject: s2b: add PDN type to the create session request ...................................................................... Patch Set 1: (3 comments) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903/comment/4e76acab_26bc… : PS1, Line 87: atom(). It's probably a good idea to define possible atom values here? ``` -type pdn_type() :: ipv4 | ipv6 | ipv4v6. ``` This allows dializer to catch typos in atoms. https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903/comment/c8dd76a5_7f9e… : PS1, Line 537: <<0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0>> Not critical, but you could do this as follows: ``` << 16#00:(8 * 4) >> %% for ipv4 << 16#00:(8 * 16) >> %% for ipv6 << 16#00:(8 * 20) >> %% for ipv4v6 ``` File src/epdg_ue_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903/comment/53e35966_d970… : PS1, Line 70: atom(), You can export `-type pdn_type` from `epdg_gtpc_s2b.erl` and use it here. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I52c9b2db38489404dbe2aac907089a0a6414c9b0 Gerrit-Change-Number: 37903 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 23 May 2025 06:24:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in ...osmo-epdg[master]: s2b: add logline on terminating module
by fixeria 23 May '25

23 May '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email ) Change subject: s2b: add logline on terminating module ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902/comment/c2be4cc2_d59c… : PS1, Line 206: State Do we really want/need to log the state here? And why do you log it as `error` given that it's `normal`? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7a3665b0a77ac86bed448a18cf224e2f6954ba73 Gerrit-Change-Number: 37902 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 23 May 2025 06:13:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by fixeria 23 May '25

23 May '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/1671b7b2_e945… : PS1, Line 145: {stop, "GTPv2C UDP socket open error: ~w~n", [Reason]} This is not a valid return value for https://www.erlang.org/doc/apps/stdlib/gen_server.html#c:init/1. In the case of `stop`, the tuple must contain two elements (`{stop, Reason}`), not three. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 23 May 2025 06:10:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-epdg[master]: s2b: set correct instance values for Bearers
by fixeria 22 May '25

22 May '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email ) Change subject: s2b: set correct instance values for Bearers ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899/comment/2a876fd6_1c41… : PS1, Line 9: explicit +ly -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd Gerrit-Change-Number: 37899 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 22 May 2025 11:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-epdg[master]: s2b: add logline on terminating module
by laforge 22 May '25

22 May '25

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email ) Change subject: s2b: add logline on terminating module ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7a3665b0a77ac86bed448a18cf224e2f6954ba73 Gerrit-Change-Number: 37902 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 22 May 2025 04:40:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by laforge 22 May '25

22 May '25

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email ) Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 22 May 2025 04:40:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-epdg[master]: s2b: answer echo requests
by laforge 22 May '25

22 May '25

Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email ) Change subject: s2b: answer echo requests ...................................................................... Patch Set 1: (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900/comment/2610c1aa_b5ea… : PS1, Line 520: IEs = [#v2_recovery{restart_counter = RCnt}], > This looks wrong. The RestartCounter we send has nothing to do with the one we receive. […] agreeing with pespin. And indeed it's supposed to increment at every local restart. So either store it in a file (like osmo-ggsn/sgsn does, AFAIR) or use a timestamp based hack as suggested. However, the timestamp must not be the local time when sending the echo, but a timestamp that's once obtained when the process starts and then used for all RestartCounter fields during the runtime of the program (basically as long as beam runs in the erlang case). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3c470bd89b9811ba269b53eb400ffc21db4fba3a Gerrit-Change-Number: 37900 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 22 May 2025 04:39:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs: ttcn3-stp*: Pass '-c all'
by pespin 21 May '25

21 May '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40326?usp=email ) Change subject: jobs: ttcn3-stp*: Pass '-c all' ...................................................................... jobs: ttcn3-stp*: Pass '-c all' That testsuite has recently migrated to use several configs, so make sure to run all of them. Depends: osmo-ttcn3-hacks.git Change-Id I4ec8e1bbc8e71d8bd421dfbd5356bf1937ce2bb4 Change-Id: I76af2a979c1f29711bf9c3865d08229240f13eba --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index dc5892b..076bbe3 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -92,7 +92,7 @@ - ttcn3-stp-test: # ~10 min testsuite: stp - args: -b osmocom:nightly + args: -b osmocom:nightly -c all timer: H 09 * * * - ttcn3-hnodeb-test: # ~1 min @@ -263,7 +263,7 @@ - ttcn3-stp-test-latest: # ~10 min testsuite: stp - args: -b osmocom:latest + args: -b osmocom:latest -c all timer: H 12 * * * - ttcn3-hnbgw-test-latest: # ~13 min @@ -396,7 +396,7 @@ - ttcn3-stp-test-io_uring: # ~10 min testsuite: stp - args: -b osmocom:nightly --io-uring + args: -b osmocom:nightly --io-uring -c all timer: H 14 * * * - ttcn3-bsc-test-io_uring: # ~96 min @@ -469,7 +469,7 @@ - ttcn3-stp-test-asan: # ~10 min testsuite: stp - args: -b osmocom:nightly:asan + args: -b osmocom:nightly:asan -c all timer: H 16 * * * - ttcn3-pcu-test-asan: # ~14 min -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40326?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I76af2a979c1f29711bf9c3865d08229240f13eba Gerrit-Change-Number: 40326 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log