- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: bsc-sccplite: Fix override of opc of incoming msgs
by pespin 04 Jul '25

04 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email ) Change subject: bsc-sccplite: Fix override of opc of incoming msgs ...................................................................... bsc-sccplite: Fix override of opc of incoming msgs This patch fixes a regression introduced recently in a patch. We basically revert that line change. This fixes osmo-bsc crashes spotted during ttcn3-bsc-test-sccplite. Fixes: 40c73568c77ee3747a02fce2cf031d723a938207 Related: OS#6806 Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e --- M bsc/osmo-bsc-sccplite.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bsc/osmo-bsc-sccplite.cfg b/bsc/osmo-bsc-sccplite.cfg index 8e6c72f..74923c1 100644 --- a/bsc/osmo-bsc-sccplite.cfg +++ b/bsc/osmo-bsc-sccplite.cfg @@ -34,7 +34,7 @@ as as-clnt-msc-0 ipa asp asp-clnt-msc-0 routing-key 0 0.23.3 - point-code override dpc 0.23.3 + point-code override dpc 0.23.1 network network country code 1 mobile network code 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e Gerrit-Change-Number: 40591 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc-sccplite: Fix override of opc of incoming msgs
by pespin 04 Jul '25

04 Jul '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email ) Change subject: bsc-sccplite: Fix override of opc of incoming msgs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging this one myself in order to avoid further ttcn3-bsc-test-sccplite crashes during weekend. See https://osmocom.org/issues/6806 for more info -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e Gerrit-Change-Number: 40591 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 22:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc-sccplite: Fix override of opc of incoming msgs
by pespin 04 Jul '25

04 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email ) Change subject: bsc-sccplite: Fix override of opc of incoming msgs ...................................................................... bsc-sccplite: Fix override of opc of incoming msgs This patch fixes a regression introduced recently in a patch. We basically revert that line change. This fixes osmo-bsc crashes spotted during ttcn3-bsc-test-sccplite. Fixes: 40c73568c77ee3747a02fce2cf031d723a938207 Related: OS#6806 Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e --- M bsc/osmo-bsc-sccplite.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/40591/1 diff --git a/bsc/osmo-bsc-sccplite.cfg b/bsc/osmo-bsc-sccplite.cfg index 8e6c72f..74923c1 100644 --- a/bsc/osmo-bsc-sccplite.cfg +++ b/bsc/osmo-bsc-sccplite.cfg @@ -34,7 +34,7 @@ as as-clnt-msc-0 ipa asp asp-clnt-msc-0 routing-key 0 0.23.3 - point-code override dpc 0.23.3 + point-code override dpc 0.23.1 network network country code 1 mobile network code 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e Gerrit-Change-Number: 40591 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_{msc,sgsn}pool_sccp_n_pcstate_detaches_cnlin...
by pespin 04 Jul '25

04 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40592?usp=email ) Change subject: hnbgw: Introduce test TC_{msc,sgsn}pool_sccp_n_pcstate_detaches_cnlink_sctp_down ...................................................................... hnbgw: Introduce test TC_{msc,sgsn}pool_sccp_n_pcstate_detaches_cnlink_sctp_down Related: OS#5917 Depends: libosmo-sigtran.git Change-Id I7e4eedb65c4f2952f8b39ca4c539ca2f40e9946c Change-Id: I079f2da09ff8d52e614ff6f5d267cd5429e4eb58 --- M hnbgw/HNBGW_Tests.default M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml M hnbgw/osmo-hnbgw.cfg M hnbgw/osmo-stp.cfg 5 files changed, 95 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/40592/1 diff --git a/hnbgw/HNBGW_Tests.default b/hnbgw/HNBGW_Tests.default index b8a4863..174b012 100644 --- a/hnbgw/HNBGW_Tests.default +++ b/hnbgw/HNBGW_Tests.default @@ -20,6 +20,16 @@ *.STATSVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" *.STATSVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" *.STATSVTY.PROMPT1 := "OsmoHNBGW> " +*.STPVTY.CTRL_MODE := "client" +*.STPVTY.CTRL_HOSTNAME := "127.0.0.1" +*.STPVTY.CTRL_PORTNUM := "4239" +*.STPVTY.CTRL_LOGIN_SKIPPED := "yes" +*.STPVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" +*.STPVTY.CTRL_READMODE := "buffered" +*.STPVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" +*.STPVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" +*.STPVTY.PROMPT1 := "OsmoSTP> " + [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoHNBGW"; diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index ef70948..b0bdca0 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -264,6 +264,7 @@ var MGCP_Emulation_CT vc_MGCP; port TELNETasp_PT HNBGWVTY; + port TELNETasp_PT STPVTY; var StatsD_Checker_CT vc_STATSD; var PFCP_Emulation_CT vc_PFCP; /* global test case guard timer (actual timeout value is set in f_init()) */ @@ -298,6 +299,16 @@ f_vty_transceive(HNBGWVTY, "enable"); } +private function f_init_vty_stp() runs on test_CT { + if (STPVTY.checkstate("Mapped")) { + /* skip initialization if already executed once */ + return; + } + map(self:STPVTY, system:STPVTY); + f_vty_set_prompts(STPVTY, prompt_prefix := "OsmoSTP"); + f_vty_transceive(STPVTY, "enable"); +} + function f_init_mgcp(charstring id) runs on test_CT { id := id & "-MGCP"; var MGCPOps ops := { @@ -1797,7 +1808,7 @@ f_perform_compl_l3(g_pars.nas_pdu, expect_success := g_pars.expect_compl_l3_success); } -private function f_TC_cnpool_compl_l3(boolean ps_domain, octetstring nas_pdu, integer cn_nr, +private function f_TC_cnpool_compl_l3(boolean ps_domain, octetstring nas_pdu, integer cn_nr := 0, template (omit) charstring inc_countername := omit, boolean expect_compl_l3_success := true) runs on test_CT { var ConnHdlr vc_conn; @@ -2490,7 +2501,63 @@ f_shutdown_helper(); } -/* When a peer point-code gets an SCCP N-PCSTATE saying it is unreachable, immediately mark the CN link as unusable. */ +private function f_vty_stp_hnbgw_asp_cmd(boolean ps_domain, charstring cmd) runs on test_CT +{ + var charstring asp_node := "asp hnbgw0-0 2906 2905 m3ua"; + f_vty_config2(STPVTY, {"cs7 instance 0", asp_node}, cmd); +} + +/* When a peer point-code gets an SCCP N-PCSTATE saying it is unreachable, + * immediately mark the CN link as unusable. + * In this scenario, the SCCP N-PCSTATE is triggered by instructing the STP to + * shutdown the ASP serving the HNBGW, which will close the SCTP assoc between + * itself and IUT (HNBGW), which should then generate an N-PCSTATE.ind. + */ +testcase TC_mscpool_sccp_n_pcstate_detaches_cnlink_sctp_down() runs on test_CT { + f_TC_cnpool_sccp_n_pcstate_detaches_cnlink_sctp_down(ps_domain := false); +} +testcase TC_sgsnpool_sccp_n_pcstate_detaches_cnlink_sctp_down() runs on test_CT { + f_TC_cnpool_sccp_n_pcstate_detaches_cnlink_sctp_down(ps_domain := true); +} +function f_TC_cnpool_sccp_n_pcstate_detaches_cnlink_sctp_down(boolean ps_domain) runs on test_CT +{ + + f_init(nr_msc := 2, nr_sgsn := 2); + f_init_vty_stp(); + f_sleep(1.0); + + /* Control which MSC gets chosen next by the round-robin, otherwise + * would be randomly affected by which other tests ran before this. */ + f_vty_set_roundrobin_next(HNBGWVTY, ps_domain, 0); + + f_ctrs_cn_init(ps_domain := ps_domain); + + var ro_octetstring compl3 := f_gen_compl3_by_domain(ps_domain, 3); + + f_TC_cnpool_compl_l3(ps_domain, compl3[0], cn_nr := 0, inc_countername := "cnpool:subscr:new"); + f_TC_cnpool_compl_l3(ps_domain, compl3[1], cn_nr := 1, inc_countername := "cnpool:subscr:new"); + + f_logp(HNBGWVTY, "Shutting down HNBGW ASP in STP"); + f_vty_stp_hnbgw_asp_cmd(ps_domain, "shutdown"); + + f_TC_cnpool_compl_l3(ps_domain, compl3[2], expect_compl_l3_success := false); + + f_logp(HNBGWVTY, "Restarting HNBGW ASP in STP"); + f_vty_stp_hnbgw_asp_cmd(ps_domain, "no shutdown"); + + /* Now round-robin would wrap to the first MSC, but since the first MSC is disconnected, it wraps around to the + * second. */ + f_TC_cnpool_compl_l3(ps_domain, compl3[2], cn_nr := 1, inc_countername := "cnpool:subscr:new"); + f_shutdown_helper(); +} + +/* When a peer point-code gets an SCCP N-PCSTATE saying it is unreachable, + * immediately mark the CN link as unusable. + * In this scenario, the SCCP N-PCSTATE is triggered by locally dropping the + * SCTP assoc at the virtual MSC (TTCN3). When STP osmo-hnbgw finds out about + * the SCTP conn STP<->MSC going down, it will send an M3UA DUNA to the IUT + * (HNBGW) which should then generate an N-PCSTATE.ind. + */ testcase TC_mscpool_sccp_n_pcstate_detaches_cnlink() runs on test_CT { f_TC_cnpool_sccp_n_pcstate_detaches_cnlink(ps_domain := false); } diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index c04876d..5563c57 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -51,6 +51,7 @@ <testcase classname='HNBGW_Tests' name='TC_mscpool_paging_imsi_rai_registered' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_no_allow_attach_round_robin' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_no_allow_attach_valid_nri' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_sccp_n_pcstate_detaches_cnlink_sctp_down' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_sccp_n_pcstate_detaches_cnlink' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_sccp_n_pcstate_attaches_cnlink' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Compl_on_1_cnlink' time='MASKED'/> @@ -59,6 +60,7 @@ <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Complete_valid_nri_2' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Compl_no_cn' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_sgsnpool_nri_from_other_PLMN' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_sccp_n_pcstate_detaches_cnlink_sctp_shutdown' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_sgsnpool_sccp_n_pcstate_detaches_cnlink' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_sgsnpool_sccp_n_pcstate_attaches_cnlink' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_second_rab_assignment' time='MASKED'/> diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg index 423cec5..e074b15 100644 --- a/hnbgw/osmo-hnbgw.cfg +++ b/hnbgw/osmo-hnbgw.cfg @@ -37,13 +37,13 @@ cs7 instance 0 point-code 0.23.5 - asp asp-clnt-msc-0 2905 2906 m3ua + asp asp-clnt-CN-0 2905 2906 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 role asp sctp-role client - as as-clnt-msc-0 m3ua - asp asp-clnt-msc-0 + as as-clnt-CN m3ua + asp asp-clnt-CN-0 routing-key 0 0.23.5 sccp-address msc-naught diff --git a/hnbgw/osmo-stp.cfg b/hnbgw/osmo-stp.cfg index ba3e3d0..b70a584 100644 --- a/hnbgw/osmo-stp.cfg +++ b/hnbgw/osmo-stp.cfg @@ -34,6 +34,15 @@ ! cs7 instance 0 xua rkm routing-key-allocation dynamic-permitted + asp hnbgw0-0 2906 2905 m3ua + local-ip 127.0.0.1 + remote-ip 127.0.0.1 + role sg + sctp-role server + as hnbgw0 m3ua + routing-key 0 0.23.5 + asp hnbgw0-0 + asp virt-msc0-0 23905 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 @@ -89,6 +98,7 @@ routing-key 6 0.1.3 route-table system + update route 0.23.5 7.255.7 linkset hnbgw0 update route 0.23.4 7.255.7 linkset virt-msc0 update route 0.0.2 7.255.7 linkset virt-msc1 update route 0.0.3 7.255.7 linkset virt-msc2 @@ -96,4 +106,4 @@ update route 0.1.2 7.255.7 linkset virt-sgsn1 update route 0.1.3 7.255.7 linkset virt-sgsn2 listen m3ua 2905 - accept-asp-connections dynamic-permitted + accept-asp-connections pre-configured -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I079f2da09ff8d52e614ff6f5d267cd5429e4eb58 Gerrit-Change-Number: 40592 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ggsn[master]: gtpie: make ies const for getter
by lynxis lazus 04 Jul '25

04 Jul '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email ) Change subject: gtpie: make ies const for getter ...................................................................... Patch Set 2: (1 comment) File include/osmocom/gtp/gtpie.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/40432/comment/6524e19c_c7ac77d6?us… : PS1, Line 304: extern int gtpie_getie(union gtpie_member * const ie[], int type, int instance); > Ah nevermind, it's an out param right? No, it returns the output for getie(). But I tried to change it to "const union gtpie_member * const ie[]" which doesn't work. I'm not sure, problably, because it expects the objects within ie[] to be const which is a different type. Any other recommendation? here is the output of gcc ``` gtp.c:2160:34: error: passing argument 1 of 'gtpie_gettv4' from incompatible pointer type [-Wincompatible-pointer-types] 2160 | if (gtpie_gettv4(ie, GTPIE_CHARGING_ID, 0, &pdp->cid)) { | ^~ | | | union gtpie_member ** ../include/osmocom/gtp/gtpie.h:314:58: note: expected 'const union gtpie_member * const*' but argument is of type 'union gtpie_member **' 314 | extern int gtpie_gettv4(union gtpie_member const * const ie[], int type, int instance, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I43195314b1cf416a1f2fd4d3ddd48c4eee462b0b Gerrit-Change-Number: 40432 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 20:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ggsn[master]: tests: add a simple gtpie_getie() test
by Jenkins Builder 04 Jul '25

04 Jul '25

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40590?usp=email ) Change subject: tests: add a simple gtpie_getie() test ...................................................................... Patch Set 1: (23 comments) File tests/gtp/gtpie_test.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b2794e45_af5c9c34?us… : PS1, Line 111: static void test_gtpie_getie() Bad function definition - void test_gtpie_getie() should probably be void test_gtpie_getie(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/457aad52_095f9d08?us… : PS1, Line 113: union gtpie_member *ie[GTPIE_SIZE] = {}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/9f37ec03_0893d11b?us… : PS1, Line 114: union gtpie_member ie_elem[3] = {}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/4751c979_fc7921cc?us… : PS1, Line 119: OSMO_ASSERT(gtpie_getie(ie, 0, 0) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/8bd3ae83_4fc4d012?us… : PS1, Line 120: OSMO_ASSERT(gtpie_getie(ie, 0, 1) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/12e5aad1_6ab5f007?us… : PS1, Line 122: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 0) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/afe66bb9_83385a95?us… : PS1, Line 123: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 1) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/d954347a_a69f9de2?us… : PS1, Line 125: ie_elem[0].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/6a84d657_4f3bf3be?us… : PS1, Line 126: ie_elem[0].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/e0681b23_95d4169f?us… : PS1, Line 127: ie[0] = &ie_elem[0]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/fa19a7b3_2798c632?us… : PS1, Line 129: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/4d0218ce_ed6ec516?us… : PS1, Line 130: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == -1); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b02dbe98_2bd2b652?us… : PS1, Line 133: ie_elem[1].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/238b4612_5ba7c09b?us… : PS1, Line 134: ie_elem[1].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b08e47b7_d3e77350?us… : PS1, Line 135: ie[2] = &ie_elem[0]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b40a78b9_91598954?us… : PS1, Line 137: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/7fa6eba9_3878deb1?us… : PS1, Line 138: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/8b35a5f2_ee7e7c53?us… : PS1, Line 141: ie_elem[2].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/11452f11_3c65064e?us… : PS1, Line 142: ie_elem[2].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/af7645e1_ce558e06?us… : PS1, Line 143: ie[GTPIE_SIZE - 1] = &ie_elem[0]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/48eef148_3b2eb26f?us… : PS1, Line 145: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/4364a93e_f1fdf8cf?us… : PS1, Line 146: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/35899a65_c7fededf?us… : PS1, Line 147: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 2) == GTPIE_SIZE - 1); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5cd45d752592c7133d4452f4e4986783fb17e256 Gerrit-Change-Number: 40590 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 04 Jul 2025 19:57:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ggsn[master]: tests: add a simple gtpie_getie() test
by lynxis lazus 04 Jul '25

04 Jul '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40590?usp=email ) Change subject: tests: add a simple gtpie_getie() test ...................................................................... tests: add a simple gtpie_getie() test Change-Id: I5cd45d752592c7133d4452f4e4986783fb17e256 --- M tests/gtp/gtpie_test.c M tests/gtp/gtpie_test.ok 2 files changed, 44 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/90/40590/1 diff --git a/tests/gtp/gtpie_test.c b/tests/gtp/gtpie_test.c index 46c0a98..fe82655 100644 --- a/tests/gtp/gtpie_test.c +++ b/tests/gtp/gtpie_test.c @@ -108,6 +108,46 @@ OSMO_ASSERT(osmo_load32be(&buf[5]) == 0x04050607); } +static void test_gtpie_getie() +{ + union gtpie_member *ie[GTPIE_SIZE] = {}; + union gtpie_member ie_elem[3] = {}; + + printf("Testing gtpie_getie()\n"); + + /* Empty ie should always return -1 */ + OSMO_ASSERT(gtpie_getie(ie, 0, 0) == -1); + OSMO_ASSERT(gtpie_getie(ie, 0, 1) == -1); + + OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 0) == -1); + OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 1) == -1); + + ie_elem[0].tv1.t = GTPIE_CAUSE; + ie_elem[0].tv1.v = GTPIE_CAUSE; + ie[0] = &ie_elem[0]; + + OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); + OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == -1); + + + ie_elem[1].tv1.t = GTPIE_CAUSE; + ie_elem[1].tv1.v = GTPIE_CAUSE; + ie[2] = &ie_elem[0]; + + OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); + OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); + + + ie_elem[2].tv1.t = GTPIE_CAUSE; + ie_elem[2].tv1.v = GTPIE_CAUSE; + ie[GTPIE_SIZE - 1] = &ie_elem[0]; + + OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); + OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); + OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 2) == GTPIE_SIZE - 1); +} + + int main(int argc, char **argv) { void *tall_ctx = talloc_named_const(NULL, 1, "Root context"); @@ -125,9 +165,11 @@ test_gtpie_tv4(); test_gtpie_tv8(); + test_gtpie_getie(); + /* TODO: gtpie_decaps() */ /* TODO: gtpie_encaps() */ /* TODO: gtpie_encaps2() */ - /* TODO: gtpie_getie(), gtpie_exist(), gtpie_get*() */ + /* TODO: gtpie_exist(), gtpie_get*() */ return 0; } diff --git a/tests/gtp/gtpie_test.ok b/tests/gtp/gtpie_test.ok index 465df72..3eea44c 100644 --- a/tests/gtp/gtpie_test.ok +++ b/tests/gtp/gtpie_test.ok @@ -4,3 +4,4 @@ Testing gtpie_tv2() Testing gtpie_tv4() Testing gtpie_tv8() +Testing gtpie_getie() -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5cd45d752592c7133d4452f4e4986783fb17e256 Gerrit-Change-Number: 40590 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-remsim[master]: bankd: implicit remove a client mapping when creating a new mapping
by lynxis lazus 04 Jul '25

04 Jul '25

Attention is currently required from: Hoernchen, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email ) Change subject: bankd: implicit remove a client mapping when creating a new mapping ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-remsim/+/40570/comment/8fffd560_81c0d897?… : PS3, Line 9: After a desynchronisation between the server and bankd happen (e.g. restart the server), > No. I'm using a plain `git commit` for that. What tool are you using? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b Gerrit-Change-Number: 40570 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Jul 2025 18:06:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: vty: Make sure user doesn't configure AS in ASP role with a non-local...
by pespin 04 Jul '25

04 Jul '25

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: vty: Make sure user doesn't configure AS in ASP role with a non-local PC as routing-key ...................................................................... vty: Make sure user doesn't configure AS in ASP role with a non-local PC as routing-key AS in ASP mode doesn't expect to route incomign traffic to other nodes. They are expected to announce its routing-key (local PC) to the SG so it knows how to reach it and in turn announce (un)availability to other SG/ASPs in the network. Change-Id: Ibbf990fd8dcbdc67ebc4118597b34a5767320cf6 --- M src/ss7_as_vty.c M src/ss7_vty.c M src/ss7_vty.h 3 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/86/40586/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibbf990fd8dcbdc67ebc4118597b34a5767320cf6 Gerrit-Change-Number: 40586 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-sigtran[master]: vty: Make sure user doesn't configure AS in ASP role with a non-local...
by pespin 04 Jul '25

04 Jul '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email ) Change subject: vty: Make sure user doesn't configure AS in ASP role with a non-local PC as routing-key ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586/comment/22f07826_fd34b… : PS1, Line 9: AS > well, it's not what the RFC authors had in mind, for sure. […] If the AS(P) of one of the STPs is configured with role ASP, then yeah we may want to configure there using a remote PC. We also have a global "enum cs7_role_t cs7_role" which we set based on call to osmo_ss7_vty_init_asp() or osmo_ss7_vty_init_sg(). I'll add that into the logic check so that the validation is only done when global cs7_role = CS7_ROLE_ASP. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibbf990fd8dcbdc67ebc4118597b34a5767320cf6 Gerrit-Change-Number: 40586 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log