- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: Use xua_msg_free() everywhere to free xua_msg
by laforge 10 Jul '25

10 Jul '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email ) Change subject: Use xua_msg_free() everywhere to free xua_msg ...................................................................... Use xua_msg_free() everywhere to free xua_msg Change-Id: I1d43478a5c430e92f1bd5a0b3d3606a39f378e44 --- M src/sccp_scoc_fsm.c M tests/xua/xua_test.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/sccp_scoc_fsm.c b/src/sccp_scoc_fsm.c index fa3019e..1833b89 100644 --- a/src/sccp_scoc_fsm.c +++ b/src/sccp_scoc_fsm.c @@ -409,7 +409,7 @@ /* Send N-DISCONNECT.ind to local user */ sccp_conn_scu_gen_encode_and_send(conn, event, xua, OSMO_SCU_PRIM_N_DISCONNECT, PRIM_OP_INDICATION); - talloc_free(xua); + xua_msg_free(xua); /* Send RLSD to peer */ sccp_conn_xua_gen_relre_and_send(conn, SCCP_RELEASE_CAUSE_EXPIRATION_INACTIVE, NULL); /* start release timer */ @@ -457,7 +457,7 @@ /* send N-DISCONNECT.ind to user */ sccp_conn_scu_gen_encode_and_send(conn, event, xua, OSMO_SCU_PRIM_N_DISCONNECT, PRIM_OP_INDICATION); - talloc_free(xua); + xua_msg_free(xua); /* Send RLSD to SCRC */ sccp_conn_xua_gen_relre_and_send(conn, SCCP_RELEASE_CAUSE_INCONSISTENT_CONN_DATA, NULL); /* Start release timer */ diff --git a/tests/xua/xua_test.c b/tests/xua/xua_test.c index e3d9ac5..0759ff7 100644 --- a/tests/xua/xua_test.c +++ b/tests/xua/xua_test.c @@ -601,8 +601,8 @@ OSMO_ASSERT(xua_msg_get_u32(nested, M3UA_IEI_LOC_RKEY_ID) == 1); OSMO_ASSERT(xua_msg_get_u32(nested, M3UA_IEI_DEST_PC) == 23); - talloc_free(nested); - talloc_free(xua); + xua_msg_free(nested); + xua_msg_free(xua); } static void test_sccp_addr_cmp(void) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1d43478a5c430e92f1bd5a0b3d3606a39f378e44 Gerrit-Change-Number: 40614 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: xua_msg: Constify ptr args in multiple APIs
by laforge 10 Jul '25

10 Jul '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40616?usp=email ) Change subject: xua_msg: Constify ptr args in multiple APIs ...................................................................... xua_msg: Constify ptr args in multiple APIs Change-Id: I9f5a564b99cfc62bd3deb98a68d3e36474d3810f --- M src/xua_msg.c M src/xua_msg.h 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/xua_msg.c b/src/xua_msg.c index d32d824..bc2a4f7 100644 --- a/src/xua_msg.c +++ b/src/xua_msg.c @@ -504,7 +504,7 @@ } } -char *xua_hdr_dump(struct xua_msg *xua, const struct xua_dialect *dialect) +char *xua_hdr_dump(const struct xua_msg *xua, const struct xua_dialect *dialect) { const struct xua_msg_class *xmc = NULL; static char buf[128]; @@ -551,7 +551,7 @@ return 1; } -char *xua_msg_dump(struct xua_msg *xua, const struct xua_dialect *dialect) +char *xua_msg_dump(const struct xua_msg *xua, const struct xua_dialect *dialect) { static char buf[1024]; struct osmo_strbuf sb = { .buf = buf, .len = sizeof(buf) }; diff --git a/src/xua_msg.h b/src/xua_msg.h index 80d4c79..8311d60 100644 --- a/src/xua_msg.h +++ b/src/xua_msg.h @@ -102,8 +102,8 @@ const char *xua_class_msg_name(const struct xua_msg_class *xmc, uint16_t msg_type); const char *xua_class_iei_name(const struct xua_msg_class *xmc, uint16_t iei); -char *xua_hdr_dump(struct xua_msg *xua, const struct xua_dialect *dialect); -char *xua_msg_dump(struct xua_msg *xua, const struct xua_dialect *dialect); +char *xua_hdr_dump(const struct xua_msg *xua, const struct xua_dialect *dialect); +char *xua_msg_dump(const struct xua_msg *xua, const struct xua_dialect *dialect); int xua_dialect_check_all_mand_ies(const struct xua_dialect *dialect, struct xua_msg *xua); int xua_msg_event_map(const struct xua_msg *xua, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9f5a564b99cfc62bd3deb98a68d3e36474d3810f Gerrit-Change-Number: 40616 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Submit SCRC Routing Failure indications asynchronously
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40615?usp=email ) Change subject: Submit SCRC Routing Failure indications asynchronously ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm not sure I'm following you. […] My point was that if we generically would enqueue all upward primitives at the SCCP user SAP, we wouldn't have to add some mechanism/queue specifically for those routing failures. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I17ae7174f7ffee8c9a004435e522803a97d4fb7b Gerrit-Change-Number: 40615 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Use xua_msg_free() everywhere to free xua_msg
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email ) Change subject: Use xua_msg_free() everywhere to free xua_msg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1d43478a5c430e92f1bd5a0b3d3606a39f378e44 Gerrit-Change-Number: 40614 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:14:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: Improve logging receiving Routing Failure
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40612?usp=email ) Change subject: Improve logging receiving Routing Failure ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic7f9fd18e55b673b8be86b5459afefa8abd07628 Gerrit-Change-Number: 40612 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:14:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: vty: Introduce missing cmd 'point-code override opc'
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: daniel, dexter, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email ) Change subject: vty: Introduce missing cmd 'point-code override opc' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id8ba5252a088dafe85bb25e13298c585acef277d Gerrit-Change-Number: 40611 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:14:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: vty: Introduce missing cmd 'point-code override opc'
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: daniel, dexter, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email ) Change subject: vty: Introduce missing cmd 'point-code override opc' ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id8ba5252a088dafe85bb25e13298c585acef277d Gerrit-Change-Number: 40611 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:13:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: vty: Make sure user doesn't configure AS in ASP role with a non-local...
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email ) Change subject: vty: Make sure user doesn't configure AS in ASP role with a non-local PC as routing-key ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586/comment/31e354bb_32eb8… : PS1, Line 9: AS > If the AS(P) of one of the STPs is configured with role ASP, then yeah we may want to configure ther […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibbf990fd8dcbdc67ebc4118597b34a5767320cf6 Gerrit-Change-Number: 40586 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:13:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: vty: Make sure user doesn't configure AS in ASP role with a non-local...
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email ) Change subject: vty: Make sure user doesn't configure AS in ASP role with a non-local PC as routing-key ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibbf990fd8dcbdc67ebc4118597b34a5767320cf6 Gerrit-Change-Number: 40586 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:12:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: vty: Make sure user doesn't configure AS in ASP role with a non-local...
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email ) Change subject: vty: Make sure user doesn't configure AS in ASP role with a non-local PC as routing-key ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibbf990fd8dcbdc67ebc4118597b34a5767320cf6 Gerrit-Change-Number: 40586 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:12:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log