lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email )
Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
......................................................................
gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
The pdp_status is actually encoded as little endian,
but there is no tlvp_val16le. Use osmo_swab16() instead.
Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c
---
M src/sgsn/gprs_gmm.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/53/40653/1
diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c
index c34c1a1..fff15e0 100644
--- a/src/sgsn/gprs_gmm.c
+++ b/src/sgsn/gprs_gmm.c
@@ -1975,7 +1975,8 @@
/* Look at PDP Context Status IE and see if MS's view of
* activated/deactivated NSAPIs agrees with our view */
if (TLVP_PRESENT(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) {
- uint16_t pdp_status = tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS);
+ /* TODO: pdp status is little endian. Create tlvp_val16be */
+ uint16_t pdp_status = osmo_swab16(tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS));
process_ms_ctx_status(ctx, pdp_status);
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c
Gerrit-Change-Number: 40653
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: SGSN: Iu: use correct service request type
......................................................................
SGSN: Iu: use correct service request type
When the UE wants to transfer data, the Service Request
must have the type data.
Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52
---
M sgsn/SGSN_Tests_Iu.ttcn
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/40649/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52
Gerrit-Change-Number: 40649
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40651?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accept is expect
......................................................................
BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accept is expect
A SecurityModeCommand is defined as an implicit Service Accept when the UE
is in PMM_IDLE (meaning, having no Iu signalling connection)
Change-Id: I5c190db28263c530a8eea188bf570a58eaffdd4d
---
M sgsn/BSSGP_ConnHdlr.ttcn
M sgsn/SGSN_Tests_Iu.ttcn
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/40651/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40651?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5c190db28263c530a8eea188bf570a58eaffdd4d
Gerrit-Change-Number: 40651
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder