- gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: use variable name rai for `struct osmo_routing_area_id`
by daniel 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40689?usp=email ) Change subject: use variable name rai for `struct osmo_routing_area_id` ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I946983d4857035e06c68af378654466b35025014 Gerrit-Change-Number: 40689 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 16:06:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: routing area: introduce ran_type on the RA
by daniel 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email ) Change subject: routing area: introduce ran_type on the RA ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c Gerrit-Change-Number: 40688 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 16:06:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Iu: use correct service request type
by lynxis lazus 15 Jul '25

15 Jul '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email ) Change subject: SGSN: Iu: use correct service request type ...................................................................... SGSN: Iu: use correct service request type When the UE wants to transfer data, the Service Request must have the type data. Remove the default of f_service_request() to force explicit defining it. Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52 --- M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/SGSN_Tests_Iu.ttcn 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 2b95ec0..6e2e611 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -753,7 +753,7 @@ } function f_service_request(inout PdpActPars apars, - ServiceType service_type := SERVICE_TYPE_Signalling, + ServiceType service_type, template (value) OCT2 pdp_status := '0000'O, boolean exp_ggsn_pdp_del := false, boolean expect_auth := false, diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn index 3de89b6..776c333 100644 --- a/sgsn/SGSN_Tests_Iu.ttcn +++ b/sgsn/SGSN_Tests_Iu.ttcn @@ -137,7 +137,7 @@ /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 3); - f_service_request(apars, ran_index := 3); + f_service_request(apars, service_type := SERVICE_TYPE_Signalling, ran_index := 3); f_pdp_ctx_act(apars, ran_index := 3); @@ -210,7 +210,7 @@ /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := ran_index); - f_service_request(apars, ran_index := ran_index); + f_service_request(apars, service_type := SERVICE_TYPE_Signalling, ran_index := ran_index); f_pdp_tx_ctx_act(apars, ran_index := ran_index); as_ggsn_gtp_ctx_act_req(apars, send_recovery := false); T.start; @@ -247,7 +247,7 @@ /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 3); - f_service_request(apars, ran_index := 3); + f_service_request(apars, service_type := SERVICE_TYPE_Signalling, ran_index := 3); f_pdp_ctx_act(apars, ran_index := 3); @@ -283,7 +283,7 @@ /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 3); - f_service_request(apars, ran_index := 3); + f_service_request(apars, service_type := SERVICE_TYPE_Signalling, ran_index := 3); f_pdp_ctx_act(apars, ran_index := 3); @@ -295,7 +295,7 @@ /* Now UE tries to send new data after a while of being IDLE. * It forgot its previous pdp status, hence := 0000. * SGSN will delete previous PDP ctx at the GGSN. */ - f_service_request(apars, pdp_status := '0000'O /*NSAPI=5*/, exp_ggsn_pdp_del := true, ran_index := 3); + f_service_request(apars, service_type := SERVICE_TYPE_Data, pdp_status := '0000'O /*NSAPI=5*/, exp_ggsn_pdp_del := true, ran_index := 3); f_pdp_ctx_act(apars, ran_index := 3); /* Now UE is in PMM ENABLED state, tear it down to clean up: */ @@ -319,7 +319,7 @@ /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 3); - f_service_request(apars, ran_index := 3); + f_service_request(apars, service_type := SERVICE_TYPE_Signalling, ran_index := 3); f_pdp_ctx_act(apars, ran_index := 3); @@ -338,7 +338,7 @@ /* Ue comes back, answering the paging: * SGSN recreates the Iu ctx and recovers the Direct Tunnel RNC<->GGSN: */ - f_service_request(apars, pdp_status := '2000'O /*NSAPI=5*/, ran_index := 3); + f_service_request(apars, service_type := SERVICE_TYPE_Data, pdp_status := '2000'O /*NSAPI=5*/, ran_index := 3); as_ranap_rab_ass_req(apars); as_ggsn_gtp_ctx_upd_req(apars, exp_dir_tun := true, ran_index := 3); @@ -367,7 +367,7 @@ /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := ran_index); - f_service_request(apars, ran_index := ran_index); + f_service_request(apars, service_type := SERVICE_TYPE_Signalling, ran_index := ran_index); f_pdp_ctx_act(apars, ran_index := ran_index); @@ -399,7 +399,7 @@ /* Ue comes back, answering the paging: * SGSN recreates the Iu ctx and recovers the Direct Tunnel RNC<->GGSN: */ - f_service_request(apars, pdp_status := '2000'O /*NSAPI=5*/, ran_index := ran_index); + f_service_request(apars, service_type := SERVICE_TYPE_Data, pdp_status := '2000'O /*NSAPI=5*/, ran_index := ran_index); as_ranap_rab_ass_req(apars); as_ggsn_gtp_ctx_upd_req(apars, exp_dir_tun := true, ran_index := ran_index); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52 Gerrit-Change-Number: 40649 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Iu: use correct service request type
by lynxis lazus 15 Jul '25

15 Jul '25

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email ) Change subject: SGSN: Iu: use correct service request type ...................................................................... Patch Set 4: (1 comment) File sgsn/SGSN_Tests_Iu.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649/comment/d20e3c34_adb2… : PS3, Line 213: SERVICE_TYPE_Signalling > to make it more clear. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52 Gerrit-Change-Number: 40649 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 16:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accep...
by lynxis lazus 15 Jul '25

15 Jul '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40651?usp=email ) Change subject: BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accept is expected ...................................................................... Patch Set 6: (1 comment) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40651/comment/5ed59f8f_4ad1… : PS2, Line 760: boolean expect_service_acc := true, > Oh. Sorry, this was a rebase accident. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c190db28263c530a8eea188bf570a58eaffdd4d Gerrit-Change-Number: 40651 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 16:03:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accep...
by lynxis lazus 15 Jul '25

15 Jul '25

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40651?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accept is expected ...................................................................... BSSGP_ConnHdlr: f_service_request: allow to define if a Service Accept is expected A SecurityModeCommand is defined as an implicit Service Accept when the UE is in PMM_IDLE (meaning, having no Iu signalling connection) Change-Id: I5c190db28263c530a8eea188bf570a58eaffdd4d --- M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/SGSN_Tests_Iu.ttcn 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/40651/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c190db28263c530a8eea188bf570a58eaffdd4d Gerrit-Change-Number: 40651 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Iu: use correct service request type
by daniel 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email ) Change subject: SGSN: Iu: use correct service request type ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52 Gerrit-Change-Number: 40649 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 15:37:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: routing area: introduce ran_type on the RA
by lynxis lazus 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: routing area: introduce ran_type on the RA ...................................................................... routing area: introduce ran_type on the RA A Routing Area should be unique identified by the RAI. Following this, it is forbidden to have a RAI which is valid in both, GERAN and UTRAN. Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c --- M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_routing_area.c M tests/gprs_routing_area/gprs_routing_area_test.c 3 files changed, 74 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/88/40688/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c Gerrit-Change-Number: 40688 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Iu: use correct service request type
by pespin 15 Jul '25

15 Jul '25

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email ) Change subject: SGSN: Iu: use correct service request type ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52 Gerrit-Change-Number: 40649 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 15:29:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Iu: use correct service request type
by lynxis lazus 15 Jul '25

15 Jul '25

Attention is currently required from: daniel, lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: SGSN: Iu: use correct service request type ...................................................................... SGSN: Iu: use correct service request type When the UE wants to transfer data, the Service Request must have the type data. Remove the default of f_service_request() to force explicit defining it. Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52 --- M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/SGSN_Tests_Iu.ttcn 2 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/40649/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52 Gerrit-Change-Number: 40649 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log