Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40700?usp=email )
Change subject: rebar.lock: use more recent exometer_core
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40700?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic0fad544d1763ac84a69d1ee7df498d80c1c5f3e
Gerrit-Change-Number: 40700
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jul 2025 11:49:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, osmith.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40684?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: xua: Introduce internal APIs to transmit DAUD
......................................................................
xua: Introduce internal APIs to transmit DAUD
Change-Id: Iab6126f1a9eac1a66bb8ec362b87e20a5eb795ff
---
M src/m3ua.c
M src/sua.c
M src/xua_internal.h
M src/xua_snm.c
4 files changed, 55 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/84/40684/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40684?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Iab6126f1a9eac1a66bb8ec362b87e20a5eb795ff
Gerrit-Change-Number: 40684
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40501?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: asp: Support Tx DAUD when ASP becomes activated
......................................................................
asp: Support Tx DAUD when ASP becomes activated
Otherwise the local Signalling Point has no way to know whether the
remote Signalling Points it wants to talk to are actually already
connected to the STP when it becomes active after the process starts
up, unless it attempts to transmit a message to it.
This pocedure is documented both for M3UA and SUA:
* RFC4666 4.6, RFC3868 4.6
* RFC4666 4.5.3, RFC3868 4.5.3 "ASP Auditing"
* RFC4666 5.5.1.1.3 "Support for ASP Querying of SS7 Destination States"
The M3UA specs (RFC4666 5.5.1.1.3) explicitly state that the point codes to audit are not
to be provided by uppers layers, so picking the ones from the locally
configured address book for now:
"""
Note: there is no primitive for the
MTP3-User to request this audit from the M3UA layer, as this is
initiated by an internal M3UA management function.
"""
This is not enabled by default since it's optional according to specs,
and some SGs may actually return errors (it's possible according to
RFC4666 to deny access to auditing by the SG).
Related: OS#5917
Related: SYS#7501
Change-Id: I7c8c5099d4d00ea6f4a8db59ed6b833fb0ffa43d
---
M src/ss7_asp.h
M src/ss7_asp_vty.c
M src/xua_asp_fsm.c
M tests/vty/osmo_stp_test.vty
4 files changed, 120 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/01/40501/7
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40501?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I7c8c5099d4d00ea6f4a8db59ed6b833fb0ffa43d
Gerrit-Change-Number: 40501
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: vty: Introduce cmd 'cs7 instance <0-15> asp NAME audit point-code POINT_CODE'
......................................................................
vty: Introduce cmd 'cs7 instance <0-15> asp NAME audit point-code POINT_CODE'
This command is useful to debug state of a given route on a remote SG.
It can also be used to manually update the state of the local stack when DAUD
response (DAVA/DUNA) arrives, in case we were not properly notified of some
change by the peer or due to some internal bug.
Change-Id: I607df3d84562e56d329bea1a730e26c8cdaae591
---
M src/ss7_asp_vty.c
M tests/vty/osmo_stp_test.vty
2 files changed, 59 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/85/40685/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I607df3d84562e56d329bea1a730e26c8cdaae591
Gerrit-Change-Number: 40685
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>