- gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: Add [no ]force-cell-sel-ind-after-rel
by fixeria 19 Jul '25

19 Jul '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40723?usp=email ) Change subject: Add [no ]force-cell-sel-ind-after-rel ...................................................................... Add [no ]force-cell-sel-ind-after-rel Change-Id: Ie5fa3e036e0a0dd4049a4230d6cd4cb7c158088e Related: SYS#7482 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/gsm_04_08_rr.c 3 files changed, 33 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/23/40723/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 59d22d7..1d82d5c 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -1086,6 +1086,9 @@ char *pcu_sock_path; unsigned int pcu_sock_wqueue_len_max; struct pcu_sock_state *pcu_state; + + /* Always include the "cell selection indicator after release of all TCHs and SDCCH" IE */ + bool force_cell_sel_ind_after_rel; }; struct gsm_audio_support { diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index e9dabf9..96c6c43 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -436,6 +436,9 @@ vty_out(vty, " pcu-socket-wqueue-length %u%s", gsmnet->pcu_sock_wqueue_len_max, VTY_NEWLINE); + if (gsmnet->force_cell_sel_ind_after_rel) + vty_out(vty, " force-cell-sel-ind-after-rel%s", VTY_NEWLINE); + neighbor_ident_vty_write_network(vty, " "); mgcp_client_pool_config_write(vty, " "); @@ -2554,6 +2557,30 @@ return CMD_SUCCESS; } +DEFUN_ATTR(cfg_net_force_cell_sel_ind_after_rel, + cfg_net_force_cell_sel_ind_after_rel_cmd, + "force-cell-sel-ind-after-rel", + "Always include the \"cell selection indicator after release of all TCHs and SDCCH\" IE\n", + CMD_ATTR_IMMEDIATE) +{ + struct gsm_network *net = gsmnet_from_vty(vty); + + net->force_cell_sel_ind_after_rel = true; + return CMD_SUCCESS; +} + +DEFUN_ATTR(cfg_net_no_force_cell_sel_ind_after_rel, + cfg_net_no_force_cell_sel_ind_after_rel_cmd, + "no force-cell-sel-ind-after-rel", + NO_STR "Do not force the \"cell selection indicator after release of all TCHs and SDCCH\" IE\n", + CMD_ATTR_IMMEDIATE) +{ + struct gsm_network *net = gsmnet_from_vty(vty); + + net->force_cell_sel_ind_after_rel = false; + return CMD_SUCCESS; +} + static struct bsc_msc_data *bsc_msc_data(struct vty *vty) { return vty->index; @@ -3644,6 +3671,8 @@ install_element(GSMNET_NODE, &cfg_net_pcu_sock_path_cmd); install_element(GSMNET_NODE, &cfg_bts_pcu_sock_wqueue_len_cmd); install_element(GSMNET_NODE, &cfg_net_no_pcu_sock_cmd); + install_element(GSMNET_NODE, &cfg_net_force_cell_sel_ind_after_rel_cmd); + install_element(GSMNET_NODE, &cfg_net_no_force_cell_sel_ind_after_rel_cmd); /* Timer configuration commands (generic osmo_tdef API) */ osmo_tdef_vty_groups_init(GSMNET_NODE, bsc_tdef_group); diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c index 1944321..ed9877e 100644 --- a/src/osmo-bsc/gsm_04_08_rr.c +++ b/src/osmo-bsc/gsm_04_08_rr.c @@ -325,7 +325,7 @@ cause = msgb_put(msg, 1); cause[0] = lchan->release.rr_cause; - if (lchan->release.last_eutran_plmn_valid) { + if (lchan->release.last_eutran_plmn_valid || bsc_gsmnet->force_cell_sel_ind_after_rel) { uint8_t buf[CELL_SEL_IND_AFTER_REL_MAX_BYTES]; int len; /* FIXME: so far we assume all configured neigbhors match last_eutran_plmn */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40723?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie5fa3e036e0a0dd4049a4230d6cd4cb7c158088e Gerrit-Change-Number: 40723 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv/requirements: simplify rsync checks
by fixeria 19 Jul '25

19 Jul '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40720?usp=email ) Change subject: testenv/requirements: simplify rsync checks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fd885aa6c9b6801e18043f783bae357da716d19 Gerrit-Change-Number: 40720 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Jul 2025 19:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: run requirements check before cfg init
by fixeria 19 Jul '25

19 Jul '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40719?usp=email ) Change subject: testenv: run requirements check before cfg init ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I09ed7af5b236aeffd910d7c0a1a0b63a78631ade Gerrit-Change-Number: 40719 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Jul 2025 19:26:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv/requirements: update link
by fixeria 19 Jul '25

19 Jul '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40718?usp=email ) Change subject: testenv/requirements: update link ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie8a6df2f8fd08983532c8a757ae1849792fbd5b3 Gerrit-Change-Number: 40718 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Jul 2025 19:24:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: timers: fix them
by laforge 19 Jul '25

19 Jul '25

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722?usp=email ) Change subject: timers: fix them ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File sysmoOCTSIM/main.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722/comment/b5a7b94d_dc… : PS2, Line 546: SysTick->CTRL &= ~SysTick_CTRL_ENABLE_Msk; // no clock ticks for osmo timers is the comment now still valid? it seems a bit contradictory to me now, eanbling systick timer but stating the osmocom timers use no clock ticks? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0a9ba7a9097fe09614beceeae7541bd7b82b9087 Gerrit-Change-Number: 40722 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Jul 2025 07:31:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: 7816 fsm: drop inverse convention lut for arm
by laforge 19 Jul '25

19 Jul '25

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email ) Change subject: 7816 fsm: drop inverse convention lut for arm ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I'm surprised that it's worth optimizing this at that level, but fine with me ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1c6f1c4b733074201cb02c0b9e7cf80a9f8dca7c Gerrit-Change-Number: 40721 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Jul 2025 07:30:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: 7816 fsm: ensure errors always return a msgb
by laforge 19 Jul '25

19 Jul '25

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email ) Change subject: 7816 fsm: ensure errors always return a msgb ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: If32484675a0a10f1504477f5eea00c879ec78f1e Gerrit-Change-Number: 40703 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Jul 2025 07:29:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: 7816 fsm: ensure errors always return a msgb
by Hoernchen 18 Jul '25

18 Jul '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email to look at the new patch set (#2). Change subject: 7816 fsm: ensure errors always return a msgb ...................................................................... 7816 fsm: ensure errors always return a msgb This should always be safe to do, since I introduced statically allocated (but useless in this case) msgbs for the fsm years ago, and this was just leftover code from before that. The only exception is the internal ISO7816_E_TPDU_CLEAR_REQ. Change-Id: If32484675a0a10f1504477f5eea00c879ec78f1e --- M ccid_common/iso7816_fsm.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/03/40703/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: If32484675a0a10f1504477f5eea00c879ec78f1e Gerrit-Change-Number: 40703 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: 7816 fsm: ensure errors always return a msgb
by Hoernchen 18 Jul '25

18 Jul '25

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email ) Change subject: 7816 fsm: ensure errors always return a msgb ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: If32484675a0a10f1504477f5eea00c879ec78f1e Gerrit-Change-Number: 40703 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Jul 2025 19:03:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ccid-firmware[master]: 7816 fsm: drop inverse convention lut for arm
by Hoernchen 18 Jul '25

18 Jul '25

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: 7816 fsm: drop inverse convention lut for arm ...................................................................... 7816 fsm: drop inverse convention lut for arm 3 instructions is more reliable than precious bytes and awfully slow memory. Change-Id: I1c6f1c4b733074201cb02c0b9e7cf80a9f8dca7c --- M ccid_common/iso7816_fsm.c 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/21/40721/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1c6f1c4b733074201cb02c0b9e7cf80a9f8dca7c Gerrit-Change-Number: 40721 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log