- gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: routing area: add LOGRA() logging macro
by lynxis lazus 01 Aug '25

01 Aug '25

Attention is currently required from: fixeria, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40692?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: routing area: add LOGRA() logging macro ...................................................................... routing area: add LOGRA() logging macro Prepend the routing area in the log message. Change-Id: Ib287b70c34b21ce64bc864f69fcf6af5fa0698b9 --- M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_routing_area.c 2 files changed, 25 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/92/40692/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib287b70c34b21ce64bc864f69fcf6af5fa0698b9 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: routing area: sgsn_ra_geran_page_ra: make argument rai const
by lynxis lazus 01 Aug '25

01 Aug '25

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40693?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: routing area: sgsn_ra_geran_page_ra: make argument rai const ...................................................................... routing area: sgsn_ra_geran_page_ra: make argument rai const The second argument mmctx can't made const because of the paging info, which uses non-const fields. Change-Id: I21d7e66e433f2b891c94bae91697aa46198fb20c --- M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_routing_area.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/93/40693/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I21d7e66e433f2b891c94bae91697aa46198fb20c Gerrit-Change-Number: 40693 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in ...logger_gsmtap[master]: logger_gsmtap.app.src: add vim modeline and syntax hint
by fixeria 01 Aug '25

01 Aug '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40801?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: logger_gsmtap.app.src: add vim modeline and syntax hint ...................................................................... logger_gsmtap.app.src: add vim modeline and syntax hint Change-Id: Id8cd8e1ab19ed2209ff1d867a7026b7663920013 --- M src/logger_gsmtap.app.src 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/logger_gsmtap.app.src b/src/logger_gsmtap.app.src index 0307fb0..8eb1a26 100644 --- a/src/logger_gsmtap.app.src +++ b/src/logger_gsmtap.app.src @@ -1,3 +1,5 @@ +%% -*- erlang -*- + {application, logger_gsmtap, [ {description, "GSMTAP handler for Erlang's Logger module"}, {vsn, semver}, @@ -9,3 +11,5 @@ {licenses, ["Mozilla Public License 2.0"]}, {links, [{"Gitea", "https://gitea.osmocom.org/erlang/logger_gsmtap"}]} ]}. + +%% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40801?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: Id8cd8e1ab19ed2209ff1d867a7026b7663920013 Gerrit-Change-Number: 40801 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in ...logger_gsmtap[master]: Fix warning: behaviour logger_handler undefined
by fixeria 01 Aug '25

01 Aug '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email ) Change subject: Fix warning: behaviour logger_handler undefined ...................................................................... Fix warning: behaviour logger_handler undefined Erlang/OTP versions below 27.0.0 have no 'logger_handler' behaviour, so let's declare it conditionally using the ?OTP_RELEASE macro. Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 --- M src/logger_gsmtap_h.erl 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/logger_gsmtap_h.erl b/src/logger_gsmtap_h.erl index c3cba56..99da8d6 100644 --- a/src/logger_gsmtap_h.erl +++ b/src/logger_gsmtap_h.erl @@ -15,7 +15,10 @@ GSMTAP logging handler. """. +%% Erlang/OTP versions below 27.0.0 have no 'logger_handler' behaviour +-if(?OTP_RELEASE >= 27). -behaviour(logger_handler). +-endif. %% logger_handler callbacks -export([adding_handler/1, -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 Gerrit-Change-Number: 40808 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in ...logger_gsmtap[master]: Fix warning: behaviour logger_handler undefined
by osmith 01 Aug '25

01 Aug '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email ) Change subject: Fix warning: behaviour logger_handler undefined ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 Gerrit-Change-Number: 40808 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 12:48:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...logger_gsmtap[master]: TEST
by fixeria 01 Aug '25

01 Aug '25

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40807?usp=email ) Change subject: TEST ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I172c97e1998ca491a468c5f4b8c643b73592092c Gerrit-Change-Number: 40807 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in ...logger_gsmtap[master]: Fix warning: behaviour logger_handler undefined
by fixeria 01 Aug '25

01 Aug '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email ) Change subject: Fix warning: behaviour logger_handler undefined ...................................................................... Fix warning: behaviour logger_handler undefined Erlang/OTP versions below 27.0.0 have no 'logger_handler' behaviour, so let's declare it conditionally using the ?OTP_RELEASE macro. Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 --- M src/logger_gsmtap_h.erl 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/logger_gsmtap refs/changes/08/40808/1 diff --git a/src/logger_gsmtap_h.erl b/src/logger_gsmtap_h.erl index c3cba56..99da8d6 100644 --- a/src/logger_gsmtap_h.erl +++ b/src/logger_gsmtap_h.erl @@ -15,7 +15,10 @@ GSMTAP logging handler. """. +%% Erlang/OTP versions below 27.0.0 have no 'logger_handler' behaviour +-if(?OTP_RELEASE >= 27). -behaviour(logger_handler). +-endif. %% logger_handler callbacks -export([adding_handler/1, -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 Gerrit-Change-Number: 40808 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: routing area: on alloc, check if RA already exists
by lynxis lazus 01 Aug '25

01 Aug '25

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email ) Change subject: routing area: on alloc, check if RA already exists ...................................................................... Patch Set 2: (1 comment) File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40691/comment/f6a780bb_3a729493?us… : PS2, Line 88: LOGL_ERROR > Please, leave this alloc function lone and use a find_or_create() API instead which uses this alloc […] It should only happen in rare cases, when the PCU + hnodeb/RNC is misconfigured. Ack at pespin. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6955a09d9d8f3ba4dc3a14d7ed5cd9798d929c61 Gerrit-Change-Number: 40691 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 12:45:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: routing area: introduce ran_type on the RA
by lynxis lazus 01 Aug '25

01 Aug '25

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email ) Change subject: routing area: introduce ran_type on the RA ...................................................................... Patch Set 2: (7 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/c7d40e7a_520e232c?us… : PS2, Line 9: unique > uniquely Done File include/osmocom/sgsn/gprs_routing_area.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/7502a69a_eee4c86d?us… : PS2, Line 34: * and for routing, the SGSN must know to which PCU a given cell is connected. > "... and, for routing, the SGSN". […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/aee3fb1d_509a88bd?us… : PS2, Line 35: 2x PCU serves > Agree with fixeria, writing like does clarifies it. Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/e7dd3a47_c2ecd07c?us… : PS2, Line 38: individual > individually Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/2f5237c0_f8cfa01c?us… : PS2, Line 39: has > have Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/6145ce6d_a2b53cfe?us… : PS2, Line 47: which are alive > yeah, known_cells, active_cells, served_cells, whatever. […] Done File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/2da1ab82_62cd4071?us… : PS2, Line 201: valid for GERAN > I agree, but this commit can't fix all that at the same time. Most of the previous api is related to geran. But will it do in a following commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c Gerrit-Change-Number: 40688 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 12:42:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...logger_gsmtap[master]: TEST
by fixeria 01 Aug '25

01 Aug '25

fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40807?usp=email ) Change subject: TEST ...................................................................... TEST Change-Id: I172c97e1998ca491a468c5f4b8c643b73592092c --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/logger_gsmtap refs/changes/07/40807/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I172c97e1998ca491a468c5f4b8c643b73592092c Gerrit-Change-Number: 40807 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log