- gerrit-log - lists.osmocom.org

[XS] Change in osmo-msc[master]: transaction: Fix potenial use after free of members
by fixeria 11 Aug '25

11 Aug '25

Attention is currently required from: laforge, matanp. fixeria has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email ) Change subject: transaction: Fix potenial use after free of members ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/40853/comment/e001f1d0_58e6747b?usp… : PS2, Line 9: In the case of multithreading We do not employ multithreading in osmo-msc and unlikely ever will, so I don't think it makes sense to merge this patch, sorry. No need to complicate the code due to circumstances that are not the case. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I177959fb298ae04c4e8df877582fc9a1bd4dc2cf Gerrit-Change-Number: 40853 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Aug 2025 22:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: silent_call: Fix use after free of paging request
by fixeria 11 Aug '25

11 Aug '25

Attention is currently required from: matanp. fixeria has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-msc/+/40852?usp=email ) Change subject: silent_call: Fix use after free of paging request ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/40852/comment/ea25b850_934c07c7?usp… : PS2, Line 10: In some cases My curiosity was piqued, so I've implemented a reproducer testcase: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863 Current osmo-msc segfaults when running it. This patch fixes the problem. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I93913d189800d71f82c013b6e946bd63db362f65 Gerrit-Change-Number: 40852 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Aug 2025 22:19:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Makefile: add 'clean-logs' target
by fixeria 11 Aug '25

11 Aug '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40862?usp=email ) Change subject: Makefile: add 'clean-logs' target ...................................................................... Makefile: add 'clean-logs' target When running tests manually I oftentimes end up with hundreds of *.log files in testsuite directories. The present patch adds a convenience target for removing them. Change-Id: Id0597f9eeea9e128ce38a2b19f2126c729e71ffd --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/40862/1 diff --git a/Makefile b/Makefile index 7a9ddb8..75e79ff 100644 --- a/Makefile +++ b/Makefile @@ -151,3 +151,6 @@ # trivial to clean up the builddir manually. clean: rm -rf _build + +clean-logs: + find $(SUBDIRS) -name "*.log" -print -delete -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id0597f9eeea9e128ce38a2b19f2126c729e71ffd Gerrit-Change-Number: 40862 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_silent_call_start_stop
by fixeria 11 Aug '25

11 Aug '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email ) Change subject: msc: add TC_silent_call_start_stop ...................................................................... msc: add TC_silent_call_start_stop This testcase triggers a use-after-free in osmo-msc. Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Related: osmo-msc.git I93913d189800d71f82c013b6e946bd63db362f65 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/40863/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 4a7acdc..46fdd4d 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -7710,6 +7710,52 @@ setverdict(pass); } +/* Bug reproducer for https://gerrit.osmocom.org/c/osmo-msc/+/40852. + * Start and stop a silent call while there's an active connection. */ +private function f_TC_silent_call_start_stop(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var charstring cmd, resp; + + f_init_handler(pars); + + cmd := "subscriber imsi " & hex2str(g_pars.imsi) & " silent-call "; + + f_perform_lu(); + f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); + + /* The MS establishes a connection (e.g. for periodic Location Updating) */ + f_establish_fully(); + + /* Meanwhile, a silent call is being initiated from the VTY */ + MSCVTY.send(cmd & "start any signalling"); + resp := f_vty_wait_for_prompt(MSCVTY); + if (resp != "% Silent call initiated") { + setverdict(fail, "VTY: Unexpected response: ", resp); + } + + /* XXX: The MSC pages the MS, even though there is an active connection?!? */ + f_expect_paging(); + + /* A silent call is being stopped from the VTY */ + MSCVTY.send(cmd & "stop"); + resp := f_vty_wait_for_prompt(MSCVTY); + if (resp != "% Silent call ended\n% Silent call stopped") { + setverdict(fail, "VTY: Unexpected response: ", resp); + } + + f_sleep(10.0); /* timer X4 is 10s */ + + /* ... osmo-msc crashes after paging timeout ... */ + + f_expect_clear(); +} +testcase TC_silent_call_start_stop() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + + vc_conn := f_start_handler(refers(f_TC_silent_call_start_stop), 30); + vc_conn.done; +} + control { execute( TC_cr_before_reset() ); execute( TC_lu_imsi_noauth_tmsi() ); @@ -7910,6 +7956,10 @@ if (Misc_Helpers.f_osmo_repo_is("nightly")) { execute( TC_stat_bsc_sctp_disconnected() ); } + + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_silent_call_start_stop() ); + } } diff --git a/msc/expected-results.xml b/msc/expected-results.xml index 7a5066d..7070662 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -177,6 +177,7 @@ <testcase classname='MSC_Tests' name='TC_lu_and_mt_csd' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_and_mo_call_reass_for_mt_codec' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_stat_bsc_sctp_disconnected' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_silent_call_start_stop' time='MASKED'/>  <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_imsi_reject' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_imsi_timeout_gsup' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Gerrit-Change-Number: 40863 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/gerrit: binpkgs: update debian versions
by fixeria 11 Aug '25

11 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40861?usp=email ) Change subject: jobs/gerrit: binpkgs: update debian versions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/40861/comment/d35a8783_2a3833a4?usp=… : PS1, Line 107: debian:11 debian:13 AFAIU, so far we have been building packages for `debian:10` and `debian:12`, but not for `debian:11`. Now we will be building for `debian:11` and `debian:13`, but not for `debian:12` anymore. Is this intentional? If so, what's the idea behind this? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifc1d603c9e6e5054ad2f121f53ba3fb7e4d05286 Gerrit-Change-Number: 40861 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Aug 2025 18:25:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/gerrit: remove binpkgs that are the default
by fixeria 11 Aug '25

11 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40860?usp=email ) Change subject: jobs/gerrit: remove binpkgs that are the default ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I348a83c8d70c2042bcab9ccaf83be2a638e722e7 Gerrit-Change-Number: 40860 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Aug 2025 18:18:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: OBS: support building debian trixie (13) pkgs
by fixeria 11 Aug '25

11 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40859?usp=email ) Change subject: OBS: support building debian trixie (13) pkgs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1377af7f74f074ed6e28e07dee82360d024edd05 Gerrit-Change-Number: 40859 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Aug 2025 18:17:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/gerrit: remove binpkgs that are the default
by osmith 11 Aug '25

11 Aug '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40860?usp=email ) Change subject: jobs/gerrit: remove binpkgs that are the default ...................................................................... jobs/gerrit: remove binpkgs that are the default Remove the pipeline_binpkgs lines that are the same as the default. This is in preparation for changing the default. Change-Id: I348a83c8d70c2042bcab9ccaf83be2a638e722e7 --- M jobs/gerrit-verifications.yml 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/60/40860/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 3d70e47..1a722d7 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -135,8 +135,7 @@ pipeline_binpkgs: "" pipeline_lint: false - - cellmgr-ng: - pipeline_binpkgs: "debian:10 debian:12" + - cellmgr-ng - docker-playground: pipeline_build: false @@ -283,8 +282,7 @@ -e WITH_MANUALS="$WITH_MANUALS" \ {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - - osmo-gsm-manuals: - pipeline_binpkgs: "debian:10 debian:12" + - osmo-gsm-manuals - osmo_gsup: repos_url: '{gerrit_url}/erlang/{repos}' @@ -349,7 +347,6 @@ - osmo-python-tests: repos_url: '{gerrit_url}/python/{repos}' gerrit_project: 'python/{repos}' - pipeline_binpkgs: "debian:10 debian:12" - pyosmocom: repos_url: '{gerrit_url}/python/{repos}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I348a83c8d70c2042bcab9ccaf83be2a638e722e7 Gerrit-Change-Number: 40860 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: OBS: support building debian trixie (13) pkgs
by osmith 11 Aug '25

11 Aug '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40859?usp=email ) Change subject: OBS: support building debian trixie (13) pkgs ...................................................................... OBS: support building debian trixie (13) pkgs Translate "debian:13" to "debian:trixie", as for some reason no docker tag is getting pushed for "debian:13". With this we can keep using the usual short naming scheme in pipeline_binpkgs lines in gerrit-verifications.yml (see next patch). Change-Id: I1377af7f74f074ed6e28e07dee82360d024edd05 --- M scripts/obs/lib/docker.py 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/59/40859/1 diff --git a/scripts/obs/lib/docker.py b/scripts/obs/lib/docker.py index a68c7f9..68ed28d 100644 --- a/scripts/obs/lib/docker.py +++ b/scripts/obs/lib/docker.py @@ -19,8 +19,16 @@ if image_type.endswith("_manuals"): return get_image_name(distro, image_type.replace("_manuals", "")) - if distro == "debian:10": - distro = "debian/eol:buster" + # Ensure we can use short names like "debian:13" instead of "debian:trixie" + # even though upstream apparently doesn't push the number-tags anymore: + # https://hub.docker.com/_/debian + match distro: + case "debian:10": + distro = "debian/eol:buster" + # debian:11 points to debian:bullseye upstream + # debian:12 points to debian:bookworm upstream + case "debian:13": + distro = "debian:trixie" return distro -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1377af7f74f074ed6e28e07dee82360d024edd05 Gerrit-Change-Number: 40859 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/gerrit: binpkgs: update debian versions
by osmith 11 Aug '25

11 Aug '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40861?usp=email ) Change subject: jobs/gerrit: binpkgs: update debian versions ...................................................................... jobs/gerrit: binpkgs: update debian versions Change the default from "debian:10 debian:12" to "debian:11 debian:13", as Debian 13 has just been released and we are about to remove Debian 10 binary packages. Related: https://osmocom.org/news/310 Related: https://osmocom.org/news/308 Related: OS#6826 Change-Id: Ifc1d603c9e6e5054ad2f121f53ba3fb7e4d05286 --- M jobs/gerrit-verifications.yml 1 file changed, 11 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/61/40861/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 1a722d7..48ba632 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -104,7 +104,7 @@ # Which jobs to run in the pipeline pipeline_build: true pipeline_lint: true - pipeline_binpkgs: "debian:10 debian:12" + pipeline_binpkgs: "debian:11 debian:13" # in alphabetical order repos: @@ -147,7 +147,7 @@ - libosmo-gprs - libosmo-netif: - pipeline_binpkgs: "centos:7 debian:10 debian:12" # centos7: SYS#6760 (osmo-pcap dep) + pipeline_binpkgs: "centos:7 debian:11 debian:13" # centos7: SYS#6760 (osmo-pcap dep) - libosmo-pfcp - libosmo-sigtran @@ -158,7 +158,7 @@ a1: !!python/tuple [arm-none-eabi, amd64] combination_filter: '!(arch=="arm-none-eabi" && label=="FreeBSD_amd64")' cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} /build/contrib/jenkins_arch.sh "$arch"' - pipeline_binpkgs: "centos:7 debian:10 debian:12" # centos7: SYS#6760 + pipeline_binpkgs: "centos:7 debian:11 debian:13" # centos7: SYS#6760 - libsmpp34 @@ -214,12 +214,11 @@ repos_url: '{gerrit_url}/erlang/{repos}' gerrit_project: 'erlang/{repos}' cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' - pipeline_binpkgs: "debian:11 debian:12" - osmo-epdg: repos_url: '{gerrit_url}/erlang/{repos}' gerrit_project: 'erlang/{repos}' - pipeline_binpkgs: "debian:12" + pipeline_binpkgs: "debian:12 debian:13" a2_name: JOB_TYPE a2: !!python/tuple ["build", "manuals"] cmd: | @@ -235,7 +234,7 @@ - osmo-s1gw: repos_url: '{gerrit_url}/erlang/{repos}' gerrit_project: 'erlang/{repos}' - pipeline_binpkgs: "debian:12" + pipeline_binpkgs: "debian:12 debian:13" cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' - logger_gsmtap: @@ -309,7 +308,7 @@ {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - osmo-pcap: - pipeline_binpkgs: "centos:7 debian:10 debian:12" # centos7: SYS#6760 + pipeline_binpkgs: "centos:7 debian:11 debian:13" # centos7: SYS#6760 - osmo-pcu: slave_axis: !!python/tuple [osmocom-gerrit, raspbian] @@ -351,7 +350,7 @@ - pyosmocom: repos_url: '{gerrit_url}/python/{repos}' gerrit_project: 'python/{repos}' - pipeline_binpkgs: "debian:12" + pipeline_binpkgs: "debian:12 debian:13" concurrent: false slave_axis: !!python/tuple [simtester,osmocom-gerrit] a2_name: JOB_TYPE @@ -421,13 +420,12 @@ "$DOCKER_IMG" {timeout_cmd} $SETARCH_CMD /build/contrib/jenkins.sh - osmocom-bb: - pipeline_binpkgs: "debian:12" + pipeline_binpkgs: "debian:12 debian:13" - osmo-tetra: pipeline_binpkgs: "" - - osmo-sysmon: - pipeline_binpkgs: "debian:10 debian:12" + - osmo-sysmon - osmo-remsim @@ -457,7 +455,7 @@ pipeline_binpkgs: "" - gapk: - pipeline_binpkgs: "debian:12" + pipeline_binpkgs: "debian:12 debian:13" - osmo-uecups @@ -485,8 +483,7 @@ -e NFTABLES="$NFTABLES" \ {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - - osmo-upf: - pipeline_binpkgs: "debian:11 debian:12" + - osmo-upf - pysim: concurrent: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifc1d603c9e6e5054ad2f121f53ba3fb7e4d05286 Gerrit-Change-Number: 40861 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log