- gerrit-log - lists.osmocom.org

[XS] Change in osmo-msc[master]: silent_call: check if subscriber has a connection
by fixeria 13 Aug '25

13 Aug '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email ) Change subject: silent_call: check if subscriber has a connection ...................................................................... silent_call: check if subscriber has a connection It makes no sense to initiate a silent call if subscriber already has an active connection (e.g. when a normal call is ongoing). Change-Id: I52b3be26c61cadacc4783b5c324809ecd6906b36 --- M src/libmsc/msc_vty.c M src/libmsc/silent_call.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/77/40877/1 diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 41cb0d4..07791f1 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -1596,6 +1596,9 @@ case -ENODEV: vty_out(vty, "%% Subscriber not attached%s", VTY_NEWLINE); break; + case -EBUSY: + vty_out(vty, "%% Subscriber has an active connection%s", VTY_NEWLINE); + break; default: if (rc) vty_out(vty, "%% Cannot start silent call (rc=%d)%s", rc, VTY_NEWLINE); diff --git a/src/libmsc/silent_call.c b/src/libmsc/silent_call.c index 9c0d2b6..327ed7f 100644 --- a/src/libmsc/silent_call.c +++ b/src/libmsc/silent_call.c @@ -142,6 +142,9 @@ struct gsm_network *net = vsub->vlr->user_ctx; struct gsm_trans *trans; + if (msc_a_for_vsub(vsub, true) != NULL) + return -EBUSY; + trans = trans_alloc(net, vsub, TRANS_SILENT_CALL, 0, 0); if (trans == NULL) return -ENODEV; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I52b3be26c61cadacc4783b5c324809ecd6906b36 Gerrit-Change-Number: 40877 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in osmo-iuh[master]: Drop iu_client - adopted by osmo-sgsn
by lynxis lazus 13 Aug '25

13 Aug '25

Attention is currently required from: daniel, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review-1 by laforge, Verified+1 by Jenkins Builder Change subject: Drop iu_client - adopted by osmo-sgsn ...................................................................... Drop iu_client - adopted by osmo-sgsn The only remaining use of iu_client is osmo-sgsn. iu_client was originally meant to be used by osmo-msc and osmo-sgsn. But the abstraction didn't hold up and osmo-msc stopped using iu_client for a long time. Move iu_client to osmo-sgsn until it got replaced by a more direct implementation (similar to IUCS in osmo-msc). Related: OS#5487 Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/Makefile.am D src/iu_client.c 4 files changed, 4 insertions(+), 1,372 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/40847/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de Gerrit-Change-Number: 40847 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in osmo-iuh[master]: iu_client: fix linter issues
by lynxis lazus 13 Aug '25

13 Aug '25

Attention is currently required from: daniel. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40848?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: iu_client: fix linter issues ...................................................................... iu_client: fix linter issues Before removing the iu_client. Fix linter issues to make jenkins more happy. Related: OS#5487 Change-Id: Ia8b3405701ed62eac39b9510d34da4ba1987146c --- M include/osmocom/ranap/iu_client.h M src/iu_client.c 2 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/48/40848/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ia8b3405701ed62eac39b9510d34da4ba1987146c Gerrit-Change-Number: 40848 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in osmo-iuh[master]: move talloc_asn1_ctx into iu_helpers
by lynxis lazus 13 Aug '25

13 Aug '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email ) Change subject: move talloc_asn1_ctx into iu_helpers ...................................................................... move talloc_asn1_ctx into iu_helpers In preparation to remove iu_client. Related: OS#5487 Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c --- M src/iu_client.c M src/iu_helpers.c 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/iu_client.c b/src/iu_client.c index e1b7af3..e31c898 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -80,7 +80,6 @@ }; void *talloc_iu_ctx; -void *talloc_asn1_ctx; /* Implement the extern asn_debug from libasn1c to indicate whether to print * asn.1 debug messages (see libasn1c). */ diff --git a/src/iu_helpers.c b/src/iu_helpers.c index 5c7ff31..27e6a25 100644 --- a/src/iu_helpers.c +++ b/src/iu_helpers.c @@ -31,6 +31,8 @@ #include <osmocom/ranap/RANAP_TransportLayerAddress.h> #include <osmocom/ranap/RANAP_TransportLayerInformation.h> +void *talloc_asn1_ctx; + /* decode a BCD-string as used inside ASN.1 encoded Iu interface protocols */ int ranap_bcd_decode(char *out, size_t out_len, const uint8_t *in, size_t in_len) { -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c Gerrit-Change-Number: 40843 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-iuh[master]: move enum ranap_nsap_addr_enc into ranap_common.h
by lynxis lazus 13 Aug '25

13 Aug '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40845?usp=email ) Change subject: move enum ranap_nsap_addr_enc into ranap_common.h ...................................................................... move enum ranap_nsap_addr_enc into ranap_common.h The enum defines how an IP address in a RAB assignment is encoded. This is part of RANAP. Related: OS#5487 Change-Id: Ie281bcf6b03d4cc431902cb0f6b0d5f722c80c74 --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M include/osmocom/ranap/ranap_common.h M src/iu_client_vty.c 4 files changed, 8 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index 2879aed..cd6ad86 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -12,3 +12,4 @@ libosmo-ranap add API iu_client.h: add ranap_iu_page_cs2/ranap_iu_page_ps2 libosmo-ranap new event RANAP_IU_EVENT_NEW_AREA libosmo-ranap move declaration (backwards compatible): asn_debug, asn1_xer_print: use osmocom/iuh/common.h instead of iu_client.h +libosmo-ranap move definition (backwards compatible): enum ranap_nsap_addr_enc: use osmocom/ranap/ranap_common.h instead of iu_client.h diff --git a/include/osmocom/ranap/iu_client.h b/include/osmocom/ranap/iu_client.h index 4b5e58c..e5f7385 100644 --- a/include/osmocom/ranap/iu_client.h +++ b/include/osmocom/ranap/iu_client.h @@ -6,6 +6,7 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/gsm/gsm48.h> #include <osmocom/iuh/common.h> +#include <osmocom/ranap/ranap_common.h> #include <osmocom/sigtran/sccp_sap.h> struct msgb; @@ -16,11 +17,6 @@ struct ranap_iu_rnc; -enum ranap_nsap_addr_enc { - RANAP_NSAP_ADDR_ENC_X213, - RANAP_NSAP_ADDR_ENC_V4RAW, -}; - struct ranap_ue_conn_ctx { struct llist_head list; struct ranap_iu_rnc *rnc; diff --git a/include/osmocom/ranap/ranap_common.h b/include/osmocom/ranap/ranap_common.h index 0da7b10..ed478fa 100644 --- a/include/osmocom/ranap/ranap_common.h +++ b/include/osmocom/ranap/ranap_common.h @@ -596,6 +596,11 @@ extern int _ranap_DRANAP; #define RANAP_DEBUG(x, args ...) DEBUGP(_ranap_DRANAP, x, ## args) +enum ranap_nsap_addr_enc { + RANAP_NSAP_ADDR_ENC_X213, + RANAP_NSAP_ADDR_ENC_V4RAW, +}; + /* Callback to be used with decoder functions in ranap_common_cn.c ranap_common_ran.c */ typedef void (*ranap_handle_cb)(void *priv, ranap_message *ranap_msg); diff --git a/src/iu_client_vty.c b/src/iu_client_vty.c index 2c5a1e4..170791f 100644 --- a/src/iu_client_vty.c +++ b/src/iu_client_vty.c @@ -28,6 +28,7 @@ #include <osmocom/iuh/common.h> #include <osmocom/ranap/iu_client.h> +#include <osmocom/ranap/ranap_common.h> static enum ranap_nsap_addr_enc *g_rab_assign_addr_enc = NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ie281bcf6b03d4cc431902cb0f6b0d5f722c80c74 Gerrit-Change-Number: 40845 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-iuh[master]: move general asn debug options into iu_helpers
by lynxis lazus 13 Aug '25

13 Aug '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email ) Change subject: move general asn debug options into iu_helpers ...................................................................... move general asn debug options into iu_helpers In prepration to remove iu_client. Move debug variables asn_debug and asn1_xer_print which are not related to iu_client into common part. Related: OS#5487 Change-Id: If5175c449af13fe81e89488df71fcd8192091659 --- M TODO-RELEASE M include/osmocom/iuh/Makefile.am A include/osmocom/iuh/common.h M include/osmocom/ranap/iu_client.h M src/iu_client.c M src/iu_client_vty.c M src/iu_helpers.c 7 files changed, 23 insertions(+), 13 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index b583f7e..2879aed 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -11,3 +11,4 @@ libosmo-ranap deprecate API ranap_ran_rx_co_decode() libosmo-ranap add API iu_client.h: add ranap_iu_page_cs2/ranap_iu_page_ps2 libosmo-ranap new event RANAP_IU_EVENT_NEW_AREA +libosmo-ranap move declaration (backwards compatible): asn_debug, asn1_xer_print: use osmocom/iuh/common.h instead of iu_client.h diff --git a/include/osmocom/iuh/Makefile.am b/include/osmocom/iuh/Makefile.am index e5dff0d..944347c 100644 --- a/include/osmocom/iuh/Makefile.am +++ b/include/osmocom/iuh/Makefile.am @@ -1,2 +1,8 @@ +iuhdir = $(includedir)/osmocom/iuh + noinst_HEADERS = \ iu_common.h + +iuh_HEADERS = \ + common.h + diff --git a/include/osmocom/iuh/common.h b/include/osmocom/iuh/common.h new file mode 100644 index 0000000..78d120d --- /dev/null +++ b/include/osmocom/iuh/common.h @@ -0,0 +1,5 @@ +#pragma once + +/* Debugging switches from asn1c and osmo-iuh */ +extern int asn_debug; +extern int asn1_xer_print; diff --git a/include/osmocom/ranap/iu_client.h b/include/osmocom/ranap/iu_client.h index 465a17d..4b5e58c 100644 --- a/include/osmocom/ranap/iu_client.h +++ b/include/osmocom/ranap/iu_client.h @@ -5,6 +5,7 @@ #include <osmocom/core/defs.h> #include <osmocom/core/linuxlist.h> #include <osmocom/gsm/gsm48.h> +#include <osmocom/iuh/common.h> #include <osmocom/sigtran/sccp_sap.h> struct msgb; @@ -15,10 +16,6 @@ struct ranap_iu_rnc; -/* Debugging switches from asn1c and osmo-iuh */ -extern int asn_debug; -extern int asn1_xer_print; - enum ranap_nsap_addr_enc { RANAP_NSAP_ADDR_ENC_X213, RANAP_NSAP_ADDR_ENC_V4RAW, diff --git a/src/iu_client.c b/src/iu_client.c index e31c898..d2b00e9 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -81,15 +81,6 @@ void *talloc_iu_ctx; -/* Implement the extern asn_debug from libasn1c to indicate whether to print - * asn.1 debug messages (see libasn1c). */ -int asn_debug = 0; - -/* Implement the extern asn1_xer_print to indicate whether the ASN.1 binary - * code decoded and encoded during Iu communication should be logged to stderr - * (see asn.1 generated code in osmo-iuh). */ -int asn1_xer_print = 0; - ranap_iu_recv_cb_t global_iu_recv_cb = NULL; ranap_iu_event_cb_t global_iu_event_cb = NULL; int iu_log_subsystem = 0; diff --git a/src/iu_client_vty.c b/src/iu_client_vty.c index b111a5b..2c5a1e4 100644 --- a/src/iu_client_vty.c +++ b/src/iu_client_vty.c @@ -26,6 +26,7 @@ #include <osmocom/sigtran/osmo_ss7.h> #include <osmocom/sigtran/sccp_sap.h> +#include <osmocom/iuh/common.h> #include <osmocom/ranap/iu_client.h> static enum ranap_nsap_addr_enc *g_rab_assign_addr_enc = NULL; diff --git a/src/iu_helpers.c b/src/iu_helpers.c index 27e6a25..705af31 100644 --- a/src/iu_helpers.c +++ b/src/iu_helpers.c @@ -33,6 +33,15 @@ void *talloc_asn1_ctx; +/* Implement the extern asn_debug from libasn1c to indicate whether to print + * asn.1 debug messages (see libasn1c). */ +int asn_debug = 0; + +/* Implement the extern asn1_xer_print to indicate whether the ASN.1 binary + * code decoded and encoded during Iu communication should be logged to stderr + * (see asn.1 generated code in osmo-iuh). */ +int asn1_xer_print = 0; + /* decode a BCD-string as used inside ASN.1 encoded Iu interface protocols */ int ranap_bcd_decode(char *out, size_t out_len, const uint8_t *in, size_t in_len) { -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If5175c449af13fe81e89488df71fcd8192091659 Gerrit-Change-Number: 40844 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-iuh[master]: move vty functions into own vty.h
by lynxis lazus 13 Aug '25

13 Aug '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40846?usp=email ) Change subject: move vty functions into own vty.h ...................................................................... move vty functions into own vty.h In preparation to remove iu_client from osmo-iuh, move all non-iu_client stuff out of iu_client files. Related: OS#5487 Change-Id: I8d393d17aa5f004dc4aa4e916bee68f44339e138 --- M TODO-RELEASE M include/osmocom/ranap/Makefile.am M include/osmocom/ranap/iu_client.h A include/osmocom/ranap/vty.h M src/iu_client_vty.c 5 files changed, 13 insertions(+), 4 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index cd6ad86..f825ac1 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -13,3 +13,4 @@ libosmo-ranap new event RANAP_IU_EVENT_NEW_AREA libosmo-ranap move declaration (backwards compatible): asn_debug, asn1_xer_print: use osmocom/iuh/common.h instead of iu_client.h libosmo-ranap move definition (backwards compatible): enum ranap_nsap_addr_enc: use osmocom/ranap/ranap_common.h instead of iu_client.h +libosmo-ranap move declaration (backwards compatible): ranap_iu_vty_init, ranap_iu_vty_config_write: use osmocom/ranap/vty.h instead of iu_client.h diff --git a/include/osmocom/ranap/Makefile.am b/include/osmocom/ranap/Makefile.am index cef1cd3..fbd3c05 100644 --- a/include/osmocom/ranap/Makefile.am +++ b/include/osmocom/ranap/Makefile.am @@ -619,6 +619,7 @@ RANAP_VerticalSpeedDirection.h \ RANAP_VerticalVelocity.h \ RANAP_VoiceSupportMatchIndicator.h \ + vty.h \ version.h \ $(NULL) diff --git a/include/osmocom/ranap/iu_client.h b/include/osmocom/ranap/iu_client.h index e5f7385..b0ff448 100644 --- a/include/osmocom/ranap/iu_client.h +++ b/include/osmocom/ranap/iu_client.h @@ -7,6 +7,7 @@ #include <osmocom/gsm/gsm48.h> #include <osmocom/iuh/common.h> #include <osmocom/ranap/ranap_common.h> +#include <osmocom/ranap/vty.h> #include <osmocom/sigtran/sccp_sap.h> struct msgb; @@ -100,6 +101,3 @@ /* freeing the UE will release all resources * This will close the SCCP connection connected to the UE */ void ranap_iu_free_ue(struct ranap_ue_conn_ctx *ue_ctx); - -void ranap_iu_vty_init(int iu_parent_node, enum ranap_nsap_addr_enc *rab_assign_addr_enc); -int ranap_iu_vty_config_write(struct vty *vty, const char *indent); diff --git a/include/osmocom/ranap/vty.h b/include/osmocom/ranap/vty.h new file mode 100644 index 0000000..750eac1 --- /dev/null +++ b/include/osmocom/ranap/vty.h @@ -0,0 +1,8 @@ +#pragma once + +#include <osmocom/ranap/ranap_common.h> + +struct vty; + +void ranap_iu_vty_init(int iu_parent_node, enum ranap_nsap_addr_enc *rab_assign_addr_enc); +int ranap_iu_vty_config_write(struct vty *vty, const char *indent); diff --git a/src/iu_client_vty.c b/src/iu_client_vty.c index 170791f..66136af 100644 --- a/src/iu_client_vty.c +++ b/src/iu_client_vty.c @@ -26,9 +26,10 @@ #include <osmocom/sigtran/osmo_ss7.h> #include <osmocom/sigtran/sccp_sap.h> +#include <osmocom/iuh/iu_common.h> #include <osmocom/iuh/common.h> -#include <osmocom/ranap/iu_client.h> #include <osmocom/ranap/ranap_common.h> +#include <osmocom/ranap/vty.h> static enum ranap_nsap_addr_enc *g_rab_assign_addr_enc = NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8d393d17aa5f004dc4aa4e916bee68f44339e138 Gerrit-Change-Number: 40846 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in osmo-iuh[master]: Drop iu_client - adopted by osmo-sgsn
by lynxis lazus 13 Aug '25

13 Aug '25

Attention is currently required from: daniel, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email ) Change subject: Drop iu_client - adopted by osmo-sgsn ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > this would make older osmo-sgsn fail to build against modern osmo-iuh versions, right? Yes, that's right. That's the intention. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de Gerrit-Change-Number: 40847 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Aug 2025 13:31:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Dockerfile: fix Suites: stable-backports
by fixeria 13 Aug '25

13 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40874?usp=email ) Change subject: testenv: Dockerfile: fix Suites: stable-backports ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc46b6dc2493806dc12f0ff442abd70fe5b48eb8 Gerrit-Change-Number: 40874 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Aug 2025 13:02:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: s1ap: add {enc,dec}_S1AP_Global_ENB_ID() API
by fixeria 13 Aug '25

13 Aug '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40875?usp=email ) Change subject: s1ap: add {enc,dec}_S1AP_Global_ENB_ID() API ...................................................................... s1ap: add {enc,dec}_S1AP_Global_ENB_ID() API Change-Id: I83c314f4929a6eb749dfa8dbd1e1371a90481ed6 Related: OS#6490 --- M library/s1ap/S1AP_EncDec.cc M library/s1ap/S1AP_Types.ttcn M mme/MME_Tests.ttcn 3 files changed, 26 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/40875/1 diff --git a/library/s1ap/S1AP_EncDec.cc b/library/s1ap/S1AP_EncDec.cc index 6f82b2b..077ec31 100644 --- a/library/s1ap/S1AP_EncDec.cc +++ b/library/s1ap/S1AP_EncDec.cc @@ -30,4 +30,26 @@ return pdu; } +OCTETSTRING enc__S1AP__Global__ENB__ID(const S1AP__IEs::Global__ENB__ID &ie) +{ + TTCN_Buffer buf; + + buf.clear(); + ie.encode(S1AP__IEs::Global__ENB__ID_descr_, buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return OCTETSTRING(buf.get_len(), buf.get_data()); +} + +S1AP__IEs::Global__ENB__ID dec__S1AP__Global__ENB__ID(const OCTETSTRING &stream) +{ + S1AP__IEs::Global__ENB__ID ie; + TTCN_Buffer buf; + + buf.clear(); + buf.put_os(stream); + ie.decode(S1AP__IEs::Global__ENB__ID_descr_, buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return ie; +} + } diff --git a/library/s1ap/S1AP_Types.ttcn b/library/s1ap/S1AP_Types.ttcn index 6730ff3..5d0ecbe 100644 --- a/library/s1ap/S1AP_Types.ttcn +++ b/library/s1ap/S1AP_Types.ttcn @@ -1,7 +1,11 @@ module S1AP_Types { import from S1AP_PDU_Descriptions language "ASN.1:1997" all; + import from S1AP_IEs language "ASN.1:1997" all; external function enc_S1AP_PDU(in S1AP_PDU pdu) return octetstring; external function dec_S1AP_PDU(in octetstring stream) return S1AP_PDU; + + external function enc_S1AP_Global_ENB_ID(in Global_ENB_ID ie) return octetstring; + external function dec_S1AP_Global_ENB_ID(in octetstring stream) return Global_ENB_ID; } diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index e039cfe..360248b 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -125,35 +125,6 @@ var UeParams g_ue_pars[NUM_UE]; } -/* Encode an S1AP Global-ENB-ID into an octetstring */ -private function enc_S1AP_Global_ENB_ID(Global_ENB_ID global_enb_id) return octetstring { - - /* Due to the limitations of libfftranscode, we can not define encoders (or decoders) for individual - * information elements (in S1AP_Types.cc). Unfortuantely Global-ENB-ID also appears in BSSGP in its - * encoded form. (see also: GTP-C 3GPP TS 48.018, section 11.3.70). To encode a given Global-ENB-ID - * we craft a full S1AP PDU and encode it. Then we can cut out the encoded Global-ENB-ID from the - * generated octetstring. */ - - var SupportedTAs supported_tas_dummy := {{ - tAC := '0000'O, - broadcastPLMNs := { '00f000'O }, - iE_Extensions := omit - }}; - var octetstring encoded; - var integer global_enb_id_len; - - if (ispresent(global_enb_id.eNB_ID.macroENB_ID)) { - global_enb_id_len := 8; - } else { - /* All other ENB ID types fit into 8 byte (homeENB_ID, short_macroENB_ID, long_macroENB_ID) */ - global_enb_id_len := 9; - } - - encoded := enc_S1AP_PDU(valueof(ts_S1AP_SetupReq(global_enb_id, supported_tas_dummy, v32))); - - return substr(encoded, 11, global_enb_id_len); -} - type component ConnHdlr extends S1AP_ConnHdlr, SGsAP_ConnHdlr, DIAMETER_ConnHdlr, GTP_ConnHdlr, GTP2_ConnHdlr { var ConnHdlrPars g_pars; timer g_Tguard := 30.0; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I83c314f4929a6eb749dfa8dbd1e1371a90481ed6 Gerrit-Change-Number: 40875 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log