Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40892?usp=email )
Change subject: 5gc: Place PDU Session params into its own subrecord
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40892?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0c8d3f0901d53e4aa75855e602234410fd00f9
Gerrit-Change-Number: 40892
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Aug 2025 18:57:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40891?usp=email )
Change subject: 5gc: Obtain amf_id from NGAP_Emulation
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40891?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I49cb6d7fe9f18734c49bb49ecceb671e8122ce88
Gerrit-Change-Number: 40891
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Aug 2025 18:56:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40890?usp=email )
Change subject: ngap: Add template for UEContextReleaseReq without PDU Session List
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40890?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0f1a549103b70bcd373dcd4c688761d3eeef10a6
Gerrit-Change-Number: 40890
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Aug 2025 18:55:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40889?usp=email )
Change subject: ngap: Add missing mandatory IE Cause to m_n2_UEContextReleaseRequest
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40889?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib7d87f957e469a23448e35fd82a697d1698c7da7
Gerrit-Change-Number: 40889
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Aug 2025 18:54:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40893?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: 5gc: Add tests for UE release context request procedure
......................................................................
5gc: Add tests for UE release context request procedure
Change-Id: Icaaeb2923fdcaba47a72ed0aedc5661f68c03774
---
M 5gc/C5G_Tests.ttcn
M 5gc/ConnHdlr.ttcn
M 5gc/expected-results.xml
3 files changed, 72 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/40893/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40893?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icaaeb2923fdcaba47a72ed0aedc5661f68c03774
Gerrit-Change-Number: 40893
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: jolly, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif
......................................................................
Patch Set 5:
(2 comments)
File include/osmocom/netif/twjit.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/147d1af4_a1b48df… :
PS2, Line 137: bool osmo_twjit_got_any_input(struct osmo_twjit *twjit);
> I haven't forgotten about this API rename idea, but I haven't changed it in patchset 3 - too many ot […]
I have warmed up to your idea of renaming this API, and I would like to include the same rename in my `twrtp-native` (director's cut) version so this part remains consistent. Please indicate whether you prefer `osmo_twjit_rr_info_is_valid()` or slightly shorter `osmo_twjit_rr_info_valid()`.
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/9785e1a6_e924e28… :
PS2, Line 504: rtph = osmo_rtp_get_hdr(msg);
> @falcon@freecalypso.org yes several people I know, not only you, (eg. me and @vyanitskiy@sysmocom. […]
@pespin@sysmocom.de: nice to hear about your interest in seeing twrtp merged and become a replacement for ortp. I plan to proceed as follows:
1. I am putting together a "director's cut" version of twrtp that is no longer a prototype (not `twrtp-proto`), that will be used long-term by ThemWi network elements. This ThemWi-native version of twrtp (controlled by me only) will reside in ThemWi area of Osmocom Gitea, planned name `twrtp-native`.
2. The manual in troff-to-PDF format, hosted on freecalypso.org, will describe `twrtp-native` version.
3. In the next revision of the present patchset, the version submitted for inclusion into `libosmo-netif` will officially become a "derivative work based on Themyscira Wireless library", and will be able to contain features requested by Osmocom that can never go into ThemWi-official version.
4. I will add a third patch to this series (revive the one dealing with documentation), adding a local version of the manual to `libosmo-netif/doc`, one that can change in sync with the code.
5. Preparation of merge-candidate patches to OsmoBTS will begin when and if `libosmo-netif` patches are merged.
OsmoBTS patch plans: you can look at my `falconia/twrtp*` branches in `osmo-bts` repo (3 branch versions so far) to see how I plan to address this one, if and when twrtp joins `libosmo-netif`. There I create an OsmoBTS-internal abstraction layer that can use either ortp or twrtp, selectable by vty config, along with a provision to make ortp compile-optional. twrtp then becomes mandatory only if the user chose to compile with ortp excluded. Or are you instead thinking about dropping ortp completely? The latter I could never imagine in my wildest dreams, but if you really do want to go there, let's revisit it after we get twrtp merged into Osmocom libs.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Aug 2025 17:37:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>