Attention is currently required from: lynxis lazus.
neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email )
Change subject: vlr: extend the subscriber invalidate callback with reasons
......................................................................
Patch Set 9: Code-Review+2
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/07db23bf_fb005693?usp… :
PS5, Line 13: b) if the HLR do a Cancel Location Procedure with reason withdraw
> I think your idea is correct, that we simply drop the subscriber from the VLR cache. […]
Done
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/cfabf467_827cef6a?usp… :
PS8, Line 15: d) duplicate entries (unsure if this is valid, but keeping the code as is)
> duplicate entries are very important to prevent. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3
Gerrit-Change-Number: 38488
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 21 Aug 2025 21:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: neels.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email )
Change subject: vlr: extend the subscriber invalidate callback with reasons
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS9:
b
File include/osmocom/vlr/vlr.h:
https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/aab3d4d2_ba8e0c32?usp… :
PS8, Line 207: enum vlr_inval_reason {
> these aren't from a spec, right? If they are, a comment to link to it would be great
no they don't come from the spec.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3
Gerrit-Change-Number: 38488
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Aug 2025 21:15:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Patch Set 7:
(1 comment)
File tests/gprs_routing_area/gprs_routing_area_test.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/227ea2d5_2b4ea6b7?us… :
PS6, Line 542: * The SGSN explicit not support the same LAC/RA for GERAN and UTRAN at the same time.
> "The SGSN explicit not support" this is wrong language-wise.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Aug 2025 21:09:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Re-introduce Iu/UTRAN support
Add support for UTRAN routing areas.
Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
---
M include/osmocom/sgsn/gprs_routing_area.h
M src/sgsn/gprs_ranap.c
M src/sgsn/gprs_routing_area.c
M tests/gprs_routing_area/gprs_routing_area_test.c
4 files changed, 206 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/13/40813/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Patch Set 6:
(1 comment)
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/0d41f9d1_e78e035d?us… :
PS6, Line 487: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI)
> I think it is better this way, […]
what ever if you like it better without else, I'll update it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Aug 2025 21:07:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Patch Set 6:
(1 comment)
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/8068ecb9_ad548eb8?us… :
PS6, Line 487: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI)
> this else can be removed, you forgot.
I think it is better this way,
because it explicit connects both statements and keep then in an order.
IMHO it improve the code readiness.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Aug 2025 21:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: lynxis lazus, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge
......................................................................
MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge
Currently the MSC/VLR doesn't inform the HLR when a MS detaches.
Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/39236/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5
Gerrit-Change-Number: 39236
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge
......................................................................
MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge
Currently the MSC/VLR doesn't inform the HLR when a MS detaches.
Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/39236/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5
Gerrit-Change-Number: 39236
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, laforge, pespin.
Hello Jenkins Builder, daniel, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
to look at the new patch set (#10).
Change subject: Deprecate iu_client
......................................................................
Deprecate iu_client
The only remaining use of iu_client is osmo-sgsn.
iu_client was originally meant to be used by osmo-msc
and osmo-sgsn. But the abstraction didn't hold up and
osmo-msc stopped using iu_client for a long time.
To start development, osmo-sgsn will start with a copy of
iu_client until it can be completely dropped from the osmo-sgsn codebase.
Future osmo-sgsn versions won't use the osmo-iuh' iu_client.
Related: OS#5487
Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
---
M TODO-RELEASE
M include/osmocom/ranap/iu_client.h
2 files changed, 26 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/40847/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
Gerrit-Change-Number: 40847
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>