Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email )
Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function
......................................................................
Patch Set 10:
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/fd3ebc33_e7db… :
PS10, Line 3350: f_sleep(1.0);
> Why is this needed?
Since I am already the second person asking why do you add an artificial delay here, please add a comment explaining why this `f_sleep()` is needed. What kind of timeouts are you running into?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3
Gerrit-Change-Number: 39017
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email )
Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function
......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/24b629da_20ce… :
PS10, Line 7: rework TC_sgsn_context_req_out to actual function
I find the commit name confusing. What's an "actual function"?
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/ddc3e65f_2f43… :
PS10, Line 3237: tr_SGSNContextReqPDU
Weird formatting here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/3e6f8a48_5cd2… :
PS10, Line 3350: f_sleep(1.0);
Why is this needed?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3
Gerrit-Change-Number: 39017
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:45:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email )
Change subject: 5gc: Test UE requested PDU Session Modification procedure
......................................................................
Patch Set 2:
(4 comments)
File 5gc/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/b45afe6a_9d97… :
PS2, Line 395: min 1 item in list doesn't allow previously allocating an empty list
You could simply do:
```
qos_flow_resp_li[i] := qos_flow_resp_it;
```
This works fine and the runtime will resize the list accordingly.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/3bc5a43d_f2f4… :
PS2, Line 443: min 1 item in list doesn't allow previously allocating an empty list
Likewise here, just assign the value using `i` as the index.
File library/NGAP_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/f74baec7_0c14… :
PS2, Line 167: Setup
Modify?
File library/NG_NAS_Osmo_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/dbcfe584_e734… :
PS2, Line 749: omit
How can the whole template be `omit`? Did you mean `value`?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9ac0f0e431c4a82dfab8675c93bf3c3f05442a7
Gerrit-Change-Number: 40895
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:36:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: neels.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email )
Change subject: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent
......................................................................
Patch Set 11:
(1 comment)
File tests/msc_vlr/msc_vlr_test_authen_reuse.err:
https://gerrit.osmocom.org/c/osmo-msc/+/38491/comment/258f5816_8515e255?usp… :
PS11, Line 184: DVLR vlr_lu_fsm(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:GERAN-A:LU){VLR_ULA_S_DONE}: Deferring: will deallocate with msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:GERAN-A:LU)
> I see here that we deallocate the msc_a much much earlier. […]
I don't know.
I ran the test cases and it looked fine (both make check and ttcn3).
Any other idea?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b
Gerrit-Change-Number: 38491
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:17:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds
......................................................................
SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds
Currently the SGSN times out after 30 seconds.
Change-Id: Ie882dd39f3c606e5fe00162fcf17c47b9f713d49
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/39257/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie882dd39f3c606e5fe00162fcf17c47b9f713d49
Gerrit-Change-Number: 39257
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39258?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: TC_attach_auth_sai_timeout: increase t_guard to 35 seconds
......................................................................
SGSN: TC_attach_auth_sai_timeout: increase t_guard to 35 seconds
Currently the SGSN times out after 30 seconds.
Change-Id: Iaef1853f1e5f9b99fedbdfbed597ffa79b9e758a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/39258/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39258?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iaef1853f1e5f9b99fedbdfbed597ffa79b9e758a
Gerrit-Change-Number: 39258
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
......................................................................
SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
Add a TC to to simulate multiple GMM Attach with a different
content.
When receiving a GMM Attach while in an Attach procedure, but with a different
content, the old GMM Attach should be discarded silently and a new
GMM Attach procedure should be initiated.
Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 71 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/39256/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
Gerrit-Change-Number: 39256
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39259?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: TC_attach_timeout_after_pdp_act: expect SAI when doing auth
......................................................................
SGSN: TC_attach_timeout_after_pdp_act: expect SAI when doing auth
While doing an attach, a authentication should happen.
Change-Id: I46853723ecb43f4809e8c292ec5c4cc5d872ad2f
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/39259/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39259?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I46853723ecb43f4809e8c292ec5c4cc5d872ad2f
Gerrit-Change-Number: 39259
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>