Attention is currently required from: fixeria.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/40952?usp=email )
Change subject: requirements: set cmd2>=2.6.2,<3.0
......................................................................
Patch Set 1:
(1 comment)
File requirements.txt:
https://gerrit.osmocom.org/c/pysim/+/40952/comment/05390852_ea12e661?usp=em… :
PS1, Line 4: cmd2>=2.6.2,<3.0
> I am not sure if it's a good idea to set `<3.0` here. […]
I'm not sure I understand what you mean. This sets the range of versions of cmd2 from 2.6.2 or higher to < 3.0. Users can either install these via pip, which has these versions, or just ignore that list and use distro packages with other versions. Or modify requirements.txt and use different versions too, but as they probably have breakage, we guard against automatically installing them.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40952?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4ba65ed486247c5670313b75f43a242d264df14b
Gerrit-Change-Number: 40952
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Aug 2025 13:14:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/40952?usp=email )
Change subject: requirements: set cmd2>=2.6.2,<3.0
......................................................................
Patch Set 1:
(1 comment)
File requirements.txt:
https://gerrit.osmocom.org/c/pysim/+/40952/comment/73e6eea7_647aa32d?usp=em… :
PS1, Line 4: cmd2>=2.6.2,<3.0
I am not sure if it's a good idea to set `<3.0` here. This is only relevant for building documentation, running with cmd2 should still be possible, right?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40952?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4ba65ed486247c5670313b75f43a242d264df14b
Gerrit-Change-Number: 40952
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Aug 2025 12:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/40953?usp=email )
Change subject: docs: fix authors line exceeding the page
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40953?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iacbba6c2f74bf2b9f96057e71bde017a11f703a8
Gerrit-Change-Number: 40953
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Aug 2025 12:49:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40953?usp=email )
Change subject: docs: fix authors line exceeding the page
......................................................................
docs: fix authors line exceeding the page
Fix that the authors get cut off as they exceed the page in the PDF
version. This can currently be seen here:
https://downloads.osmocom.org/docs/pysim/master/osmopysim-usermanual.pdf
Change-Id: Iacbba6c2f74bf2b9f96057e71bde017a11f703a8
---
M docs/conf.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/40953/1
diff --git a/docs/conf.py b/docs/conf.py
index 8455007..9091878 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -21,6 +21,14 @@
copyright = '2009-2023 by Sylvain Munaut, Harald Welte, Philipp Maier, Supreeth Herle, Merlin Chlosta'
author = 'Sylvain Munaut, Harald Welte, Philipp Maier, Supreeth Herle, Merlin Chlosta'
+# PDF: Avoid that the authors list exceeds the page by inserting '\and'
+# manually as line break (https://github.com/sphinx-doc/sphinx/issues/6875)
+latex_elements = {
+ "maketitle":
+ r"""\author{Sylvain Munaut, Harald Welte, Philipp Maier, \and Supreeth Herle, Merlin Chlosta}
+\sphinxmaketitle
+"""
+}
# -- General configuration ---------------------------------------------------
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40953?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iacbba6c2f74bf2b9f96057e71bde017a11f703a8
Gerrit-Change-Number: 40953
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40952?usp=email )
Change subject: requirements: set cmd2>=2.6.2,<3.0
......................................................................
requirements: set cmd2>=2.6.2,<3.0
Remove the previous workaround that set cmd2==2.4.3 in jenkins.sh. The
bug this worked around has been fixed in 2.6.2.
3.0 will break unless we use some new additional decorator.
Related: OS#6776
Change-Id: I4ba65ed486247c5670313b75f43a242d264df14b
---
M contrib/jenkins.sh
M requirements.txt
2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/52/40952/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 63087f0..de1d9f8 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -82,10 +82,6 @@
pip install -r requirements.txt
- # XXX: workaround for https://github.com/python-cmd2/cmd2/issues/1414
- # 2.4.3 was the last stable release not affected by this bug (OS#6776)
- pip install cmd2==2.4.3
-
rm -rf docs/_build
make -C "docs" html latexpdf
diff --git a/requirements.txt b/requirements.txt
index 9749d7f..056d912 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,7 +1,7 @@
pyscard
pyserial
pytlv
-cmd2>=1.5
+cmd2>=2.6.2,<3.0
jsonpath-ng
construct>=2.10.70
bidict
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40952?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4ba65ed486247c5670313b75f43a242d264df14b
Gerrit-Change-Number: 40952
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>