- gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: ranap: Reject InitialUE without RAC IE
by pespin 28 Aug '25

28 Aug '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40972?usp=email ) Change subject: ranap: Reject InitialUE without RAC IE ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Good idea! How about also freeing the iu signalling connection? I'm already improving this further in follow-up patches when adding the RESET FSM in my WIP branch. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40972?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7d6b996ddf1c5a7cde1bf06b500d3ed19c6090c6 Gerrit-Change-Number: 40972 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 28 Aug 2025 21:41:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ci[master]: OBS: --version-append: never override version
by keith 28 Aug '25

28 Aug '25

Attention is currently required from: fixeria, osmith. keith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email ) Change subject: OBS: --version-append: never override version ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/40965/comment/972c1302_fdb64ec6?usp=… : PS1, Line 25: While IMHO it is a bad idea to just amend the commit of the last release > I think what I did there was checkout the latest tag, then git rebase -i [quite_some_commits back] a […] Actually, looking at it again: In the case of osmo-sgsn, What I did was pick a bunch of commits, on top of a particular commit I had been working on and then add more of my own work, but I mistakenly included the commit that bumped the version in the debian changelog. But as I said, understanding the issue, I don't need this change, so if you are making it for me only, then maybe don't. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I589ceb08b9e1ff2ccdd54e94216b25e1e40f22fe Gerrit-Change-Number: 40965 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 21:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: keith <keith(a)rhizomatica.org>

1 0

[S] Change in osmo-ci[master]: OBS: --version-append: never override version
by keith 28 Aug '25

28 Aug '25

Attention is currently required from: fixeria, osmith. keith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email ) Change subject: OBS: --version-append: never override version ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/40965/comment/7233975f_9562c18b?usp=… : PS1, Line 25: While IMHO it is a bad idea to just amend the commit of the last release > yes, but on their own branch, not master. I think what I did there was checkout the latest tag, then git rebase -i [quite_some_commits back] and delete the commits relating to running as osmocom user. Anyway, it doesn't matter. All I'll say is don't make this change on my account, as I understand better now how it works, I'm fine with it. I cannot speak to whether or not it is a good idea in general. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I589ceb08b9e1ff2ccdd54e94216b25e1e40f22fe Gerrit-Change-Number: 40965 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 20:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: ranap: Create iu_rnc upon rx RESET
by lynxis lazus 28 Aug '25

28 Aug '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40976?usp=email ) Change subject: ranap: Create iu_rnc upon rx RESET ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iaf31271feb4d88881382ed8594d0d8e20e22b194 Gerrit-Change-Number: 40976 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 20:18:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: ranap: Create iu_rnc upon rx RESET
by lynxis lazus 28 Aug '25

28 Aug '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40976?usp=email ) Change subject: ranap: Create iu_rnc upon rx RESET ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Not about this patch, but what should the RNC lifecycle be? Create on first PDU, Vty can destroy it. How about time outs? Can a RNC de-register itself? Or sending a reset and loosing the connection? Or..? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iaf31271feb4d88881382ed8594d0d8e20e22b194 Gerrit-Change-Number: 40976 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 20:05:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: ranap: Improve error handling in Rx RESET
by lynxis lazus 28 Aug '25

28 Aug '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email ) Change subject: ranap: Improve error handling in Rx RESET ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/40975/comment/d5952491_38dfd864?us… : PS1, Line 8: please describe a little bit more what fancy error handling you're doing. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2a53e10c3903992a42d081e3ec300fbdb9b3c34c Gerrit-Change-Number: 40975 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 20:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: fix missing hasattr check
by fixeria 28 Aug '25

28 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40970?usp=email ) Change subject: testenv: fix missing hasattr check ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File _testenv/testenv/__init__.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40970/comment/6e066386_9fda… : PS1, Line 282: if hasattr(args, "distro") and args.distro is None: > Maybe do `getattr(args, "distro", None) is None` here? Ah, my proposal is actually wrong. Nevermind. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I138fda5f5807588428bba4eb1593b887fe7357c9 Gerrit-Change-Number: 40970 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 20:03:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: ranap: Improve error handling in Rx RESET
by lynxis lazus 28 Aug '25

28 Aug '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email ) Change subject: ranap: Improve error handling in Rx RESET ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/sgsn/gprs_ranap.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40975/comment/1ae7bf99_6dd98e1b?us… : PS1, Line 332: /* Send CL RANAP message over SCCP: */ CL means? https://gerrit.osmocom.org/c/osmo-sgsn/+/40975/comment/a27fbfd9_c41f8378?us… : PS1, Line 679: if (ies->presenceMask & ERRORINDICATIONIES_RANAP_CN_DOMAININDICATOR_PRESENT) { a reset without domain ie is valid and expect? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2a53e10c3903992a42d081e3ec300fbdb9b3c34c Gerrit-Change-Number: 40975 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 20:03:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: fix missing hasattr check
by fixeria 28 Aug '25

28 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40970?usp=email ) Change subject: testenv: fix missing hasattr check ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File _testenv/testenv/__init__.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40970/comment/196a6506_9e33… : PS1, Line 282: if hasattr(args, "distro") and args.distro is None: Maybe do `getattr(args, "distro", None) is None` here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I138fda5f5807588428bba4eb1593b887fe7357c9 Gerrit-Change-Number: 40970 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 20:02:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-iuh[master]: ranap: Introduce ranap_new_msg_error_ind()
by lynxis lazus 28 Aug '25

28 Aug '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40974?usp=email ) Change subject: ranap: Introduce ranap_new_msg_error_ind() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Could you describe a little bit more about the usage of the error indication? E.g. what for is it used? How to react to it? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I58c75b3e0e0f33f48d077385ffac820a6b2be59e Gerrit-Change-Number: 40974 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 19:58:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log