Attention is currently required from: fixeria, jolly, pespin.
Hello Jenkins Builder, jolly, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40993?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by jolly, Code-Review+1 by pespin
Change subject: s1ap_proxy: erab_fsm_start_reg/2: check if already registered
......................................................................
s1ap_proxy: erab_fsm_start_reg/2: check if already registered
Before this patch, s1ap_proxy would spawn a new erab_fsm process with
a duplicate UID and simply replace the old process in the registry.
This would result in stale erab_fsm process, still linked but not
present in the registry, and thus not reachable.
If there's already an E-RAB process for the given UID, simply return
Pid of that existing process. The FSM will most likely reject an
unexpected event, resulting in a negative verdict:
* 'reply' for duplicate E-RAB SETUP REQUEST
* 'drop' for duplicate INITIAL CONTEXT SETUP REQUEST
Change-Id: I8e93492219100496fd8dc69e031310858ba9c7fb
---
M src/s1ap_proxy.erl
M test/s1ap_proxy_test.erl
2 files changed, 42 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/93/40993/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40993?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8e93492219100496fd8dc69e031310858ba9c7fb
Gerrit-Change-Number: 40993
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, lynxis lazus, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40956?usp=email )
Change subject: Split most of iu_client.{c,h} into sccp.{c,h} and iu_rnc.{c,h}
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5:
(+2 since it already was +2 before and just contains an obvious bugfix)
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40956?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4c792ae665720460b5a954b5c7cbfe5acbc37473
Gerrit-Change-Number: 40956
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 03 Sep 2025 06:37:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes