Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41753?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: 5gc: Document procedures not implemented in open5gs
......................................................................
5gc: Document procedures not implemented in open5gs
Change-Id: I1480dc8ee1f0db78c179406fa9090835364c01e8
---
M 5gc/C5G_Tests.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/41753/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41753?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1480dc8ee1f0db78c179406fa9090835364c01e8
Gerrit-Change-Number: 41753
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: 5gc: Test UE Triggered Service Request
......................................................................
5gc: Test UE Triggered Service Request
Related: SYS#7073
Change-Id: I65cf7844d11be55d9d5c8e31fd87a3c72e6a607b
---
M 5gc/C5G_Tests.ttcn
M 5gc/ConnHdlr.ttcn
M 5gc/expected-results.xml
M library/NGAP_Functions.ttcn
M library/NG_NAS_Osmo_Templates.ttcn
M library/NG_NAS_Osmo_Types.ttcn
6 files changed, 346 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/41747/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I65cf7844d11be55d9d5c8e31fd87a3c72e6a607b
Gerrit-Change-Number: 41747
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41756?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: 5gc: Network Triggered Service Request
......................................................................
5gc: Network Triggered Service Request
Change-Id: I42e422d104f254bc27d5f3bb3e8df0cba6380648
---
M 5gc/C5G_Tests.ttcn
M 5gc/ConnHdlr.ttcn
M 5gc/expected-results.xml
M library/GTPv1U_Emulation.ttcnpp
4 files changed, 94 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/41756/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41756?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I42e422d104f254bc27d5f3bb3e8df0cba6380648
Gerrit-Change-Number: 41756
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email )
Change subject: 5gc: Test UE Triggered Service Request
......................................................................
Patch Set 3:
(3 comments)
File 5gc/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747/comment/a416a288_6000… :
PS3, Line 410: var PDUSessionResourceSetupItemSURes it_resp;
: it_resp := f_pdu_handle_session_resource_setup_item_su(li_req[i]);
: if (i == 0) { /* min 1 item in list doesn't allow previously allocating an empty list */
: li_resp := { it_resp };
: } else {
: li_resp := li_resp & { it_resp };
:
> Assigning items via the index works fine: […]
I'll keep it as is to keep it in line with other instances of this code in this file, since I think it's also fine as is.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747/comment/189473a8_f79d… :
PS3, Line 691: var template (value) NGAP_PDU tx_pdu;
> unused
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747/comment/c3eef43c_f904… :
PS3, Line 694: var NG_NAS_DL_Message_Type rx_nas;
> unused
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I65cf7844d11be55d9d5c8e31fd87a3c72e6a607b
Gerrit-Change-Number: 41747
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jan 2026 10:15:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40740?usp=email )
Change subject: add lint_ruff.sh
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
What purpose does this serve? Why do we have linter calls that are outside /separate and hence different from the automatic build verification?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40740?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ca385eef9e6831a49f61456aa24492d4fa2ec17
Gerrit-Change-Number: 40740
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jan 2026 10:15:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40739?usp=email )
Change subject: add lint_pylint.sh
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
What purpose does this serve? Why is it separate from what contrib/jenkins.sh executes? If at all, we should have one way to execute the linter, and one place where the parameters are defined.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40739?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0aeb38604909bbc7d3daaa83cf2088e9e62a23f9
Gerrit-Change-Number: 40739
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jan 2026 10:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40823?usp=email )
Change subject: add test_configurable_parameters.py
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
When/how is this used? IMHO It is not clear or common that multiple NAA would have the same key material. I think multiple USIM is a hypothetical option, but USIM and ISIM with different keys might be more realistic/common
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40823?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia55f0d11f8197ca15a948a83a34b3488acf1a0b4
Gerrit-Change-Number: 40823
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Jan 2026 10:13:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No