January 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: Avoid accessing struct log_target members directly
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/41881?usp=email ) Change subject: Avoid accessing struct log_target members directly ...................................................................... Avoid accessing struct log_target members directly Use newly available APIs instead. Change-Id: Ib6e34e948e4ad9b8a8883febf54b31345c3bcd97 Depends: libosmocore.git Change-Id Ie48e7e635feb91509b9c034394df4fb16cb931a3 --- M TODO-RELEASE M src/gprs_debug.c 2 files changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/41881/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..fb115da 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmocore >1.12.0 log_get_context(), log_{get,set}_filter(_data)() diff --git a/src/gprs_debug.c b/src/gprs_debug.c index ba9aeec..6813c06 100644 --- a/src/gprs_debug.c +++ b/src/gprs_debug.c @@ -147,17 +147,17 @@ static int filter_fn(const struct log_context *ctx, struct log_target *tar) { - const struct gprs_nsvc *nsvc = (const struct gprs_nsvc*)ctx->ctx[LOG_CTX_GB_NSVC]; - const struct gprs_nsvc *bvc = (const struct gprs_nsvc*)ctx->ctx[LOG_CTX_GB_BVC]; + const struct gprs_nsvc *nsvc = (const struct gprs_nsvc *)log_get_context(ctx, LOG_CTX_GB_NSVC); + const struct gprs_nsvc *bvc = (const struct gprs_nsvc *)log_get_context(ctx, LOG_CTX_GB_BVC); /* Filter on the NS Virtual Connection */ - if ((tar->filter_map & (1 << LOG_FLT_GB_NSVC)) != 0 - && nsvc && (nsvc == tar->filter_data[LOG_FLT_GB_NSVC])) + if (log_get_filter(tar, LOG_FLT_GB_NSVC) && + nsvc && (nsvc == log_get_filter_data(tar, LOG_FLT_GB_NSVC))) return 1; /* Filter on the BVC */ - if ((tar->filter_map & (1 << LOG_FLT_GB_BVC)) != 0 - && bvc && (bvc == tar->filter_data[LOG_FLT_GB_BVC])) + if (log_get_filter(tar, LOG_FLT_GB_BVC) && + bvc && (bvc == log_get_filter_data(tar, LOG_FLT_GB_BVC))) return 1; return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/41881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib6e34e948e4ad9b8a8883febf54b31345c3bcd97 Gerrit-Change-Number: 41881 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: Avoid accessing struct log_target members directly
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/41880?usp=email ) Change subject: Avoid accessing struct log_target members directly ...................................................................... Avoid accessing struct log_target members directly Use newly available APIs instead. Depends: libosmocore.git Change-Id Ie48e7e635feb91509b9c034394df4fb16cb931a3 Change-Id: I81020f368c7e0e7b8dcd92917301bf3844157705 --- M src/libvlr/vlr.c M src/osmo-msc/msc_main.c 2 files changed, 14 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/80/41880/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 919def3..26ab35b 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1733,21 +1733,23 @@ void log_set_filter_vlr_subscr(struct log_target *target, struct vlr_subscr *vlr_subscr) { - struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR]; - const char *use = "logfilter"; + struct vlr_subscr *fsub = log_get_filter_data(target, LOG_FLT_VLR_SUBSCR); + static const char *use = "logfilter"; /* free the old data */ - if (*fsub) { - vlr_subscr_put(*fsub, use); - *fsub = NULL; + if (fsub) { + log_set_filter_data(target, LOG_FLT_VLR_SUBSCR, NULL); + vlr_subscr_put(fsub, use); } if (vlr_subscr) { - target->filter_map |= (1 << LOG_FLT_VLR_SUBSCR); vlr_subscr_get(vlr_subscr, use); - *fsub = vlr_subscr; - } else - target->filter_map &= ~(1 << LOG_FLT_VLR_SUBSCR); + log_set_filter_data(target, LOG_FLT_VLR_SUBSCR, vlr_subscr); + log_set_filter(target, LOG_FLT_VLR_SUBSCR, true); + } else { + log_set_filter_data(target, LOG_FLT_VLR_SUBSCR, NULL); + log_set_filter(target, LOG_FLT_VLR_SUBSCR, false); + } } int g_vlr_log_cat[_OSMO_VLR_LOGC_MAX]; diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index 3c09742..ae4745b 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -540,10 +540,10 @@ static int filter_fn(const struct log_context *ctx, struct log_target *tar) { - const struct vlr_subscr *vsub = ctx->ctx[LOG_CTX_VLR_SUBSCR]; + const struct vlr_subscr *vsub = log_get_context(ctx, LOG_CTX_VLR_SUBSCR); - if ((tar->filter_map & (1 << LOG_FLT_VLR_SUBSCR)) != 0 - && vsub && vsub == tar->filter_data[LOG_FLT_VLR_SUBSCR]) + if (log_get_filter(tar, LOG_FLT_VLR_SUBSCR) && + vsub && vsub == log_get_filter_data(tar, LOG_FLT_VLR_SUBSCR)) return 1; return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I81020f368c7e0e7b8dcd92917301bf3844157705 Gerrit-Change-Number: 41880 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: logging: Add APIs to set/get log_{target,context} fields
by Jenkins Builder 20 Jan '26

20 Jan '26

Jenkins Builder has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41879?usp=email ) Change subject: logging: Add APIs to set/get log_{target,context} fields ...................................................................... Patch Set 1: (1 comment) File src/core/logging.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmocore/+/41879/comment/f961be5e_246d9271?… : PS1, Line 921: return target->filter_map & (1 << log_filter_index); space prohibited after that '&' (ctx:WxW) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie48e7e635feb91509b9c034394df4fb16cb931a3 Gerrit-Change-Number: 41879 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 20 Jan 2026 11:25:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: logging: Add APIs to set/get log_{target,context} fields
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41879?usp=email ) Change subject: logging: Add APIs to set/get log_{target,context} fields ...................................................................... logging: Add APIs to set/get log_{target,context} fields Change-Id: Ie48e7e635feb91509b9c034394df4fb16cb931a3 --- M TODO-RELEASE M include/osmocom/core/logging.h M src/core/libosmocore.map M src/core/logging.c 4 files changed, 115 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/79/41879/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 3c98f06..b7d1585 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -10,3 +10,4 @@ core added osmo_sock_set_nonblock(), osmo_sock_get_nonblock() core added gsmtap_source_set_nonblock(), gsmtap_source_using_wq() core added osmo_iofd_set_name_f() +core added log_{get,set}_filter(_data)(), log_get_context() diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index 44263fb..286f646 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -225,7 +225,7 @@ /*! Log context information, passed to filter */ struct log_context { - void *ctx[LOG_MAX_CTX+1]; + void *ctx[LOG_MAX_CTX+1] OSMO_DEPRECATED_OUTSIDE("Accessing struct log_context members directly is deprecated"); }; /*! Compatibility with older libosmocore versions */ @@ -298,13 +298,15 @@ }; /*! structure representing a logging target */ +#define OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE_LOG_TARGET \ + OSMO_DEPRECATED_OUTSIDE("Accessing struct log_target members directly is deprecated") struct log_target { struct llist_head entry; /*!< linked list */ /*! Internal data for filtering */ - int filter_map; + int filter_map OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE_LOG_TARGET; /*! Internal data for filtering */ - void *filter_data[LOG_MAX_FILTERS+1]; + void *filter_data[LOG_MAX_FILTERS+1] OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE_LOG_TARGET; /*! logging categories */ struct log_category *categories; @@ -406,10 +408,16 @@ /* context management */ void log_reset_context(void); -int log_set_context(uint8_t ctx, void *value); +int log_set_context(uint8_t ctx_nr, void *value); +void *log_get_context(const struct log_context *ctx, uint8_t ctx_nr); /* filter on the targets */ void log_set_all_filter(struct log_target *target, int); +bool log_get_filter(const struct log_target *target, int log_filter_index); +int log_set_filter(struct log_target *target, int log_filter_index, bool enable); +void *log_get_filter_data(const struct log_target *target, int log_filter_index); +int log_set_filter_data(struct log_target *target, int log_filter_index, void *data); + int log_cache_enable(void); void log_cache_update(int mapped_subsys, uint8_t enabled, uint8_t level); void log_set_use_color(struct log_target *target, int); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 2818f8a..3ec322c 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -75,8 +75,13 @@ log_parse_level; logp_stub; log_reset_context; +log_get_context; +log_get_filter; +log_get_filter_data; log_set_all_filter; log_set_category_filter; +log_set_filter; +log_set_filter_data; log_set_context; log_set_log_level; log_set_print_category; diff --git a/src/core/logging.c b/src/core/logging.c index 9e5ae9f..ac10d00 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -886,7 +886,42 @@ return 0; } -/*! Enable the \ref LOG_FLT_ALL log filter +/*! Get the logging context + * \param[in] ctx logging context + * \param[in] ctx_nr logging context number + * \returns value set for the context + * + * A logging context is something like the subscriber identity to which + * the currently processed message relates, or the BTS through which it + * was received. The main use of this API is during + * (struct log_info)->filter_fn(ctx, log_tgt). + */ +void *log_get_context(const struct log_context *ctx, uint8_t ctx_nr) +{ + if (ctx_nr > LOG_MAX_CTX) + return NULL; + return ctx->ctx[ctx_nr]; +} + +/*! Query whether a log filter is enabled or disabled + * \param[in] target Log target to be queried + * \param[in] log_filter_index the index of the log filter to query + * \returns whether the filtering is enabled (true) or disabled (false) + */ +bool log_get_filter(const struct log_target *target, int log_filter_index) +{ + /* TODO: in the future we can support app-specified log filters here, + * similar to how we do dynamic cateogries defined by apps. */ + if (log_filter_index < 0) + return false; + + if (log_filter_index >= LOG_MAX_FILTERS) + return false; + + return target->filter_map & (1 << log_filter_index); +} + +/*! Enable/disable the \ref LOG_FLT_ALL log filter * \param[in] target Log target to be affected * \param[in] all enable (1) or disable (0) the ALL filter * @@ -902,6 +937,67 @@ target->filter_map &= ~(1 << LOG_FLT_ALL); } +/*! Enable/disable a log filter + * \param[in] target Log target to be affected + * \param[in] log_filter_index the index of the log filter to set + * \param[in] enable enable (true) or disable (false) the ALL filter + * \returns 0 on success, negative on error. + */ +int log_set_filter(struct log_target *target, int log_filter_index, bool enable) +{ + /* TODO: in the future we can support app-specified log filters here, + * similar to how we do dynamic cateogries defined by apps. */ + if (log_filter_index < 0) + return -EINVAL; + + if (log_filter_index >= LOG_MAX_FILTERS) + return -EINVAL; + + if (enable) + target->filter_map |= (1 << log_filter_index); + else + target->filter_map &= ~(1 << log_filter_index); + return 0; +} + +/*! Obtain data associated to a log filter + * \param[in] target Log target to be queried + * \param[in] log_filter_index the index of the log filter to query + * \returns data associated to the log filter + */ +void *log_get_filter_data(const struct log_target *target, int log_filter_index) +{ + /* TODO: in the future we can support app-specified log filters here, + * similar to how we do dynamic cateogries defined by apps. */ + if (log_filter_index < 0) + return NULL; + + if (log_filter_index >= LOG_MAX_FILTERS) + return NULL; + + return target->filter_data[log_filter_index]; +} + +/*! Set data associated to a log filter + * \param[in] target Log target to be affected + * \param[in] log_filter_index the index of the log filter to set associate data for + * \param[in] data The user provided data pointer to associate to the log filter + * \returns 0 on success, negative on error. + */ +int log_set_filter_data(struct log_target *target, int log_filter_index, void *data) +{ + /* TODO: in the future we can support app-specified log filters here, + * similar to how we do dynamic cateogries defined by apps. */ + if (log_filter_index < 0) + return -EINVAL; + + if (log_filter_index >= LOG_MAX_FILTERS) + return -EINVAL; + + target->filter_data[log_filter_index] = data; + return 0; +} + /*! Enable or disable the use of colored output * \param[in] target Log target to be affected * \param[in] use_color Use color (1) or don't use color (0) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie48e7e635feb91509b9c034394df4fb16cb931a3 Gerrit-Change-Number: 41879 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: build: move netns/tun conditionals to configure.ac Move Linux-/embedd...
by Timur Davydov 20 Jan '26

20 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email ) Change subject: build: move netns/tun conditionals to configure.ac Move Linux-/embedded-specific conditional compilation out of the sources and into configure.ac. ...................................................................... build: move netns/tun conditionals to configure.ac Move Linux-/embedded-specific conditional compilation out of the sources and into configure.ac. - Define USE_NETNS based on host_os and disable it for --enable-embedded. - Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use HAVE_IN6_ADDR_S6_ADDR32 instead of __linux__. - Do not build tun.c for embedded targets (previously it was compiled but effectively empty due to #if (!EMBEDDED)). No functional changes intended, this is a preparatory refactor to keep follow-up patches focused and easier to review. Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea --- M configure.ac M include/osmocom/core/netns.h M src/core/Makefile.am M src/core/socket.c M src/core/tun.c 5 files changed, 23 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/78/41878/1 diff --git a/configure.ac b/configure.ac index 64690f9..bc060b6 100644 --- a/configure.ac +++ b/configure.ac @@ -25,6 +25,13 @@ AC_PROG_INSTALL LT_INIT([pic-only disable-static]) +dnl Define USE_NETNS when building for Linux +case "${host_os}" in +*linux*) + AC_DEFINE([USE_NETNS], [1], [Define to 1 if network namespace support is available]) + ;; +esac + AC_CONFIG_MACRO_DIR([m4]) dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang @@ -86,6 +93,13 @@ AC_CHECK_LIB(execinfo, backtrace, BACKTRACE_LIB=-lexecinfo, BACKTRACE_LIB=) AC_SUBST(BACKTRACE_LIB) +# check for struct in6_addr has s6_addr32 field +AC_CHECK_MEMBER([struct in6_addr.s6_addr32], + [AC_DEFINE([HAVE_IN6_ADDR_S6_ADDR32], [1], + [Define if struct in6_addr has s6_addr32 field])], + [], + [[#include <netinet/in.h>]]) + # check for pthread (PTHREAD_CFLAGS, PTHREAD_LIBS) AX_PTHREAD @@ -225,6 +239,7 @@ [embedded=$enableval], [embedded=$ENABLE_EMBEDDED_DEFAULT]) AM_CONDITIONAL(EMBEDDED, test x"$embedded" = x"yes") AM_CONDITIONAL(ENABLE_SERCOM_STUB, test x"$embedded" = x"yes") +AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes") if test x"$embedded" = x"yes" then @@ -246,6 +261,7 @@ ENABLE_SYSLOG_LOGGING_DEFAULT="no" ENABLE_PANIC_INFLOOP_DEFAULT="yes" ENABLE_GNUTLS_DEFAULT="no" + AC_DEFINE([USE_NETNS],[0]) fi AC_ARG_ENABLE([uring], [AS_HELP_STRING([--disable-uring], [Build without io_uring support])], diff --git a/include/osmocom/core/netns.h b/include/osmocom/core/netns.h index 5bbf224..45ae614 100644 --- a/include/osmocom/core/netns.h +++ b/include/osmocom/core/netns.h @@ -2,9 +2,7 @@ * Network namespace convenience functions. */ #pragma once -#if (!EMBEDDED) - -#if defined(__linux__) +#if (USE_NETNS) #include <signal.h> @@ -18,7 +16,5 @@ int osmo_netns_switch_exit(struct osmo_netns_switch_state *state); -#endif /* defined(__linux__) */ - -#endif /* (!EMBEDDED) */ +#endif /* (USE_NETNS) */ /*! @} */ diff --git a/src/core/Makefile.am b/src/core/Makefile.am index f2cf138..6fdf893 100644 --- a/src/core/Makefile.am +++ b/src/core/Makefile.am @@ -74,13 +74,16 @@ timer.c \ timer_gettimeofday.c \ timer_clockgettime.c \ - tun.c \ use_count.c \ utils.c \ write_queue.c \ probes.d \ $(NULL) +if ENABLE_TUN +libosmocore_la_SOURCES += tun.c +endif + if HAVE_SSSE3 libosmocore_la_SOURCES += conv_acc_sse.c if HAVE_SSE4_1 diff --git a/src/core/socket.c b/src/core/socket.c index bb32185..2de4bb3 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -1695,7 +1695,7 @@ static unsigned int in6_addr_netmask_to_prefixlen(const struct in6_addr *netmask) { - #if defined(__linux__) + #if (HAVE_IN6_ADDR_S6_ADDR32) #define ADDRFIELD(i) s6_addr32[i] #else #define ADDRFIELD(i) __u6_addr.__u6_addr32[i] diff --git a/src/core/tun.c b/src/core/tun.c index 09a3f81..8234e4b 100644 --- a/src/core/tun.c +++ b/src/core/tun.c @@ -67,8 +67,6 @@ * osmo_tundev_free(tundev); */ -#if (!EMBEDDED) - #include <stdio.h> #include <stdlib.h> #include <stdio.h> @@ -584,6 +582,4 @@ } -#endif /* (!EMBEDDED) */ - /*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: contrib/jenkins_arm.sh: Remove explicit configure.sh disable args
by pespin 20 Jan '26

20 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41871?usp=email ) Change subject: contrib/jenkins_arm.sh: Remove explicit configure.sh disable args ...................................................................... contrib/jenkins_arm.sh: Remove explicit configure.sh disable args Since --enable-embedded was reworked in 9197c1ac176ab8aa33f82e059404dcd482577a31, it is no longer needed to pass those flags explicitly for proper checking, since --enable-embedded preset takes care of enabling/disabling them and do the related checks. Change-Id: Ie1f99305c198a4e164d54ce7090c9fc67e99a891 --- M contrib/jenkins_arm.sh 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/contrib/jenkins_arm.sh b/contrib/jenkins_arm.sh index a65bb67..1d72f2f 100755 --- a/contrib/jenkins_arm.sh +++ b/contrib/jenkins_arm.sh @@ -18,10 +18,6 @@ --enable-embedded \ --disable-doxygen \ --disable-shared \ - --disable-libsctp \ - --disable-libusb \ - --disable-libmnl \ - --disable-syslog-logging \ CFLAGS="-Os -ffunction-sections -fdata-sections -nostartfiles -nodefaultlibs $WERROR_FLAGS" $MAKE $PARALLEL_MAKE -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie1f99305c198a4e164d54ce7090c9fc67e99a891 Gerrit-Change-Number: 41871 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: Print SMSC in pySim-read.py
by dexter 20 Jan '26

20 Jan '26

Attention is currently required from: fixeria, phcoder. dexter has posted comments on this change by phcoder. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in pySim-read.py ...................................................................... Patch Set 15: Code-Review+1 Verified+1 (1 comment) Patchset: PS15: I have tried this out and it works fine. I have also set the EF.SMSP record 1 to all FF to see what happens. No problem, it just shows "SMSC: " I would suggest to indent the SMSC: output to make more clear that it is related to SMSP. (similar to SIM Service Table, there you have the hex string and below are the parsed results with an indentation. Maybe also print "SMSC: (none)" in case it is not set. In any case, those are just cosmetic suggestions. I think its ok the way it is and I don't want to block you. Also the output of pySim-read.py has some consistency issues here and there anyway. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 15 Gerrit-Owner: phcoder <phcoder(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: phcoder <phcoder(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jan 2026 10:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by Timur Davydov 20 Jan '26

20 Jan '26

Attention is currently required from: Timur Davydov, laforge, neels. Hello Jenkins Builder, fixeria, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Add Emscripten build support and JS callback logging backend This change enables building libosmocore for sandboxed, non-POSIX environments, specifically WebAssembly targets produced via the Emscripten toolchain. The broader motivation is to allow partial execution of selected Osmocom components in isolated runtime environments where direct access to hardware and traditional operating system facilities (filesystem, sockets, privileged execution) is not available. One intended use case is running a GSM 2G base station where the radio-facing components are executed inside a web environment, while the remaining Osmocom stack and core network components continue to run unchanged on a conventional backend server. In this model, highly stripped-down variants of osmo-bts and osmo-trx are built as static WebAssembly libraries and executed in the browser, while depending on core libraries such as libosmocore, libosmo-netif, and libosmo-abis. A practical advantage of this approach is that no deployment or privileged setup is required on the radio endpoint side. A user can instantiate a radio endpoint with minimal configuration, while all stateful logic and operational complexity remains centralized on the backend. Multiple such radio endpoints may connect to the same backend core network, effectively forming a single logical network from the core network perspective, independent of the physical location of the radio endpoints. Existing libosmocore build logic and platform assumptions rely on the availability of POSIX APIs and OS services which are not present in WebAssembly runtimes. This currently prevents libosmocore from being built for such targets without targeted, build-time adjustments. This patch introduces the minimal set of changes required to enable such builds, without affecting native platforms. As part of this groundwork, a minimal callback-based logging hook is introduced. When building for Emscripten, this hook allows forwarding log messages to an external environment via a user-provided JavaScript callback. This enables integration with browser-side logging or UI infrastructure without introducing new logging backends or runtime dependencies. For all other build targets, the hook resolves to a no-op implementation and does not alter existing logging behavior. No runtime behavior, protocol semantics, or network interactions are changed by this patch. All modifications are strictly limited to build-time and platform-specific code paths and are only active when targeting Emscripten. Native builds and existing deployment scenarios remain unaffected. This patch is intended as groundwork. Follow-up changes, proposed separately and incrementally, may extend similar support to other Osmocom components such as libosmo-netif, libosmo-abis, osmo-bts, and osmo-trx, while keeping all such changes optional and isolated from native builds. Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 --- M .gitignore M configure.ac M include/osmocom/core/logging.h M include/osmocom/core/netns.h M src/core/Makefile.am M src/core/libosmocore.map A src/core/logging_emscripten.c M src/core/netdev.c M src/core/osmo_io_internal.h M src/core/socket.c M src/core/stats_tcp.c M src/core/tun.c M src/vty/logging_vty.c 13 files changed, 206 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/41813/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 9 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in pysim[master]: pySim.apdu_source.stdin_hex
by dexter 20 Jan '26

20 Jan '26

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: I have tried this out. and fed it some APDUs (the testcases from current master, /tests/pySim-shell_test/apdu/test_apdu.script). Case 1-3 seem to work fine but when I enter 00a40004023f0000 (case 4) it seems to have problems. Leaving out the Le field also does not help. Here is what I tried: ./pySim-trace.py stdin-hex INFO root: Opening source stdin-hex... Detected UICC Add-on "SIM" Detected UICC Add-on "GSM-R" Detected UICC Add-on "RUIM" Can't read AIDs from SIM -- 'list' object has no attribute 'lower' warning: EF.DIR seems to be empty! ADF.ECASD: a0000005591010ffffffff8900000200 ADF.ISD-R: a0000005591010ffffffff8900000100 ISIM: a0000000871004 USIM: a0000000871002 INFO root: Entering main loop... C-APDU >00a40004023f0000 C-APDU > (nothing happens, so I just press enter...) Traceback (most recent call last): File "/home/user/work/git_master/pysim/./pySim-trace.py", line 220, in <module> tracer.main() File "/home/user/work/git_master/pysim/./pySim-trace.py", line 117, in main apdu = self.source.read() ^^^^^^^^^^^^^^^^^^ File "/home/user/work/git_master/pysim/pySim/apdu_source/__init__.py", line 23, in read r = self.read_packet() ^^^^^^^^^^^^^^^^^^ File "/home/user/work/git_master/pysim/pySim/apdu_source/stdin_hex.py", line 40, in read_packet return ApduCommands.parse_cmd_bytes(h2b(command) + h2b(response)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/work/git_master/pysim/pySim/apdu/__init__.py", line 405, in parse_cmd_bytes raise ValueError('Unknown CLA=%02X INS=%02X' % (cla, ins)) ValueError: Unknown CLA=90 INS=00 I also wonder what is with the responses? Those aren't intended to be analyzed?. Maybe I am just using it wrong. As I said, some more info in the commit message would be helpful. Commit Message: https://gerrit.osmocom.org/c/pysim/+/37925/comment/81eab98c_0a6648d1?usp=em… : PS1, Line 7: pySim.apdu_source.stdin_hex I think it would be good to write a sentence or two what this is patch is about and how it can be useful. I can see it is for pySim-trace, but I do not get the usecase. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jan 2026 10:25:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: less cluttered output for failed cmds
by osmith 20 Jan '26

20 Jan '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41868?usp=email ) Change subject: testenv: less cluttered output for failed cmds ...................................................................... testenv: less cluttered output for failed cmds The testenv.cmd.run() already prints the command to run at the start, prints the command output and blocks until the command is done. If the command fails, do not print the command again, and do not print a python stack trace. The reason for the failure is most likely in the output shown by the program itself (e.g. a prepare= script that failed). Make it easier for the user to spot this error by uncluttering the output. Change-Id: I508322b017e5ed9c21396384ef759a4c49c8d3da --- M _testenv/testenv/cmd.py 1 file changed, 4 insertions(+), 11 deletions(-) Approvals: osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index c14f694..bde0bf3 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -1,10 +1,11 @@ -# Copyright 2024 sysmocom - s.f.m.c. GmbH +# Copyright 2026 sysmocom - s.f.m.c. GmbH # SPDX-License-Identifier: GPL-3.0-or-later import logging import os import os.path import re import subprocess +import sys import testenv import testenv.testsuite @@ -79,15 +80,6 @@ env_extra["TESTENV_QEMU_SCRIPTS"] = os.path.join(testenv.data_dir, "scripts/qemu") -def exit_error_cmd(completed, error_msg): - """:param completed: return from run_cmd() below""" - - logging.error(error_msg) - logging.debug(f"Command: {completed.args}") - logging.debug(f"Returncode: {completed.returncode}") - raise RuntimeError("shell command related error, find details right above this python trace") - - def generate_env(env={}, podman=False): ret = dict(env_extra) path = os.path.join(testenv.data_dir, "scripts") @@ -139,4 +131,5 @@ if p.returncode == 0 or not check: return p - exit_error_cmd(p, "Command failed unexpectedly") + logging.error(f"Command failed unexpectedly (returncode: {p.returncode})") + sys.exit(1) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I508322b017e5ed9c21396384ef759a4c49c8d3da Gerrit-Change-Number: 41868 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026