January 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-pfcp[master]: Avoid marking rx PFCP Assoc Setup Req as duplicate
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/41876?usp=email ) Change subject: Avoid marking rx PFCP Assoc Setup Req as duplicate ...................................................................... Avoid marking rx PFCP Assoc Setup Req as duplicate Newer versions of PFCP spec state that "A PFCP function shall ignore the Recovery Timestamp received in the PFCP Association Setup Request message." Hence, there's no real way to make sure an incoming PFCP ASSOC SETUP REQ is a duplicate or is simply a new message from a new instance of the peer node which "decided" to use the same SeqNr as the previous one. In that case, it's better to be on the safe side and process it to tear down state rather than ignoring it and keeping old state. If it turns out to be a duplicate (rare scenario), we'd maybe tear down some stuff which would have been set up a few seconds ago. Change-Id: Ia461550e6791aaf00d18e0310bb4f17fdd2a3f65 --- M src/libosmo-pfcp/pfcp_endpoint.c 1 file changed, 24 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/76/41876/1 diff --git a/src/libosmo-pfcp/pfcp_endpoint.c b/src/libosmo-pfcp/pfcp_endpoint.c index 7c1058f..64ea347 100644 --- a/src/libosmo-pfcp/pfcp_endpoint.c +++ b/src/libosmo-pfcp/pfcp_endpoint.c @@ -161,8 +161,13 @@ return osmo_tdef_get(ep->cfg.tdefs, OSMO_PFCP_TIMER_T1, OSMO_TDEF_MS, -1); } -static unsigned int ep_keep_resp(struct osmo_pfcp_endpoint *ep) +static unsigned int ep_keep_resp(const struct osmo_pfcp_endpoint *ep, const struct osmo_pfcp_msg *m) { + /* Don't check for PFCP Assoc Setup Req duplicates: There's no way to + * differentiate a duplicate from a new instance of a CP peer which chooses + * (willingly or randomly) after restart the same Sequence Number as in previous run. */ + if (m->h.message_type == OSMO_PFCP_MSGT_ASSOC_SETUP_REQ) + return 0; return osmo_tdef_get(ep->cfg.tdefs, OSMO_PFCP_TIMER_KEEP_RESP, OSMO_TDEF_MS, -1); } @@ -271,18 +276,23 @@ static int osmo_pfcp_endpoint_retrans_queue_add(struct osmo_pfcp_endpoint *endpoint, struct osmo_pfcp_msg *m) { struct osmo_pfcp_queue_entry *qe; - unsigned int n1 = ep_n1(endpoint); - unsigned int t1_ms = ep_t1(endpoint); - unsigned int keep_resp_ms = ep_keep_resp(endpoint); - unsigned int timeout = m->is_response ? keep_resp_ms : t1_ms; + unsigned int timeout_ms; + unsigned int n1 = 0; - LOGP(DLPFCP, LOGL_DEBUG, "retransmit unanswered Requests %u x %ums; keep sent Responses for %ums\n", - n1, t1_ms, keep_resp_ms); - /* If there are no retransmissions or no timeout, it makes no sense to add to the queue. */ - if (!n1 || !t1_ms) { - if (!m->is_response && m->ctx.resp_cb) - m->ctx.resp_cb(m, NULL, "PFCP timeout is zero, cannot wait for a response"); - return 0; + if (m->is_response) { + timeout_ms = ep_keep_resp(endpoint, m); + OSMO_LOG_PFCP_MSG(m, LOGL_DEBUG, "keep sent Responses for %ums\n", timeout_ms); + } else { + timeout_ms = ep_t1(endpoint); + n1 = ep_n1(endpoint); + + OSMO_LOG_PFCP_MSG(m, LOGL_DEBUG, "retransmit unanswered Requests %u x %ums\n", n1, timeout_ms); + /* If there are no retransmissions or no timeout, it makes no sense to add to the queue. */ + if (!n1 || !timeout_ms) { + if (!m->is_response && m->ctx.resp_cb) + m->ctx.resp_cb(m, NULL, "PFCP timeout is zero, cannot wait for a response"); + return 0; + } } qe = talloc(endpoint, struct osmo_pfcp_queue_entry); @@ -290,7 +300,7 @@ *qe = (struct osmo_pfcp_queue_entry){ .ep = endpoint, .m = m, - .n1_remaining = m->is_response ? 0 : n1, + .n1_remaining = n1, }; talloc_steal(qe, m); @@ -308,7 +318,7 @@ } talloc_set_destructor(qe, osmo_pfcp_queue_destructor); - osmo_timer_schedule(&qe->t1, timeout/1000, (timeout % 1000) * 1000); + osmo_timer_schedule(&qe->t1, timeout_ms/1000, (timeout_ms % 1000) * 1000); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/41876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ia461550e6791aaf00d18e0310bb4f17fdd2a3f65 Gerrit-Change-Number: 41876 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in pysim[master]: esim/http_json_api: extend JSON API with server functionality
by Jenkins Builder 20 Jan '26

20 Jan '26

Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41874?usp=email ) Change subject: esim/http_json_api: extend JSON API with server functionality ...................................................................... Patch Set 1: (1 comment) File pySim/esim/http_json_api.py: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/pysim/+/41874/comment/9012bc16_e34d679f?usp=em… : PS1, Line 375: encoded JSON string (HTTP response code and headers are set by calling the apropriate methods on the 'apropriate' may be misspelled - perhaps 'appropriate'? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I277aa90fddb5171c4bf6c3436259aa371d30d092 Gerrit-Change-Number: 41874 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 19 Jan 2026 17:08:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: contrib: add utility to receive ES2+handleDownloadProgressInfo calls
by dexter 20 Jan '26

20 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41875?usp=email ) Change subject: contrib: add utility to receive ES2+handleDownloadProgressInfo calls ...................................................................... contrib: add utility to receive ES2+handleDownloadProgressInfo calls We already have a tool to work with the ES2+ API provided by an SMDP+ (es2p_client.py) With this tool we can only make API calls towards an SMDP+. However, SGP.22 also defines a "reverse direction" ES2+ interface through wich the SMDP+ may make API calls towards the MNO. At the moment the only possible MNO originated API call is ES2+handleDownloadProgressInfo. Let's add a simple tool that runs a HTTP server to receive and log the ES2+handleDownloadProgressInfo requests. Related: SYS#7825 Change-Id: I95af30cebae31f7dc682617b1866f4a2dc9b760c --- A contrib/es2p_server.py 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/41875/1 diff --git a/contrib/es2p_server.py b/contrib/es2p_server.py new file mode 100755 index 0000000..435d4f1 --- /dev/null +++ b/contrib/es2p_server.py @@ -0,0 +1,47 @@ +#!/usr/bin/env python3 + +# (C) 2026 by sysmocom - s.f.m.c. GmbH +# All Rights Reserved +# +# Author: Philipp Maier +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU Affero General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU Affero General Public License for more details. +# +# You should have received a copy of the GNU Affero General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +import sys +import argparse +import logging +from pySim.esim.es2p import param, Es2pApiServer, Es2pApiServerHandler + +logger = logging.getLogger(__name__) + +parser = argparse.ArgumentParser(description=""" +Utility to receive and log requests against the ES2+ API of an SM-DP+ according to GSMA SGP.22.""") +parser.add_argument('--server-cert', help='X.509 server certificate used to provide the ES2+ HTTPs service') +parser.add_argument('--client-ca-cert', help='X.509 CA certificates to authenticate the requesting client(s)') +parser.add_argument("-v", "--verbose", help="enable debug output", action='store_true', default=False) + +class Es2pApiServerHandlerForLogging(Es2pApiServerHandler): + def call_handleDownloadProgressInfo(self, data: dict) -> (dict, str): + logging.info("ES2+:handleDownloadProgressInfo: %s" % str(data)) + return {}, None + +if __name__ == "__main__": + args = parser.parse_args() + + logging.basicConfig(level=logging.DEBUG if args.verbose else logging.WARNING, + format='%(asctime)s %(levelname)s %(message)s', + datefmt='%Y-%m-%d %H:%M:%S') + + Es2pApiServer(8030, "127.0.0.1", Es2pApiServerHandlerForLogging(), args.server_cert, args.client_ca_cert) + -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95af30cebae31f7dc682617b1866f4a2dc9b760c Gerrit-Change-Number: 41875 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: esim/http_json_api: add missing check
by dexter 20 Jan '26

20 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41873?usp=email ) Change subject: esim/http_json_api: add missing check ...................................................................... esim/http_json_api: add missing check The line actual_sec = func_ex_status.get('statusCodeData', None) suggests that 'statusCodeData' may be None under normal circumstances. So let's guard sec.update(actual_sec) so that we won't run into an exception in case 'statusCodeData' is not in func_ex_status. Related: SYS#7825 Change-Id: I8a1a3cd5e029dba4a3aec1a64702e19b0d694ae2 --- M pySim/esim/http_json_api.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/41873/1 diff --git a/pySim/esim/http_json_api.py b/pySim/esim/http_json_api.py index 8324bb9..bb41df3 100644 --- a/pySim/esim/http_json_api.py +++ b/pySim/esim/http_json_api.py @@ -149,7 +149,8 @@ 'message': None, } actual_sec = func_ex_status.get('statusCodeData', None) - sec.update(actual_sec) + if actual_sec: + sec.update(actual_sec) self.subject_code = sec['subjectCode'] self.reason_code = sec['reasonCode'] self.subject_id = sec['subjectIdentifier'] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8a1a3cd5e029dba4a3aec1a64702e19b0d694ae2 Gerrit-Change-Number: 41873 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: esim/http_json_api: extend JSON API with server functionality
by dexter 20 Jan '26

20 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41874?usp=email ) Change subject: esim/http_json_api: extend JSON API with server functionality ...................................................................... esim/http_json_api: extend JSON API with server functionality At the moment http_json_api only supports the client role. Let's also add support for the server role. This patch refactors the existing client code. This in particular means that the following preperations have to be made: - To use the existing JsonHttpApiFunction definitions in the client and server the scheme has to be symetric. It already is for the most part, but it treads the header field differently. So let's just tread the header field like any other mandatory field and add it input_params. (this does not affect the es9p.py code since in ES9+ the requests have no header messages, see also SGP.22, section 6.5.1.1) - The JsonHttpApiFunction class currently also has the code to perform the client requests. Let's seperate that code in a JsonHttpApiClient class to which we pass an JsonHttpApiFunction object. - The code that does the encoding and decoding in the client role has lots of conditions the tread the header differently. Let's do the decisions about the header in the JsonHttpApiClient. The encoder and decoder function should do the generic encoding and decoding only. (however, some generic header specific conditions will remain). The code for the server role logically mirrors the code for the client role. We add a JsonHttpApiServer class that can be used to create API endpoints. The API user has to pass in a call_handler through which the application logic is defined. Above that we add an Es2pApiServer class in es2p. In this class we implement the logic that runs the HTTP server and receives the requests. The Es2pApiServer supports all ES2+ functions defined by GSMA SGP.22. The user may use the provided Es2pApiServerHandler base class to define the application logic for each ES2+ function. Related: SYS#7825 Change-Id: I277aa90fddb5171c4bf6c3436259aa371d30d092 --- M pySim/esim/es2p.py M pySim/esim/http_json_api.py 2 files changed, 293 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/74/41874/1 diff --git a/pySim/esim/es2p.py b/pySim/esim/es2p.py index b917b47..9aa1764 100644 --- a/pySim/esim/es2p.py +++ b/pySim/esim/es2p.py @@ -16,6 +16,12 @@ # along with this program. If not, see <http://www.gnu.org/licenses/>. import requests +from klein import Klein +from twisted.internet import defer, protocol, ssl, task, endpoints, reactor +from twisted.internet.posixbase import PosixReactorBase +from pathlib import Path +from twisted.web.server import Site, Request + import logging from datetime import datetime import time @@ -123,10 +129,12 @@ class DownloadOrder(Es2PlusApiFunction): path = '/gsma/rsp2/es2plus/downloadOrder' input_params = { + 'header': JsonRequestHeader, 'eid': param.Eid, 'iccid': param.Iccid, 'profileType': param.ProfileType } + input_mandatory = ['header'] output_params = { 'header': JsonResponseHeader, 'iccid': param.Iccid, @@ -137,6 +145,7 @@ class ConfirmOrder(Es2PlusApiFunction): path = '/gsma/rsp2/es2plus/confirmOrder' input_params = { + 'header': JsonRequestHeader, 'iccid': param.Iccid, 'eid': param.Eid, 'matchingId': param.MatchingId, @@ -144,7 +153,7 @@ 'smdsAddress': param.SmdsAddress, 'releaseFlag': param.ReleaseFlag, } - input_mandatory = ['iccid', 'releaseFlag'] + input_mandatory = ['header', 'iccid', 'releaseFlag'] output_params = { 'header': JsonResponseHeader, 'eid': param.Eid, @@ -157,12 +166,13 @@ class CancelOrder(Es2PlusApiFunction): path = '/gsma/rsp2/es2plus/cancelOrder' input_params = { + 'header': JsonRequestHeader, 'iccid': param.Iccid, 'eid': param.Eid, 'matchingId': param.MatchingId, 'finalProfileStatusIndicator': param.FinalProfileStatusIndicator, } - input_mandatory = ['finalProfileStatusIndicator', 'iccid'] + input_mandatory = ['header', 'finalProfileStatusIndicator', 'iccid'] output_params = { 'header': JsonResponseHeader, } @@ -172,9 +182,10 @@ class ReleaseProfile(Es2PlusApiFunction): path = '/gsma/rsp2/es2plus/releaseProfile' input_params = { + 'header': JsonRequestHeader, 'iccid': param.Iccid, } - input_mandatory = ['iccid'] + input_mandatory = ['header', 'iccid'] output_params = { 'header': JsonResponseHeader, } @@ -184,6 +195,7 @@ class HandleDownloadProgressInfo(Es2PlusApiFunction): path = '/gsma/rsp2/es2plus/handleDownloadProgressInfo' input_params = { + 'header': JsonRequestHeader, 'eid': param.Eid, 'iccid': param.Iccid, 'profileType': param.ProfileType, @@ -192,10 +204,9 @@ 'notificationPointStatus': param.NotificationPointStatus, 'resultData': param.ResultData, } - input_mandatory = ['iccid', 'profileType', 'timestamp', 'notificationPointId', 'notificationPointStatus'] + input_mandatory = ['header', 'iccid', 'profileType', 'timestamp', 'notificationPointId', 'notificationPointStatus'] expected_http_status = 204 - class Es2pApiClient: """Main class representing a full ES2+ API client. Has one method for each API function.""" def __init__(self, url_prefix:str, func_req_id:str, server_cert_verify: str = None, client_cert: str = None): @@ -206,18 +217,17 @@ if client_cert: self.session.cert = client_cert - self.downloadOrder = DownloadOrder(url_prefix, func_req_id, self.session) - self.confirmOrder = ConfirmOrder(url_prefix, func_req_id, self.session) - self.cancelOrder = CancelOrder(url_prefix, func_req_id, self.session) - self.releaseProfile = ReleaseProfile(url_prefix, func_req_id, self.session) - self.handleDownloadProgressInfo = HandleDownloadProgressInfo(url_prefix, func_req_id, self.session) + self.downloadOrder = JsonHttpApiClient(DownloadOrder(), url_prefix, func_req_id, self.session) + self.confirmOrder = JsonHttpApiClient(ConfirmOrder(), url_prefix, func_req_id, self.session) + self.cancelOrder = JsonHttpApiClient(CancelOrder(), url_prefix, func_req_id, self.session) + self.releaseProfile = JsonHttpApiClient(ReleaseProfile(), url_prefix, func_req_id, self.session) + self.handleDownloadProgressInfo = JsonHttpApiClient(HandleDownloadProgressInfo(), url_prefix, func_req_id, self.session) def _gen_func_id(self) -> str: """Generate the next function call id.""" self.func_id += 1 return 'FCI-%u-%u' % (time.time(), self.func_id) - def call_downloadOrder(self, data: dict) -> dict: """Perform ES2+ DownloadOrder function (SGP.22 section 5.3.1).""" return self.downloadOrder.call(data, self._gen_func_id()) @@ -237,3 +247,93 @@ def call_handleDownloadProgressInfo(self, data: dict) -> dict: """Perform ES2+ HandleDownloadProgressInfo function (SGP.22 section 5.3.5).""" return self.handleDownloadProgressInfo.call(data, self._gen_func_id()) + +class Es2pApiServerHandler(): + """ES2+ API Server handler class. The API user is expected to override the contained methods as needed.""" + + def call_downloadOrder(self, data: dict) -> (dict, str): + """Perform ES2+ DownloadOrder function (SGP.22 section 5.3.1).""" + return {}, 'Failed' + + def call_confirmOrder(self, data: dict) -> (dict, str): + """Perform ES2+ ConfirmOrder function (SGP.22 section 5.3.2).""" + return {}, 'Failed' + + def call_cancelOrder(self, data: dict) -> (dict, str): + """Perform ES2+ CancelOrder function (SGP.22 section 5.3.3).""" + return {}, 'Failed' + + def call_releaseProfile(self, data: dict) -> (dict, str): + """Perform ES2+ CancelOrder function (SGP.22 section 5.3.4).""" + return {}, 'Failed' + + def call_handleDownloadProgressInfo(self, data: dict) -> (dict, str): + """Perform ES2+ HandleDownloadProgressInfo function (SGP.22 section 5.3.5).""" + return {}, 'Failed' + +class Es2pApiServer: + """Main class representing a full ES2+ API server. Has one method for each API function.""" + app = Klein() + + def __init__(self, port: int, interface: str, handler: Es2pApiServerHandler, + server_cert: str = None, client_cert_verify: str = None): + logger.debug("HTTP SRV: starting ES2+ API server on %s:%s" % (interface, port)) + + self.port = port + self.interface = interface + self.handler = handler + if server_cert: + self.server_cert = ssl.PrivateCertificate.loadPEM(Path(server_cert).read_text()) + else: + self.server_cert = None + if client_cert_verify: + self.client_cert_verify = ssl.Certificate.loadPEM(Path(client_cert_verify).read_text()) + else: + self.client_cert_verify = None + + self.downloadOrder = JsonHttpApiServer(DownloadOrder(), handler.call_downloadOrder) + self.confirmOrder = JsonHttpApiServer(ConfirmOrder(), handler.call_confirmOrder) + self.cancelOrder = JsonHttpApiServer(CancelOrder(), handler.call_cancelOrder) + self.releaseProfile = JsonHttpApiServer(ReleaseProfile(), handler.call_releaseProfile) + self.handleDownloadProgressInfo = JsonHttpApiServer(HandleDownloadProgressInfo(), + handler.call_handleDownloadProgressInfo) + + task.react(self.reactor) + + def reactor(self, reactor: PosixReactorBase): + logger.debug("HTTP SRV: listen on %s:%s" % (self.interface, self.port)) + if self.server_cert: + if self.client_cert_verify: + reactor.listenSSL(self.port, Site(self.app.resource()), self.server_cert.options(self.client_cert_verify), + interface=self.interface) + else: + reactor.listenSSL(self.port, Site(self.app.resource()), self.server_cert.options(), + interface=self.interface) + else: + reactor.listenTCP(self.port, Site(self.app.resource()), interface=self.interface) + return defer.Deferred() + + @app.route(DownloadOrder.path) + def call_downloadOrder(self, request: Request) -> dict: + """Perform ES2+ DownloadOrder function (SGP.22 section 5.3.1).""" + return self.downloadOrder.call(request) + + @app.route(ConfirmOrder.path) + def call_confirmOrder(self, request: Request) -> dict: + """Perform ES2+ ConfirmOrder function (SGP.22 section 5.3.2).""" + return self.confirmOrder.call(request) + + @app.route(CancelOrder.path) + def call_cancelOrder(self, request: Request) -> dict: + """Perform ES2+ CancelOrder function (SGP.22 section 5.3.3).""" + return self.cancelOrder.call(request) + + @app.route(ReleaseProfile.path) + def call_releaseProfile(self, request: Request) -> dict: + """Perform ES2+ CancelOrder function (SGP.22 section 5.3.4).""" + return self.releaseProfile.call(request) + + @app.route(HandleDownloadProgressInfo.path) + def call_handleDownloadProgressInfo(self, request: Request) -> dict: + """Perform ES2+ HandleDownloadProgressInfo function (SGP.22 section 5.3.5).""" + return self.handleDownloadProgressInfo.call(request) diff --git a/pySim/esim/http_json_api.py b/pySim/esim/http_json_api.py index bb41df3..1081f91 100644 --- a/pySim/esim/http_json_api.py +++ b/pySim/esim/http_json_api.py @@ -21,6 +21,8 @@ import json from typing import Optional import base64 +from twisted.web.server import Request + logger = logging.getLogger(__name__) logger.setLevel(logging.DEBUG) @@ -131,6 +133,16 @@ if status not in ['Executed-Success', 'Executed-WithWarning', 'Failed', 'Expired']: raise ValueError('Unknown/unspecified status "%s"' % status) +class JsonRequestHeader(ApiParam): + """SGP.22 section 6.5.1.3.""" + @classmethod + def verify_decoded(cls, data): + func_req_id = data.get('functionRequesterIdentifier') + if not func_req_id: + raise ValueError('Missing mandatory functionRequesterIdentifier in header') + func_call_id = data.get('functionCallIdentifier') + if not func_call_id: + raise ValueError('Missing mandatory functionCallIdentifier in header') class HttpStatusError(Exception): pass @@ -161,36 +173,46 @@ class JsonHttpApiFunction(abc.ABC): """Base class for representing an HTTP[s] API Function.""" - # the below class variables are expected to be overridden in derived classes + # The below class variables are used to describe the properties of the API function. Derived classes are expected + # to orverride those class properties with useful values. The prefixes "input_" and "output_" refer to the API + # function from an abstract point of view. Seen from the client perspective, "input_" will refer to parameters the + # client sends to a HTTP server. Seen from the server perspective, "input_" will refer to parameters the server + # receives from the a requesting client. The same applies vice versa to class variables that have an "output_" + # prefix. + # path of the API function (e.g. '/gsma/rsp2/es2plus/confirmOrder') path = None + # dictionary of input parameters. key is parameter name, value is ApiParam class input_params = {} + # list of mandatory input parameters input_mandatory = [] + # dictionary of output parameters. key is parameter name, value is ApiParam class output_params = {} + # list of mandatory output parameters (for successful response) output_mandatory = [] + + # list of mandatory output parameters (for failed response) + output_mandatory_failed = [] + # expected HTTP status code of the response expected_http_status = 200 + # the HTTP method used (GET, OPTIONS, HEAD, POST, PUT, PATCH or DELETE) http_method = 'POST' + + # additional custom HTTP headers (client requests) extra_http_req_headers = {} - def __init__(self, url_prefix: str, func_req_id: Optional[str], session: requests.Session): - self.url_prefix = url_prefix - self.func_req_id = func_req_id - self.session = session + # additional custom HTTP headers (server responses) + extra_http_res_headers = {} - def encode(self, data: dict, func_call_id: Optional[str] = None) -> dict: + def encode_client(self, data: dict) -> dict: """Validate an encode input dict into JSON-serializable dict for request body.""" output = {} - if func_call_id: - output['header'] = { - 'functionRequesterIdentifier': self.func_req_id, - 'functionCallIdentifier': func_call_id - } for p in self.input_mandatory: if not p in data: @@ -204,22 +226,19 @@ output[p] = p_class.encode(v) return output - def decode(self, data: dict) -> dict: + def decode_client(self, data: dict) -> dict: """[further] Decode and validate the JSON-Dict of the response body.""" output = {} - if 'header' in self.output_params: - # let's first do the header, it's special - if not 'header' in data: - raise ValueError('Mandatory output parameter "header" missing') - hdr_class = self.output_params.get('header') - output['header'] = hdr_class.decode(data['header']) + output_mandatory = self.output_mandatory - if output['header']['functionExecutionStatus']['status'] not in ['Executed-Success','Executed-WithWarning']: - raise ApiError(output['header']['functionExecutionStatus']) - # we can only expect mandatory parameters to be present in case of successful execution - for p in self.output_mandatory: - if p == 'header': - continue + # In case a provided header (may be optional) indicates that the API function call was unsuccessful, a + # different set of mandatory parameters applies. + header = data.get('header') + if header: + if data['header']['functionExecutionStatus']['status'] not in ['Executed-Success','Executed-WithWarning']: + output_mandatory = self.output_mandatory_failed + + for p in output_mandatory: if not p in data: raise ValueError('Mandatory output parameter "%s" missing' % p) for p, v in data.items(): @@ -231,30 +250,160 @@ output[p] = p_class.decode(v) return output + def encode_server(self, data: dict) -> dict: + """Validate an encode input dict into JSON-serializable dict for response body.""" + output = {} + output_mandatory = self.output_mandatory + + # In case a provided header (may be optional) indicates that the API function call was unsuccessful, a + # different set of mandatory parameters applies. + header = data.get('header') + if header: + if data['header']['functionExecutionStatus']['status'] not in ['Executed-Success','Executed-WithWarning']: + output_mandatory = self.output_mandatory_failed + + for p in output_mandatory: + if not p in data: + raise ValueError('Mandatory output parameter %s missing' % p) + for p, v in data.items(): + p_class = self.output_params.get(p) + if not p_class: + logger.warning('Unexpected/unsupported output parameter %s=%s', p, v) + output[p] = v + else: + output[p] = p_class.encode(v) + return output + + def decode_server(self, data: dict) -> dict: + """[further] Decode and validate the JSON-Dict of the request body.""" + output = {} + + for p in self.input_mandatory: + if not p in data: + raise ValueError('Mandatory input parameter "%s" missing' % p) + for p, v in data.items(): + p_class = self.input_params.get(p) + if not p_class: + logger.warning('Unexpected/unsupported input parameter "%s"="%s"', p, v) + output[p] = v + else: + output[p] = p_class.decode(v) + return output + +class JsonHttpApiClient(): + def __init__(self, api_func: JsonHttpApiFunction, url_prefix: str, func_req_id: Optional[str], + session: requests.Session): + self.api_func = api_func + self.url_prefix = url_prefix + self.func_req_id = func_req_id + self.session = session + def call(self, data: dict, func_call_id: Optional[str] = None, timeout=10) -> Optional[dict]: - """Make an API call to the HTTP API endpoint represented by this object. - Input data is passed in `data` as json-serializable dict. Output data - is returned as json-deserialized dict.""" - url = self.url_prefix + self.path - encoded = json.dumps(self.encode(data, func_call_id)) + """Make an API call to the HTTP API endpoint represented by this object. Input data is passed in `data` as + json-serializable dict. Output data is returned as json-deserialized dict.""" + + # In case a function caller ID is supplied, use it together with the stored function requestor ID to generate + # and prepend the header field according to SGP.22, section 6.5.1.1 and 6.5.1.3. (the presence of the header + # field is checked by the encode_client method) + if func_call_id: + data = {'header' : {'functionRequesterIdentifier': self.func_req_id, + 'functionCallIdentifier': func_call_id}} | data + + # Encode the message (the presence of mandatory fields is checked during encoding) + encoded = json.dumps(self.api_func.encode_client(data)) + + # Apply HTTP request headers according to SGP.22, section 6.5.1 req_headers = { 'Content-Type': 'application/json', 'X-Admin-Protocol': 'gsma/rsp/v2.5.0', } - req_headers.update(self.extra_http_req_headers) + req_headers.update(self.api_func.extra_http_req_headers) + # Perform HTTP request + url = self.url_prefix + self.api_func.path logger.debug("HTTP REQ %s - hdr: %s '%s'" % (url, req_headers, encoded)) - response = self.session.request(self.http_method, url, data=encoded, headers=req_headers, timeout=timeout) + response = self.session.request(self.api_func.http_method, url, data=encoded, headers=req_headers, timeout=timeout) logger.debug("HTTP RSP-STS: [%u] hdr: %s" % (response.status_code, response.headers)) logger.debug("HTTP RSP: %s" % (response.content)) - if response.status_code != self.expected_http_status: + # Check HTTP response status code and make sure that the returned HTTP headers look plausible (according to + # SGP.22, section 6.5.1) + if response.status_code != self.api_func.expected_http_status: raise HttpStatusError(response) if not response.headers.get('Content-Type').startswith(req_headers['Content-Type']): raise HttpHeaderError(response) if not response.headers.get('X-Admin-Protocol', 'gsma/rsp/v2.unknown').startswith('gsma/rsp/v2.'): raise HttpHeaderError(response) + # Decode response and return the result back to the caller if response.content: - return self.decode(response.json()) + output = self.api_func.decode_client(response.json()) + # In case the response contains a header, check it to make sure that the API call was executed successfully + # (the presence of the header field is checked by the decode_client method) + if 'header' in output: + if output['header']['functionExecutionStatus']['status'] not in ['Executed-Success','Executed-WithWarning']: + raise ApiError(output['header']['functionExecutionStatus']) + return output return None + +class JsonHttpApiServer(): + def __init__(self, api_func: JsonHttpApiFunction, call_handler = None): + """ + Args: + api_func : API function definition (JsonHttpApiFunction) + call_handler : handler function to process the request. This function must accept the + decoded request as a dictionary. The handler function must return a tuple consisting + of the response in the form of a dictionary (may be empty), and a function execution + status string ('Executed-Success', 'Executed-WithWarning', 'Failed' or 'Expired') + """ + self.api_func = api_func + if call_handler: + self.call_handler = call_handler + else: + self.call_handler = self.default_handler + + def default_handler(self, data: dict) -> (dict, str): + """default handler, used in case no call handler is provided.""" + logger.error("no handler function for request: %s" % str(data)) + return {}, 'Failed' + + def call(self, request: Request) -> str: + """ Process an incoming request. + Args: + request : request object as received using twisted.web.server + Returns: + encoded JSON string (HTTP response code and headers are set by calling the apropriate methods on the + provided the request object) + """ + + # Make sure the request is done with the correct HTTP method + if (request.method.decode() != self.api_func.http_method): + raise ValueError('Wrong HTTP method %s!=%s' % (request.method.decode(), self.api_func.http_method)) + + # Decode the request + decoded_request = self.api_func.decode_server(json.loads(request.content.read())) + + # Run call handler (see above) + data, fe_status = self.call_handler(decoded_request) + + # In case a function execution status is returned, use it to generate and prepend the header field according to + # SGP.22, section 6.5.1.2 and 6.5.1.4 (the presence of the header filed is checked by the encode_server method) + if fe_status: + data = {'header' : {'functionExecutionStatus': {'status' : fe_status}}} | data + + # Encode the message (the presence of mandatory fields is checked during encoding) + encoded = json.dumps(self.api_func.encode_server(data)) + + # Apply HTTP request headers according to SGP.22, section 6.5.1 + res_headers = { + 'Content-Type': 'application/json', + 'X-Admin-Protocol': 'gsma/rsp/v2.5.0', + } + res_headers.update(self.api_func.extra_http_res_headers) + for header, value in res_headers.items(): + request.setHeader(header, value) + request.setResponseCode(self.api_func.expected_http_status) + + # Return the encoded result back to the caller for sending (using twisted/klein) + return encoded + -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I277aa90fddb5171c4bf6c3436259aa371d30d092 Gerrit-Change-Number: 41874 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: Increase T3101 in osmo-bsc.cfg
by pespin 20 Jan '26

20 Jan '26

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41872?usp=email ) Change subject: bsc: Increase T3101 in osmo-bsc.cfg ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Sporadic failure due to crazy delays can be seen more clearly in ttcn3-bsc-test-latest run #2674 TC_mscpool_L3Compl_on_1_msc. See how CTRL GET msg is sent over IPA_CTRL_PORT and it takes >2s for the component to read from IPA_CTRL_PORT (and hence timeout waiting for answer fails, because it didn't even get time to transmit the request...): 13:20:55.938375 9884 Osmocom_CTRL_Functions.ttcn:38 Sent on IPA_CTRL to IPA-CTRL-CLI-IPA(2336) @Osmocom_CTRL_Types.CtrlMessage : { cmd := { verb := "GET", id := "523358685", variable := "rate_ctr.abs.msc.0.mscpool:subscr:new", val := omit } } 13:20:55.938791 9884 Osmocom_CTRL_Functions.ttcn:39 Start timer T: 2 s 13:20:55.938942 25043 IPA_Emulation.ttcnpp:772 Message enqueued on IPA_CTRL_PORT from mtc @Osmocom_CTRL_Types.CtrlMessage : { cmd := { verb := "GET", id := "523358685", variable := "rate_ctr.abs.msc.0.mscpool:subscr:new", val := omit } } id 4 13:20:56.997081 25042 M3UA_Emulation.ttcn:887 Timeout T_ASPUP_resend: 2 s 13:20:57.938977 9884 Osmocom_CTRL_Functions.ttcn:52 Timeout T: 2 s 13:20:57.939751 9884 Misc_Helpers.ttcn:35 setverdict(fail): none -> fail reason: ""Osmocom_CTRL_Functions.ttcn:53 : Timeout waiting for CTRL GET REPLY \"rate_ctr.abs.msc.0.mscpool:subscr:new\""", new component reason: ""Osmocom_CTRL_Functions.ttcn:53 : Timeout waiting for CTRL GET REPLY \"rate_ctr.abs.msc.0.mscpool:subscr:new\""" 13:20:57.940065 9884 Misc_Helpers.ttcn:38 Stopping testcase execution from "Osmocom_CTRL_Functions.ttcn":53 13:20:57.940483 9884 Misc_Helpers.ttcn:43 Stopping all components. ... 13:20:58.093877 25042 M3UA_Emulation.ttcn:907 Timeout T_ASPAC_resend: 2 s 13:20:58.093923 25043 IPA_Emulation.ttcnpp:921 Receive operation on port IPA_CTRL_PORT succeeded, message from mtc: @Osmocom_CTRL_Types.CtrlMessage : { cmd := { verb := "GET", id := "523358685", variable := "rate_ctr.abs.msc.0.mscpool:subscr:new", val := omit } } id 4 13:20:58.094122 25043 IPA_Emulation.ttcnpp:921 Message with id 4 was extracted from the queue of IPA_CTRL_PORT. 13:20:58.094154 25042 M3UA_Emulation.ttcn:922 Start timer T_ASPAC_resend: 2 s 13:20:58.094339 25043 IPA_Emulation.ttcnpp:922 enc_CtrlMessage(): Encoding @Osmocom_CTRL_Types.CtrlMessage: { cmd := { verb := "GET", id := "523358685", variable := "rate_ctr.abs.msc.0.mscpool:subscr:new", val := omit } }#3106#3106#3106 TC_mscpool_L3Compl_on_1_msc -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90f4bded452c33dab343b20fc4b209520991ea84 Gerrit-Change-Number: 41872 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 16:28:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: Increase T3101 in osmo-bsc.cfg
by pespin 20 Jan '26

20 Jan '26

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41872?usp=email to look at the new patch set (#2). Change subject: bsc: Increase T3101 in osmo-bsc.cfg ...................................................................... bsc: Increase T3101 in osmo-bsc.cfg Test BSC_Tests.TC_ho_during_lcs_loc_req sporadically failed due to ttcn3 taking >2s to transmit the Handover Complete and T3101 (3s by default) firing before receiving it. Increase it to give some more room and avoid sporadic failures. See how 2nd RSL1.send() in as_handover() is delayed for >2s: """ 09:50:39.134962 27946 MSC_ConnectionHandler.ttcn:1737 Sent on RSL1 to IPA-BTS1-TRX0-RSL-RSL(2945) @RSL_Types.RSL_Message : { msg_disc := { msg_group := RSL_MDISC_DCHAN (4), transparent := false }, msg_type := RSL_MT_HANDO_DET (39), ies := { { iei := RSL_IE_CHAN_NR (1), body := { chan_nr := { u := { sdcch4 := { tag := '001'B, sub_chan := 0 } }, tn := 0 } } } } } ... 09:50:39.135037 27946 Osmocom_Types.ttcn:126 Start timer T: 0.3 s 09:50:39.435079 27946 Osmocom_Types.ttcn:127 Timeout T: 0.3 s 09:50:39.718007 27937 M3UA_Emulation.ttcn:887 Timeout T_ASPUP_resend: 2 s 09:50:42.131009 27943 IPA_Emulation.ttcnpp:772 Message enqueued on IPA_PORT from system @IPL4asp_Types.ASP_RecvFrom : { connId := 1, remName := "127.0.0.1", remPort := 3003, locName := "127.0.0.1", locPort := 11000, proto := { tcp := { } }, userData := 0, msg := '00040008250120'O } id 17 09:50:42.188991 27946 MSC_ConnectionHandler.ttcn:1742 enc_PDU_ML3_MS_NW(): Encoding @MobileL3_Types.PDU_ML3_MS_NW: { discriminator := '0000'B, tiOrSkip := { skipIndicator := '0000'B }, msgs := { rrm := { handoverComplete := { messageType := '00101100'B, rRCause := { valuePart := '00'O }, mobileObsservedTimeDiff := omit, mobileTimeDifferenceHyperframe := omit } } } } """ Change-Id: I90f4bded452c33dab343b20fc4b209520991ea84 --- M bsc/osmo-bsc.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/41872/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90f4bded452c33dab343b20fc4b209520991ea84 Gerrit-Change-Number: 41872 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: Print SMSC in pySim-read.py
by phcoder 20 Jan '26

20 Jan '26

Attention is currently required from: dexter, fixeria, laforge. phcoder has posted comments on this change by phcoder. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in pySim-read.py ...................................................................... Patch Set 15: (1 comment) File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/41786/comment/2b9c712b_ea9c3c5b?usp=em… : PS14, Line 148: smsc_a.get('ton_npi', None).get > `smsc_a.get()` may return `None`, resulting in an exception: […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 15 Gerrit-Owner: phcoder <phcoder(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Jan 2026 16:20:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: Increase T3101 in osmo-bsc.cfg
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41872?usp=email ) Change subject: bsc: Increase T3101 in osmo-bsc.cfg ...................................................................... bsc: Increase T3101 in osmo-bsc.cfg Test BSC_Tests.TC_ho_during_lcs_loc_req sporafically failed due to ttcn3 taking >2s to transmit the Handover Complete and T3101 (3s by default) firing before receiving it. Increase it to give some more room and avoid sporadic failures. See how 2nd RSL1.send() in as_handover() is delayed for >2s: """ 09:50:39.134962 27946 MSC_ConnectionHandler.ttcn:1737 Sent on RSL1 to IPA-BTS1-TRX0-RSL-RSL(2945) @RSL_Types.RSL_Message : { msg_disc := { msg_group := RSL_MDISC_DCHAN (4), transparent := false }, msg_type := RSL_MT_HANDO_DET (39), ies := { { iei := RSL_IE_CHAN_NR (1), body := { chan_nr := { u := { sdcch4 := { tag := '001'B, sub_chan := 0 } }, tn := 0 } } } } } ... 09:50:39.135037 27946 Osmocom_Types.ttcn:126 Start timer T: 0.3 s 09:50:39.435079 27946 Osmocom_Types.ttcn:127 Timeout T: 0.3 s 09:50:39.718007 27937 M3UA_Emulation.ttcn:887 Timeout T_ASPUP_resend: 2 s 09:50:42.131009 27943 IPA_Emulation.ttcnpp:772 Message enqueued on IPA_PORT from system @IPL4asp_Types.ASP_RecvFrom : { connId := 1, remName := "127.0.0.1", remPort := 3003, locName := "127.0.0.1", locPort := 11000, proto := { tcp := { } }, userData := 0, msg := '00040008250120'O } id 17 09:50:42.188991 27946 MSC_ConnectionHandler.ttcn:1742 enc_PDU_ML3_MS_NW(): Encoding @MobileL3_Types.PDU_ML3_MS_NW: { discriminator := '0000'B, tiOrSkip := { skipIndicator := '0000'B }, msgs := { rrm := { handoverComplete := { messageType := '00101100'B, rRCause := { valuePart := '00'O }, mobileObsservedTimeDiff := omit, mobileTimeDifferenceHyperframe := omit } } } } """ Change-Id: I90f4bded452c33dab343b20fc4b209520991ea84 --- M bsc/osmo-bsc.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/41872/1 diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index 621d4c9..1cc4b22 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -77,6 +77,7 @@ handover power budget interval 6 handover power budget hysteresis 3 handover maximum distance 9999 + timer t3101 5 timer t3113 10 timer t3212 30 mgw 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90f4bded452c33dab343b20fc4b209520991ea84 Gerrit-Change-Number: 41872 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: contrib/jenkins_arm.sh: Remove explicit configure.sh disable args
by pespin 20 Jan '26

20 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41871?usp=email ) Change subject: contrib/jenkins_arm.sh: Remove explicit configure.sh disable args ...................................................................... contrib/jenkins_arm.sh: Remove explicit configure.sh disable args Since --enable-embedded was reworked in 9197c1ac176ab8aa33f82e059404dcd482577a31, it is no longer needed to pass those flags explicitly for proper checking, since --enable-embedded preset takes care of enabling/disabling them and do the related checks. Change-Id: Ie1f99305c198a4e164d54ce7090c9fc67e99a891 --- M contrib/jenkins_arm.sh 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/41871/1 diff --git a/contrib/jenkins_arm.sh b/contrib/jenkins_arm.sh index a65bb67..1d72f2f 100755 --- a/contrib/jenkins_arm.sh +++ b/contrib/jenkins_arm.sh @@ -18,10 +18,6 @@ --enable-embedded \ --disable-doxygen \ --disable-shared \ - --disable-libsctp \ - --disable-libusb \ - --disable-libmnl \ - --disable-syslog-logging \ CFLAGS="-Os -ffunction-sections -fdata-sections -nostartfiles -nodefaultlibs $WERROR_FLAGS" $MAKE $PARALLEL_MAKE -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie1f99305c198a4e164d54ce7090c9fc67e99a891 Gerrit-Change-Number: 41871 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026