Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr
......................................................................
tests/{ctrl,vty}_test_runner.py: dump stdout/stderr
From time to time, we're seeing the following error in Jenkins:
----------------------------------------------------------------------
Traceback (most recent call last):
File ".../tests/vty_test_runner.py", line 70, in tearDown
raise Exception("Process returned %d" % rc)
Exception: Process returned -9
----------------------------------------------------------------------
Let's dump stdout/stderr of the process to get more information.
Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a
Related: OS#5665
---
M tests/ctrl_test_runner.py
M tests/vty_test_runner.py
2 files changed, 37 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/27/41127/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a
Gerrit-Change-Number: 41127
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email )
Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr
......................................................................
Patch Set 1:
(1 comment)
File tests/ctrl_test_runner.py:
https://gerrit.osmocom.org/c/osmo-msc/+/41127/comment/bc65f89f_9d05f7bf?usp… :
PS1, Line 54: self.stdout = tempfile.TemporaryFile()
> Does that mean now we create a temporary file each time a test is run which is never destroyed autom […]
No. These files will be destroyed as soon as they're closed, see:
https://docs.python.org/3/library/tempfile.html
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a
Gerrit-Change-Number: 41127
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Sep 2025 12:54:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email )
Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr
......................................................................
Patch Set 1:
(1 comment)
File tests/ctrl_test_runner.py:
https://gerrit.osmocom.org/c/osmo-msc/+/41127/comment/eb36b838_e57924d0?usp… :
PS1, Line 54: self.stdout = tempfile.TemporaryFile()
Does that mean now we create a temporary file each time a test is run which is never destroyed automatically? This will end up with tons of files being created in tmpfs?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a
Gerrit-Change-Number: 41127
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Sep 2025 12:44:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41116?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: cosmetic: RANAP_CodecPort.ttcn: Fix trailing whitespace
......................................................................
cosmetic: RANAP_CodecPort.ttcn: Fix trailing whitespace
Change-Id: Ibad0a23cfc15dd9d9a03e78ca64eb26b4ecee6d8
---
M library/ranap/RANAP_CodecPort.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/library/ranap/RANAP_CodecPort.ttcn b/library/ranap/RANAP_CodecPort.ttcn
index 07e1b00..af2090c 100644
--- a/library/ranap/RANAP_CodecPort.ttcn
+++ b/library/ranap/RANAP_CodecPort.ttcn
@@ -353,7 +353,7 @@
} with {extension "prototype(fast)" }
-/*
+/*
type port RANAP_CODEC_PT message map to SCCPasp_PT {
out RANAP_N_CONNECT_req to ASP_SCCP_N_CONNECT_req with f_enc_ConnectReq(),
RANAP_N_CONNECT_res to ASP_SCCP_N_CONNECT_res with f_enc_ConnectRes(),
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41116?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibad0a23cfc15dd9d9a03e78ca64eb26b4ecee6d8
Gerrit-Change-Number: 41116
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>