September 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-gsm-manuals[master]: sigtran.adoc: small fixes and improvements

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41087?usp=email ) Change subject: sigtran.adoc: small fixes and improvements ...................................................................... sigtran.adoc: small fixes and improvements Change-Id: Ia8457f3fef3c7e455b102b4685850be5fbf6f186 --- M common/chapters/sigtran.adoc 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/common/chapters/sigtran.adoc b/common/chapters/sigtran.adoc index 75767e3..308f157 100644 --- a/common/chapters/sigtran.adoc +++ b/common/chapters/sigtran.adoc @@ -419,7 +419,7 @@ transmitting user data to us. In order to be able to use this feature, the SCTP association peer must support -the ASCONF extension. The extension support is negotiation during the INIT +the ASCONF extension. The extension support is negotiated during the INIT handshake of the association. Furthermore, for ASCONF features to work properly, the assoc also needs to announce/use the AUTH extension, as per RFC5061 section 4.2.7. Otherwise, the peer receiving an SCTP INIT with @@ -430,7 +430,8 @@ As of the time of writing this documentation (linux 6.4.12) and since basically ever, those extensions are runtime-disabled by default. They can be enabled per socket using the kernel sockopts SCTP_ASCONF_SUPPORTED and SCTP_AUTH_SUPPORTED, -and that's what the Osmocom stack is currently doing for all SCTP sockets. +and that's what the Osmocom stack is currently doing for all its SCTP sockets. + However, those sockopts are farily new (linux v5.4), which means user running older kernels will see in the logs setting those sockopts fail, but connection will keep ongoing, simply without those features available (so setting `primary` -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia8457f3fef3c7e455b102b4685850be5fbf6f186 Gerrit-Change-Number: 41087 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 week, 3 days

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Improve route section

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41088?usp=email ) Change subject: sigtran-osmocom.adoc: Improve route section ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ice7c6f09bbf37c032af9a7f6f21d7994ce53ea82 Gerrit-Change-Number: 41088 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Sep 2025 11:59:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week, 3 days

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: sigtran.adoc: small fixes and improvements

by laforge

Attention is currently required from: daniel, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41087?usp=email ) Change subject: sigtran.adoc: small fixes and improvements ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia8457f3fef3c7e455b102b4685850be5fbf6f186 Gerrit-Change-Number: 41087 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Sep 2025 11:59:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week, 3 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: mme: Initial working state for MME_Tests_SGsAP.ttcn tests

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41046?usp=email ) Change subject: mme: Initial working state for MME_Tests_SGsAP.ttcn tests ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If07f1a67eb4213985da82afec94adb08786a0980 Gerrit-Change-Number: 41046 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Sep 2025 11:59:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGsAP_Emulation: Introduce proper support for server-mode

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41083?usp=email ) Change subject: SGsAP_Emulation: Introduce proper support for server-mode ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iccf4ac96c56e947529f0ffc06428e2325a115d50 Gerrit-Change-Number: 41083 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Sep 2025 11:59:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email ) Change subject: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures ...................................................................... s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures These will be used to test MT CS call over SGsAP in MME_Tests_SGsAP. Change-Id: I87fa7d988bec90ccade2f40ac4d2a0924059058e --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 95 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 031ac59..3f9b1f8 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -17,6 +17,8 @@ import from S1AP_PDU_Contents all; import from S1AP_PDU_Descriptions all; +import from General_Types all; + /********************************************************************************* * non-UE related *********************************************************************************/ @@ -991,14 +993,88 @@ } /* 9.1.4.8 UE CONTEXT MODIFICATION REQUEST */ +private function f_tr_S1AP_UeContextModificationReq(template (present) MME_UE_S1AP_ID mme_id := ?, + template (present) ENB_UE_S1AP_ID enb_id := ?, + template CSFallbackIndicator csfb_ind := *, + template LAI registered_lai := *, + template AdditionalCSFallbackIndicator add_csfb_ind := *) +return template UEContextModificationRequest +{ + var template UEContextModificationRequest req := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := {MME_UE_S1AP_ID := mme_id} + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := {ENB_UE_S1AP_ID := enb_id} + } + } + }; + var integer idx := lengthof(req.protocolIEs); + + if (ispresent(csfb_ind)) { + req.protocolIEs[idx] := { + id := id_CSFallbackIndicator, + criticality := reject, + value_ := { CSFallbackIndicator := csfb_ind } + }; + idx := idx + 1; + } + + if (ispresent(registered_lai)) { + req.protocolIEs[idx] := { + id := id_RegisteredLAI, + criticality := ignore, + value_ := { LAI := registered_lai } + }; + idx := idx + 1; + } + + if (ispresent(add_csfb_ind)) { + req.protocolIEs[idx] := { + id := id_AdditionalCSFallbackIndicator, + criticality := ignore, + value_ := { AdditionalCSFallbackIndicator := add_csfb_ind } + }; + idx := idx + 1; + } + + /* ignore the remaining IEs */ + req.protocolIEs[idx] := *; + return req; +} + template (present) S1AP_PDU tr_S1AP_UeContextModificationReq(template (present) MME_UE_S1AP_ID mme_id := ?, - template (present) ENB_UE_S1AP_ID enb_id := ?) := { + template (present) ENB_UE_S1AP_ID enb_id := ?, + template CSFallbackIndicator csfb_ind := *, + template LAI registered_lai := *, + template AdditionalCSFallbackIndicator add_csfb_ind := *) := { initiatingMessage := { procedureCode := id_UEContextModification, criticality := reject, value_ := { - UEContextModificationRequest := { + UEContextModificationRequest := f_tr_S1AP_UeContextModificationReq(mme_id, + enb_id, + csfb_ind, + registered_lai, + add_csfb_ind) + } + } +} + +/* 9.1.4.98 UE CONTEXT MODIFICATION RESPONSE */ +template (value) S1AP_PDU +ts_S1AP_UeContextModificationResp(template (value) MME_UE_S1AP_ID mme_id, + template (value) ENB_UE_S1AP_ID enb_id) := { + successfulOutcome := { + procedureCode := id_UEContextModification, + criticality := reject, + value_ := { + UEContextModificationResponse := { protocolIEs := { { id := S1AP_Constants.id_MME_UE_S1AP_ID, @@ -1008,7 +1084,8 @@ id := S1AP_Constants.id_eNB_UE_S1AP_ID, criticality := reject, value_ := {ENB_UE_S1AP_ID := enb_id} - }, * + } + /* TODO: Criticality Diagnostics IE (Optional) */ } } } @@ -2798,4 +2875,19 @@ } } +/* 9.2.3.1 LAI */ +template (value) LAI ts_S1AP_LAI(template (value) PLMNidentity plmn_id, + template (value) OCT2 lac) := { + pLMNidentity := plmn_id, + lAC := lac, + iE_Extensions := omit +}; + +template (present) LAI tr_S1AP_LAI(template (present) PLMNidentity plmn_id := ?, + template (present) OCT2 lac := ?) := { + pLMNidentity := plmn_id, + lAC := lac, + iE_Extensions := * +}; + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87fa7d988bec90ccade2f40ac4d2a0924059058e Gerrit-Change-Number: 41082 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 week, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/NAS_EPS_Templates.ttcn: Add templates to handle CS Fallback r...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41081?usp=email ) Change subject: library/NAS_EPS_Templates.ttcn: Add templates to handle CS Fallback related procedures ...................................................................... library/NAS_EPS_Templates.ttcn: Add templates to handle CS Fallback related procedures These will be used to test MT CS call over SGsAP in MME_Tests_SGsAP. Change-Id: If8884224e353a9883200c84d737e63c3a3ca9b33 --- M library/NAS_EPS_Templates.ttcn 1 file changed, 100 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/NAS_EPS_Templates.ttcn b/library/NAS_EPS_Templates.ttcn index 9b1242c..90c507a 100644 --- a/library/NAS_EPS_Templates.ttcn +++ b/library/NAS_EPS_Templates.ttcn @@ -71,6 +71,30 @@ elementIdentifier := '1000'B } +/* 9.9.3.5 CSFB response */ +template (value) CSFB_ResponseTV +ts_NAS_CSFB_ResponseTV(template (value) BIT3 cSFB_ResponseValue) := { + cSFB_ResponseValue := cSFB_ResponseValue, + spare := '0'B, + elementIdentifier := '1011'B +} +function f_ts_CSFB_ResponseTV(template (omit) BIT3 cSFB_ResponseValue) +return template (omit) CSFB_ResponseTV { + if (istemplatekind(cSFB_ResponseValue, "omit")) { + return omit; + } + return ts_NAS_CSFB_ResponseTV(cSFB_ResponseValue); +} + +/* 9.9.2.3 Mobile identity */ +template (value) MobileIdentityV +ts_NAS_MobileIdentityV_TMSI(OCT4 tmsi) := { + typeOfIdentity := '100'B, + oddEvenInd_identity := { + tmsi_ptmsi_mtmsi := f_enc_TMSI_PTMSI_MTMSI(oct2hex(tmsi)) + } +} + private template (value) MobileIdentityLV ts_NAS_MobileIdLV(template (value) MobileIdentityV mid) := { lengthIndicator := 0, @@ -121,6 +145,19 @@ return l3; } +private function f_enc_TMSI_PTMSI_MTMSI(hexstring digits) return TMSI_PTMSI_MTMSI { + var TMSI_PTMSI_MTMSI l3; + var integer len := lengthof(digits); + if (len rem 2 == 1) { /* modulo remainder */ + l3.oddevenIndicator := '1'B; + } else { + l3.oddevenIndicator := '0'B; + } + l3.digits := digits; + l3.fillerDigit := '1111'B; + return l3; +} + template (value) GUTI ts_NAS_GUTI(hexstring mcc_mnc, OCT2 mmegi, OCT1 mmec, OCT4 tmsi) := { oddevenIndicator := '0'B, spare := '1111'B, @@ -204,6 +241,20 @@ return ts_NonceTV(nonce); } +/* 9.9.3.25A Paging identity */ +template (present) PagingIdentityV +tr_PagingIdentityV(template (present) BIT1 pagingIdentityValue := ?) := { + pagingIdentityValue := pagingIdentityValue, + spare := '0000000'B +} +template (value) PagingIdentityV +ts_PagingIdentityV(template (value) BIT1 pagingIdentityValue) := { + pagingIdentityValue := pagingIdentityValue, + spare := '0000000'B +} +template (value) PagingIdentityV +ts_PagingIdentityV_TMSI := tr_PagingIdentityV('1'B); + /* 9.9.3.26 P-TMSI signature */ template (value) P_TMSISignatureTV ts_PTMSI_SignatureTV(template (value) OCT3 ptmsi_sig) := { @@ -384,6 +435,55 @@ } } +/* 8.2.9 CS service notirication */ +template (present) PDU_NAS_EPS +tr_NAS_CS_ServiceNotification(template (present) PagingIdentityV pagingIdentity := ?, + template CLITLV cLI := *, + template SS_CodeTV sS_Code := *, + template LCS_IndicatorTV lCS_Indicator := *, + template LCS_ClientIdentityTLV lCS_ClientIdentity := *) := { + protocolDiscriminator := c_EPS_NAS_PD_EMM, + ePS_messages := { + ePS_MobilityManagement := { + pDU_NAS_EPS_CS_ServiceNotification := { + securityHeaderType := c_EPS_SEC_NONE, + messageType := '01100100'B, + pagingIdentity := pagingIdentity, + cLI := cLI, + sS_Code := sS_Code, + lCS_Indicator := lCS_Indicator, + lCS_ClientIdentity := lCS_ClientIdentity + } + } + } +} + +/* 8.2.15 Extended service request */ +template (value) PDU_NAS_EPS +ts_NAS_CS_ExtendedServiceRequest(template (value) BIT4 serviceType, + template (value) NAS_KeySetIdentifierV nAS_KeySetIdentifier, + template (value) MobileIdentityV m_TMSI, + template (omit) BIT3 cSFB_ResponseValue := omit, + template (omit) EPS_BearerContextStatusTLV ePS_BearerContextStatus := omit, + template (omit) DevicePropertiesTV deviceProperties := omit) := { + protocolDiscriminator := c_EPS_NAS_PD_EMM, + ePS_messages := { + ePS_MobilityManagement := { + pDU_NAS_EPS_ExtendedServiceRequest := { + securityHeaderType := c_EPS_SEC_NONE, + messageType := '01001100'B, + serviceType := serviceType, + nAS_KeySetIdentifier := nAS_KeySetIdentifier, + m_TMSI := ts_NAS_MobileIdLV(m_TMSI), + cSFB_Response := f_ts_CSFB_ResponseTV(cSFB_ResponseValue), + ePS_BearerContextStatus := ePS_BearerContextStatus, + deviceProperties := deviceProperties + } + } + } +} + + /* 9.9.3.14 EPS update type */ const BIT3 c_EPS_UPD_TYPE_TA_UPD := '000'B; const BIT3 c_EPS_UPD_TYPE_COMB_TA_LA_UPD := '001'B; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If8884224e353a9883200c84d737e63c3a3ca9b33 Gerrit-Change-Number: 41081 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 week, 3 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: mme: Mark GTP and diameter emulations alive

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41074?usp=email ) Change subject: mme: Mark GTP and diameter emulations alive ...................................................................... mme: Mark GTP and diameter emulations alive Change-Id: I53851dc981e9395e025cd5d2fb0122bea49564ee --- M mme/MME_Tests.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 5a58f96..2847bcc 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -197,7 +197,7 @@ }; g_enb_pars[num] := enb_pars; - vc_S1AP[num] := S1AP_Emulation_CT.create(id); + vc_S1AP[num] := S1AP_Emulation_CT.create(id) alive; map(vc_S1AP[num]:S1AP, system:S1AP_CODEC_PT); connect(vc_S1AP[num]:S1AP_PROC, self:S1AP_PROC[num]); connect(vc_S1AP[num]:S1AP_UNIT, self:S1AP_UNIT[num]); @@ -255,7 +255,7 @@ auth_app_id := omit, vendor_app_id := c_DIAMETER_3GPP_S6_AID }; - vc_DIAMETER := DIAMETER_Emulation_CT.create(id); + vc_DIAMETER := DIAMETER_Emulation_CT.create(id) alive; map(vc_DIAMETER:DIAMETER, system:DIAMETER_CODEC_PT); connect(vc_DIAMETER:DIAMETER_UNIT, self:DIAMETER_UNIT); connect(vc_DIAMETER:DIAMETER_PROC, self:DIAMETER_PROC); @@ -273,7 +273,7 @@ sgsn_role := true }; - vc_GTP := GTP_Emulation_CT.create(id); + vc_GTP := GTP_Emulation_CT.create(id) alive; vc_GTP.start(GTP_Emulation.main(gtp_cfg)); } @@ -288,7 +288,7 @@ sgw_role := true }; - vc_GTP2 := GTPv2_Emulation_CT.create(id); + vc_GTP2 := GTPv2_Emulation_CT.create(id) alive; map(vc_GTP2:GTP2C, system:GTP2C); connect(vc_GTP2:TEIC0, self:TEIC0); vc_GTP2.start(GTPv2_Emulation.main(cfg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53851dc981e9395e025cd5d2fb0122bea49564ee Gerrit-Change-Number: 41074 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>

1 week, 3 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/s1ap: Support receiving UEContextModificationRequest

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41075?usp=email ) Change subject: library/s1ap: Support receiving UEContextModificationRequest ...................................................................... library/s1ap: Support receiving UEContextModificationRequest Change-Id: Iadb80eea7281b3bdf3359b0e2956e18bdb208207 --- M library/S1AP_Functions.ttcn M library/s1ap/S1AP_Templates.ttcn 2 files changed, 31 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/S1AP_Functions.ttcn b/library/S1AP_Functions.ttcn index 63bdaa4..fbdcada 100644 --- a/library/S1AP_Functions.ttcn +++ b/library/S1AP_Functions.ttcn @@ -43,6 +43,9 @@ return omit; } } + case (tr_S1AP_UeContextModificationReq) { + return im.value_.UEContextModificationRequest.protocolIEs[1].value_.ENB_UE_S1AP_ID; + } case (tr_S1AP_ConnEstInd) { return im.value_.ConnectionEstablishmentIndication.protocolIEs[1].value_.ENB_UE_S1AP_ID; } @@ -98,6 +101,9 @@ case (tr_S1AP_ConnEstInd) { return im.value_.ConnectionEstablishmentIndication.protocolIEs[0].value_.MME_UE_S1AP_ID; } + case (tr_S1AP_UeContextModificationReq) { + return im.value_.UEContextModificationRequest.protocolIEs[0].value_.MME_UE_S1AP_ID; + } /* TODO */ } } else if (ischosen(s1ap.successfulOutcome)) { diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 7910465..031ac59 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -990,6 +990,31 @@ } } +/* 9.1.4.8 UE CONTEXT MODIFICATION REQUEST */ +template (present) S1AP_PDU +tr_S1AP_UeContextModificationReq(template (present) MME_UE_S1AP_ID mme_id := ?, + template (present) ENB_UE_S1AP_ID enb_id := ?) := { + initiatingMessage := { + procedureCode := id_UEContextModification, + criticality := reject, + value_ := { + UEContextModificationRequest := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := {MME_UE_S1AP_ID := mme_id} + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := {ENB_UE_S1AP_ID := enb_id} + }, * + } + } + } + } +} + /* 9.1.4.20 CONNECTION ESTABLISHMENT INDICATION */ template (value) S1AP_PDU ts_S1AP_ConnEstInd(template (value) MME_UE_S1AP_ID mme_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41075?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iadb80eea7281b3bdf3359b0e2956e18bdb208207 Gerrit-Change-Number: 41075 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 week, 3 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: mme: Add missing tests to expected-results.xml

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41080?usp=email ) Change subject: mme: Add missing tests to expected-results.xml ...................................................................... mme: Add missing tests to expected-results.xml Change-Id: I9fbe1dd102268558f4b360dc8e870117e4e17096 --- M mme/expected-results.xml 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/mme/expected-results.xml b/mme/expected-results.xml index 370aa0e..6826995 100644 --- a/mme/expected-results.xml +++ b/mme/expected-results.xml @@ -1,7 +1,13 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='71' failures='8' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='10' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='MME_Tests' name='TC_s1ap_setup_unknown_global_enb_id_plmn' time='MASKED'/> <testcase classname='MME_Tests' name='TC_s1ap_setup_wrong_tac' time='MASKED'/> <testcase classname='MME_Tests' name='TC_s1ap_setup' time='MASKED'/> <testcase classname='MME_Tests' name='TC_s1ap_attach' time='MASKED'/> + <testcase classname='MME_Tests' name='TC_s1ap_tau_unknown_guti' time='MASKED'/> + <testcase classname='MME_Tests' name='TC_gn_echo_request' time='MASKED'/> + <testcase classname='MME_Tests' name='TC_RIM_RAN_INF' time='MASKED'/> + <testcase classname='MME_Tests' name='TC_s1ap_reset' time='MASKED'/> + <testcase classname='MME_Tests' name='TC_ue_cell_reselect_eutran_to_geran' time='MASKED'/> + <testcase classname='MME_Tests' name='TC_ue_cell_reselect_geran_to_eutran' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9fbe1dd102268558f4b360dc8e870117e4e17096 Gerrit-Change-Number: 41080 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 week, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025