September 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: m3ua: Fix memleak in m3ua_rx_snm_sg() and some paths of m3ua_rx_snm()

by pespin

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41090?usp=email ) Change subject: m3ua: Fix memleak in m3ua_rx_snm_sg() and some paths of m3ua_rx_snm() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41090/comment/47e4083b_f8dfb… : PS1, Line 1013: = 0; > I don't think assigning 0 is needed here. ack but it doesn't hurt either and makes it safer if code paths are moved below at some point. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iab795da63e65d9539a44c985d9ca85aa76d203c6 Gerrit-Change-Number: 41090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Sep 2025 19:14:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 week, 2 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: Propagate rx M3UA SCON -> MTP-STATUS.ind -> N-PCSTATE.ind

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41092?usp=email ) Change subject: Propagate rx M3UA SCON -> MTP-STATUS.ind -> N-PCSTATE.ind ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/sigtran/protocol/mtp.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41092/comment/b0370c20_4c13b… : PS1, Line 32: Q.705 Did you mean `Q.704` here (since you're changing the reference above)? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41092?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I82541612c039b1cc0191cb44d2eecdcbb07fae96 Gerrit-Change-Number: 41092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Sep 2025 19:09:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 week, 2 days

1
0
0 0

[S] Change in libosmo-sigtran[master]: m3ua: Forward SCON messages in SG role

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41091?usp=email ) Change subject: m3ua: Forward SCON messages in SG role ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41091/comment/9b714896_49be1… : PS1, Line 1068: pe er peer -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic68345688d39f5430c30e156b94b1501d77e388c Gerrit-Change-Number: 41091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Sep 2025 19:01:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 week, 2 days

1
0
0 0

[S] Change in libosmo-sigtran[master]: m3ua: Fix memleak in m3ua_rx_snm_sg() and some paths of m3ua_rx_snm()

by fixeria

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41090?usp=email ) Change subject: m3ua: Fix memleak in m3ua_rx_snm_sg() and some paths of m3ua_rx_snm() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41090/comment/5dcec3dd_4a7ad… : PS1, Line 1013: = 0; I don't think assigning 0 is needed here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iab795da63e65d9539a44c985d9ca85aa76d203c6 Gerrit-Change-Number: 41090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Sep 2025 18:58:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 week, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: S1GW: Add test case to test release of failed e-RABs during handover ...

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email ) Change subject: S1GW: Add test case to test release of failed e-RABs during handover resource allocation ...................................................................... Patch Set 2: (2 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/c5696485_e6b9… : PS2, Line 1131: in ERabIdxList erabs_failed := {}) No more "in" churn please. File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/9aeef6e6_f26e… : PS2, Line 955: f_ConnHdlr_handover_ack( no need for this extra line in params. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic14f560ae16b8386e58ac85f8af53b19d7c7a5c9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 12 Sep 2025 12:23:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 week, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: S1GW: Add test case to test release of e-RABs during handover prepera...

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email ) Change subject: S1GW: Add test case to test release of e-RABs during handover preperation ...................................................................... Patch Set 2: (3 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/c0cf947c_16ad… : PS2, Line 1210: in ERabIdxList erabs_release := {}) I vote for stopping adding more "in" churn :D https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/9bd2384d_4f11… : PS2, Line 1247: in ERabIdxList erabs_release := {}) I vote for stopping adding more "in" churn :D https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/0501fc5b_2252… : PS2, Line 1720: in ERabIdxList erabs_forward, No more "in" churn please. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic70ba19c0a6e349f63aae124607d075b6d19e779 Gerrit-Change-Number: 41094 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 12 Sep 2025 12:22:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 week, 3 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Add optonal e-RAB lists to HANDOVER messages

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41093?usp=email ) Change subject: Add optonal e-RAB lists to HANDOVER messages ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41093/comment/a279fbe5_b405… : PS2, Line 2771: template (value) E_RABFailedtoSetupListHOReqAck Can you add spec reference where these are mentioned? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41093?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I78d2fa8e72bb672674727a01d5c5a9aaf31cab7b Gerrit-Change-Number: 41093 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 12 Sep 2025 12:16:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 week, 3 days

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: Handle "E-RABs Failed to Setup List" IE

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41089?usp=email ) Change subject: s1ap_proxy: Handle "E-RABs Failed to Setup List" IE ...................................................................... s1ap_proxy: Handle "E-RABs Failed to Setup List" IE The HANDOVER REQUEST ACKNOWLEDGE PDU may contain an optional IE with the list of E-RABs that the eNB failed to setup. The S1GW needs to handle this list and terminate the respective E-RAB FSMs. Change-Id: I207094fd0019d10a61a5566c649ded1f98a41967 Related: 05b55609 ("s1ap_proxy: Add support for S1 HANDOVER procedure") Related: SYS#7309 --- M src/s1ap_proxy.erl 1 file changed, 26 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 658f08c..22c2da7 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -690,8 +690,9 @@ value = C0} = Msg}, S0) -> ?LOG_DEBUG("Processing HANDOVER REQUEST ACKNOWLEDGE"), ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_REQ_ACK, S0), - case handle_ies(?'id-E-RABAdmittedList', - C0#'HandoverRequestAcknowledge'.protocolIEs, S0) of + %% handle the list of admitted E-RABs + {Result, S2} = case handle_ies(?'id-E-RABAdmittedList', + C0#'HandoverRequestAcknowledge'.protocolIEs, S0) of {{ok, IEs}, S1} -> C1 = C0#'HandoverRequestAcknowledge'{protocolIEs = IEs}, PDU = {Outcome, Msg#'SuccessfulOutcome'{value = C1}}, @@ -700,7 +701,13 @@ ?LOG_NOTICE("Failed to process HANDOVER REQUEST ACKNOWLEDGE: ~p", [Reason]), ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_PROC_ERROR, S1), {drop, S1} %% drop this PDU - end; + end, + %% handle the (optional) list of failed E-RABs + %% no #proxy_state modification is expected here + handle_ies(?'id-E-RABFailedToSetupListHOReqAck', + C0#'HandoverRequestAcknowledge'.protocolIEs, S2), + {Result, S2}; + %% TODO: 9.1.5.8 PATH SWITCH REQUEST :: (M) Transport Layer Address %% TODO: 9.1.5.9 PATH SWITCH REQUEST ACKNOWLEDGE :: (M) Transport Layer Address @@ -1149,6 +1156,22 @@ {{error, erab_not_registered}, S} end; +handle_ie([?'id-E-RABFailedToSetupListHOReqAck'], C, S) -> + %% This IE contains a list of id-E-RABFailedtoSetupItemHOReqAck, so patch inner IEs + handle_ies(?'id-E-RABFailedtoSetupItemHOReqAck', C, S); + +handle_ie([?'id-E-RABFailedtoSetupItemHOReqAck', + ?'id-E-RABFailedToSetupListHOReqAck'], + #'E-RABFailedToSetupItemHOReqAck'{'e-RAB-ID' = ERABId} = C, S) -> + %% poke E-RAB FSM + case erab_fsm_find(ERABId, S) of + {ok, Pid} -> + ok = erab_fsm:erab_release_ind(Pid), + {{ok, C}, S}; + error -> + ?LOG_ERROR("E-RAB-ID ~p is not registered", [erab_uid(ERABId, S)]), + {{error, erab_not_registered}, S} + end; %% Catch-all variant, which should not be called normally handle_ie(P, C, S) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I207094fd0019d10a61a5566c649ded1f98a41967 Gerrit-Change-Number: 41089 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu>

1 week, 3 days

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: Handle "E-RABs Failed to Setup List" IE

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41089?usp=email ) Change subject: s1ap_proxy: Handle "E-RABs Failed to Setup List" IE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I207094fd0019d10a61a5566c649ded1f98a41967 Gerrit-Change-Number: 41089 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Sep 2025 12:00:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week, 3 days

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Improve route section

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41088?usp=email ) Change subject: sigtran-osmocom.adoc: Improve route section ...................................................................... sigtran-osmocom.adoc: Improve route section Change-Id: Ice7c6f09bbf37c032af9a7f6f21d7994ce53ea82 --- M common/chapters/sigtran-osmocom.adoc 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/common/chapters/sigtran-osmocom.adoc b/common/chapters/sigtran-osmocom.adoc index ddba669..32d03cf 100644 --- a/common/chapters/sigtran-osmocom.adoc +++ b/common/chapters/sigtran-osmocom.adoc @@ -381,11 +381,16 @@ === Osmocom SS7 Routes -An Osmocom SS7 Route routes traffic with a matching destination point -code and point code mask (similar to IP Address + Netmask) towards a -specified SS7 Linkset or Application Server. The Linkset or +An Osmocom SS7 Route holds information to route traffic with a matching +destination point code and point code mask (similar to IP Address + Netmask) +towards a specified SS7 Linkset or Application Server. The Linkset or Application Servers are identified by their name. +Routes are inserted in a routing table, where they are ordered first based +on prefix mask length (longest prefix first) and then on priority (lowest value first). +As a result, more specific routes (eg. a single Point Code) will match and +be used before more generic ones (eg. a subnet). + .Major Attributes of an Osmocom SS7 Application Server Process [options="header",cols="25%,75%"] |==== @@ -393,8 +398,16 @@ |Point Code|Destination Point Code for this route |Mask|Destination Mask for this route (like an IP netmask) |Linkset/AS Name|Destination Linkset or AS, identified by name +|Priority|Priority of the route in the routing table; lower value means higher priority |==== +The `show cs7 instance <0-15> route` command can be used on the +VTY to obtain the list of routes inserted in the system routing table. + +The `show cs7 instance <0-15> route-lookup <DPC> from <OPC> sls <SLS>` command +can be used on the VTY to test and debug routing of specific traffic on the +currently running routing table, similar to what `ip route get` linux command +does in the IP world. === Osmocom SCCP Instances -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ice7c6f09bbf37c032af9a7f6f21d7994ce53ea82 Gerrit-Change-Number: 41088 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 week, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025