July 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: ss7_vty: Avoid adding route to local PC in role ASP

by laforge

Attention is currently required from: dexter, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email ) Change subject: ss7_vty: Avoid adding route to local PC in role ASP ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: adding @dexter as he wrote the original commit. I don't understand the rationale of b4f1b2cb8bd404f08601dc8ca700b672a455846c as on the ASP side the routing context (identiifed by a key) is the ASP-side point code and not a remote point code. But probably still worth to get @dexter input [and revisit SYS#5392 which apparently prompted the original commit] -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic602de42e37c4579f530823bb41e0a8193ce73bb Gerrit-Change-Number: 40579 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:29:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: Add multiple messages buffers to io_uring write operations

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email ) Change subject: Add multiple messages buffers to io_uring write operations ...................................................................... Patch Set 4: (8 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/f4ab2e23_66117fc5?… : PS4, Line 248: lh = iofd->tx_queue.msg_queue.prev; fyi we have llist_last(). We may also want to add llist_last_entry_or_null() to linuxlist.h, we already have llist_first_entry_or_null(). https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/ec17b58f_8a08236b?… : PS4, Line 444: /* Re-enqueue remaining buffers. */ Here we should improve it by adding new msg from the tx_queue into the iov if we aren't yet doing it. https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/7d307ae3_038efe13?… : PS4, Line 451: if (rc < chunk) shouldn't this case be already handled in the if path in line 431? https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/7d6fa351_bb7a5ab3?… : PS4, Line 465: iofd->io_ops.write_cb(iofd, (rc < 0) ? rc : chunk, msg); Again, by incorporation the negative value case into chunk variable, we can simplify all these lines here which now have a ": ?". https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/bcc08743_17cb65c4?… : PS4, Line 479: msgb_free(msghdr->msg[idx]); msghdr->msg[idx] = NULL; https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/48579013_26af2f86?… : PS4, Line 517: msghdr = iofd_txqueue_tail(iofd); why are you picking the tail here? Because the assumption is that the other before it are already filled? Do you mind writing teh rationale in a comment? https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/eddfcee1_12b0e64c?… : PS4, Line 531: you can simply do "idx = msghdr->msg_len - 1;" here, and simplify both branches above. https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/867d036a_1ebad94d?… : PS4, Line 539: rc = iofd_txqueue_enqueue(iofd, msghdr); are you submitting to io_uring queue inside here? Because then it looks like yoy may be modifying stuff you already submitted to io_uring... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c4e0a785cf66becd7fb5b2caf718c9724b56686 Gerrit-Change-Number: 40493 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:28:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs: add ttcn3-bsc-test-{sccplite,vamos}-asan

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40587?usp=email ) Change subject: jobs: add ttcn3-bsc-test-{sccplite,vamos}-asan ...................................................................... jobs: add ttcn3-bsc-test-{sccplite,vamos}-asan Fix that we didn't have asan variants of those two. Change-Id: I9888ec08bc39baaf713cb0a89d133e10fed50e0d --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 609a215..542dcf4 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -502,6 +502,16 @@ args: -b osmocom:nightly:asan -c generic timer: H 16 * * * + - ttcn3-bsc-test-sccplite-asan: # ~76 min + testsuite: bsc + args: -b osmocom:nightly:asan -c sccplite + timer: H 16 * * * + + - ttcn3-bsc-test-vamos-asan: # ~4 min + testsuite: bsc + args: -b osmocom:nightly:asan -c vamos + timer: H 16 * * * + - ttcn3-pcap-client-test-asan: # ~1 min testsuite: pcap-client args: -b osmocom:nightly:asan -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9888ec08bc39baaf713cb0a89d133e10fed50e0d Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs: add ttcn3-bsc-test-{sccplite,vamos}-asan

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40587?usp=email ) Change subject: jobs: add ttcn3-bsc-test-{sccplite,vamos}-asan ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9888ec08bc39baaf713cb0a89d133e10fed50e0d Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:25:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: Add multiple messages buffers to struct iofd_msghdr

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email ) Change subject: Add multiple messages buffers to struct iofd_msghdr ...................................................................... Patch Set 3: (1 comment) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/536cc246_047db4a8?… : PS3, Line 140: int msg_max; > this field should probably be in struct osmo_iofd. I agee. The only reason to have it here was in case the value would change during the lifetime of an io_fd. Like if sometimes we wanted 1, sometimes 5 and sometimes 10 msgb per read/write. As we don't want that, it should indeed go to osmo_iofd, of course with a more descriptive name. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92 Gerrit-Change-Number: 40491 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:20:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: Submit all SQEs to kernel if they don't fit in the io_uring

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40490?usp=email ) Change subject: Submit all SQEs to kernel if they don't fit in the io_uring ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40490/comment/5026b1ac_d27929cb?… : PS3, Line 139: sqe = io_uring_get_sqe(&g_ring.ring); > I bet this can still probably return NULL since between call to io_uring_submit() and this line the […] I doubt this patch is useful in general. The *submit* will not release a sqe. It just notifies the kernel that there are new sqe in the shared memory region. The kernel can then start to process them. Let's assume they're all reads, which will only ever complete if some remote node has sent us something. We cannot assume that this will be true between the two lines above. Even if some of our seq are write to a datagram socket, we have no guarantee that the kernel will have completed those between submit and get_sqe. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I476d9db285a1d257a4a5d43ee45ee0116c7d7009 Gerrit-Change-Number: 40490 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:15:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: Add multiple messages buffers to io_uring read operations

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email ) Change subject: Add multiple messages buffers to io_uring read operations ...................................................................... Patch Set 3: (7 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/1795d0da_4483d815?… : PS3, Line 176: /* Set IO vectors and allocate additional read buffers (but only for READ). */ why only for READ? please explain in the comment. https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/54a664cc_9553dfac?… : PS3, Line 179: if (idx) why we don't do it for idx=0? https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/3ab43425_5ad741fe?… : PS3, Line 185: Can we please clena all the above up by moving the different logic to each of the cases in the switch below? https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/5841b711_30cdd492?… : PS3, Line 236: int chunk; msghdr->msg[idx] = NULL; https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/37a9fd1b_83c6dde5?… : PS3, Line 238: if (rc >= 0) { if you keep the chunk being negative you can remove the extra logic in 246 which imho makes it clearer: if (rc > 0) { if (rc > msghdr->iov[idx].iov_len) chunk = msghdr->iov[idx].iov_len; else chunk = rc; msgb_put(msg, chunk); rc -= chunk; } else { chunk = rc; } .... if (...) iofd_handle_recv(iofd, msg, chunk, msghdr); https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/f6554de5_19045744?… : PS3, Line 251: idx++; moving this idx++ after the for loop may also make it simpler. https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/61e7154d_ea124144?… : PS3, Line 256: msgb_free(msghdr->msg[idx]); msghdr->msg[idx] = NULL; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic4544b8fcbad5a266db748d6864d3ae93ee06bce Gerrit-Change-Number: 40492 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:14:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: Allow io_uring_submit batching just ahead of poll/select

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email ) Change subject: Allow io_uring_submit batching just ahead of poll/select ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Several comments: […] I think for now it's good to have it optional so we can compare, indeed. The delayed submit will likely increase throughput - but at the cost of some added latency. I think it's worth it, but before we've done extensive benchmarks (and asked users to try it in loaded production setups) it might be good to have it disabled by default. As we don't have VTY in all libosmocore applications, and IO_URING is enabled via environment, adding another env variable is fine with me. But I agree with @pespin regarding the global variable. Note that it will likely have to be __thread / thread-local-storage like all of our I/O. It should be very chaep to set and check compared to unneeded io_uring_submit() all the time without knowig if we actually did submit any new sqe during that given select loop iteration. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id34fe2ced32c63d15b14810e145744f7509064cc Gerrit-Change-Number: 40489 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:12:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: add run --asan

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40589?usp=email ) Change subject: testenv: add run --asan ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1947dd3a7d9ce51dcbef9cffd5d7b402f236b9e2 Gerrit-Change-Number: 40589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:08:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Cosmetic: testenv: tweak argparse formatting

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40588?usp=email ) Change subject: Cosmetic: testenv: tweak argparse formatting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1804f0313a27ddf8f7197ce0b2ad3b56421b290 Gerrit-Change-Number: 40588 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:08:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025