July 2025 - gerrit-log - lists.osmocom.org

[XL] Change in libosmo-sigtran[master]: sccp: Split sccp_scoc into multiple files

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40581?usp=email ) Change subject: sccp: Split sccp_scoc into multiple files ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Like many of your patches moving stuff around and splitting it into more files I don't reall see the benefit... it just makes it harder to navigate the code as one always has to use ctags or related to jump between all those files. Just my two cents. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I51e9bf60bc4c4b2babd3f408daed914eaf398e82 Gerrit-Change-Number: 40581 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:32:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Cosmetic: testenv: tweak argparse formatting

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40588?usp=email ) Change subject: Cosmetic: testenv: tweak argparse formatting ...................................................................... Cosmetic: testenv: tweak argparse formatting Make all "add_argument" calls consistently have one function argument in one line, instead of only having it in some places, and have all arguments in one line in others. Having one function arg in one line is enforced via ruff format when having a comma at the end of the function call. Change-Id: Ia1804f0313a27ddf8f7197ce0b2ad3b56421b290 --- M _testenv/testenv/__init__.py 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/_testenv/testenv/__init__.py b/_testenv/testenv/__init__.py index 511ec58..f2f0321 100644 --- a/_testenv/testenv/__init__.py +++ b/_testenv/testenv/__init__.py @@ -73,7 +73,10 @@ sub_run = sub.add_parser("run", help="build components and run a testsuite") group = sub_run.add_argument_group("testsuite options") - group.add_argument("testsuite", help="a directory in osmo-ttcn3-hacks.git (msc, bsc, mgw, ...)") + group.add_argument( + "testsuite", + help="a directory in osmo-ttcn3-hacks.git (msc, bsc, mgw, ...)", + ) group.add_argument( "-t", "--test", @@ -85,8 +88,17 @@ action="append", help="which testenv.cfg to use (supports * wildcards via fnmatch)", ) - group.add_argument("-i", "--io-uring", action="store_true", help="set LIBOSMO_IO_BACKEND=IO_URING") - group.add_argument("-T", "--titan-version", help="which eclipse-titan version to use") + group.add_argument( + "-i", + "--io-uring", + action="store_true", + help="set LIBOSMO_IO_BACKEND=IO_URING", + ) + group.add_argument( + "-T", + "--titan-version", + help="which eclipse-titan version to use", + ) group = sub_run.add_argument_group("source/binary options", "All components are built from source by default.") group.add_argument( @@ -147,10 +159,19 @@ " repository ending in :latest is set" " or --latest is used.", ) - group.add_argument("--latest", action="store_true", help="use latest configs") + group.add_argument( + "--latest", + action="store_true", + help="use latest configs", + ) group = sub_run.add_argument_group("podman options", "All components are run directly on the host by default.") - group.add_argument("-p", "--podman", action="store_true", help="run all components inside podman") + group.add_argument( + "-p", + "--podman", + action="store_true", + help="run all components inside podman", + ) group.add_argument( "-d", "--distro", @@ -165,7 +186,11 @@ ) group = sub_run.add_argument_group("output options") - group.add_argument("-l", "--log-dir", help="log here instead of a random dir in /tmp") + group.add_argument( + "-l", + "--log-dir", + help="log here instead of a random dir in /tmp", + ) group.add_argument( "-n", "--no-tee", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1804f0313a27ddf8f7197ce0b2ad3b56421b290 Gerrit-Change-Number: 40588 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: add run --asan

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40589?usp=email ) Change subject: testenv: add run --asan ...................................................................... testenv: add run --asan Add a new --asan option for building Osmocom libraries and programs from source with address sanitizer enabled. This works by adding sanitize.opts to osmo-dev's gen_makefile.py, which in turn adds --enable-sanitize to most Osmocom projects. The --autoreconf-in-src-copy argument for gen_makefile.py must be moved up, so the list of *.opts files is not interrupted by another type of argument that causes argument parsing to fail. Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Related: https://gitea.osmocom.org/osmocom/osmo-dev/src/branch/master/sanitize.opts Change-Id: I1947dd3a7d9ce51dcbef9cffd5d7b402f236b9e2 --- M _testenv/testenv/__init__.py M _testenv/testenv/cmd.py M _testenv/testenv/osmo_dev.py 3 files changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/_testenv/testenv/__init__.py b/_testenv/testenv/__init__.py index f2f0321..3de7f0c 100644 --- a/_testenv/testenv/__init__.py +++ b/_testenv/testenv/__init__.py @@ -113,6 +113,12 @@ help="number of jobs to run simultaneously (default: nproc)", type=int, ) + group.add_argument( + "-a", + "--asan", + action="store_true", + help="pass --enable-sanitize to Osmocom configure scripts", + ) group = sub_run.add_argument_group("exit options", "When and how testenv should exit when done.") group = group.add_mutually_exclusive_group() @@ -229,6 +235,11 @@ if args.action != "run": return + if args.binary_repo and args.asan: + raise NoTraceException( + "--binary-repo cannot be used with --asan, consider using '--binary-repo osmocom:nightly:asan' instead" + ) + if args.binary_repo and not args.podman: raise NoTraceException("--binary-repo requires --podman") diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index d4a1e9a..e8598f0 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -56,6 +56,8 @@ else: make_dir = os.path.join(testenv.args.cache, "host", "make") make_dir += str(make_dir_version) + if testenv.args.asan: + make_dir += "-asan" env_extra["OSMO_DEV_MAKE_DIR"] = make_dir if testenv.args.kernel == "debian": diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index 45912ae..5852063 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -58,6 +58,8 @@ return extra_opts = [] + if testenv.args.asan: + extra_opts += ["sanitize.opts"] if testenv.args.jobs: extra_opts += [f"-j{testenv.args.jobs}"] @@ -73,6 +75,7 @@ "--no-ldconfig", "--src-dir", testenv.src_dir, + "--autoreconf-in-src-copy", "default.opts", "ccache.opts", "gtp_linux.opts", @@ -85,7 +88,6 @@ "no_systemd.opts", "werror.opts", os.path.join(testenv.data_dir, "osmo-dev/testenv.opts"), - "--autoreconf-in-src-copy", ] + extra_opts cwd = get_osmo_dev_dir() -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1947dd3a7d9ce51dcbef9cffd5d7b402f236b9e2 Gerrit-Change-Number: 40589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: add run --asan

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40589?usp=email ) Change subject: testenv: add run --asan ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1947dd3a7d9ce51dcbef9cffd5d7b402f236b9e2 Gerrit-Change-Number: 40589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:32:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Cosmetic: testenv: tweak argparse formatting

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40588?usp=email ) Change subject: Cosmetic: testenv: tweak argparse formatting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1804f0313a27ddf8f7197ce0b2ad3b56421b290 Gerrit-Change-Number: 40588 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:31:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: as: Avoid adding dyn route when IPA AS becomes active

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40580?usp=email ) Change subject: as: Avoid adding dyn route when IPA AS becomes active ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8997d40f2a779734432b40d27f9345d9a739d36f Gerrit-Change-Number: 40580 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:30:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[M] Change in libosmocore[master]: Send multiple read/recvfrom SQEs in advance

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email ) Change subject: Send multiple read/recvfrom SQEs in advance ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: I think you are not taking into account that you may receive unordered receives with this? File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/54b5678f_a425aa19?… : PS4, Line 122: if ((env = getenv(OSMO_IO_URING_READ_SQE))) { again, this should be configurable per osmo_iofd API afaiu, rather than here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id50a8900fa2fe6de553e5025feae7e1e8d501e30 Gerrit-Change-Number: 40494 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 6 days

1
0
0 0

[S] Change in libosmo-sigtran[master]: ss7_vty: Avoid adding route to local PC in role ASP

by laforge

Attention is currently required from: dexter, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email ) Change subject: ss7_vty: Avoid adding route to local PC in role ASP ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: adding @dexter as he wrote the original commit. I don't understand the rationale of b4f1b2cb8bd404f08601dc8ca700b672a455846c as on the ASP side the routing context (identiifed by a key) is the ASP-side point code and not a remote point code. But probably still worth to get @dexter input [and revisit SYS#5392 which apparently prompted the original commit] -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic602de42e37c4579f530823bb41e0a8193ce73bb Gerrit-Change-Number: 40579 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:29:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[M] Change in libosmocore[master]: Add multiple messages buffers to io_uring write operations

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email ) Change subject: Add multiple messages buffers to io_uring write operations ...................................................................... Patch Set 4: (8 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/f4ab2e23_66117fc5?… : PS4, Line 248: lh = iofd->tx_queue.msg_queue.prev; fyi we have llist_last(). We may also want to add llist_last_entry_or_null() to linuxlist.h, we already have llist_first_entry_or_null(). https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/ec17b58f_8a08236b?… : PS4, Line 444: /* Re-enqueue remaining buffers. */ Here we should improve it by adding new msg from the tx_queue into the iov if we aren't yet doing it. https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/7d307ae3_038efe13?… : PS4, Line 451: if (rc < chunk) shouldn't this case be already handled in the if path in line 431? https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/7d6fa351_bb7a5ab3?… : PS4, Line 465: iofd->io_ops.write_cb(iofd, (rc < 0) ? rc : chunk, msg); Again, by incorporation the negative value case into chunk variable, we can simplify all these lines here which now have a ": ?". https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/bcc08743_17cb65c4?… : PS4, Line 479: msgb_free(msghdr->msg[idx]); msghdr->msg[idx] = NULL; https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/48579013_26af2f86?… : PS4, Line 517: msghdr = iofd_txqueue_tail(iofd); why are you picking the tail here? Because the assumption is that the other before it are already filled? Do you mind writing teh rationale in a comment? https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/eddfcee1_12b0e64c?… : PS4, Line 531: you can simply do "idx = msghdr->msg_len - 1;" here, and simplify both branches above. https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/867d036a_1ebad94d?… : PS4, Line 539: rc = iofd_txqueue_enqueue(iofd, msghdr); are you submitting to io_uring queue inside here? Because then it looks like yoy may be modifying stuff you already submitted to io_uring... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c4e0a785cf66becd7fb5b2caf718c9724b56686 Gerrit-Change-Number: 40493 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:28:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 6 days

1
0
0 0

[S] Change in osmo-ci[master]: jobs: add ttcn3-bsc-test-{sccplite,vamos}-asan

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40587?usp=email ) Change subject: jobs: add ttcn3-bsc-test-{sccplite,vamos}-asan ...................................................................... jobs: add ttcn3-bsc-test-{sccplite,vamos}-asan Fix that we didn't have asan variants of those two. Change-Id: I9888ec08bc39baaf713cb0a89d133e10fed50e0d --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 609a215..542dcf4 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -502,6 +502,16 @@ args: -b osmocom:nightly:asan -c generic timer: H 16 * * * + - ttcn3-bsc-test-sccplite-asan: # ~76 min + testsuite: bsc + args: -b osmocom:nightly:asan -c sccplite + timer: H 16 * * * + + - ttcn3-bsc-test-vamos-asan: # ~4 min + testsuite: bsc + args: -b osmocom:nightly:asan -c vamos + timer: H 16 * * * + - ttcn3-pcap-client-test-asan: # ~1 min testsuite: pcap-client args: -b osmocom:nightly:asan -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9888ec08bc39baaf713cb0a89d133e10fed50e0d Gerrit-Change-Number: 40587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025