July 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Indicate PC (un)availability from address-book when AS goes up/down

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40563?usp=email ) Change subject: Indicate PC (un)availability from address-book when AS goes up/down ...................................................................... Indicate PC (un)availability from address-book when AS goes up/down These are generally PCs the user wants to get information about, and they may have no fully-qualified route because: - user may not have configured such fully qualified route, but a summary route (eg. 0.0.0/0 default route). - peer SG may have not announced them (DAVA/DUNA) Change-Id: I8b15b2ce46ced1be8fb6467cb3239337731b1090 --- M src/ss7_route_table.c M src/ss7_route_table.h M src/xua_as_fsm.c 3 files changed, 96 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/ss7_route_table.c b/src/ss7_route_table.c index 16eb9bd..210d69c 100644 --- a/src/ss7_route_table.c +++ b/src/ss7_route_table.c @@ -341,3 +341,49 @@ } return false; } + +/* Figure out whether a remote PC is accessible over a route via a specific AS + * Note: Unlike ss7_route_table_lookup_route(), this function is read-only and doesn't modify any state. */ +bool ss7_route_table_dpc_is_accessible_via_as(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, const struct osmo_ss7_as *as) +{ + struct osmo_ss7_combined_linkset *clset; + struct osmo_ss7_route *rt; + /* we assume the combined_links are sorted by mask length, i.e. more + * specific combined links first, and less specific combined links with shorter + * mask later */ + llist_for_each_entry(clset, &rtbl->combined_linksets, list) { + if ((dpc & clset->cfg.mask) != clset->cfg.pc) + continue; + llist_for_each_entry(rt, &clset->routes, list) { + if (rt->dest.as != as) + continue; + if (!ss7_route_is_available(rt)) + continue; + return true; + } + } + return false; +} + +/* Figure out whether a remote PC is accessible over any route not going via a specific excluded AS + * Note: Unlike ss7_route_table_lookup_route(), this function is read-only and doesn't modify any state. */ +bool ss7_route_table_dpc_is_accessible_skip_as(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, const struct osmo_ss7_as *as) +{ + struct osmo_ss7_combined_linkset *clset; + struct osmo_ss7_route *rt; + /* we assume the combined_links are sorted by mask length, i.e. more + * specific combined links first, and less specific combined links with shorter + * mask later */ + llist_for_each_entry(clset, &rtbl->combined_linksets, list) { + if ((dpc & clset->cfg.mask) != clset->cfg.pc) + continue; + llist_for_each_entry(rt, &clset->routes, list) { + if (rt->dest.as == as) + continue; + if (!ss7_route_is_available(rt)) + continue; + return true; + } + } + return false; +} diff --git a/src/ss7_route_table.h b/src/ss7_route_table.h index 582a8d3..98cddab 100644 --- a/src/ss7_route_table.h +++ b/src/ss7_route_table.h @@ -47,6 +47,8 @@ struct osmo_ss7_route * ss7_route_table_lookup_route(const struct osmo_ss7_route_table *rtbl, const struct osmo_ss7_route_label *rtlabel); bool ss7_route_table_dpc_is_accessible(const struct osmo_ss7_route_table *rtbl, uint32_t dpc); +bool ss7_route_table_dpc_is_accessible_via_as(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, const struct osmo_ss7_as *as); +bool ss7_route_table_dpc_is_accessible_skip_as(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, const struct osmo_ss7_as *as); struct osmo_ss7_combined_linkset * ss7_route_table_find_combined_linkset(const struct osmo_ss7_route_table *rtbl, uint32_t dpc, uint32_t mask, uint32_t prio); diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index eb3ac49..89512de 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -24,6 +24,7 @@ #include <osmocom/sigtran/protocol/m3ua.h> #include <sys/types.h> +#include "sccp_internal.h" #include "ss7_as.h" #include "ss7_asp.h" #include "ss7_combined_linkset.h" @@ -451,6 +452,28 @@ xua_snm_pc_available(as, &aff_pc, 1, NULL, false); } } + + /* Generate PC unavailability indications for PCs in the sccp address-book. + * These are generally PCs the user wants to get information about, and + * they may have no fully-qualified route because: + * - user may have not configured such fully qualified route, but a + * summary route (eg. 0.0.0/0 default route). + * - peer SG may have not announced them (DAVA/DUNA). + */ + struct osmo_sccp_addr_entry *entry; + llist_for_each_entry(entry, &s7i->cfg.sccp_address_book, list) { + if (!(entry->addr.presence & OSMO_SCCP_ADDR_T_PC)) + continue; + if (osmo_ss7_pc_is_local(s7i, entry->addr.pc)) + continue; + /* Still available: */ + if (ss7_route_table_dpc_is_accessible_skip_as(rtbl, entry->addr.pc, as)) + continue; + LOGPAS(as, DLSS7, LOGL_INFO, "AS became inactive => address-book pc=%u=%s is now unavailable\n", + entry->addr.pc, osmo_ss7_pointcode_print(s7i, entry->addr.pc)); + aff_pc = htonl(entry->addr.pc); + xua_snm_pc_available(as, &aff_pc, 1, NULL, false); + } } /* AS became active, trigger SNM PC availability for PCs it served: */ @@ -483,6 +506,31 @@ xua_snm_pc_available(as, &aff_pc, 1, NULL, true); } } + + /* Generate PC availability indications for PCs in the sccp address-book. + * These are generally PCs the user wants to get information about, and + * they may have no fully-qualified route because: + * - user may have not configured such fully qualified route, but a + * summary route (eg. 0.0.0/0 default route). + * - peer SG may have not announced them (DAVA/DUNA). + */ + struct osmo_sccp_addr_entry *entry; + llist_for_each_entry(entry, &s7i->cfg.sccp_address_book, list) { + if (!(entry->addr.presence & OSMO_SCCP_ADDR_T_PC)) + continue; + if (osmo_ss7_pc_is_local(s7i, entry->addr.pc)) + continue; + /* PC was already available: */ + if (ss7_route_table_dpc_is_accessible_skip_as(rtbl, entry->addr.pc, as)) + continue; + /* Try to find if there's an available route via the AS matching this PC. */ + if (!ss7_route_table_dpc_is_accessible_via_as(rtbl, entry->addr.pc, as)) + continue; + LOGPAS(as, DLSS7, LOGL_INFO, "AS became active => address-book pc=%u=%s is now available\n", + entry->addr.pc, osmo_ss7_pointcode_print(s7i, entry->addr.pc)); + aff_pc = htonl(entry->addr.pc); + xua_snm_pc_available(as, &aff_pc, 1, NULL, true); + } } /* onenter call-back responsible of transmitting NTFY to all ASPs in -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8b15b2ce46ced1be8fb6467cb3239337731b1090 Gerrit-Change-Number: 40563 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

3 weeks, 6 days

1
0
0 0

[S] Change in libosmo-sigtran[master]: Improve error log when adding >16 ASPs to an AS

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40571?usp=email ) Change subject: Improve error log when adding >16 ASPs to an AS ...................................................................... Improve error log when adding >16 ASPs to an AS Change-Id: Id9d13e6de24acd6465a099052a48c8b322a8f245 --- M src/ss7_as.c M src/ss7_as_vty.c 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/ss7_as.c b/src/ss7_as.c index fac5ffe..16da09f 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -169,6 +169,7 @@ } } + LOGPAS(as, DLSS7, LOGL_ERROR, "Failed adding ASP %s to AS, ASP table is full!\n", asp->cfg.name); return -ENOSPC; } diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index c34bbed..6ea170e 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -110,9 +110,15 @@ CMD_ATTR_IMMEDIATE) { struct osmo_ss7_as *as = vty->index; + int rc = osmo_ss7_as_add_asp(as, argv[0]); - if (osmo_ss7_as_add_asp(as, argv[0])) { - vty_out(vty, "cannot find ASP '%s'%s", argv[0], VTY_NEWLINE); + if (rc < 0) { + if (rc == -ENODEV) + vty_out(vty, "%% Cannot find ASP '%s'%s", argv[0], VTY_NEWLINE); + else if (rc == -ENOSPC) + vty_out(vty, + "%% Cannot associate ASP '%s' to AS '%s': ASP table for the AS is full!%s", + argv[0], as->cfg.name, VTY_NEWLINE); return CMD_WARNING; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id9d13e6de24acd6465a099052a48c8b322a8f245 Gerrit-Change-Number: 40571 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: Send DUNA during ASP ACT time

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40564?usp=email ) Change subject: Send DUNA during ASP ACT time ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40564?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id9d92c3fda7423a9c79fffac6b650abba9651853 Gerrit-Change-Number: 40564 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Jul 2025 14:29:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: Indicate PC (un)availability from address-book when AS goes up/down

by pespin

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40563?usp=email ) Change subject: Indicate PC (un)availability from address-book when AS goes up/down ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8b15b2ce46ced1be8fb6467cb3239337731b1090 Gerrit-Change-Number: 40563 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Jul 2025 14:29:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[XS] Change in pysim[master]: tester: temporarily disable physical tests

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40577?usp=email ) Change subject: tester: temporarily disable physical tests ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: this is not the way. the tests need to get fixed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I395adbcc9c0559e782c8bec64173def3deaa0084 Gerrit-Change-Number: 40577 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Jul 2025 13:51:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[XS] Change in pysim[master]: tester: temporarily disable physical tests

by laforge

laforge has restored this change. ( https://gerrit.osmocom.org/c/pysim/+/40577?usp=email ) Change subject: tester: temporarily disable physical tests ...................................................................... Restored -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I395adbcc9c0559e782c8bec64173def3deaa0084 Gerrit-Change-Number: 40577 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

3 weeks, 6 days

1
0
0 0

[XS] Change in pysim[master]: tester: temporarily disable physical tests

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40577?usp=email ) Change subject: tester: temporarily disable physical tests ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I395adbcc9c0559e782c8bec64173def3deaa0084 Gerrit-Change-Number: 40577 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

3 weeks, 6 days

1
0
0 0

[XS] Change in pysim[master]: tester: temporarily disable physical tests

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40577?usp=email ) Change subject: tester: temporarily disable physical tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I395adbcc9c0559e782c8bec64173def3deaa0084 Gerrit-Change-Number: 40577 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Jul 2025 13:50:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[XS] Change in pysim[master]: tester: temporarily disable physical tests

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40577?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: tester: temporarily disable physical tests ...................................................................... tester: temporarily disable physical tests Setup is being worked on. Change-Id: I395adbcc9c0559e782c8bec64173def3deaa0084 --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/77/40577/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I395adbcc9c0559e782c8bec64173def3deaa0084 Gerrit-Change-Number: 40577 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[M] Change in osmo-bsc[master]: bsc: Make sure MSC PC is added to sccp-addressbook

by osmith

Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40562?usp=email ) Change subject: bsc: Make sure MSC PC is added to sccp-addressbook ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I57dca92eb5f482e9017d9b19cd7f8feebd9e2721 Gerrit-Change-Number: 40562 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Jul 2025 12:52:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025