July 2025 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-ggsn[master]: gtp: add support for SGSN Context Req/Resp/Ack

by lynxis lazus

Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email ) Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... Patch Set 20: (15 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/ced5c66e_f8be7790?us… : PS18, Line 11: the API for the SGSN which uses libgtp as well as the external SGSN which communicates > cosmetic: too long commit log; your local git client should likely have warned you about it already? No, my git client doesn't warn me about it. I'll check how to enable it. File gtp/gtp.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/86ba9f2e_a86c4f94?us… : PS18, Line 400: union gtp_packet *packet, int len, > indentation Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/01712082_610a06b3?us… : PS18, Line 888: const struct sockaddr_in *peer, union gtpie_member **ie, size_t ie_size) > the "**ie" contents can be consitfied like you did in a previous patch right? no. it gets modified. https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e32d80c4_8b1c3275?us… : PS18, Line 894: union gtpie_member resp_ie_elem[2] = {}; > req_ie_elem? Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/57ce1f68_8368b643?us… : PS18, Line 925: union gtpie_member **ie, unsigned int ie_size) > constify? no. it gets modified. https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/80cd35a2_c26410c6?us… : PS18, Line 967: union gtpie_member *ie[GTP_MAX] = {}; > why GTP_MAX elements if you are only configuring one below? Because of the GTP code base. I've removed ie_size/ie_len field from the outside api because the whole internal code expect to have an ie[GTPIE_SIZE]. I dislike this behavior, but don't see a good point in fixing this here. https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/bab2186f_3d9709c1?us… : PS18, Line 981: union gtpie_member **ie, unsigned int ie_size) > constify I would like to allow the fsm to modify the list of ies on the way to the wire. Or I have to copy the whole list. https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/16abb64f_215b51e4?us… : PS18, Line 1203: /* FIXME: parse PDP Address */ > what about this? afaiu it's done bleow already? Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/fd68c81f_b2e6b423?us… : PS18, Line 1217: /* FIXME: check for correct type and length */ > what about this? Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/433b7c9a_763b6ad2?us… : PS18, Line 1429: /* FIXME: retransmission need to be implemented: > afaiu this is already done by gtp_conf()? I need to write a test case for and check if gtp_conf() is really re-transmitting. The SGSN Req/Resp/Ack is a little bit special in this regard, because they are 3 packets instead of 2 (Req/Resp). File gtp/gtp_sgsn_ctx.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/7b6ff65f_9fcd98cd?us… : PS18, Line 25: /* remote SGSN/MME request a Ctx from this peer */ > adding a whitespace line before this one may help understand there are 2 blocks of states. Done https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/9038ccf5_fb19520f?us… : PS18, Line 52: struct llist_head local_reqs; > we'll probably need some sort of hashtable here later on. Sure we could switch to a hash map. But there shouldn't be a huge list of outstanding SGSN contexts around. https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/0a08b041_487c4d32?us… : PS18, Line 67: struct osmo_fsm_inst *fsm; > can we call this "fi" like virtually everywhere in our code base? Done File gtp/gtp_sgsn_ctx.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/20fe9a60_464b202e?us… : PS18, Line 325: llist_del(&req->list); > req is not added to any llist during _alloc(), which means if user calls "req = sgsn_ctx_alloc(); sg […] It is added to a list by sgsn_ctx_req_alloc_outgoing or *sgsn_ctx_req_alloc_incoming. sgsn_ctx_req_alloc() is never directly called except to one of those. I'll add an underscope to the function to make it more clear. https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/34a75f76_f1502df3?us… : PS18, Line 439: /* TODO: move tx GTPv1 into the fsm */ > what about this and similar ones below? I'm currently not very happy with this approach. The fsm doesn't transmit the packet, it only validates a packet, but not transmitting it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 20 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 23:21:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XL] Change in osmo-ggsn[master]: gtp: add support for SGSN Context Req/Resp/Ack

by lynxis lazus

Attention is currently required from: daniel, lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email to look at the new patch set (#20). Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... gtp: add support for SGSN Context Req/Resp/Ack To handle both incoming and outgoing SGSN Context via GTPv1. Introduce a FSM which handles the state of SGSN Context to simplify the API for the SGSN which uses libgtp as well as the external SGSN which communicates via GTP. Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 --- M TODO-RELEASE M configure.ac M gtp/Makefile.am M gtp/gsn.c M gtp/gtp.c A gtp/gtp_sgsn_ctx.c A gtp/gtp_sgsn_ctx.h M include/osmocom/gtp/gsn.h M include/osmocom/gtp/gtp.h 9 files changed, 1,368 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/38/38938/20 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 20 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ggsn[master]: gtp.c: no-op: use ntohs instead of htons

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40433?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gtp.c: no-op: use ntohs instead of htons ...................................................................... gtp.c: no-op: use ntohs instead of htons Even the operation is the same, the sin_port is in network order. Change-Id: Iebb031debfa7706f0ab682c94492b37573ae918d --- M gtp/gsn.c M gtp/gtp.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/33/40433/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40433?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iebb031debfa7706f0ab682c94492b37573ae918d Gerrit-Change-Number: 40433 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ggsn[master]: gtp: internal LOGP_WITH_ADDR macro: use pointer of peer

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40434?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gtp: internal LOGP_WITH_ADDR macro: use pointer of peer ...................................................................... gtp: internal LOGP_WITH_ADDR macro: use pointer of peer Using a pointer is more universal for the macro. Further the upcoming SGSN Context Req/Response/Ack code will use a peer pointer instead of the direct object. Change-Id: Iab11a8b07eb177c479e1920cd7fa8be2099a4b7b --- M gtp/gsn.c M gtp/gtp.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/34/40434/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iab11a8b07eb177c479e1920cd7fa8be2099a4b7b Gerrit-Change-Number: 40434 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h ...................................................................... gtp: move LOGP_WITH_ADDR & GTP_LOGPKG into gtp_internal.h Log macros will be used by multiple internal files. Change-Id: I3b59b067fc75d2ca2cbfe5cec010615e9b788923 --- M gtp/gsn.c M gtp/gtp.c M gtp/gtp_internal.h 3 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/35/40435/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40435?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3b59b067fc75d2ca2cbfe5cec010615e9b788923 Gerrit-Change-Number: 40435 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 months, 2 weeks

1
0
0 0

[M] Change in osmo-ggsn[master]: gsn: fix coding style issue

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gsn: fix coding style issue ...................................................................... gsn: fix coding style issue Remove a space between callbacks. Change-Id: I1d978ed32619b626e82aa70887ac94b82c4de378 --- M gtp/gsn.c M include/osmocom/gtp/gsn.h 2 files changed, 36 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/36/40436/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40436?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1d978ed32619b626e82aa70887ac94b82c4de378 Gerrit-Change-Number: 40436 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 months, 2 weeks

1
0
0 0

[XL] Change in osmo-ggsn[master]: gtp: add support for SGSN Context Req/Resp/Ack

by lynxis lazus

Attention is currently required from: daniel, lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email to look at the new patch set (#19). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... gtp: add support for SGSN Context Req/Resp/Ack To handle both incoming and outgoing SGSN Context via GTPv1. Introduce a FSM which handles the state of SGSN Context to simplify the API for the SGSN which uses libgtp as well as the external SGSN which communicates via GTP. Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 --- M TODO-RELEASE M configure.ac M gtp/Makefile.am M gtp/gsn.c M gtp/gtp.c A gtp/gtp_sgsn_ctx.c A gtp/gtp_sgsn_ctx.h M include/osmocom/gtp/gsn.h M include/osmocom/gtp/gtp.h 9 files changed, 1,368 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/38/38938/19 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc-sccplite: Fix override of opc of incoming msgs

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email ) Change subject: bsc-sccplite: Fix override of opc of incoming msgs ...................................................................... bsc-sccplite: Fix override of opc of incoming msgs This patch fixes a regression introduced recently in a patch. We basically revert that line change. This fixes osmo-bsc crashes spotted during ttcn3-bsc-test-sccplite. Fixes: 40c73568c77ee3747a02fce2cf031d723a938207 Related: OS#6806 Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e --- M bsc/osmo-bsc-sccplite.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bsc/osmo-bsc-sccplite.cfg b/bsc/osmo-bsc-sccplite.cfg index 8e6c72f..74923c1 100644 --- a/bsc/osmo-bsc-sccplite.cfg +++ b/bsc/osmo-bsc-sccplite.cfg @@ -34,7 +34,7 @@ as as-clnt-msc-0 ipa asp asp-clnt-msc-0 routing-key 0 0.23.3 - point-code override dpc 0.23.3 + point-code override dpc 0.23.1 network network country code 1 mobile network code 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e Gerrit-Change-Number: 40591 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc-sccplite: Fix override of opc of incoming msgs

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email ) Change subject: bsc-sccplite: Fix override of opc of incoming msgs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging this one myself in order to avoid further ttcn3-bsc-test-sccplite crashes during weekend. See https://osmocom.org/issues/6806 for more info -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e Gerrit-Change-Number: 40591 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 22:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc-sccplite: Fix override of opc of incoming msgs

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email ) Change subject: bsc-sccplite: Fix override of opc of incoming msgs ...................................................................... bsc-sccplite: Fix override of opc of incoming msgs This patch fixes a regression introduced recently in a patch. We basically revert that line change. This fixes osmo-bsc crashes spotted during ttcn3-bsc-test-sccplite. Fixes: 40c73568c77ee3747a02fce2cf031d723a938207 Related: OS#6806 Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e --- M bsc/osmo-bsc-sccplite.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/40591/1 diff --git a/bsc/osmo-bsc-sccplite.cfg b/bsc/osmo-bsc-sccplite.cfg index 8e6c72f..74923c1 100644 --- a/bsc/osmo-bsc-sccplite.cfg +++ b/bsc/osmo-bsc-sccplite.cfg @@ -34,7 +34,7 @@ as as-clnt-msc-0 ipa asp asp-clnt-msc-0 routing-key 0 0.23.3 - point-code override dpc 0.23.3 + point-code override dpc 0.23.1 network network country code 1 mobile network code 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e Gerrit-Change-Number: 40591 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025