osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/40336?usp=email )
Change subject: Fix typo osmo-bsc -> osmo-cbc
......................................................................
Fix typo osmo-bsc -> osmo-cbc
Change-Id: I3da908d250771ca13e8b3f9069fe4f781defb461
---
M debian/osmo-cbc.install
M doc/manuals/chapters/running.adoc
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/36/40336/1
diff --git a/debian/osmo-cbc.install b/debian/osmo-cbc.install
index 76373fd..5ce45f2 100644
--- a/debian/osmo-cbc.install
+++ b/debian/osmo-cbc.install
@@ -1,4 +1,4 @@
/etc/osmocom/osmo-cbc.cfg
lib/systemd/system/osmo-cbc.service
usr/bin/osmo-cbc
-usr/share/doc/osmo-cbc/examples/osmo-cbc/*.cfg usr/share/doc/osmo-bsc/examples
+usr/share/doc/osmo-cbc/examples/osmo-cbc/*.cfg usr/share/doc/osmo-cbc/examples
diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc
index 5cbe873..b930de1 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -17,5 +17,5 @@
Fork the process as a daemon into background.
*-c, --config-file 'CONFIGFILE'*::
Specify the file and path name of the configuration file to be
- used. If none is specified, use `osmo-bsc.cfg` in the current
+ used. If none is specified, use `osmo-cbc.cfg` in the current
working directory.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/40336?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I3da908d250771ca13e8b3f9069fe4f781defb461
Gerrit-Change-Number: 40336
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40335?usp=email )
Change subject: testenv: check eclipse-titan version
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40335?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icace325f492ce803d6f25a30b128ee0676e16727
Gerrit-Change-Number: 40335
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 May 2025 11:56:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email )
Change subject: start-testsuite: remove workaround for TITAN < 9.0.0
......................................................................
Patch Set 3:
(1 comment)
File start-testsuite.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129/comment/5185618e_2851… :
PS1, Line 48:
> Good points!
adding a version check in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40335 using python's packaging.version to parse and compare the version.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa
Gerrit-Change-Number: 40129
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 May 2025 10:54:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40335?usp=email )
Change subject: testenv: check eclipse-titan version
......................................................................
testenv: check eclipse-titan version
The osmocom:latest repository currently has eclipse-titan 9.0.0 and we
assume that the user has at least this version installed. Add a check to
avoid subtle unexpected errors caused by using older versions.
Related: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa
Change-Id: Icace325f492ce803d6f25a30b128ee0676e16727
---
M _testenv/testenv/requirements.py
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/40335/1
diff --git a/_testenv/testenv/requirements.py b/_testenv/testenv/requirements.py
index cd320d5..5ab61ad 100644
--- a/_testenv/testenv/requirements.py
+++ b/_testenv/testenv/requirements.py
@@ -1,8 +1,10 @@
# Copyright 2024 sysmocom - s.f.m.c. GmbH
# SPDX-License-Identifier: GPL-3.0-or-later
+from packaging.version import Version
import logging
import os.path
import shutil
+import subprocess
import sys
import testenv
import testenv.cmd
@@ -69,6 +71,30 @@
sys.exit(1)
+def check_ttcn3_compiler_version():
+ if testenv.args.podman:
+ return
+
+ ttcn3_min_version = "9.0.0"
+
+ v = subprocess.run(["ttcn3_compiler", "-v"], capture_output=True, text=True)
+ current = None
+ for line in v.stderr.split("\n"):
+ if not line.startswith("Version: "):
+ continue
+
+ current = line.split(":", 1)[1].strip()
+ if Version(current) >= Version(ttcn3_min_version):
+ return
+
+ logging.error(f"Found ttcn3_compiler version {current}, but {ttcn3_min_version} or higher is required.")
+
+ if not current:
+ logging.error("Could not parse ttcn3_compiler version.")
+ logging.error(f"Please install at least version {ttcn3_min_version} and try again.")
+ sys.exit(1)
+
+
def check_fftranscode():
cmd = [
"grep",
@@ -98,6 +124,7 @@
def check():
check_programs()
+ check_ttcn3_compiler_version()
if not testenv.args.podman:
check_fftranscode()
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40335?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icace325f492ce803d6f25a30b128ee0676e16727
Gerrit-Change-Number: 40335
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email )
Change subject: asp: Avoid double-free of received msg if conn is teared down
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Triggered by STP_Tests_IPA.TC_unknown_as_client_nodynamic introduced in osmo-ttcn3-hacks.git Change-Id If6a9f54a19f6a4d833bbf66aad5dafd7e9917f82
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I69f80f611c14db2b328dafd4a90247c6f2dac6fd
Gerrit-Change-Number: 40327
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 May 2025 14:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No