neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40341?usp=email )
Change subject: es2p.py: also allow 18 digit ICCID
......................................................................
es2p.py: also allow 18 digit ICCID
While at it, also use tuples (const) instead of lists (var).
Tweaked-by: nhofmeyr(a)sysmocom.de (docstring, tuples)
Change-Id: Iaa6e710132e3f4c6cecc5ff786922f6c0fcfb54e
---
M pySim/esim/es2p.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/41/40341/1
diff --git a/pySim/esim/es2p.py b/pySim/esim/es2p.py
index 954c7dc..373714e 100644
--- a/pySim/esim/es2p.py
+++ b/pySim/esim/es2p.py
@@ -27,7 +27,7 @@
class param:
class Iccid(ApiParamString):
- """String representation of 19 or 20 digits, where the 20th digit MAY optionally be the padding
+ """String representation of 18 to 20 digits, where the 20th digit MAY optionally be the padding
character F."""
@classmethod
def _encode(cls, data):
@@ -40,7 +40,7 @@
@classmethod
def verify_encoded(cls, data):
- if len(data) not in [19, 20]:
+ if len(data) not in (18, 19, 20):
raise ValueError('ICCID (%s) length (%u) invalid' % (data, len(data)))
@classmethod
@@ -53,7 +53,7 @@
@classmethod
def verify_decoded(cls, data):
data = str(data)
- if len(data) not in [19, 20]:
+ if len(data) not in (18, 19, 20):
raise ValueError('ICCID (%s) length (%u) invalid' % (data, len(data)))
if len(data) == 19:
decimal_part = data
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iaa6e710132e3f4c6cecc5ff786922f6c0fcfb54e
Gerrit-Change-Number: 40341
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/upf-benchmark/+/40339?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: testsuites: Add tunend-2trex test env
......................................................................
testsuites: Add tunend-2trex test env
In order to validate tunend scenario (encaps/decaps) against an UPF, we
use TRex in stateful mode (ASTF) with its tunnels_topo infrastructure.
This setup is less performant than the stateless mode used in the tunmap
scenario, and as a result less throughput can be generated.
This really poses a problem if the host running TRex (generating the
GTPU traffic) is the same or less poerful hardware than the UIT running
the UPF, as generating+handling traffic is at least as complex as the
work UPF is doing.
Hence, in order to be able to use less performant hardware to generate
the traffic, a new test environment is added which expects 2 hosts
instead of 1 running TRex. As a result, the tunnels configured their
traffic are split into 2 segments/buckets of IP addresses/TEIDs, each
configured on the UPF by its own osmo-upf-load-gen over PFCP, and also
traffic for each of those two being generated/handled by one of the two
TRex instances being run.
In order to get the benchmark results, one must add the output from the
console from both TRex instances running in parallel on separate hosts.
With this it becomes possible to fill in the 100Gbps using C240-1 and
c240-2 hosts.
Change-Id: I6dcc3a27ef61857c05ab8d5cb67cceab5bb3dffa
---
A testsuites/gtplab-sysmo2025/tunend-2trex/README.md
A testsuites/gtplab-sysmo2025/tunend-2trex/cpf/0.gtp_flood.vty
A testsuites/gtplab-sysmo2025/tunend-2trex/cpf/0.osmo-upf-load-gen.cfg
A testsuites/gtplab-sysmo2025/tunend-2trex/cpf/1.gtp_flood.vty
A testsuites/gtplab-sysmo2025/tunend-2trex/cpf/1.osmo-upf-load-gen.cfg
A testsuites/gtplab-sysmo2025/tunend-2trex/cpf/configure.sh
A testsuites/gtplab-sysmo2025/tunend-2trex/cpf/gen_gtpu_concurrent_ue_addr_range.py
A testsuites/gtplab-sysmo2025/tunend-2trex/cpf/run.sh
A testsuites/gtplab-sysmo2025/tunend-2trex/topology.dot
A testsuites/gtplab-sysmo2025/tunend-2trex/trex/configure.sh
A testsuites/gtplab-sysmo2025/tunend-2trex/trex/gtpu_topo.py
A testsuites/gtplab-sysmo2025/tunend-2trex/trex/run.sh
A testsuites/gtplab-sysmo2025/tunend-2trex/trex/trex_cfg_c240-1.yaml
A testsuites/gtplab-sysmo2025/tunend-2trex/trex/trex_cfg_c240-2.yaml
A testsuites/gtplab-sysmo2025/tunend-2trex/trex/trex_cfg_epyc1.yaml
A testsuites/gtplab-sysmo2025/tunend-2trex/trex/trex_cfg_gtplab2.yaml
A testsuites/gtplab-sysmo2025/tunend-2trex/trex/udp_simple.py
A testsuites/gtplab-sysmo2025/tunend-2trex/upf/eupf/configure.sh
A testsuites/gtplab-sysmo2025/tunend-2trex/upf/eupf/eupf.yaml
A testsuites/gtplab-sysmo2025/tunend-2trex/upf/eupf/run.sh
A testsuites/gtplab-sysmo2025/tunend-2trex/upf/osmo-upf/configure.sh
A testsuites/gtplab-sysmo2025/tunend-2trex/upf/osmo-upf/osmo-upf.cfg
A testsuites/gtplab-sysmo2025/tunend-2trex/upf/osmo-upf/run.sh
23 files changed, 1,007 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/upf-benchmark refs/changes/39/40339/2
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/40339?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I6dcc3a27ef61857c05ab8d5cb67cceab5bb3dffa
Gerrit-Change-Number: 40339
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder