May 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: stp: Rename STP_Tests.ttcn -> STP_Tests_IPA_M3UA.ttcn

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40308?usp=email ) Change subject: stp: Rename STP_Tests.ttcn -> STP_Tests_IPA_M3UA.ttcn ...................................................................... stp: Rename STP_Tests.ttcn -> STP_Tests_IPA_M3UA.ttcn The previous name usually causes confusion since it seems to indicate either: * Some sort of common placeholder for STP_Tests_IPA and STP_Tests_M3UA (it's not the case, we already have STP_Tests_Common.ttcn for that) * A placeholder for tests not IPA or M3UA related (it's not the case, since it only contains IPA<->M3UA tests). Hence, rename it to denote better the aim of that file, ie. testing forwarding between IPA and M3UA AS(P)s. Change-Id: Id2963407adf11add01630c3899a062d764c8ad75 --- M stp/README.md M stp/STP_Tests.cfg M stp/STP_Tests_Common.ttcn M stp/STP_Tests_IPA.ttcn R stp/STP_Tests_IPA_M3UA.ttcn M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml 7 files changed, 11 insertions(+), 11 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/stp/README.md b/stp/README.md index 20a42b5..d79b741 100644 --- a/stp/README.md +++ b/stp/README.md @@ -1,4 +1,4 @@ -# STP_Tests.ttcn +# STP_Tests_*.ttcn * external interfaces * M3UA/SCTP (can emulate both client and server side) @@ -9,7 +9,7 @@ digraph G { rankdir=LR; STP [label="IUT\nosmo-stp",shape="box"]; - ATS [label="ATS\nSTP_Tests.ttcn"]; + ATS [label="ATS\nSTP_Tests_*.ttcn"]; ATS -> STP [label="M3UA", dir="both"]; ATS -> STP [label="IPA", dir="both"]; diff --git a/stp/STP_Tests.cfg b/stp/STP_Tests.cfg index 945ef8f..169185e 100644 --- a/stp/STP_Tests.cfg +++ b/stp/STP_Tests.cfg @@ -17,4 +17,4 @@ [EXECUTE] STP_Tests_M3UA.control STP_Tests_IPA.control -STP_Tests.control +STP_Tests_IPA_M3UA.control diff --git a/stp/STP_Tests_Common.ttcn b/stp/STP_Tests_Common.ttcn index a540b10..463e935 100644 --- a/stp/STP_Tests_Common.ttcn +++ b/stp/STP_Tests_Common.ttcn @@ -10,9 +10,9 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -friend module STP_Tests; friend module STP_Tests_M3UA; friend module STP_Tests_IPA; +friend module STP_Tests_IPA_M3UA; import from TELNETasp_PortType all; import from Osmocom_VTY_Functions all; diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index ae7e1da..b7da439 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -10,7 +10,7 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -friend module STP_Tests; +friend module STP_Tests_IPA_M3UA; import from General_Types all; import from Osmocom_Types all; diff --git a/stp/STP_Tests.ttcn b/stp/STP_Tests_IPA_M3UA.ttcn similarity index 99% rename from stp/STP_Tests.ttcn rename to stp/STP_Tests_IPA_M3UA.ttcn index b7f6ec1..08ca5aa 100644 --- a/stp/STP_Tests.ttcn +++ b/stp/STP_Tests_IPA_M3UA.ttcn @@ -1,4 +1,4 @@ -module STP_Tests { +module STP_Tests_IPA_M3UA { /* Osmocom STP test suite in in TTCN-3 * (C) 2019 Harald Welte <laforge(a)gnumonks.org> diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 0d2e87d..eddd0b1 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -11,7 +11,7 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -friend module STP_Tests; +friend module STP_Tests_IPA_M3UA; import from General_Types all; import from Osmocom_Types all; diff --git a/stp/expected-results.xml b/stp/expected-results.xml index dbe97bf..c0fb22f 100644 --- a/stp/expected-results.xml +++ b/stp/expected-results.xml @@ -52,8 +52,8 @@ <testcase classname='STP_Tests_IPA' name='TC_tmt_loadshare_roundrobin' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_tmt_loadshare_sls' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_tmt_loadshare' time='MASKED'/> - <testcase classname='STP_Tests' name='TC_m3ua_to_ipa' time='MASKED'/> - <testcase classname='STP_Tests' name='TC_ipa_to_m3ua' time='MASKED'/> - <testcase classname='STP_Tests' name='TC_ipa_to_m3ua_ni' time='MASKED'/> - <testcase classname='STP_Tests' name='TC_ipa_to_m3ua_patch_sccp' time='MASKED'/> + <testcase classname='STP_Tests_IPA_M3UA' name='TC_m3ua_to_ipa' time='MASKED'/> + <testcase classname='STP_Tests_IPA_M3UA' name='TC_ipa_to_m3ua' time='MASKED'/> + <testcase classname='STP_Tests_IPA_M3UA' name='TC_ipa_to_m3ua_ni' time='MASKED'/> + <testcase classname='STP_Tests_IPA_M3UA' name='TC_ipa_to_m3ua_patch_sccp' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id2963407adf11add01630c3899a062d764c8ad75 Gerrit-Change-Number: 40308 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_IPA: Support configuring less than 8 AS(P)s

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40322?usp=email ) Change subject: stp: STP_Tests_IPA: Support configuring less than 8 AS(P)s ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40322?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I820d295cd22fe824abf0f60bf6f1f0f3fd069d85 Gerrit-Change-Number: 40322 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 May 2025 12:45:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Rename STP_Tests.ttcn -> STP_Tests_IPA_M3UA.ttcn

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40308?usp=email ) Change subject: stp: Rename STP_Tests.ttcn -> STP_Tests_IPA_M3UA.ttcn ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id2963407adf11add01630c3899a062d764c8ad75 Gerrit-Change-Number: 40308 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 19 May 2025 12:45:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: OBS: build_binpkg: fix building for ubuntu 24.04

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40329?usp=email ) Change subject: OBS: build_binpkg: fix building for ubuntu 24.04 ...................................................................... OBS: build_binpkg: fix building for ubuntu 24.04 Delete the user with the given UID if it already exists, so the image can be built for ubuntu 24.04 too with UID=1000: > [3/6] RUN USERADD --uid=1000 -m user: 0.166 useradd: UID 1000 is not unique Change-Id: I85acbf2de53f02a65ef72d4fed8c2918ec6fa317 --- M scripts/obs/data/build_binpkg.Dockerfile 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/29/40329/1 diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile index 0a96272..ba26a2d 100644 --- a/scripts/obs/data/build_binpkg.Dockerfile +++ b/scripts/obs/data/build_binpkg.Dockerfile @@ -6,7 +6,11 @@ COPY Release.key /usr/share/keyrings/osmocom.asc -RUN useradd --uid=${UID} -m user +RUN set -x && \ + if id "${UID}" >/dev/null 2>&1; then \ + userdel "$(getent passwd "${UID}" | cut -d: -f1)"; \ + fi && \ + useradd --uid=${UID} -m user # Only install build-essential here, and what's needed to add the Osmocom # repository. Everything else must be defined as dependency in the package -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40329?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I85acbf2de53f02a65ef72d4fed8c2918ec6fa317 Gerrit-Change-Number: 40329 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 month, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: OBS: gerrit_binpkgs: add FEED parameter

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40331?usp=email ) Change subject: OBS: gerrit_binpkgs: add FEED parameter ...................................................................... OBS: gerrit_binpkgs: add FEED parameter Allow switching to another feed easily. I'm using this to build packages for ubuntu quickly, for which we don't have a master feed (only for debian 10, 11, 12 currently). Change-Id: I1b04694e475a74b130ab3f801b99a0e827519ff8 --- M scripts/obs/gerrit_binpkgs.sh 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/31/40331/1 diff --git a/scripts/obs/gerrit_binpkgs.sh b/scripts/obs/gerrit_binpkgs.sh index f199844..34f90c4 100755 --- a/scripts/obs/gerrit_binpkgs.sh +++ b/scripts/obs/gerrit_binpkgs.sh @@ -1,6 +1,7 @@ #!/bin/sh -e SCRIPTS_OBS_DIR="$(realpath "$(dirname "$0")")" DISTRO="$1" +FEED=${2:-master} error_exit() { echo "---" @@ -12,9 +13,13 @@ if [ -z "$DISTRO" ]; then - echo "usage: gerrit-binpkgs.sh DISTRO" + echo "usage: gerrit-binpkgs.sh DISTRO [FEED]" + echo + echo "FEED defaults to master." + echo echo "examples:" echo " gerrit-binpkgs.sh debian:12" + echo " gerrit-binpkgs.sh ubuntu:24.04 nightly" echo " gerrit-binpkgs.sh almalinux:8" exit 1 fi @@ -35,6 +40,8 @@ mkdir -p "$CACHE_DIR" rsync -a --delete "$GIT_REPO_DIR" "$CACHE_DIR" +# --feed must be master here, as for build_srcpkg it means that we take the +# currently checked out commit and add a commit_….txt file. echo ":: Building the source package" "$SCRIPTS_OBS_DIR"/build_srcpkg.py \ --allow-unknown-package \ @@ -48,6 +55,7 @@ echo ":: Building the binary packages" "$SCRIPTS_OBS_DIR"/build_binpkg.py \ --docker "$DISTRO" \ + --feed "$FEED" \ "$PROJECT_NAME" || error_exit echo ":: Find binary packages in: $SCRIPTS_OBS_DIR/_temp/binpkgs" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1b04694e475a74b130ab3f801b99a0e827519ff8 Gerrit-Change-Number: 40331 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: OBS: build_binpkg: ubuntu 24.04: fix eclipse-titan

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40330?usp=email ) Change subject: OBS: build_binpkg: ubuntu 24.04: fix eclipse-titan ...................................................................... OBS: build_binpkg: ubuntu 24.04: fix eclipse-titan Fix that installing openjdk-21 as builddep of eclipse-titan fails with: Setting up openjdk-21-jre-headless:amd64 (21.0.7+6~us1-0ubuntu1~24.04) ... update-alternatives: using /usr/lib/jvm/java-21-openjdk-amd64/bin/java to provide /usr/bin/java (java) in auto mode update-alternatives: error: error creating symbolic link '/usr/share/man/man1/java.1.gz.dpkg-tmp': No such file or directory Change-Id: I0d3cf36e5f54616fc7b8629b4ad8eb63342ceb08 --- M scripts/obs/data/build_binpkg.Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/30/40330/1 diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile index ba26a2d..a86d48b 100644 --- a/scripts/obs/data/build_binpkg.Dockerfile +++ b/scripts/obs/data/build_binpkg.Dockerfile @@ -25,6 +25,7 @@ echo "path-exclude=/usr/share/man/*" \ > /etc/dpkg/dpkg.cfg.d/exclude-man-pages && \ rm -rf /usr/share/man/ && \ + mkdir -p /usr/share/man/man1/ && \ apt-get update && \ apt-get install -y --no-install-recommends \ build-essential \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0d3cf36e5f54616fc7b8629b4ad8eb63342ceb08 Gerrit-Change-Number: 40330 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 month, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: asp: Avoid double-free of received msg if conn is teared down

by osmith

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email ) Change subject: asp: Avoid double-free of received msg if conn is teared down ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I69f80f611c14db2b328dafd4a90247c6f2dac6fd Gerrit-Change-Number: 40327 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 May 2025 08:04:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs: ttcn3-stp*: Pass '-c all'

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ci/+/40326?usp=email ) Change subject: jobs: ttcn3-stp*: Pass '-c all' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40326?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I76af2a979c1f29711bf9c3865d08229240f13eba Gerrit-Change-Number: 40326 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 May 2025 07:59:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: stp: ipa: Specify ASP names to use per test

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40328?usp=email ) Change subject: stp: ipa: Specify ASP names to use per test ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifce2a3964d4caf0850691515e516cee93dbe8d44 Gerrit-Change-Number: 40328 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 May 2025 07:58:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Specify ASP names to use per test

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40325?usp=email ) Change subject: stp: m3ua: Specify ASP names to use per test ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40325?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I63ed043014ee8a9a593ed17797b621f39c746bcd Gerrit-Change-Number: 40325 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 May 2025 07:55:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025