April 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: asp: Rename and clarify asp_id field

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email ) Change subject: asp: Rename and clarify asp_id field ...................................................................... Patch Set 1: (1 comment) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006/comment/e0b8c081_87bf4… : PS1, Line 219: xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp->asp_id); > the commit message only talks about renaming the field, but here the logic is changed to not send th […] I'm already explaining it in the commit msg: "and using this same value when sending our own ASP Identifier during ASPUP. This was not causing a problem since actually we have no real way to set asp_id_present on our own in ASP mode yet, so no local ASP Identifier is ever being transmitted." It makes more sense to do it here, because this commit is not omly a "rename" commit but a "clarify and rename" commit, and both need to go together since 2 different uses were entangled in the same field. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8e4304099db6fb12cf4b40a5b9a4aa3a83c95fde Gerrit-Change-Number: 40006 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Apr 2025 13:02:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in osmo-hnbgw[master]: Improve paging to support Paging Area ID

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email ) Change subject: Improve paging to support Paging Area ID ...................................................................... Improve paging to support Paging Area ID Avoid broadcasting to all HNBs if CN requests paging on a specific LAI/RAI. The overall logic is also improved, eg. avoid adding a record if we didn't forward any paging request at all... Change-Id: I915254a39ee04898aa740674b4632a328f281955 --- M include/osmocom/hnbgw/hnbgw_cn.h M src/osmo-hnbgw/cnlink_paging.c M src/osmo-hnbgw/hnbgw_ranap.c 3 files changed, 120 insertions(+), 25 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/hnbgw/hnbgw_cn.h b/include/osmocom/hnbgw/hnbgw_cn.h index 0c99b26..a5fa132 100644 --- a/include/osmocom/hnbgw/hnbgw_cn.h +++ b/include/osmocom/hnbgw/hnbgw_cn.h @@ -25,7 +25,7 @@ void cnlink_resend_reset(struct hnbgw_cnlink *cnlink); void cnlink_set_disconnected(struct hnbgw_cnlink *cnlink); -const char *cnlink_paging_add_ranap(struct hnbgw_cnlink *cnlink, RANAP_InitiatingMessage_t *imsg); +const char *cnlink_paging_add_ranap(struct hnbgw_cnlink *cnlink, const RANAP_PagingIEs_t *paging_ies); struct hnbgw_cnlink *cnlink_find_by_paging_mi(struct hnbgw_cnpool *cnpool, const struct osmo_mobile_identity *mi); enum hnbgw_cnpool_ctr { diff --git a/src/osmo-hnbgw/cnlink_paging.c b/src/osmo-hnbgw/cnlink_paging.c index e5ef2c2..cac78ed 100644 --- a/src/osmo-hnbgw/cnlink_paging.c +++ b/src/osmo-hnbgw/cnlink_paging.c @@ -164,34 +164,27 @@ return NULL; } -const char *cnlink_paging_add_ranap(struct hnbgw_cnlink *cnlink, RANAP_InitiatingMessage_t *imsg) +const char *cnlink_paging_add_ranap(struct hnbgw_cnlink *cnlink, const RANAP_PagingIEs_t *paging_ies) { - RANAP_PagingIEs_t ies; struct osmo_mobile_identity mi = {}; struct osmo_mobile_identity mi2 = {}; RANAP_CN_DomainIndicator_t domain; const char *errmsg; - if (ranap_decode_pagingies(&ies, &imsg->value) < 0) - return "decoding RANAP IEs failed"; + domain = paging_ies->cN_DomainIndicator; + errmsg = omi_from_ranap_ue_id(&mi, &paging_ies->permanentNAS_UE_ID); - domain = ies.cN_DomainIndicator; - errmsg = omi_from_ranap_ue_id(&mi, &ies.permanentNAS_UE_ID); + if (!errmsg && (paging_ies->presenceMask & PAGINGIES_RANAP_TEMPORARYUE_ID_PRESENT)) + errmsg = omi_from_ranap_temp_ue_id(&mi2, &paging_ies->temporaryUE_ID); - if (!errmsg && (ies.presenceMask & PAGINGIES_RANAP_TEMPORARYUE_ID_PRESENT)) - errmsg = omi_from_ranap_temp_ue_id(&mi2, &ies.temporaryUE_ID); - - ranap_free_pagingies(&ies); - LOG_CNLINK(cnlink, DCN, LOGL_DEBUG, "Decoded Paging: %s %s %s%s%s\n", - ranap_domain_name(domain), osmo_mobile_identity_to_str_c(OTC_SELECT, &mi), + LOG_CNLINK(cnlink, DCN, errmsg ? LOGL_NOTICE : LOGL_DEBUG, + "Decoded Paging: %s %s %s%s%s\n", + ranap_domain_name(domain), + osmo_mobile_identity_to_str_c(OTC_SELECT, &mi), mi2.type ? osmo_mobile_identity_to_str_c(OTC_SELECT, &mi2) : "-", errmsg ? " -- MI error: " : "", errmsg ? : ""); - if (cnlink->pool->domain != domain) - return talloc_asprintf(OTC_SELECT, "message indicates domain %s, but this is %s on domain %s\n", - ranap_domain_name(domain), cnlink->name, ranap_domain_name(cnlink->pool->domain)); - if (errmsg) return errmsg; diff --git a/src/osmo-hnbgw/hnbgw_ranap.c b/src/osmo-hnbgw/hnbgw_ranap.c index 3078b7d..f97f53f 100644 --- a/src/osmo-hnbgw/hnbgw_ranap.c +++ b/src/osmo-hnbgw/hnbgw_ranap.c @@ -322,35 +322,137 @@ return 0; } +static const struct value_string ranap_paging_area_id_names[] = { + { RANAP_PagingAreaID_PR_NOTHING, "NOTHING" }, + { RANAP_PagingAreaID_PR_lAI, "LAI" }, + { RANAP_PagingAreaID_PR_rAI, "RAI" }, + { 0, NULL } +}; + +static bool hnb_paging_area_id_match(const struct hnb_context *hnb, + enum RANAP_PagingAreaID_PR t, + const struct osmo_routing_area_id *rai) +{ + switch (t) { + case RANAP_PagingAreaID_PR_NOTHING: + return true; + case RANAP_PagingAreaID_PR_rAI: + if (hnb->id.rac != rai->rac) + return false; + /* fall through */ + case RANAP_PagingAreaID_PR_lAI: + if (hnb->id.lac != rai->lac.lac) + return false; + if (osmo_plmn_cmp(&hnb->id.plmn, &rai->lac.plmn)) + return false; + /* fall through */ + } + return true; +} + +static int lai_from_RANAP_RANAP_LAI(struct osmo_location_area_id *lai, const RANAP_LAI_t *ranap_lai) +{ + if (ranap_lai->pLMNidentity.size < 3) + return -EINVAL; + osmo_plmn_from_bcd(ranap_lai->pLMNidentity.buf, &lai->plmn); + lai->lac = asn1str_to_u16(&ranap_lai->lAC); + return 0; +} + +static int rai_from_RANAP_PagingAreaID(struct osmo_routing_area_id *rai, const RANAP_PagingAreaID_t *paid) +{ + switch (paid->present) { + case RANAP_PagingAreaID_PR_NOTHING: + break; + case RANAP_PagingAreaID_PR_lAI: + return lai_from_RANAP_RANAP_LAI(&rai->lac, &paid->choice.lAI); + case RANAP_PagingAreaID_PR_rAI: + rai->rac = asn1str_to_u8(&paid->choice.rAI.rAC); + return lai_from_RANAP_RANAP_LAI(&rai->lac, &paid->choice.rAI.lAI); + } + return 0; +} + +/* 3GPP TS 25.413 8.15 */ static int cn_ranap_rx_paging_cmd(struct hnbgw_cnlink *cnlink, RANAP_InitiatingMessage_t *imsg, const uint8_t *data, unsigned int len) { + RANAP_PagingIEs_t ies; + RANAP_CN_DomainIndicator_t domain; const char *errmsg; struct hnb_context *hnb; bool is_ps = cnlink->pool->domain == DOMAIN_PS; + bool forwarded = false; + bool page_area_present; + struct osmo_routing_area_id page_rai = {}; - errmsg = cnlink_paging_add_ranap(cnlink, imsg); - if (errmsg) { - LOG_CNLINK(cnlink, DCN, LOGL_ERROR, "Rx Paging from CN: %s. Dropping paging record." - " Later on, the Paging Response may be forwarded to the wrong CN peer.\n", - errmsg); + if (ranap_decode_pagingies(&ies, &imsg->value) < 0) { + LOG_CNLINK(cnlink, DCN, LOGL_ERROR, + "Rx Paging from CN: decoding RANAP IEs failed\n"); return -1; } + domain = ies.cN_DomainIndicator; + page_area_present = (ies.presenceMask & PAGINGIES_RANAP_PAGINGAREAID_PRESENT); - /* FIXME: determine which HNBs to send this Paging command, - * rather than broadcasting to all HNBs */ + if (cnlink->pool->domain != domain) { + LOG_CNLINK(cnlink, DCN, LOGL_ERROR, + "Rx Paging from CN: message indicates domain %s, but cnlink is on domain %s\n", + ranap_domain_name(domain), + ranap_domain_name(cnlink->pool->domain)); + goto free_ies_ret; + } + + if (page_area_present) { + if (rai_from_RANAP_PagingAreaID(&page_rai, &ies.pagingAreaID) < 0) { + LOG_CNLINK(cnlink, DCN, LOGL_ERROR, + "Rx Paging from CN: decoding RANAP IE Paging Area ID failed, broadcasting to all HNBs\n"); + /* fail over to broadcast... */ + page_area_present = false; + } + } + + LOG_CNLINK(cnlink, DCN, LOGL_DEBUG, + "Rx Paging from CN: %s PagingAreaID: %s %s\n", + ranap_domain_name(domain), + page_area_present ? + get_value_string(ranap_paging_area_id_names, ies.pagingAreaID.present) : + "NOT_PRESENT", + osmo_rai_name2(&page_rai) + ); + llist_for_each_entry(hnb, &g_hnbgw->hnb_list, list) { if (!hnb->hnb_registered) continue; + if (page_area_present && + !hnb_paging_area_id_match(hnb, ies.pagingAreaID.present, &page_rai)) + continue; + if (is_ps) HNBP_CTR_INC(hnb->persistent, HNB_CTR_PS_PAGING_ATTEMPTED); else HNBP_CTR_INC(hnb->persistent, HNB_CTR_CS_PAGING_ATTEMPTED); - rua_tx_udt(hnb, data, len); + if (rua_tx_udt(hnb, data, len) == 0) + forwarded = true; } + if (forwarded) { + /* If Paging command was forwarded anywhere, store a record for it, to match paging response: */ + errmsg = cnlink_paging_add_ranap(cnlink, &ies); + if (errmsg) { + LOG_CNLINK(cnlink, DCN, LOGL_ERROR, + "Rx Paging from CN: %s. Skip storing paging record." + " Later on, the Paging Response may be forwarded to the wrong CN peer.\n", + errmsg); + goto free_ies_ret; + } + } + ranap_free_pagingies(&ies); return 0; + +free_ies_ret: + ranap_free_pagingies(&ies); + return -1; } static int ranap_rx_udt_dl_initiating_msg(struct hnbgw_cnlink *cnlink, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I915254a39ee04898aa740674b4632a328f281955 Gerrit-Change-Number: 39995 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in osmo-hnbgw[master]: Improve paging to support Paging Area ID

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email ) Change subject: Improve paging to support Paging Area ID ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I915254a39ee04898aa740674b4632a328f281955 Gerrit-Change-Number: 39995 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Apr 2025 12:50:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs-sync: add Ubuntu 25.04

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40009?usp=email ) Change subject: jobs/osmocom-obs-sync: add Ubuntu 25.04 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaddd4e97153c55febbb95ee2ef0ffaee3582be7f Gerrit-Change-Number: 40009 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Apr 2025 12:49:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: ipa: Use pseudo-random number for SLS in TCP-client too

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40001?usp=email ) Change subject: ipa: Use pseudo-random number for SLS in TCP-client too ...................................................................... ipa: Use pseudo-random number for SLS in TCP-client too Previous commit (see below) replaced the SLS generation from using the LSB of the file descriptor to a pseudo-random SLS since the former didn't really achieve enough entropy in real world use cases. However, that commit only applied it for TCP-server conns, but forgot to update TCP-client ones. Present commit fixes that missing part. asp->asp_id is already being set using a pseudo-randome number in xua_cli_connect_cb(). Fixes: 2c9ba16c2c0210a189c72064eafad5ef336254cd Related: SYS#6543 Related: SYS#6802 Change-Id: I837505868b608ac5ed658a7e98bb3eeebe3e852c --- M src/osmo_ss7_asp.c 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo_ss7_asp.c b/src/osmo_ss7_asp.c index 3f6500c..f785264 100644 --- a/src/osmo_ss7_asp.c +++ b/src/osmo_ss7_asp.c @@ -1027,7 +1027,6 @@ /* read call-back for IPA/SCCPlite socket */ static int ipa_cli_read_cb(struct osmo_stream_cli *conn, int res, struct msgb *msg) { - int fd = osmo_stream_cli_get_fd(conn); struct osmo_ss7_asp *asp = osmo_stream_cli_get_data(conn); if (res <= 0) { @@ -1042,9 +1041,9 @@ msg->dst = asp; rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); - /* we can use the 'fd' return value of osmo_stream_srv_get_fd() here unverified as all we do - * is 'roll the dice' to obtain a 4-bit SLS value. */ - return ipa_rx_msg(asp, msg, fd & 0xf); + /* we simply use the lower 4 bits of the asp_id, which is initialized to a pseudo-random value upon + * connect */ + return ipa_rx_msg(asp, msg, asp->asp_id & 0xf); } /* read call-back for M3UA-over-TCP socket */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I837505868b608ac5ed658a7e98bb3eeebe3e852c Gerrit-Change-Number: 40001 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: AS loadsharing: Pick 1st ASP upon 1st roundrobin assignment

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40000?usp=email ) Change subject: AS loadsharing: Pick 1st ASP upon 1st roundrobin assignment ...................................................................... AS loadsharing: Pick 1st ASP upon 1st roundrobin assignment Before this patch, the AS started filling it's loadsharing tables with the 2nd ASP in the list, which is actually fine too but a bit unexpected when debugging. Change-Id: I9ac08d371dde2cfd433be22f1fb6cd01d6ef12be --- M src/osmo_ss7_as.c 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo_ss7_as.c b/src/osmo_ss7_as.c index e84a36d..4dedfc3 100644 --- a/src/osmo_ss7_as.c +++ b/src/osmo_ss7_as.c @@ -127,6 +127,10 @@ as->cfg.mode = OSMO_SS7_AS_TMOD_OVERRIDE; as->cfg.recovery_timeout_msec = 2000; as->cfg.routing_key.l_rk_id = ss7_find_free_l_rk_id(inst); + + /* Pick 1st ASP upon 1st roundrobin assignment: */ + as->cfg.last_asp_idx_assigned = ARRAY_SIZE(as->cfg.asps) - 1; + as->fi = xua_as_fsm_start(as, LOGL_DEBUG); llist_add_tail(&as->list, &inst->as_list); @@ -356,7 +360,7 @@ void ss7_as_loadshare_binding_table_reset(struct osmo_ss7_as *as) { memset(&as->aesls_table[0], 0, sizeof(as->aesls_table)); - as->cfg.last_asp_idx_assigned = 0; + as->cfg.last_asp_idx_assigned = ARRAY_SIZE(as->cfg.asps) - 1; } static as_ext_sls_t osmo_ss7_instance_calc_itu_as_ext_sls(const struct osmo_ss7_as *as, uint32_t opc, uint8_t sls) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9ac08d371dde2cfd433be22f1fb6cd01d6ef12be Gerrit-Change-Number: 40000 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs-sync: add Ubuntu 25.04

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40009?usp=email ) Change subject: jobs/osmocom-obs-sync: add Ubuntu 25.04 ...................................................................... jobs/osmocom-obs-sync: add Ubuntu 25.04 Change-Id: Iaddd4e97153c55febbb95ee2ef0ffaee3582be7f --- M jobs/osmocom-obs-sync.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/09/40009/1 diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 61578ba..671db02 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -38,6 +38,7 @@ Ubuntu:22.04 Ubuntu:24.04 Ubuntu:24.10 + Ubuntu:25.04 " ./scripts/obs/sync_obs_projects.py \ --docker \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaddd4e97153c55febbb95ee2ef0ffaee3582be7f Gerrit-Change-Number: 40009 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: asp: Expect optional ASP Identifier in Rx ASPUP ACK

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40008?usp=email ) Change subject: asp: Expect optional ASP Identifier in Rx ASPUP ACK ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idaa1a547d835402ca82e4abbae90681a3286d4da Gerrit-Change-Number: 40008 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Apr 2025 08:34:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40007?usp=email ) Change subject: asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9d8fabd8dccea4d45d78c6934737bfea25385e4a Gerrit-Change-Number: 40007 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Apr 2025 08:33:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: asp: Rename and clarify asp_id field

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email ) Change subject: asp: Rename and clarify asp_id field ...................................................................... Patch Set 1: (1 comment) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006/comment/716ca9cf_8965c… : PS1, Line 219: xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp->asp_id); the commit message only talks about renaming the field, but here the logic is changed to not send the identifier anymore in peer_send(). Probably makes sense to mention that in the commit message (or possibly split it out into a separate patch as it is a separate logical change and the commit msg is quite long already?) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8e4304099db6fb12cf4b40a5b9a4aa3a83c95fde Gerrit-Change-Number: 40006 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Apr 2025 08:32:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025