[S] Change in libosmo-sigtran[master]: asp: Rename and clarify asp_id field
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email ) Change subject: asp: Rename and clarify asp_id field ...................................................................... Patch Set 1: (1 comment) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006/comment/716ca9cf_8965c2... : PS1, Line 219: xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp->asp_id); the commit message only talks about renaming the field, but here the logic is changed to not send the identifier anymore in peer_send(). Probably makes sense to mention that in the commit message (or possibly split it out into a separate patch as it is a separate logical change and the commit msg is quite long already?) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8e4304099db6fb12cf4b40a5b9a4aa3a83c95fde Gerrit-Change-Number: 40006 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 11 Apr 2025 08:32:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
osmith