April 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40007?usp=email ) Change subject: asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK ...................................................................... asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK This will basically use the same code logic as ASPUP branch above, so document it here so that it is added in both places at the same time. Change-Id: I9d8fabd8dccea4d45d78c6934737bfea25385e4a --- M src/xua_asp_fsm.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/40007/1 diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index d1e8b24..65af441 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -231,6 +231,17 @@ case XUA_ASP_E_ASPSM_ASPUP_ACK: /* RFC3868 Ch. 3.5.2 */ xua->hdr = XUA_HDR(SUA_MSGC_ASPSM, SUA_ASPSM_UP_ACK); + /* Optional: ASP ID */ +#if 0 + /* TODO: RFC 4666 3.5.2: + * "The optional ASP Identifier parameter is specifically useful for IPSP + * communication. In that case, the IPSP answering the ASP Up message + * MAY include its own ASP Identifier value." */ + if (ss7_asp_peer_requires_asp_id(asp)) { /* Maybe configure in VTY "asp" node? */ + asp_id = /* get a unique id of asp within as, eg. the index in as->asps[] */; + xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp_id); + } +#endif /* Optional: Info String */ break; case XUA_ASP_E_ASPSM_ASPDN: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9d8fabd8dccea4d45d78c6934737bfea25385e4a Gerrit-Change-Number: 40007 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in libosmo-sigtran[master]: ipa: Try picking unused asp_id in AS to use as SLS

by pespin

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email ) Change subject: ipa: Try picking unused asp_id in AS to use as SLS ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS2: Fixed problem with non-dynamic asps, can be reviewed now. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I723eac25e59002630dca87a738c8eb7c62edec75 Gerrit-Change-Number: 40003 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 17:56:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: cosmetic: Fix typo in API comment description

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40004?usp=email ) Change subject: cosmetic: Fix typo in API comment description ...................................................................... cosmetic: Fix typo in API comment description Change-Id: I12546a9a242ad99164c6851921e5bc7eb07cb567 --- M src/xua_asp_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/04/40004/1 diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index ec149d1..cd60df2 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -805,7 +805,7 @@ static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp, enum osmo_ss7_asp_role role, int log_level); -/*! \brief Start a new ASP finite stae machine for given ASP (stored in asp->fi) +/*! \brief Start a new ASP finite state machine for given ASP (stored in asp->fi) * \param[in] asp Application Server Process for which to start FSM * \param[in] role Role (ASP, SG, IPSP) of this FSM * \param[in] log_level Logging Level for ASP FSM logging -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I12546a9a242ad99164c6851921e5bc7eb07cb567 Gerrit-Change-Number: 40004 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in osmo-hnbgw[master]: Improve paging to support Paging Area ID

by fixeria

Attention is currently required from: lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email ) Change subject: Improve paging to support Paging Area ID ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/osmo-hnbgw/hnbgw_ranap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995/comment/bafc3542_7fcb7658?u… : PS2, Line 401: cnlink->name > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I915254a39ee04898aa740674b4632a328f281955 Gerrit-Change-Number: 39995 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 10 Apr 2025 17:26:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in libosmo-sigtran[master]: ipa: Try picking unused asp_id in AS to use as SLS

by pespin

Attention is currently required from: daniel, laforge, osmith, pespin. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email ) Change subject: ipa: Try picking unused asp_id in AS to use as SLS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This breaks non-dynamic IPA ASPs since they apparently never receive the ASSIGNED event, looking at it, marking as WIP meanwhile. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I723eac25e59002630dca87a738c8eb7c62edec75 Gerrit-Change-Number: 40003 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 17:17:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

[M] Change in libosmo-sigtran[master]: ipa: Try picking unused asp_id in AS to use as SLS

by fixeria

Attention is currently required from: daniel, laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email ) Change subject: ipa: Try picking unused asp_id in AS to use as SLS ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003/comment/e98ef5fb_99632… : PS1, Line 1119: for (unsigned i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { > We could, but it's not really a problem right now, we use this same construct in all plces iterating […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I723eac25e59002630dca87a738c8eb7c62edec75 Gerrit-Change-Number: 40003 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 17:16:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in libosmo-sigtran[master]: ipa: Try picking unused asp_id in AS to use as SLS

by pespin

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email ) Change subject: ipa: Try picking unused asp_id in AS to use as SLS ...................................................................... Patch Set 1: (1 comment) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003/comment/de3d4acd_43e9d… : PS1, Line 1119: for (unsigned i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { > I am wondering if we can optimize this a bit by calculating a bitmask of used ASP IDs first? You cou […] We could, but it's not really a problem right now, we use this same construct in all plces iterating ASPs for now. Bear in mind ARRAY_SIZE() is 16 here, and this is only called upon IPA handshake time, so really not important. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I723eac25e59002630dca87a738c8eb7c62edec75 Gerrit-Change-Number: 40003 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 17:05:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in osmo-hnbgw[master]: Improve paging to support Paging Area ID

by pespin

Attention is currently required from: fixeria, lynxis lazus, osmith. Hello Jenkins Builder, fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email to look at the new patch set (#4). Change subject: Improve paging to support Paging Area ID ...................................................................... Improve paging to support Paging Area ID Avoid broadcasting to all HNBs if CN requests paging on a specific LAI/RAI. The overall logic is also improved, eg. avoid adding a record if we didn't forward any paging request at all... Change-Id: I915254a39ee04898aa740674b4632a328f281955 --- M include/osmocom/hnbgw/hnbgw_cn.h M src/osmo-hnbgw/cnlink_paging.c M src/osmo-hnbgw/hnbgw_ranap.c 3 files changed, 120 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/95/39995/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I915254a39ee04898aa740674b4632a328f281955 Gerrit-Change-Number: 39995 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 1 week

1
0
0 0

[M] Change in osmo-hnbgw[master]: Improve paging to support Paging Area ID

by pespin

Attention is currently required from: fixeria, lynxis lazus, osmith. Hello Jenkins Builder, fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: Improve paging to support Paging Area ID ...................................................................... Improve paging to support Paging Area ID Avoid broadcasting to all HNBs if CN requests paging on a specific LAI/RAI. The overall logic is also improved, eg. avoid adding a record if we didn't forward any paging request at all... Change-Id: I915254a39ee04898aa740674b4632a328f281955 --- M include/osmocom/hnbgw/hnbgw_cn.h M src/osmo-hnbgw/cnlink_paging.c M src/osmo-hnbgw/hnbgw_ranap.c 3 files changed, 120 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/95/39995/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I915254a39ee04898aa740674b4632a328f281955 Gerrit-Change-Number: 39995 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 1 week

1
0
0 0

[M] Change in libosmo-sigtran[master]: ipa: Try picking unused asp_id in AS to use as SLS

by fixeria

Attention is currently required from: daniel, laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email ) Change subject: ipa: Try picking unused asp_id in AS to use as SLS ...................................................................... Patch Set 1: (1 comment) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003/comment/ba5e70c9_cff9a… : PS1, Line 1119: for (unsigned i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { I am wondering if we can optimize this a bit by calculating a bitmask of used ASP IDs first? You could then quickly do `mask & (1 << asp_id)` to check if it's used or free. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I723eac25e59002630dca87a738c8eb7c62edec75 Gerrit-Change-Number: 40003 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 17:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025