April 2025 - gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: jenkins-common: support {latest,master}-debian10

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40021?usp=email ) Change subject: jenkins-common: support {latest,master}-debian10 ...................................................................... jenkins-common: support {latest,master}-debian10 It is required that we run the FR tests with debian 10. Adjust jenkins-common.sh so we can use IMAGE_SUFFIX=master-debian10 and IMAGE_SUFFIX=latest-debian10. The related osmo-ci patch will configure jenkins to make use of this. Related: OS#6494#note-19 Related: osmo-ci Ibd4cb705048ef5c39fa4192870e2b0f0d067842f Change-Id: I1a41ca8ddd06f716c4bf29d60a0c2f0f82dc4e35 --- M jenkins-common.sh 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/21/40021/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index acdf262..56cef2a 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -23,6 +23,7 @@ osmo-*-latest-centos8) echo "centos8-obs-latest" ;; osmo-*-centos7) echo "centos7-build" ;; osmo-*-centos8) echo "centos8-build" ;; + osmo-*-debian10) echo "debian-buster-build" ;; osmo-*-latest) echo "debian-$DEBIAN_DEFAULT-obs-latest" ;; osmo-*-asan) echo "debian-$DEBIAN_DEFAULT-obs-asan" ;; osmo_dia2gsup-*) echo "debian-$DEBIAN_DEFAULT-erlang" ;; @@ -40,6 +41,7 @@ osmo-*-centos8) echo "centos8" ;; centos7-*) echo "centos7" ;; centos8-*) echo "centos8" ;; + osmo-*-debian10) echo "debian-buster" ;; debian-buster-*) echo "debian-buster" ;; debian-bullseye-*) echo "debian-bullseye" ;; debian-bookworm-*) echo "debian-bookworm" ;; @@ -53,6 +55,7 @@ osmo-*-centos8) echo "almalinux:8"; ;; centos7-*) echo "centos:centos7" ;; centos8-*) echo "almalinux:8" ;; + osmo-*-debian10) echo "debian:buster" ;; debian9-*) echo "debian:stretch" ;; debian10-*) echo "debian:buster" ;; debian11-*) echo "debian:bullseye" ;; @@ -79,6 +82,10 @@ # e.g. osmo-mgw-latest-centos8 -> osmo-mgw-latest echo "$1" | sed 's/\-centos8$//' ;; + osmo-*-debian10) + # e.g. osmo-gbproxy-master-debian10 -> osmo-gbproxy-master + echo "$1" | sed 's/\-debian10$//' + ;; centos8-obs-20*q*) # e.g. centos8-obs-2021q1 -> centos8-obs-latest echo "$1" | sed 's/20[0-9][0-9]q.*$/latest/' -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1a41ca8ddd06f716c4bf29d60a0c2f0f82dc4e35 Gerrit-Change-Number: 40021 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[L] Change in docker-playground[master]: Remove ttcn3 testsuites ported to testenv, part 3

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40022?usp=email ) Change subject: Remove ttcn3 testsuites ported to testenv, part 3 ...................................................................... Remove ttcn3 testsuites ported to testenv, part 3 Related: OS#6494 Change-Id: Ic07793fb7d8889684fd89b00860ebd0b17561a9e --- D ttcn3-msc-test/Dockerfile D ttcn3-msc-test/MSC_Tests.cfg D ttcn3-msc-test/Makefile D ttcn3-msc-test/jenkins.sh D ttcn3-msc-test/osmo-msc.cfg D ttcn3-msc-test/osmo-stp.cfg D ttcn3-sccp-test/Dockerfile D ttcn3-sccp-test/Makefile D ttcn3-sccp-test/SCCP_Tests.cfg D ttcn3-sccp-test/jenkins.sh D ttcn3-sccp-test/sccp_demo_user.cfg 11 files changed, 0 insertions(+), 405 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/22/40022/1 diff --git a/ttcn3-msc-test/Dockerfile b/ttcn3-msc-test/Dockerfile deleted file mode 100644 index 6fe48d4..0000000 --- a/ttcn3-msc-test/Dockerfile +++ /dev/null @@ -1,13 +0,0 @@ -ARG REGISTRY -ARG USER -FROM $REGISTRY/$USER/debian-bookworm-titan -ARG OSMO_TTCN3_BRANCH="master" - -ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-ttcn3-hacks/+/$OSMO_TTCN3_B… /tmp/commit -RUN ttcn3-docker-prepare "$OSMO_TTCN3_BRANCH" msc - -VOLUME /data - -COPY MSC_Tests.cfg /data/MSC_Tests.cfg - -CMD ttcn3-docker-run msc MSC_Tests diff --git a/ttcn3-msc-test/MSC_Tests.cfg b/ttcn3-msc-test/MSC_Tests.cfg deleted file mode 100644 index 66ad4d1..0000000 --- a/ttcn3-msc-test/MSC_Tests.cfg +++ /dev/null @@ -1,60 +0,0 @@ -[ORDERED_INCLUDE] -"/osmo-ttcn3-hacks/Common.cfg" -"/osmo-ttcn3-hacks/msc/MSC_Tests.default" - -[LOGGING] - -[TESTPORT_PARAMETERS] -*.MSCVTY.CTRL_HOSTNAME := "172.18.20.10" - -[MODULE_PARAMETERS] -# connection to STP -MSC_Tests.mp_bssap_cfg := { - { - transport := BSSAP_TRANSPORT_AoIP, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23906, "172.18.20.103", 2905, "172.18.20.200" }, - own_pc := 193, /* 0.24.1 BSC emulation [0] */ - own_ssn := 254, - peer_pc := 185, /* 0.23.1 osmo-msc */ - peer_ssn := 254, - sio := '83'O, - rctx := 0 - }, - { - transport := BSSAP_TRANSPORT_AoIP, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23907, "172.18.20.103", 2905, "172.18.20.200" }, - own_pc := 194, /* 0.24.2 BSC emulation [1] */ - own_ssn := 254, - peer_pc := 185, /* 0.23.1 osmo-msc */ - peer_ssn := 254, - sio := '83'O, - rctx := 1 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23908, "172.18.20.103", 2905, "172.18.20.200" }, - own_pc := 195, /* 0.24.3 BSC emulation [2] */ - own_ssn := 142, - peer_pc := 185, /* 0.23.1 osmo-msc */ - peer_ssn := 142, - sio := '83'O, - rctx := 2 - } -}; - -# remote (IUT) side -MSC_Tests.mp_msc_mncc := "/data/unix/mncc"; -MSC_Tests.mp_msc_ip := "172.18.20.10"; -# local (emulation) side) -MSC_Tests.mp_hlr_ip := "172.18.20.103"; -MSC_Tests.mp_mgw_ip := "172.18.20.103"; - -[MAIN_CONTROLLER] - -[EXECUTE] -MSC_Tests.control -MSC_Tests_Iu.control -MSC_Tests_ASCI.control diff --git a/ttcn3-msc-test/Makefile b/ttcn3-msc-test/Makefile deleted file mode 100644 index 6eb2c78..0000000 --- a/ttcn3-msc-test/Makefile +++ /dev/null @@ -1,3 +0,0 @@ -RUN_ARGS?=-it --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.20.202 -v ggsn-test-vol:/data - -include ../make/Makefile diff --git a/ttcn3-msc-test/jenkins.sh b/ttcn3-msc-test/jenkins.sh deleted file mode 100755 index 46844d5..0000000 --- a/ttcn3-msc-test/jenkins.sh +++ /dev/null @@ -1,60 +0,0 @@ -#!/bin/sh - -. ../jenkins-common.sh -IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" -docker_images_require \ - "osmo-stp-$IMAGE_SUFFIX" \ - "osmo-msc-$IMAGE_SUFFIX" \ - "ttcn3-msc-test" - -set_clean_up_trap -set -e - -mkdir $VOL_BASE_DIR/msc-tester -mkdir $VOL_BASE_DIR/msc-tester/unix -cp MSC_Tests.cfg $VOL_BASE_DIR/msc-tester/ -write_mp_osmo_repo "$VOL_BASE_DIR/msc-tester/MSC_Tests.cfg" - -mkdir $VOL_BASE_DIR/stp -cp osmo-stp.cfg $VOL_BASE_DIR/stp/ - -mkdir $VOL_BASE_DIR/msc -mkdir $VOL_BASE_DIR/msc/unix -cp osmo-msc.cfg $VOL_BASE_DIR/msc/ - -mkdir $VOL_BASE_DIR/unix - -network_create -network_replace_subnet_in_configs - -echo Starting container with STP -docker run --rm \ - $(docker_network_params $SUBNET 200) \ - --ulimit core=-1 \ - -v $VOL_BASE_DIR/stp:/data \ - --name ${BUILD_TAG}-stp -d \ - $REPO_USER/osmo-stp-$IMAGE_SUFFIX - -echo Starting container with MSC -docker run --rm \ - $(docker_network_params $SUBNET 10) \ - --ulimit core=-1 \ - -v $VOL_BASE_DIR/msc:/data \ - -v $VOL_BASE_DIR/unix:/data/unix \ - --name ${BUILD_TAG}-msc -d \ - $DOCKER_ARGS \ - $REPO_USER/osmo-msc-$IMAGE_SUFFIX \ - /bin/sh -c "osmo-msc -c /data/osmo-msc.cfg >>/data/osmo-msc.log 2>&1" - -echo Starting container with MSC testsuite -docker run --rm \ - $(docker_network_params $SUBNET 103) \ - --ulimit core=-1 \ - -e "TTCN3_PCAP_PATH=/data" \ - -e "OSMO_SUT_HOST=$SUB4_PREFIX.$SUBNET.10" \ - -e "OSMO_SUT_PORT=4254" \ - -v $VOL_BASE_DIR/msc-tester:/data \ - -v $VOL_BASE_DIR/unix:/data/unix \ - --name ${BUILD_TAG}-ttcn3-msc-test \ - $DOCKER_ARGS \ - $REPO_USER/ttcn3-msc-test diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg deleted file mode 100644 index b7b39f9..0000000 --- a/ttcn3-msc-test/osmo-msc.cfg +++ /dev/null @@ -1,98 +0,0 @@ -! -! OsmoMSC (1.1.2.66-629c4-dirty) configuration saved from vty -!! -! -log gsmtap 172.18.20.103 - logging level set-all debug - logging filter all 1 -! -log stderr - logging filter all 1 - logging color 1 - logging print category 1 - logging timestamp 1 - logging print extended-timestamp 1 - logging level rll notice - logging level cc debug - logging level mm debug - logging level rr notice - logging level mncc debug - logging level pag notice - logging level msc notice - logging level mgcp debug - logging level ho notice - logging level db notice - logging level ref notice - logging level ctrl notice - logging level smpp debug - logging level ranap debug - logging level vlr debug - logging level iucs debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl info - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice - logging level lss7 notice - logging level lsccp notice - logging level lsua notice - logging level lm3ua notice - logging level lmgcp debug -! -stats interval 5 -! -line vty - no login - bind 0.0.0.0 -ctrl - bind 0.0.0.0 -! -cs7 instance 0 - point-code 0.23.1 - asp asp-clnt-OsmoMSC-A 2905 0 m3ua - local-ip 172.18.20.10 - local-ip fd02:db8:20::10 - remote-ip 172.18.20.200 - remote-ip fd02:db8:20::200 - role asp - sctp-role client - as as-clnt-OsmoMSC-A m3ua - asp asp-clnt-OsmoMSC-A - routing-key 3 0.23.1 -network - network country code 262 - mobile network code 42 - short name OsmoMSC - long name OsmoMSC - encryption a5 0 - encryption uea 0 - authentication optional - rrlp mode none - mm info 0 -msc - assign-tmsi - cs7-instance-a 0 - cs7-instance-iu 0 - mgw remote-ip 172.18.20.103 - emergency-call route-to-msisdn 112 - mncc external /data/unix/mncc -mncc-int - default-codec tch-f fr - default-codec tch-h hr -smpp - local-tcp-port 2775 - policy closed - no smpp-first - esme msc_tester - password osmocom1 -hlr - remote-ip 172.18.20.103 - remote-port 4222 - ipa-name test-MSC diff --git a/ttcn3-msc-test/osmo-stp.cfg b/ttcn3-msc-test/osmo-stp.cfg deleted file mode 100644 index a893f4b..0000000 --- a/ttcn3-msc-test/osmo-stp.cfg +++ /dev/null @@ -1,62 +0,0 @@ -! -! OsmoSTP (0.8.1) configuration saved from vty -!! -! -log gsmtap 172.18.20.103 - logging level set-all debug - logging filter all 1 -! -log stderr - logging filter all 1 - logging color 1 - logging print category 1 - logging timestamp 1 - logging print extended-timestamp 1 - logging level set-all debug -! -line vty - no login -! -cs7 instance 0 - xua rkm routing-key-allocation dynamic-permitted - asp virt-bsc0-0 23906 2905 m3ua - local-ip 172.18.20.200 - local-ip fd02:db8:20::200 - remote-ip 172.18.20.103 - remote-ip fd02:db8:20::103 - role sg - sctp-role server - as virt-bsc0 m3ua - asp virt-bsc0-0 - routing-key 0 0.24.1 - asp virt-bsc1-0 23907 2905 m3ua - local-ip 172.18.20.200 - local-ip fd02:db8:20::200 - remote-ip 172.18.20.103 - remote-ip fd02:db8:20::103 - role sg - sctp-role server - as virt-bsc1 m3ua - asp virt-bsc1-0 - routing-key 1 0.24.2 - asp virt-rnc0-0 23908 2905 m3ua - local-ip 172.18.20.200 - local-ip fd02:db8:20::200 - remote-ip 172.18.20.103 - remote-ip fd02:db8:20::103 - role sg - sctp-role server - as virt-rnc0 m3ua - asp virt-rnc0-0 - routing-key 2 0.24.3 - route-table system - update route 0.24.1 7.255.7 linkset virt-bsc0 - update route 0.24.2 7.255.7 linkset virt-bsc1 - update route 0.24.3 7.255.7 linkset virt-rnc0 - listen m3ua 2905 - accept-asp-connections dynamic-permitted - local-ip 172.18.20.200 - local-ip fd02:db8:20::200 - listen ipa 5000 - accept-asp-connections dynamic-permitted - local-ip 172.18.20.200 diff --git a/ttcn3-sccp-test/Dockerfile b/ttcn3-sccp-test/Dockerfile deleted file mode 100644 index 8d52787..0000000 --- a/ttcn3-sccp-test/Dockerfile +++ /dev/null @@ -1,13 +0,0 @@ -ARG REGISTRY -ARG USER -FROM $REGISTRY/$USER/debian-bookworm-titan -ARG OSMO_TTCN3_BRANCH="master" - -ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-ttcn3-hacks/+/$OSMO_TTCN3_B… /tmp/commit -RUN ttcn3-docker-prepare "$OSMO_TTCN3_BRANCH" sccp - -VOLUME /data - -COPY SCCP_Tests.cfg /data/SCCP_Tests.cfg - -CMD ttcn3-docker-run sccp SCCP_Tests diff --git a/ttcn3-sccp-test/Makefile b/ttcn3-sccp-test/Makefile deleted file mode 100644 index 4848603..0000000 --- a/ttcn3-sccp-test/Makefile +++ /dev/null @@ -1,3 +0,0 @@ -RUN_ARGS?=-it --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.2.202 -v ggsn-test-vol:/data - -include ../make/Makefile diff --git a/ttcn3-sccp-test/SCCP_Tests.cfg b/ttcn3-sccp-test/SCCP_Tests.cfg deleted file mode 100644 index 0d6a91b..0000000 --- a/ttcn3-sccp-test/SCCP_Tests.cfg +++ /dev/null @@ -1,30 +0,0 @@ -[ORDERED_INCLUDE] -"/osmo-ttcn3-hacks/Common.cfg" -"/osmo-ttcn3-hacks/sccp/SCCP_Tests.default" - -[LOGGING] -*.JUnitLogger.testsuite_name := "SCCP_Tests" - -[TESTPORT_PARAMETERS] -*.SCCP_DEMO_USER_VTY.CTRL_HOSTNAME := "172.18.22.200" -*.SCCP_DEMO_USER_VTY.CTRL_PORTNUM := "2324" - -[MODULE_PARAMETERS] -SCCP_Tests.mp_sccp_cfg := { - { - sccp_service_type := "mtp3_itu", - sctp_addr := { 2905, "172.18.22.203", 2905, "172.18.22.200" }, - own_pc := 23, - own_ssn := 202, /* sscp_test_server.c: SSN_TEST_ECHO */ - peer_pc := 1, - peer_ssn := 202, /* sscp_test_server.c: SSN_TEST_ECHO */ - sio := '03'O, /* NI=Internal, SCCP */ - rctx := 0 - } -}; - -[MAIN_CONTROLLER] - -[EXECUTE] -SCCP_Tests.control -SCCP_Tests_RAW.control diff --git a/ttcn3-sccp-test/jenkins.sh b/ttcn3-sccp-test/jenkins.sh deleted file mode 100755 index 03a630c..0000000 --- a/ttcn3-sccp-test/jenkins.sh +++ /dev/null @@ -1,46 +0,0 @@ -#!/bin/sh - -. ../jenkins-common.sh -IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" -# Always require osmo-stp-master since is the only with sccp_demo_user installed -docker_images_require \ - "osmo-stp-master" \ - "ttcn3-sccp-test" - -set_clean_up_trap -set -e - -mkdir $VOL_BASE_DIR/sccp-tester -cp SCCP_Tests.cfg $VOL_BASE_DIR/sccp-tester/ -write_mp_osmo_repo "$VOL_BASE_DIR/sccp-tester/SCCP_Tests.cfg" - -mkdir $VOL_BASE_DIR/sccp -cp sccp_demo_user.cfg $VOL_BASE_DIR/sccp/ - -network_create -network_replace_subnet_in_configs - -echo Starting container with sccp_demo_user -docker run --rm \ - $(docker_network_params $SUBNET 200) \ - --ulimit core=-1 \ - -v $VOL_BASE_DIR/sccp:/data \ - --name ${BUILD_TAG}-stp -d \ - $DOCKER_ARGS \ - $REPO_USER/osmo-stp-master \ - /bin/sh -c "sccp_demo_user \ - -l $SUB4_PREFIX.$SUBNET.200 \ - -r $SUB4_PREFIX.$SUBNET.203 \ - -C /data/sccp_demo_user.cfg \ - >>/data/sccp_demo_user.log 2>&1" - - -echo Starting container with SCCP testsuite -docker run --rm \ - $(docker_network_params $SUBNET 203) \ - --ulimit core=-1 \ - -e "TTCN3_PCAP_PATH=/data" \ - -v $VOL_BASE_DIR/sccp-tester:/data \ - --name ${BUILD_TAG}-ttcn3-sccp-test \ - $DOCKER_ARGS \ - $REPO_USER/ttcn3-sccp-test diff --git a/ttcn3-sccp-test/sccp_demo_user.cfg b/ttcn3-sccp-test/sccp_demo_user.cfg deleted file mode 100644 index 59c0867..0000000 --- a/ttcn3-sccp-test/sccp_demo_user.cfg +++ /dev/null @@ -1,17 +0,0 @@ -log gsmtap 172.18.22.203 - logging level set-all debug - logging filter all 1 - -log stderr - logging filter all 1 - logging color 1 - logging print level 1 - logging print category 1 - logging print category-hex 0 - logging print file basename last - logging print extended-timestamp 1 - logging level set-all debug - -line vty - no login - bind 172.18.22.200 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic07793fb7d8889684fd89b00860ebd0b17561a9e Gerrit-Change-Number: 40022 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in libosmo-sigtran[master]: asp: Rework s/get_all_rctx_for_asp/ss7_asp_get_all_rctx_be/g

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40013?usp=email ) Change subject: asp: Rework s/get_all_rctx_for_asp/ss7_asp_get_all_rctx_be/g ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40013?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic3a1c0bd663fe33ab14828e30e057a8beaa84c3f Gerrit-Change-Number: 40013 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Apr 2025 06:04:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: Unify amount of supported rctx items in IE to 128

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40012?usp=email ) Change subject: Unify amount of supported rctx items in IE to 128 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40012?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I703c9e62ed909dc1cd9c3e943612205856edbf2c Gerrit-Change-Number: 40012 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Apr 2025 06:02:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: xua_as_fsm: Remove unneeded double call to fill_notify_statchg_pars()

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40010?usp=email ) Change subject: xua_as_fsm: Remove unneeded double call to fill_notify_statchg_pars() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5d1e2768de13e9ab5ede849b3c06347c8669de1c Gerrit-Change-Number: 40010 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Apr 2025 06:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: asp: Rename and clarify asp_id field

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email ) Change subject: asp: Rename and clarify asp_id field ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006/comment/640f76ce_dffa9… : PS1, Line 219: xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp->asp_id); > I'm already explaining it in the commit msg: […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8e4304099db6fb12cf4b40a5b9a4aa3a83c95fde Gerrit-Change-Number: 40006 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Apr 2025 06:01:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: Fix typo in comment

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40002?usp=email ) Change subject: stp: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9f4a1e5ec0b0d2614b3cec0768e8847fce3e3cdf Gerrit-Change-Number: 40002 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Apr 2025 05:32:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs-sync: add Ubuntu 25.04

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40009?usp=email ) Change subject: jobs/osmocom-obs-sync: add Ubuntu 25.04 ...................................................................... jobs/osmocom-obs-sync: add Ubuntu 25.04 Change-Id: Iaddd4e97153c55febbb95ee2ef0ffaee3582be7f --- M jobs/osmocom-obs-sync.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 61578ba..671db02 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -38,6 +38,7 @@ Ubuntu:22.04 Ubuntu:24.04 Ubuntu:24.10 + Ubuntu:25.04 " ./scripts/obs/sync_obs_projects.py \ --docker \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaddd4e97153c55febbb95ee2ef0ffaee3582be7f Gerrit-Change-Number: 40009 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: sctp_{client,server}: set sndbuf/recbuf explicitly

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40019?usp=email to look at the new patch set (#2). Change subject: sctp_{client,server}: set sndbuf/recbuf explicitly ...................................................................... sctp_{client,server}: set sndbuf/recbuf explicitly For some reason, Erlang/OTP does overwrite the OS-default SO_SNDBUF/SO_RCVBUF values even if the respective socket options are not given to gen_sctp:open/N explicitly. Even worse, the receive buffer size is set to a very low value (1024), resulting in major performance issues when dealing with large packets. Set both sndbuf/recbuf to 65536 explicitly - this is the value that Erlang/OTP sets for the sndbuf by default. Allow tuning sndbuf/recbuf via the environment variables. Change-Id: I66f4a0f6a2441a3c8a4dbd266da8e44a3860b993 Related: SYS#7288 --- M src/osmo_s1gw_sup.erl 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/19/40019/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I66f4a0f6a2441a3c8a4dbd266da8e44a3860b993 Gerrit-Change-Number: 40019 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

4 months, 1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: sctp_{client,server}: make sctp_nodelay configurable

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40018?usp=email ) Change subject: sctp_{client,server}: make sctp_nodelay configurable ...................................................................... sctp_{client,server}: make sctp_nodelay configurable Keep the Nagle's algorithm disabled by default, but allow the user to re-enable it via the environment variables {mme,s1gw}_nodelay. Change-Id: Ida5418f8590f40414215fc9667fb4ea70e2b1614 Related: SYS#7288 --- M src/osmo_s1gw_sup.erl M src/sctp_client.erl M src/sctp_server.erl 3 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/18/40018/1 diff --git a/src/osmo_s1gw_sup.erl b/src/osmo_s1gw_sup.erl index 22a0298..67b6f47 100644 --- a/src/osmo_s1gw_sup.erl +++ b/src/osmo_s1gw_sup.erl @@ -42,6 +42,7 @@ -define(SERVER, ?MODULE). -define(ENV_APP_NAME, osmo_s1gw). +-define(ENV_DEFAULT_SCTP_NODELAY, true). -define(ENV_DEFAULT_S1GW_BIND_ADDR, "127.0.1.1"). -define(ENV_DEFAULT_S1GW_BIND_PORT, ?S1AP_PORT). -define(ENV_DEFAULT_MME_LOC_ADDR, "127.0.2.1"). @@ -88,15 +89,19 @@ -spec client_cfg() -> sctp_client:cfg(). client_cfg() -> + SockOpts = #{sctp_nodelay => get_env(mme_nodelay, ?ENV_DEFAULT_SCTP_NODELAY)}, #{laddr => get_env(mme_loc_addr, ?ENV_DEFAULT_MME_LOC_ADDR), raddr => get_env(mme_rem_addr, ?ENV_DEFAULT_MME_REM_ADDR), - rport => get_env(mme_rem_port, ?ENV_DEFAULT_MME_REM_PORT)}. + rport => get_env(mme_rem_port, ?ENV_DEFAULT_MME_REM_PORT), + sockopts => maps:to_list(SockOpts)}. -spec server_cfg() -> sctp_server:cfg(). server_cfg() -> + SockOpts = #{sctp_nodelay => get_env(s1gw_nodelay, ?ENV_DEFAULT_SCTP_NODELAY)}, #{laddr => get_env(s1gw_bind_addr, ?ENV_DEFAULT_S1GW_BIND_ADDR), lport => get_env(s1gw_bind_port, ?ENV_DEFAULT_S1GW_BIND_PORT), + sockopts => maps:to_list(SockOpts), handler => sctp_proxy, priv => client_cfg()}. diff --git a/src/sctp_client.erl b/src/sctp_client.erl index 0396109..bea3c16 100644 --- a/src/sctp_client.erl +++ b/src/sctp_client.erl @@ -86,7 +86,6 @@ RPort = maps:get(rport, Cfg), {ok, Sock} = gen_sctp:open([{ip, LAddr}, {type, seqpacket}, - {sctp_nodelay, true}, {active, true}] ++ SockOpts), gen_sctp:connect_init(Sock, RAddr, RPort, []), {ok, Sock}. diff --git a/src/sctp_server.erl b/src/sctp_server.erl index 7f12878..34b2381 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -121,7 +121,6 @@ {port, LPort}, {type, seqpacket}, {reuseaddr, true}, - {sctp_nodelay, true}, {active, true}] ++ SockOpts), ?LOG_INFO("SCTP server listening on ~p:~p", [LAddr, LPort]), ok = gen_sctp:listen(Sock, true), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ida5418f8590f40414215fc9667fb4ea70e2b1614 Gerrit-Change-Number: 40018 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025