November 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator
by pespin 13 Nov '25

13 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email ) Change subject: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator ...................................................................... Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator Most of the configs were so far configured to use Network Indicator "National Network", while our osmocom IUT programs are by default configured to use "International Network". Since libosmo-sigtran.git 875198f4914a2d59667deee9d1c1c4ce6e5e1129 the NI is validated at the rx path, so tests started failing and showed wrong configs were being used. Change-Id: I32d36dbb294632c340df3dba2a0f249189449699 --- M SCCP_Test/SCCP_Testcases.cfg M SCCP_Test/SCCP_Testcases.ttcn M bsc/BSC_Tests.default M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_SCCPlite.cfg M hnbgw/HNBGW_Tests.default M library/IPA_Emulation.ttcnpp M msc/MSC_Tests.default M sccp/SCCP_Tests.default M sgsn/SGSN_Tests.default M smlc/SMLC_Tests.cfg M smlc/SMLC_Tests.ttcn M stp/STP_Tests_TCAP.cfg 13 files changed, 35 insertions(+), 35 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/SCCP_Test/SCCP_Testcases.cfg b/SCCP_Test/SCCP_Testcases.cfg index 9920cf0..1548346 100644 --- a/SCCP_Test/SCCP_Testcases.cfg +++ b/SCCP_Test/SCCP_Testcases.cfg @@ -37,7 +37,7 @@ SCCP_Testcases.tsp_own_GT := '14377760'H SCCP_Testcases.tsp_remote_GT := '14375760'H SCCP_Testcases.tsp_SSN := 1 //8:MSC 5:MAP see 3.4.2.2/Q.713 -SCCP_Testcases.tsp_SIO := '83'O //SCCP national +SCCP_Testcases.tsp_SIO := '03'O // NI=International, SI=SCCP SCCP_Testcases.tsp_own_SPC := 23 SCCP_Testcases.tsp_remote_SPC := 1// max value on 14 bits SCCP_Testcases.tsp_SLS := 0 diff --git a/SCCP_Test/SCCP_Testcases.ttcn b/SCCP_Test/SCCP_Testcases.ttcn index bf93380..ed53c6a 100644 --- a/SCCP_Test/SCCP_Testcases.ttcn +++ b/SCCP_Test/SCCP_Testcases.ttcn @@ -41,7 +41,7 @@ hexstring tsp_own_GT := '0614377760'H; hexstring tsp_remote_GT := '0614375760'H; integer tsp_SSN := 2; //8:MSC 5:MAP see 3.4.2.2/Q.713 - octetstring tsp_SIO := '83'O;//SCCP national + octetstring tsp_SIO := '03'O; //NI=International, SI=SCCP integer tsp_own_SPC := 461087; // =0x07091E integer tsp_remote_SPC := 461086; // =0x07091D integer tsp_SLS := 0; diff --git a/bsc/BSC_Tests.default b/bsc/BSC_Tests.default index fe5ec86..e23cdea 100644 --- a/bsc/BSC_Tests.default +++ b/bsc/BSC_Tests.default @@ -53,7 +53,7 @@ own_ssn := 254, peer_pc := 187, # 0.23.3 osmo-bsc peer_ssn := 254, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1 } }, @@ -71,7 +71,7 @@ own_ssn := 254, peer_pc := 187,# 0.23.3 osmo-bsc peer_ssn := 254, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 2 } }, @@ -89,7 +89,7 @@ own_ssn := 254, peer_pc := 187, # 0.23.3 osmo-bsc peer_ssn := 254, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 3 } } diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index ef3867b..11e8784 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -709,7 +709,7 @@ own_ssn := 252, /* SMLC side SSN */ peer_pc := 187, /* 0.23.3 osmo-bsc */ peer_ssn := 250, /* BSC side SSN */ - sio := '83'O, + sio := '03'O, /* NI=International, SI=SCCP */ rctx := 6 }; boolean mp_enable_lcs_tests := true; diff --git a/bsc/BSC_Tests_SCCPlite.cfg b/bsc/BSC_Tests_SCCPlite.cfg index 7e5b4b2..e254379 100644 --- a/bsc/BSC_Tests_SCCPlite.cfg +++ b/bsc/BSC_Tests_SCCPlite.cfg @@ -30,7 +30,7 @@ own_ssn := 254, peer_pc := 187, # 0.23.3 osmo-bsc peer_ssn := 254, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 0 } } diff --git a/hnbgw/HNBGW_Tests.default b/hnbgw/HNBGW_Tests.default index 5cafb12..5fa13d4 100644 --- a/hnbgw/HNBGW_Tests.default +++ b/hnbgw/HNBGW_Tests.default @@ -49,7 +49,7 @@ own_ssn := 142, peer_pc := 189, # 0.23.5 osmo-hnbgw peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1 } }, @@ -67,7 +67,7 @@ own_ssn := 142, peer_pc := 189, # 0.23.5 osmo-hnbgw peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 3 } }, @@ -85,7 +85,7 @@ own_ssn := 142, peer_pc := 189, # 0.23.5 osmo-hnbgw peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 5 } }, @@ -103,7 +103,7 @@ own_ssn := 142, peer_pc := 189, # 0.23.5 osmo-hnbgw peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 7 } }, @@ -122,7 +122,7 @@ own_ssn := 142, peer_pc := 189, # 2237, 1.23.5 osmo-hnbgw peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 2 } }, @@ -140,7 +140,7 @@ own_ssn := 142, peer_pc := 189, # 2237, 1.23.5 osmo-hnbgw peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 4 } }, @@ -158,7 +158,7 @@ own_ssn := 142, peer_pc := 189, # 2237, 1.23.5 osmo-hnbgw peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 6 } }, @@ -176,7 +176,7 @@ own_ssn := 142, peer_pc := 189, # 2237, 1.23.5 osmo-hnbgw peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 8 } } diff --git a/library/IPA_Emulation.ttcnpp b/library/IPA_Emulation.ttcnpp index 9105f41..1c9f28b 100644 --- a/library/IPA_Emulation.ttcnpp +++ b/library/IPA_Emulation.ttcnpp @@ -375,7 +375,7 @@ #ifdef IPA_EMULATION_SCCP template ASP_MTP3_TRANSFERind ts_MTP3_XFER_ind(integer opc, octetstring data) := { - sio := { '10'B, '00'B, '0011'B }, + sio := { '00'B, '00'B, '0011'B }, opc := opc, dpc := 0, sls := 0, diff --git a/msc/MSC_Tests.default b/msc/MSC_Tests.default index 61fa94c..0b8c8e6 100644 --- a/msc/MSC_Tests.default +++ b/msc/MSC_Tests.default @@ -59,7 +59,7 @@ own_ssn := 254, peer_pc := 185, peer_ssn := 254, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 0 } }, @@ -77,7 +77,7 @@ own_ssn := 254, peer_pc := 185, peer_ssn := 254, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1 } }, @@ -95,7 +95,7 @@ own_ssn := 142, peer_pc := 185, peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 2 } } diff --git a/sccp/SCCP_Tests.default b/sccp/SCCP_Tests.default index 6dda647..417af49 100644 --- a/sccp/SCCP_Tests.default +++ b/sccp/SCCP_Tests.default @@ -24,7 +24,7 @@ own_ssn := 202, /* sscp_test_server.c: SSN_TEST_ECHO */ peer_pc := 1, peer_ssn := 202, /* sscp_test_server.c: SSN_TEST_ECHO */ - sio := '03'O, /* NI=Internal, SCCP */ + sio := '03'O, /* NI=International, SCCP */ rctx := 0 } }; diff --git a/sgsn/SGSN_Tests.default b/sgsn/SGSN_Tests.default index 330dc1b..9081b5f 100644 --- a/sgsn/SGSN_Tests.default +++ b/sgsn/SGSN_Tests.default @@ -54,7 +54,7 @@ own_ssn := 142, peer_pc := 188, # 0.23.4 peer_ssn := 142, - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 2 } } diff --git a/smlc/SMLC_Tests.cfg b/smlc/SMLC_Tests.cfg index f1a7001..05b4aa1 100644 --- a/smlc/SMLC_Tests.cfg +++ b/smlc/SMLC_Tests.cfg @@ -24,7 +24,7 @@ own_ssn := 250, /* BSC side SSN */ peer_pc := 190, /* 0.23.6 osmo-smlc */ peer_ssn := 252, /* SMLC side SSN */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1 } }; diff --git a/smlc/SMLC_Tests.ttcn b/smlc/SMLC_Tests.ttcn index 671f483..393d69f 100644 --- a/smlc/SMLC_Tests.ttcn +++ b/smlc/SMLC_Tests.ttcn @@ -108,7 +108,7 @@ own_ssn := 250, /* BSC side SSN */ peer_pc := 190, /* 0.23.6 osmo-smlc */ peer_ssn := 252, /* SMLC side SSN */ - sio := '83'O, + sio := '03'O, /* NI=International, SI=SCCP */ rctx := 1 } }; diff --git a/stp/STP_Tests_TCAP.cfg b/stp/STP_Tests_TCAP.cfg index 0ba90d7..a096d26 100644 --- a/stp/STP_Tests_TCAP.cfg +++ b/stp/STP_Tests_TCAP.cfg @@ -28,7 +28,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 5, peer_ssn := 6, /* HLR (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1000 } }, @@ -47,7 +47,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 5, peer_ssn := 6, /* HLR (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1000 } }, @@ -67,7 +67,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 25, peer_ssn := 6, /* HLR (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1001 } }, @@ -86,7 +86,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 25, peer_ssn := 6, /* HLR (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1001 } }, @@ -106,7 +106,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 24, peer_ssn := 6, /* HLR (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1002 } }, @@ -125,7 +125,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 24, peer_ssn := 6, /* HLR (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 1002 } }, @@ -147,7 +147,7 @@ own_ssn := 6, /* HLR (MAP) */ peer_pc := 23, peer_ssn := 8, /* MSC (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 0 } }, @@ -168,7 +168,7 @@ own_ssn := 6, /* HLR (MAP) */ peer_pc := 23, peer_ssn := 8, /* MSC (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 0 } }, @@ -190,7 +190,7 @@ own_ssn := 6, /* HLR (MAP) */ peer_pc := 7, peer_ssn := 8, /* MSC (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 0 } }, @@ -211,7 +211,7 @@ own_ssn := 6, /* HLR (MAP) */ peer_pc := 7, peer_ssn := 8, /* MSC (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 0 } }, @@ -233,7 +233,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 6, peer_ssn := 6, /* HLR (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 0 } }, @@ -254,7 +254,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 6, peer_ssn := 6, /* HLR (MAP) */ - sio := '83'O, + sio := '03'O, # NI=International, SI=SCCP rctx := 0 } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32d36dbb294632c340df3dba2a0f249189449699 Gerrit-Change-Number: 41426 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace
by pespin 13 Nov '25

13 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41425?usp=email ) Change subject: cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace ...................................................................... cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace Change-Id: I17140056c40305a8eb8024df5403897d0853098e --- M SCCP_Test/SCCP_Testcases.cfg M SCCP_Test/SCCP_Testcases.ttcn 2 files changed, 94 insertions(+), 94 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/SCCP_Test/SCCP_Testcases.cfg b/SCCP_Test/SCCP_Testcases.cfg index 5ba8c60..9920cf0 100644 --- a/SCCP_Test/SCCP_Testcases.cfg +++ b/SCCP_Test/SCCP_Testcases.cfg @@ -2,9 +2,9 @@ #FileName := "SCCP_selftest.cfg" FileMask := LOG_ALL | TTCN_DEBUG | TTCN_MATCHING #ConsoleMask := LOG_ALL -#ConsoleMask := TTCN_TESTCASE | TTCN_PORTEVENT | TTCN_DEBUG | TTCN_MATCHING +#ConsoleMask := TTCN_TESTCASE | TTCN_PORTEVENT | TTCN_DEBUG | TTCN_MATCHING #ConsoleMask := TTCN_WARNING | TTCN_ERROR | TTCN_TESTCASE | TTCN_STATISTICS | TTCN_PORTEVENT -#ConsoleMask := LOG_ALL | TTCN_DEBUG | TTCN_MATCHING +#ConsoleMask := LOG_ALL | TTCN_DEBUG | TTCN_MATCHING LogSourceInfo := Yes [EXECUTE] @@ -47,7 +47,7 @@ #for mtp3_itu/gti0011 or mtp3_ansi/gti0001 : #tsp_translationType := 7 SCCP_Emulation.tsp_SIF_MaxLength := 272 -SCCP_Emulation.tsp_force_xudt := 0 // 1:yes, 0:no +SCCP_Emulation.tsp_force_xudt := 0 // 1:yes, 0:no [MAIN_CONTROLLER] //TCPPort := 7145 diff --git a/SCCP_Test/SCCP_Testcases.ttcn b/SCCP_Test/SCCP_Testcases.ttcn index b659fc6..bf93380 100644 --- a/SCCP_Test/SCCP_Testcases.ttcn +++ b/SCCP_Test/SCCP_Testcases.ttcn @@ -16,10 +16,10 @@ // // File: SCCP_TestCases.ttcn // Description: SS7 SCCP basic SEA test -// according to specification ITU-T SS7 SCCP, ANSI ..., TCC ... -// References: ITU-T: Recommendation Q.711-Q.714, -// ANSI T1.112-2001, -// TCC +// according to specification ITU-T SS7 SCCP, ANSI ..., TCC ... +// References: ITU-T: Recommendation Q.711-Q.714, +// ANSI T1.112-2001, +// TCC // Rev: <RnXnn> // Updated: 2007.04.12 // Contact: http://ttcn.ericsson.se @@ -28,7 +28,7 @@ -//Note : this has been modified to include M3UA Emulation and SCTP Test port +//Note : this has been modified to include M3UA Emulation and SCTP Test port //Elemer Lelik 12.04.2017 @@ -36,17 +36,17 @@ module SCCP_Testcases {//startmodule -modulepar +modulepar { hexstring tsp_own_GT := '0614377760'H; hexstring tsp_remote_GT := '0614375760'H; integer tsp_SSN := 2; //8:MSC 5:MAP see 3.4.2.2/Q.713 octetstring tsp_SIO := '83'O;//SCCP national - integer tsp_own_SPC := 461087; // =0x07091E + integer tsp_own_SPC := 461087; // =0x07091E integer tsp_remote_SPC := 461086; // =0x07091D integer tsp_SLS := 0; charstring tsp_sccp_serviceType := "mtp3_itu"; - + octetstring MTP3_UserPart_SIO; integer MTP3_UserPart_OPC, MTP3_UserPart_DPC, @@ -84,10 +84,10 @@ // Model of MSC: type component system_CT { - - port SCTPasp_PT sctp; - + port SCTPasp_PT sctp; + + }; @@ -101,13 +101,13 @@ var M3UA_CT vc_M3UA ; - var MSC_SCCP_MTP3_parameters v_BootA; + var MSC_SCCP_MTP3_parameters v_BootA; var SCCP_PAR_Connection_Id v_cid_A ; - - port SCCPasp_PT A_PORT; //SCCPuserA + + port SCCPasp_PT A_PORT; //SCCPuserA } -function initBootParams() runs on MTC_CT +function initBootParams() runs on MTC_CT { v_BootA := { sio:= @@ -116,8 +116,8 @@ si:= substr(oct2bit(tsp_SIO),4,4) }, opc:=tsp_own_SPC, - dpc:=tsp_remote_SPC, - sls:=tsp_SLS, + dpc:=tsp_remote_SPC, + sls:=tsp_SLS, sccp_serviceType:=tsp_sccp_serviceType, ssn:= tsp_SSN }; @@ -128,21 +128,21 @@ { initBootParams(); log("v_BootA:",v_BootA); - + // Protocol Stack creation & connections: vc_SCCP_A:=SCCP_CT.create; vc_M3UA:=M3UA_CT.create; connect(self:A_PORT,vc_SCCP_A:SCCP_SP_PORT); connect(vc_M3UA:MTP3_SP_PORT,vc_SCCP_A:MTP3_SCCP_PORT); - map(vc_M3UA:SCTP_PORT,system:sctp); - - vc_M3UA.start(f_M3UA_Emulation(tsp_address)); - vc_SCCP_A.start( SCCPStart( v_BootA ) ); // Bootparameters + map(vc_M3UA:SCTP_PORT,system:sctp); - + vc_M3UA.start(f_M3UA_Emulation(tsp_address)); + vc_SCCP_A.start( SCCPStart( v_BootA ) ); // Bootparameters + + log( "init() is done"); - + }// init function terminate( ) runs on MTC_CT //system system_CT @@ -154,16 +154,16 @@ }*/ all component.stop; - unmap(vc_M3UA:SCTP_PORT,system:sctp); - disconnect(vc_M3UA:MTP3_SP_PORT,vc_SCCP_A:MTP3_SCCP_PORT); + unmap(vc_M3UA:SCTP_PORT,system:sctp); + disconnect(vc_M3UA:MTP3_SP_PORT,vc_SCCP_A:MTP3_SCCP_PORT); disconnect(self:A_PORT,vc_SCCP_A:SCCP_SP_PORT); - + log(" all components stopped"); self.stop; } //terminate -// function getOddEven returns '0' +// function getOddEven returns '0' // if even number of dec digit can be found in GT see Q.713 function getOddEven( in hexstring pl_GT) return bitstring { @@ -184,19 +184,19 @@ function setAddresses_gti0001() runs on MTC_CT { - if( (tsp_sccp_serviceType == "mtp3_itu") or + if( (tsp_sccp_serviceType == "mtp3_itu") or (tsp_sccp_serviceType == "mtp3b_itu") or (tsp_sccp_serviceType == "mtp3_ttc") or (tsp_sccp_serviceType == "mtp3b_ttc") ) { - v_CalledAddress :={ + v_CalledAddress :={ addressIndicator := { pointCodeIndic := '1'B, ssnIndicator := '1'B, globalTitleIndic := '0001'B, routingIndicator := '1'B },//addressIndicator - signPointCode := SCCP_SPC_int2bit(tsp_remote_SPC, tsp_sccp_serviceType, tsp_SIO), // see SCCP.ttcn + signPointCode := SCCP_SPC_int2bit(tsp_remote_SPC, tsp_sccp_serviceType, tsp_SIO), // see SCCP.ttcn subsystemNumber := tsp_SSN, globalTitle := { gti0001:= { @@ -206,72 +206,72 @@ } }//globalTitle } // v_CalledAddress - - v_CallingAddress :={ + + v_CallingAddress :={ addressIndicator := { pointCodeIndic := '1'B, ssnIndicator := '1'B, globalTitleIndic := '0001'B, routingIndicator := '1'B },//addressIndicator - signPointCode := SCCP_SPC_int2bit(tsp_own_SPC, tsp_sccp_serviceType, tsp_SIO), // see SCCP.ttcn + signPointCode := SCCP_SPC_int2bit(tsp_own_SPC, tsp_sccp_serviceType, tsp_SIO), // see SCCP.ttcn subsystemNumber := tsp_SSN, - globalTitle:= { + globalTitle:= { gti0001 := { natureOfAddress := '0000011'B, - oddeven := getOddEven( tsp_own_GT ), + oddeven := getOddEven( tsp_own_GT ), globalTitleAddress := tsp_own_GT } }//globalTitle } // v_CallingAddress - + } else if( (tsp_sccp_serviceType == "mtp3_ansi") or - (tsp_sccp_serviceType == "mtp3b_ansi") + (tsp_sccp_serviceType == "mtp3b_ansi") ) { - - v_CalledAddress :={ + + v_CalledAddress :={ addressIndicator := { pointCodeIndic := '1'B, ssnIndicator := '1'B, globalTitleIndic := '0001'B, routingIndicator := '0'B },//addressIndicator - signPointCode := SCCP_SPC_int2bit(tsp_remote_SPC, tsp_sccp_serviceType, tsp_SIO), // see SCCP.ttcn + signPointCode := SCCP_SPC_int2bit(tsp_remote_SPC, tsp_sccp_serviceType, tsp_SIO), // see SCCP.ttcn subsystemNumber := tsp_SSN, globalTitle := { gti0011:= { translationType := int2oct(7,1), - encodingScheme := getOddEven_ansi( tsp_remote_GT ), - numberingPlan := '0111'B, //ISDN/mobile numbering plan, see T1.112.3-2001/3.4.2.3.1 + encodingScheme := getOddEven_ansi( tsp_remote_GT ), + numberingPlan := '0111'B, //ISDN/mobile numbering plan, see T1.112.3-2001/3.4.2.3.1 globalTitleAddress:= tsp_remote_GT } }//globalTitle } // v_CalledAddress - - v_CallingAddress :={ + + v_CallingAddress :={ addressIndicator := { pointCodeIndic := '1'B, ssnIndicator := '1'B, globalTitleIndic := '0001'B, routingIndicator := '0'B },//addressIndicator - signPointCode := SCCP_SPC_int2bit(tsp_remote_SPC, tsp_sccp_serviceType, tsp_SIO), // see SCCP.ttcn + signPointCode := SCCP_SPC_int2bit(tsp_remote_SPC, tsp_sccp_serviceType, tsp_SIO), // see SCCP.ttcn subsystemNumber := tsp_SSN, globalTitle := { gti0011:= { translationType := int2oct(7,1), - encodingScheme := getOddEven_ansi( tsp_own_GT ), - numberingPlan := '0111'B, //ISDN/mobile numbering plan, see T1.112.3-2001/3.4.2.3.1 + encodingScheme := getOddEven_ansi( tsp_own_GT ), + numberingPlan := '0111'B, //ISDN/mobile numbering plan, see T1.112.3-2001/3.4.2.3.1 globalTitleAddress:= tsp_own_GT } }//globalTitle } // v_CallingAddress }//if - + }//setAddresses_gti001 -function f_SendAndReceive1N_UNITDATA(in octetstring pl_userdata) runs on MTC_CT +function f_SendAndReceive1N_UNITDATA(in octetstring pl_userdata) runs on MTC_CT { var ASP_SCCP_N_UNITDATA_ind vl_N_UNITDATA_ind; timer TL_timer:= 120.0; @@ -282,12 +282,12 @@ '00000001'B, //return option pl_userdata, omit ) ); - alt { + alt { [] A_PORT.receive( tr_ASP_N_UNITDATA_ind ) -> value vl_N_UNITDATA_ind - { + { if( (vl_N_UNITDATA_ind.calledAddress == v_CalledAddress ) and - (vl_N_UNITDATA_ind.callingAddress == v_CallingAddress) and + (vl_N_UNITDATA_ind.callingAddress == v_CallingAddress) and (vl_N_UNITDATA_ind.userData == pl_userdata) ) { log("Correct CalledAddress, CallingAddress and userData received, data are correct"); @@ -298,13 +298,13 @@ log("Some data corrupted"); setverdict( fail ); } - }; - [] TL_timer.timeout - { + }; + [] TL_timer.timeout + { setverdict( fail ); log("Timeout...."); - }; - } //alt + }; + } //alt TL_timer.stop; }//f_SendAndReceive1N_UNITDATA @@ -315,8 +315,8 @@ /**************************************************** function f_connect Establishes a connection -(Sends an ASP_SCCP_N_CONNECT_req on A_PORT and waits for -N_CONNECT_ind on B_PORT. If it is received, +(Sends an ASP_SCCP_N_CONNECT_req on A_PORT and waits for +N_CONNECT_ind on B_PORT. If it is received, it sends back an ASP_SCCP_N_CONNECT_res on B_PORT and waits for N_CONNECT_cfm on A_PORT) ****************************************************/ @@ -327,14 +327,14 @@ setverdict(none); v_cid_A := 13; timer TL_timer:= 120.0; - TL_timer.start; - + TL_timer.start; + A_PORT.send( t_ASP_N_CONNECT_req( v_CalledAddress, v_CallingAddress, omit, //expeditedDataSel omit, //QoS omit, //userData - v_cid_A, + v_cid_A, omit //importance ) ); @@ -345,7 +345,7 @@ log("f_connect finished successfully"); return true; } - [] TL_timer.timeout + [] TL_timer.timeout { setverdict( fail ); log("Timeout...."); @@ -371,21 +371,21 @@ { setverdict( pass ); log("f_connect finished successfully"); - + } - [] TL_timer.timeout + [] TL_timer.timeout { setverdict( fail ); log("Timeout...."); - + } - + } //alt }//f_send //f_disconnect with timeout -function f_disconnect( ) runs on MTC_CT +function f_disconnect( ) runs on MTC_CT { var ASP_SCCP_N_DISCONNECT_ind vl_N_DISCONNECT_ind; timer TL_timer:= 25.0; @@ -393,22 +393,22 @@ A_PORT.send( t_ASP_N_DISCONNECT_req( omit, // respondingAddress 0, //reason : end user originated, see 3.11/Q.713 omit, //userData - v_cid_A, + v_cid_A, omit )) alt { - + [] A_PORT.receive { repeat; } - [] TL_timer.timeout - { + [] TL_timer.timeout + { setverdict( pass ); log("Timeout...."); - }; + }; }//alt - - + + }//f_disconnect //=================================================== @@ -419,17 +419,17 @@ tc_ConnlessSendingShortASP Sends a 300 octet long userdata in one ASP_SCCP_N_UNITDATA_req and receives it in one ASP_SCCP_N_UNITDATA_req. -SCCP transfers information +SCCP transfers information in udp or (forced) xudp packets. ****************************************************/ -testcase tc_ConnlessSendingShortASP() runs on MTC_CT +testcase tc_ConnlessSendingShortASP() runs on MTC_CT { var octetstring vl_userdata; init(); setAddresses_gti0001(); - vl_userdata :='12345678901234567890'O; + vl_userdata :='12345678901234567890'O; f_SendAndReceive1N_UNITDATA( vl_userdata ); - terminate(); + terminate(); } //tc_ConnlessSendingShortASP /**************************************************** @@ -437,21 +437,21 @@ Sends a 300 octet long userdata in one ASP_SCCP_N_UNITDATA_req and receives it in one ASP_SCCP_N_UNITDATA_req. It is used for segmentation and reassembly. - SCCP transfers information -in xudp packets + SCCP transfers information +in xudp packets ****************************************************/ testcase tc_ConnlessSendingLongASP() runs on MTC_CT system system_CT { var octetstring vl_userdata; - var integer vl_i; + var integer vl_i; init(); setAddresses_gti0001(); vl_userdata := ''O; for(vl_i:=0;vl_i<30;vl_i:=vl_i+1) { - vl_userdata := vl_userdata &'12345678901234567890'O; + vl_userdata := vl_userdata &'12345678901234567890'O; } f_SendAndReceive1N_UNITDATA( vl_userdata ); - terminate(); + terminate(); }//tc_ConnlessSendingLongASP /**************************************************** @@ -468,20 +468,20 @@ f_send(vl_userdata); f_disconnect(); } - terminate(); + terminate(); } /**************************************************** tc_ConnOrientedLongASPSending ****************************************************/ -testcase tc_ConnOrientedLongASPSending() runs on MTC_CT +testcase tc_ConnOrientedLongASPSending() runs on MTC_CT { var octetstring vl_userdata; - var integer vl_i; + var integer vl_i; init(); setAddresses_gti0001(); vl_userdata := ''O; for(vl_i:=0;vl_i<30;vl_i:=vl_i+1) { - vl_userdata := vl_userdata &'12345678901234567890'O; + vl_userdata := vl_userdata &'12345678901234567890'O; } if(f_connect()) { @@ -489,12 +489,12 @@ //f_SendAndReceive1N_UNITDATA( vl_userdata ); f_disconnect(); } - terminate(); + terminate(); } /**************************************************** CONTROL ****************************************************/ -control +control { execute( tc_ConnlessSendingShortASP() ); execute( tc_ConnlessSendingLongASP() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17140056c40305a8eb8024df5403897d0853098e Gerrit-Change-Number: 41425 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace
by pespin 13 Nov '25

13 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41425?usp=email ) Change subject: cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17140056c40305a8eb8024df5403897d0853098e Gerrit-Change-Number: 41425 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Nov 2025 19:49:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: mtp: Implement already defined osmo_mtp_prim_name()
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: daniel, fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41416?usp=email ) Change subject: mtp: Implement already defined osmo_mtp_prim_name() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ifa21c26ceaa079435a2d157f99813e06cfc12e71 Gerrit-Change-Number: 41416 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Nov 2025 19:04:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41425?usp=email ) Change subject: cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: well, that is code we received from Ericsson, and not code we wrote ourselves. But since it's safe to assume that we won't ever have to sync with any updated versions from Ericsson (I doubt there ever will be any), we can make cosmetic changes like this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17140056c40305a8eb8024df5403897d0853098e Gerrit-Change-Number: 41425 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Nov 2025 19:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email ) Change subject: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32d36dbb294632c340df3dba2a0f249189449699 Gerrit-Change-Number: 41426 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Nov 2025 19:02:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator
by laforge 13 Nov '25

13 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email ) Change subject: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: it was intentional that osmocom software uses international by default (as that's the only one standardized to use ITU SS7, while "national" can mean many different national flavours of SS7 including ANSI, which we never implemented. The test suites have been wrong and should be fixed with a patch like this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32d36dbb294632c340df3dba2a0f249189449699 Gerrit-Change-Number: 41426 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Nov 2025 19:02:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator
by pespin 13 Nov '25

13 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email ) Change subject: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @laforge@gnumonks.org I see a problem here: Cisco ITP manual states "national" (10) is the default, but we so far have been setting no explicit default in code during ss7_instance_alloc(), which means our defualt is "international" (00). So we either: * keep our own default as "international" (00) different from Cisco ITP and merge this commit as presented now. * Change our default to be "national" (10) in libosmo-sigtran and adapt this commit to make sure we use sio "83" everywhere instead of "03". -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32d36dbb294632c340df3dba2a0f249189449699 Gerrit-Change-Number: 41426 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 13 Nov 2025 17:21:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-sigtran[master]: mtp: Introduce osmo_ss7_user_find_by_si() public API
by pespin 13 Nov '25

13 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41429?usp=email ) Change subject: mtp: Introduce osmo_ss7_user_find_by_si() public API ...................................................................... mtp: Introduce osmo_ss7_user_find_by_si() public API This is needed by mtp_sap/ss7_user API users to figure out whether there's a user set up already for a given Service Indicator. Change-Id: I7db659dc443148f3aab70d2c6229c2271346cf38 --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/ss7_hmrt.c M src/ss7_user.c M src/ss7_user.h M src/xua_snm.c 6 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/29/41429/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 28aed5b..8a42b9c 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -12,3 +12,4 @@ libosmo-sigtran add osmo_ss7_instance_get_network_indicator() libosmo-sigtran add osmo_ss7_user_mtp_sap_prim_down() libosmo-sigtran add osmo_mtp_prim_xfer_req_prepend() +libosmo-sigtran add osmo_ss7_user_find_by_si() diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index b560caf..9ea929f 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -95,6 +95,7 @@ int osmo_ss7_user_register(struct osmo_ss7_user *user, uint8_t service_ind); int osmo_ss7_user_unregister(struct osmo_ss7_user *user, uint8_t service_ind); +struct osmo_ss7_user *osmo_ss7_user_find_by_si(const struct osmo_ss7_instance *inst, uint8_t service_indicator); /* MTP User wants to submit a primitive down to MTP SAP */ int osmo_ss7_user_mtp_sap_prim_down(struct osmo_ss7_user *user, diff --git a/src/ss7_hmrt.c b/src/ss7_hmrt.c index 81a56a8..72b26d8 100644 --- a/src/ss7_hmrt.c +++ b/src/ss7_hmrt.c @@ -123,7 +123,7 @@ } /* "User Part Available?" */ - osu = ss7_user_find(inst, service_ind); + osu = osmo_ss7_user_find_by_si(inst, service_ind); if (!osu) { /* "Discard Message" */ LOGSS7(inst, LOGL_NOTICE, "No MTP-User for SI %u\n", service_ind); diff --git a/src/ss7_user.c b/src/ss7_user.c index 0ec42ff..7137b7a 100644 --- a/src/ss7_user.c +++ b/src/ss7_user.c @@ -54,7 +54,7 @@ talloc_free(user); } -struct osmo_ss7_user *ss7_user_find(struct osmo_ss7_instance *inst, uint8_t service_indicator) +struct osmo_ss7_user *osmo_ss7_user_find_by_si(const struct osmo_ss7_instance *inst, uint8_t service_indicator) { if (service_indicator >= ARRAY_SIZE(inst->user)) return NULL; diff --git a/src/ss7_user.h b/src/ss7_user.h index bec6c22..25259e8 100644 --- a/src/ss7_user.h +++ b/src/ss7_user.h @@ -23,7 +23,6 @@ void *priv; }; -struct osmo_ss7_user *ss7_user_find(struct osmo_ss7_instance *inst, uint8_t service_indicator); void ss7_user_unregister_all(struct osmo_ss7_user *user); int ss7_user_mtp_sap_prim_up(const struct osmo_ss7_user *osu, struct osmo_mtp_prim *omp); diff --git a/src/xua_snm.c b/src/xua_snm.c index 4890f79..efa7e91 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -309,7 +309,7 @@ unsigned int num_rctx; /* Translate to MTP-STATUS.ind towards MTP-User (SCCP will create N-PCSTATE.ind to SCU) */ - osu = ss7_user_find(s7i, user); + osu = osmo_ss7_user_find_by_si(s7i, user); if (osu) { struct osmo_mtp_prim *omp = mtp_prim_status_ind_alloc(dpc, cause, false, 0); ss7_user_mtp_sap_prim_up(osu, omp); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7db659dc443148f3aab70d2c6229c2271346cf38 Gerrit-Change-Number: 41429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Constify xua_msg in data_hdr_from_m3ua()
by pespin 13 Nov '25

13 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41428?usp=email ) Change subject: Constify xua_msg in data_hdr_from_m3ua() ...................................................................... Constify xua_msg in data_hdr_from_m3ua() Related: SYS#5423 Change-Id: I372054dcb7f153e3ca7c845ce0bd1f558e7bb9fa --- M src/m3ua.c M src/xua_internal.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/m3ua.c b/src/m3ua.c index f5030d0..8e93515 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -570,7 +570,7 @@ ***********************************************************************/ /* obtain the destination point code from a M3UA message in XUA fmt * */ -struct m3ua_data_hdr *data_hdr_from_m3ua(struct xua_msg *xua) +struct m3ua_data_hdr *data_hdr_from_m3ua(const struct xua_msg *xua) { struct xua_msg_part *data_ie; struct m3ua_data_hdr *data_hdr; diff --git a/src/xua_internal.h b/src/xua_internal.h index 6cc0d72..36393f3 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -64,7 +64,7 @@ struct msgb *m3ua_msgb_alloc(const char *name); struct xua_msg *m3ua_xfer_from_data(const struct m3ua_data_hdr *data_hdr, const uint8_t *data, unsigned int data_len); -struct m3ua_data_hdr *data_hdr_from_m3ua(struct xua_msg *xua); +struct m3ua_data_hdr *data_hdr_from_m3ua(const struct xua_msg *xua); void m3ua_dh_to_xfer_param(struct osmo_mtp_transfer_param *param, const struct m3ua_data_hdr *mdh); void mtp_xfer_param_to_m3ua_dh(struct m3ua_data_hdr *mdh, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I372054dcb7f153e3ca7c845ce0bd1f558e7bb9fa Gerrit-Change-Number: 41428 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025